aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/cpp
Commit message (Collapse)AuthorAge
* Some minor updates to the BUILD files.Gravatar Ulf Adams2015-09-15
| | | | | -- MOS_MIGRATED_REVID=103087492
* Configured Java logging for BazelGravatar Damien Martin-Guillerez2015-09-14
| | | | | | | | | Previously the logger output was sent out to the console, leading to garbage information in batch mode. Now, the log are sent to a log file in the output base. -- MOS_MIGRATED_REVID=102989990
* Fix compile warningsGravatar Kristina Chodorow2015-09-09
| | | | | | | | | | | | | | | | | | | | | | | | | | This was printing: src/main/cpp/blaze_util.cc: In function 'bool blaze::WriteFile(const string&, const string&)': src/main/cpp/blaze_util.cc:211:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] return r == content.size(); ^ src/main/cpp/blaze_util.cc: In function 'bool blaze::CheckJavaVersionIsAtLeast(const string&, const string&)': src/main/cpp/blaze_util.cc:334:41: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < jvm_version_vect.size() && i < version_spec_vect.size(); ^ src/main/cpp/blaze_util.cc:334:73: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < jvm_version_vect.size() && i < version_spec_vect.size(); ^ src/main/cpp/blaze_util.cc:344:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (i < version_spec_vect.size()) { ^ src/main/cpp/blaze_util.cc:345:39: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (; i < version_spec_vect.size(); i++) { This also fixes that we weren't checking write()'s return code. -- MOS_MIGRATED_REVID=102656105
* Fix the blaze_util_test to compile and pass.Gravatar Ulf Adams2015-09-08
| | | | | | | | I had to comment out a couple of tests, I don't know why they're not passing right now. -- MOS_MIGRATED_REVID=102535967
* Quick fix for shipping the android tools in the Bazel binaryGravatar Damien Martin-Guillerez2015-09-03
| | | | | | | | | | | | | | This is not really nice, there are several hacks there. This repository will get removed in the future and linked to a remote one instead. I tested it against the tutorial and it works like a charm. mobile-install seems like to work, maybe that's also fixing the last issue reported in #392. Known issue: Java compilation output errors about files being modified in the future. -- MOS_MIGRATED_REVID=102282979
* Port to FreeBSD.Gravatar Doug Rabson2015-08-26
| | | | | | | -- Change-Id: I4e65cc583e758d2f7e45209ffcb37f6a871e2ed7 Reviewed-on: https://bazel-review.git.corp.google.com/#/c/1840 MOS_MIGRATED_REVID=101462155
* Fix some missing headers and data dependencies in BUILD files.Gravatar Philipp Wollermann2015-08-24
| | | | | -- MOS_MIGRATED_REVID=101218746
* Fix a minor issue with Windows compilationGravatar Dmitry Lomov2015-08-14
| | | | | -- MOS_MIGRATED_REVID=100609863
* Add a server.pid file for platforms where GetPeerProcessId is not supportedGravatar Doug Rabson2015-08-14
| | | | | | | -- Change-Id: I36b096cfdf7b150121809ff5b07c74eac1cbf7ad Reviewed-on: https://bazel-review.git.corp.google.com/#/c/1771 MOS_MIGRATED_REVID=100573875
* Allow runtime introspection of a content hash of the Blaze binary and all ↵Gravatar Eric Fellheimer2015-08-12
| | | | | | | embedded binaries. -- MOS_MIGRATED_REVID=100476182
* Avoid command line argument mangling on Windows.Gravatar Dmitry Lomov2015-08-12
| | | | | | | | | | | | | | exec(3) under mingw converts every command line argument that looks like Unix path into Windows path when executing non-mingw images (criteria for non-mingw image is that the image does not depend on msys-<version>.dll). This affects bazel labels (`//foo:bar` becomes `/foo:bar` for example). This CL: 1) Replaces usage of execv(3) with Windows-native CreateProcess. 2) Converts all command line arguments that are indeed paths into Windows paths. -- MOS_MIGRATED_REVID=100386350
* Externalize file_test and strings_test, and fix up the BUILD files.Gravatar Ulf Adams2015-08-10
| | | | | -- MOS_MIGRATED_REVID=100109450
* Remove vestigial references to 32-bit/64-bit binaries.Gravatar Janak Ramakrishnan2015-07-30
| | | | | -- MOS_MIGRATED_REVID=99411524
* Fix some C++ compiler warnings to comply with -Wall.Gravatar Ulf Adams2015-07-27
| | | | | | | | | Some progress towards #311. -- Change-Id: I9276519d4a97d358b7c4f4e34a861522d75dd495 Reviewed-on: https://bazel-review.googlesource.com/#/c/1710 MOS_MIGRATED_REVID=99019961
* Add #include <sys/socket.h> to blaze_util_mingw.ccGravatar Googler2015-07-23
| | | | | -- MOS_MIGRATED_REVID=98924654
* Use custom util instead of std::to_string.Gravatar Googler2015-07-23
| | | | | | | std::to_string is not avcaliable on mingw. -- MOS_MIGRATED_REVID=98923935
* Add a BUILD file to src/main/cpp/util.Gravatar Ulf Adams2015-07-23
| | | | | -- MOS_MIGRATED_REVID=98918607
* Add #include <cstdio>.Gravatar Googler2015-07-23
| | | | | | | fprintf and friends live in cstdio per standard, and compilation fails under msys gcc if it is not included. -- MOS_MIGRATED_REVID=98817931
* Support --nowatchfs global option in the launcher.Gravatar Han-Wen Nienhuys2015-06-26
| | | | | -- MOS_MIGRATED_REVID=96965558
* Support the --[no]master_bazelrc flagGravatar Damien Martin-Guillerez2015-06-25
| | | | | | | And get rid of usage of "blazerc" flags in our scripts. -- MOS_MIGRATED_REVID=96776423
* Added /etc/bazel.bazelrc as a global Bazel's master rc.Gravatar Damien Martin-Guillerez2015-06-15
| | | | | | | | | | This will allow system-wide configuration for system-wide installation of Bazel. -- Change-Id: I71b7232e648f2690766c3b9184f863dc888524c0 Reviewed-on: https://bazel-review.googlesource.com/#/c/1540/ MOS_MIGRATED_REVID=95994630
* Cleanup: Initialize field members through ctor initializer list.Gravatar Thiago Farina2015-06-12
| | | | | | | | | | | | | This seems to be a win as it avoids re-initialing the fields that have a default constructor (non-POD), besides being the best and idiomatic practice. More details in http://stackoverflow.com/a/9903927 -- Change-Id: I6c184e8a53b385756938084ec60aebc8184243a0 Reviewed-on: https://bazel-review.googlesource.com/#/c/1513/3 MOS_MIGRATED_REVID=95815524
* Support --bazelrc= syntax to specify rcfileGravatar Damien Martin-Guillerez2015-06-05
| | | | | | | | | | We still support the --blazerc syntax and don't use the product name for legacy reasons. Bazel should only refer to --bazelrc now. Fixes #229 -- MOS_MIGRATED_REVID=95282659
* Cleanup: Mark single-parameter constructors as explicit.Gravatar Thiago Farina2015-06-05
| | | | | | | | | | This should fix the following cpplint.py warning: Single-parameter constructors should be marked explicit. [runtime/explicit] [5] -- Change-Id: I2bf74ced08f86bd5a4e6d57720188327bbd9efe6 Reviewed-on: https://bazel-review.googlesource.com/#/c/1452/ MOS_MIGRATED_REVID=95109413
* Pass user-specified JVM flags to AddJVMArguments so that JVM flags can be ↵Gravatar Janak Ramakrishnan2015-06-03
| | | | | | | customized based on user's flags. -- MOS_MIGRATED_REVID=95015135
* Use the ijar ZIP implementation in Blaze instead of libarchiveGravatar Damien Martin-Guillerez2015-06-01
| | | | | | | | | | | This ZIP implementation is lightweight and rely on zlib for compression. libarchive was a bit tricky to set-up so it's better to use that one. -- Change-Id: I607b492998572e834e095a4606eeb77c0b574542 Reviewed-on: https://bazel-review.googlesource.com/#/c/1410/ MOS_MIGRATED_REVID=94910072
* launcher: observe umask in MakeDirectories.Gravatar Han-Wen Nienhuys2015-06-01
| | | | | -- MOS_MIGRATED_REVID=94905648
* Cleanup: Remove unused Is64BitBlazeJavabase() function declaration.Gravatar Thiago Farina2015-06-01
| | | | | | | | | | This function has only a declaration, no implementation and thus no uses. Confirmed that it has no uses internally as well. -- Change-Id: Ifd9214b546f304077e4d729bf22abf6b49cc6af1 Reviewed-on: https://bazel-review.googlesource.com/1411 MOS_MIGRATED_REVID=94763256
* Remove unused helper functions.Gravatar Han-Wen Nienhuys2015-05-27
| | | | | -- MOS_MIGRATED_REVID=94577279
* Store RcFile pointers, rather than inline objects.Gravatar Han-Wen Nienhuys2015-05-22
| | | | | | | | | | | | | Since RcFile hands out pointers to its string members, modifying vector<RcFile> may cause reallocation, which invalidates handed out pointers. Fixes #205. -- Change-Id: Id4eb0a4e8a52373130140f1de5697f4e4f4a6f95 Reviewed-on: https://bazel-review.googlesource.com/#/c/1360/ MOS_MIGRATED_REVID=94276823
* Global cleanup change.Gravatar Googler2015-05-18
| | | | | -- MOS_MIGRATED_REVID=93882453
* Cleanup: Pass std::string arguments by reference (this avoids makingGravatar Thiago Farina2015-05-18
| | | | | | | | | | | | | unnecessary copies) and label them const, per the Google style guide. Tested: $ ./bootstrap_test.sh all -- Change-Id: I17636703cf43283f71b9b913c130a51065bd896b Reviewed-on: https://bazel-review.googlesource.com/1350 MOS_MIGRATED_REVID=93876332
* Cleanup: port.cc should include its header file port.hGravatar Thiago Farina2015-05-18
| | | | | | | | | | | | | port.cc implements sys_ioprio_set() function, but was not including the header that declares it. Also included port.h in blaze_util_linux.cc for iwyu, since that file is using sys_ioprio_set(). -- Change-Id: Ie6130df9ed72e8125d07f72455fc53a03afedbc1 Reviewed-on: https://bazel-review.googlesource.com/#/c/1321/ MOS_MIGRATED_REVID=93868707
* Remove hack for OSX javabaseGravatar Damien Martin-Guillerez2015-05-18
| | | | | | | Fixes #102 -- MOS_MIGRATED_REVID=93705078
* Remove race condition from directory creation in launcherGravatar Kristina Chodorow2015-05-15
| | | | | | | | | If someone ran two Bazel commands at the same time, the second mkdir call could fail because the first had already created the directory MakeDirectories was being called on. -- MOS_MIGRATED_REVID=93531813
* Build 'client' target with -Wno-sign-compare.Gravatar Thiago Farina2015-05-15
| | | | | | | | | | | | This way we don't get the following warning when building with -Wall: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] -- Change-Id: I259c2398c2d8df5b3444d2d2ed6d45d8c5cfceef Reviewed-on: https://bazel-review.googlesource.com/1291 MOS_MIGRATED_REVID=93514679
* Cleanup: Remove unused GetMountpoint() function.Gravatar Thiago Farina2015-05-15
| | | | | | | | | This was found by building 'client' target with -Wall. -- Change-Id: If14355813b83b9e29b36411eaf597de8d57bda6e Reviewed-on: https://bazel-review.googlesource.com/#/c/1290 MOS_MIGRATED_REVID=93415497
* Update include guards.Gravatar Han-Wen Nienhuys2015-05-15
| | | | | -- MOS_MIGRATED_REVID=93413161
* Remove declaration of **environ from blaze.cc.Gravatar Thiago Farina2015-05-08
| | | | | | | | | | | | The one we need is already in option_processor.cc. Tested on Linux with the following command line: $ ./bootstrap_test.sh all -- Change-Id: I5cdd781d0c2e20242773db1ccb7e9eccd2980a78 MOS_MIGRATED_REVID=93122461
* Fix the remaining 'seperated' typos.Gravatar Thiago Farina2015-05-08
| | | | | | | | | | | | | I forgot to look at the header file when doing https://github.com/google/bazel/commit/a0592a13c8801f395a17641579f16a3c3bc4587e. Now I ran the following command line to make sure I didn't miss any: $ git grep seperated -- Change-Id: Id834f87667135e91bd0c3024e0a99e52954a7038 MOS_MIGRATED_REVID=93120398
* Fix 'seperated' typo in ProcessArg() parameter.Gravatar Thiago Farina2015-05-07
| | | | | | | | s/seperated/separated. -- Change-Id: I303e4ff20b241c2c58fe00ad0a5e340b5bff54d9 MOS_MIGRATED_REVID=93025985
* Cleanup: Remove GetJvm() function declaration.Gravatar Thiago Farina2015-05-07
| | | | | | | | There is no implementation and thus nobody is calling/using it. -- Change-Id: I2cf184e3d80eb0ef2b04ea4617697e8426cc7a58 MOS_MIGRATED_REVID=93018104
* Remove comment about a limitation that does not exist anymore.Gravatar Thiago Farina2015-05-07
| | | | | | | | | Since we are now in C++11, this comment about C++03 and ARRAYSIZE() macro (which we don't even have) does not apply and thus we can just remove it. -- Change-Id: Id0c0c59eab5b90ff5f70d5078caa2c8e618d787a MOS_MIGRATED_REVID=93017596
* Cleanup: Use the standard types from stdint.h.Gravatar Thiago Farina2015-05-05
| | | | | | | | | Now that our toolchain supports stdint.h, we don't need to provide our custom types ourselves through numbers.h. -- Change-Id: I01de083e735e5cd64bcca723b19c55b9429632b7 MOS_MIGRATED_REVID=92840495
* Cleanup: Mark some functions as static.Gravatar Thiago Farina2015-04-28
| | | | | | | | | Like the other functions in this file, these do not need to be public. So lets mark them as static so they are consistent with the surrounding code. -- Change-Id: I8de8d1578c0f9bdfec0fee3f67b527de4e135a82 MOS_MIGRATED_REVID=92281179
* Cleanup: Do not include unnecessary headers in blaze_util.h.Gravatar Thiago Farina2015-04-28
| | | | | | | | | | | | The header only uses std::string, std::vector, int and char types, and thus all these headers do not need to be included there. If necessary, they should be included in the relevant source files instead. -- Change-Id: Id1849a0f427016dcf732fe6bfc673e599e8d4b14 MOS_MIGRATED_REVID=92192506
* Explain extra_options more clearly.Gravatar Han-Wen Nienhuys2015-04-27
| | | | | -- MOS_MIGRATED_REVID=92152092
* Move blaze_exit_code.h into util/ directory.Gravatar Thiago Farina2015-04-24
| | | | | | | | This is so util/ files do not depend on anything from higer level. -- Change-Id: I522be6722851f25e79d9c2b85275856cbbd978de MOS_MIGRATED_REVID=91882837
* Header cleanups.Gravatar Han-Wen Nienhuys2015-04-22
| | | | | -- MOS_MIGRATED_REVID=91681168
* Check that getenv() returns non-null in blaze::Which()Gravatar Damien Martin-Guillerez2015-04-14
| | | | | | | | getenv() returns value was not checked for non-null result and it led to exception raised at runtime on some corner case (see bug #113). -- MOS_MIGRATED_REVID=91071694