aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/cpp/blaze_util.h
Commit message (Collapse)AuthorAge
* Remove the check for the existence of the server process in the signal ↵Gravatar Lukacs Berki2016-06-21
| | | | | | | | | handler in the client. This makes Ctrl-C work on Windows somewhat: in particular, in non-batch mode and while no actions are running. -- MOS_MIGRATED_REVID=125318172
* Revert server.pid to be a symlink so that old server version can shut down ↵Gravatar Lukacs Berki2016-04-26
| | | | | | | | | new ones. Add server.pid.txt that contains the same information in text form. ExecuteDaemon() on Windows will simply not write server.pid . -- MOS_MIGRATED_REVID=120802055
* Factor out various ways to execute subprocesses into separate functions.Gravatar Lukacs Berki2016-04-25
| | | | | | | This is so that they can be implemented properly for Windows. For now, though, they are left in blaze_util.cc since the Windows implementations aren't there yet. -- MOS_MIGRATED_REVID=120709884
* cpp: keep the documentation of MakeAbsolute() function up-to-dateGravatar Thiago Farina2016-04-22
| | | | | | | | | | | | | | commit 2ad804cef42f: ("Fixed bugs blocking bazel shell test on Windows"), updated the documentation in blaze_util.cc but forgot to update the same doc comment in the header file. To prevent this from happening again, this copies the added sentence to the header file and deletes the documentation from the source file. -- Change-Id: I240b3a31d7b457ef4d50558f1ca54619666b8d2c Reviewed-on: https://bazel-review.googlesource.com/#/c/3470 MOS_MIGRATED_REVID=120561630
* Remove unused declared function AddJVMSpecificArguments.Gravatar Nathan Harmata2016-03-11
| | | | | | | | | Kudos to @tfarina for pointing out this dead function declaration. An older commit (prior to bazel being open sourced) moved the file out of blaze_util.cc but forgot to delete the function declaration from the header file. And a subsequent change (also before bazel was open sourced) renamed/moved the implementation to a place that is now internal-only. -- MOS_MIGRATED_REVID=116980458
* cpp: some minor changes to the usage of DeleteFile() functionGravatar Thiago Farina2016-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This functions was introduced by commit bf98f39d5d69: "Add the ability to customize the bazel client's...", but at that time it didn't update EnsureCorrectRunningVersion() function, that uses unlink() function, to use DeleteFile() as well. So this patch updates EnsureCorrectRunningVersion() to make use of it now. While there is nothing wrong with the current name, it is not very much correct from the documentation point. If the path is a symlink, unlink() will just the symbolic link and the file won't be removed (affected at all). Otherwise, if it is just a normal file, it will just decrement the link count of the file and when that count reaches zero (0) then the file will longer be accessible. So while at it we renamed the function to UnlinkPath(), but could just stay as DeleteFile() if we wanted. In this process we also improved the documentation for this function to be a little more clear and removed moved it from the source file, since the header file already has it. For further reference, adhere to the documentation in http://pubs.opengroup.org/onlinepubs/009695399/functions/unlink.html. -- Change-Id: I0fc569f3324322cbc67a8fb540836c127f5c3399 Reviewed-on: https://bazel-review.googlesource.com/#/c/3061/ MOS_MIGRATED_REVID=116769254
* Add the ability to customize the bazel client's exit code used when the ↵Gravatar Nathan Harmata2016-01-08
| | | | | | | bazel server exits abruptly. -- MOS_MIGRATED_REVID=111641619
* Rationalize copyright headersGravatar Damien Martin-Guillerez2015-09-25
| | | | | | | | | | | The headers were modified with `find . -type f -exec 'sed' '-Ei' 's|Copyright 201([45]) Google|Copyright 201\1 The Bazel Authors|' '{}' ';'` And manual edit for not Google owned copyright. Because of the nature of ijar, I did not modified the header of file owned by Alan Donovan. The list of authors were extracted from the git log. It is missing older Google contributors that can be added on-demand. -- MOS_MIGRATED_REVID=103938715
* Avoid command line argument mangling on Windows.Gravatar Dmitry Lomov2015-08-12
| | | | | | | | | | | | | | exec(3) under mingw converts every command line argument that looks like Unix path into Windows path when executing non-mingw images (criteria for non-mingw image is that the image does not depend on msys-<version>.dll). This affects bazel labels (`//foo:bar` becomes `/foo:bar` for example). This CL: 1) Replaces usage of execv(3) with Windows-native CreateProcess. 2) Converts all command line arguments that are indeed paths into Windows paths. -- MOS_MIGRATED_REVID=100386350
* Use custom util instead of std::to_string.Gravatar Googler2015-07-23
| | | | | | | std::to_string is not avcaliable on mingw. -- MOS_MIGRATED_REVID=98923935
* Cleanup: Remove unused Is64BitBlazeJavabase() function declaration.Gravatar Thiago Farina2015-06-01
| | | | | | | | | | This function has only a declaration, no implementation and thus no uses. Confirmed that it has no uses internally as well. -- Change-Id: Ifd9214b546f304077e4d729bf22abf6b49cc6af1 Reviewed-on: https://bazel-review.googlesource.com/1411 MOS_MIGRATED_REVID=94763256
* Remove unused helper functions.Gravatar Han-Wen Nienhuys2015-05-27
| | | | | -- MOS_MIGRATED_REVID=94577279
* Cleanup: Pass std::string arguments by reference (this avoids makingGravatar Thiago Farina2015-05-18
| | | | | | | | | | | | | unnecessary copies) and label them const, per the Google style guide. Tested: $ ./bootstrap_test.sh all -- Change-Id: I17636703cf43283f71b9b913c130a51065bd896b Reviewed-on: https://bazel-review.googlesource.com/1350 MOS_MIGRATED_REVID=93876332
* Remove race condition from directory creation in launcherGravatar Kristina Chodorow2015-05-15
| | | | | | | | | If someone ran two Bazel commands at the same time, the second mkdir call could fail because the first had already created the directory MakeDirectories was being called on. -- MOS_MIGRATED_REVID=93531813
* Update include guards.Gravatar Han-Wen Nienhuys2015-05-15
| | | | | -- MOS_MIGRATED_REVID=93413161
* Cleanup: Remove GetJvm() function declaration.Gravatar Thiago Farina2015-05-07
| | | | | | | | There is no implementation and thus nobody is calling/using it. -- Change-Id: I2cf184e3d80eb0ef2b04ea4617697e8426cc7a58 MOS_MIGRATED_REVID=93018104
* Cleanup: Do not include unnecessary headers in blaze_util.h.Gravatar Thiago Farina2015-04-28
| | | | | | | | | | | | The header only uses std::string, std::vector, int and char types, and thus all these headers do not need to be included there. If necessary, they should be included in the relevant source files instead. -- Change-Id: Id1849a0f427016dcf732fe6bfc673e599e8d4b14 MOS_MIGRATED_REVID=92192506
* Move blaze_exit_code.h into util/ directory.Gravatar Thiago Farina2015-04-24
| | | | | | | | This is so util/ files do not depend on anything from higer level. -- Change-Id: I522be6722851f25e79d9c2b85275856cbbd978de MOS_MIGRATED_REVID=91882837
* Header cleanups.Gravatar Han-Wen Nienhuys2015-04-22
| | | | | -- MOS_MIGRATED_REVID=91681168
* Cleanup: Build file.cc as part of util library.Gravatar Thiago Farina2015-04-14
| | | | | | | | | | | | | | | | | | | | | | Looks like in the transition it was forgotten to be moved to the new location. As an effect of this change it was discovered that file.cc had an dependency back on blaze_util.cc (from client binary for die/pdie functions). In order to fix that dependency we have had to move die/pdie functions into util library (added errors.(cc|h)) for this. Tested on Linux with the following command lines: $ ./compile.sh $ ./output/bazel build //src/main/cpp:all $ ./output/bazel build //src:bazel $ ./bootstrap_test.sh all -- Change-Id: I70fb1b6189dc5af31f816332d76efe380ef26302 MOS_MIGRATED_REVID=90987514
* Cleanup: Remove unused SPAM variable.Gravatar Thiago Farina2015-04-03
| | | | | | | | | The same functionality is already provided by blaze_util::VerboseLogging() function. -- Change-Id: I6102ffd985354e666dc8440080de6c35146199cb MOS_MIGRATED_REVID=90155343
* Read the whole file descriptor instead of reading part of it for java ↵Gravatar Damien Martin-Guillerez2015-02-10
| | | | | | | | | -version parsing. The one-time read sometime fails when the JAVA_TOOL_OPTIONS is set making Bazel unable to detect JDK version. -- MOS_MIGRATED_REVID=85984806
* Update from Google.Gravatar Han-Wen Nienhuys2015-02-25
-- MOE_MIGRATED_REVID=85702957