aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/java_tools
Commit message (Collapse)AuthorAge
* Explicitly cast ByteBuffer in clear() call to Buffer.Gravatar Tobias Werth2018-08-14
| | | | | | | | | | | | | This works around the following error: java.lang.NoSuchMethodError: java.nio.ByteBuffer.clear()Ljava/nio/ByteBuffer; at com.google.devtools.build.lib.profiler.Profiler$BinaryFormatWriter.run(Profiler.java:949) at java.lang.Thread.run(Thread.java:748) JDK 9 introduced an overloaded methods with covariant return type. Closes #5886. PiperOrigin-RevId: 208642556
* 'DumpPlatformClasspath' now dumps the current JDK's default platform classpathGravatar cushon2018-08-08
| | | | | | | | | | | instead of indirecting through javac's bootclasspath handling and attempting to pin to a particular source version. This is a stop-gap until we can just use javac's --release flag. Using the output of DumpPlatformClasspath as the bootclasspath for the default java_toolchain side-steps issues with @local_jdk (see #5744, #5594). PiperOrigin-RevId: 207890272
* Temporarily ignore some spurious diagnostics related to running javac9 on JDK 10Gravatar cushon2018-08-07
| | | | PiperOrigin-RevId: 207773685
* Remove uses of java_toolchain.encodingGravatar cushon2018-08-07
| | | | PiperOrigin-RevId: 207734653
* Tolerate empty bootclasspaths in VanillaJavaBuilderGravatar cushon2018-08-07
| | | | PiperOrigin-RevId: 207730551
* PiperOrigin-RevId: 207121273Gravatar cushon2018-08-02
|
* Quiet 'The following options were not recognized by any processor' warningsGravatar cushon2018-07-30
| | | | PiperOrigin-RevId: 206697829
* Skip strict deps suggested fix commands with strict deps disabledGravatar cushon2018-07-27
| | | | | | | instead of just skipping the add dep errors. RELNOTES: follow-up to https://github.com/bazelbuild/bazel/commit/1ac359743176e659e9c7472645e3142f3c44b9e8 PiperOrigin-RevId: 206350053
* Perform strict deps enforcement on compilations with attribution errorsGravatar cushon2018-07-26
| | | | | | | | | | | | | Reporting strict deps errors in addition to attribution errors is helpful particularly with code-generating annotation processors that may fail due to missing transitive deps. Currently those failures prevent add_dep suggestions from being emitted, making the problem harder to diagnose. The presence of other errors may prevent some SJD issues from being detected, but in theory should never lead to spurious SJD errors from being reported, so the additional errors should generally be helpful. PiperOrigin-RevId: 206261677
* Unconditionally run the SJD machinery, which is necessary for jdeps outputGravatar cushon2018-07-26
| | | | | | | | | | | | and just skip the diagnostics at the end if strict deps errors are disabled. This is necessary to javac-turbine, where we don't report strict deps errors (we rely on JavaBuilder for enforcement) but where we still want to emit jdeps. See also bazelbuild/rules_scala#559 PiperOrigin-RevId: 206257304
* PiperOrigin-RevId: 206091795Gravatar cushon2018-07-25
|
* Internal changeGravatar cushon2018-07-25
| | | | PiperOrigin-RevId: 206085005
* Kill the deps mapGravatar cushon2018-07-25
| | | | PiperOrigin-RevId: 206025645
* GenClass: Assume that prefixes that don't correspond to a known ↵Gravatar cushon2018-07-23
| | | | | | non-generated source are generated. PiperOrigin-RevId: 205756917
* Use the host javac for bootstrappingGravatar cushon2018-07-22
| | | | | | | | | | | now that the bootstrap build uses the VanillaJavaBuilder it is compatible with the host JDK's javac, and avoiding -Xbootclasspath/p makes the bootstrap build more compatible with JDK 9. See #5521 RELNOTES: N/A PiperOrigin-RevId: 205605294
* Bazel server, tools: ensure Writers are closedGravatar laszlocsomor2018-07-10
| | | | | | | | | | | | | | | | | | | | Follow-up to commit 09d20311d982606093ed881d779bb05a5ee70ed3. Use try-with-resources to ensure Writer objects are closed eagerly. Eagerly closing Writers avoids hanging on to file handles until the garbage collector finalizes the object, meaning Bazel on Windows (and other processes) can delete or mutate these files. Hopefully this avoids intermittent file deletion errors that sometimes occur on Windows. See https://github.com/bazelbuild/bazel/issues/5512 RELNOTES: none PiperOrigin-RevId: 203934471
* Bazel server, tools: ensure Readers are closedGravatar laszlocsomor2018-07-09
| | | | | | | | | | | | | | | | | | | | Follow-up to commit 59f17d6e0550bf63a0b6ef182e2d63474e058ede. Use try-with-resources to ensure Reader objects are closed eagerly. Eagerly closing Readers avoids hanging on to file handles until the garbage collector finalizes the object, meaning Bazel on Windows (and other processes) can delete or mutate these files. Hopefully this avoids intermittent file deletion errors that sometimes occur on Windows. See https://github.com/bazelbuild/bazel/issues/5512 RELNOTES: none PiperOrigin-RevId: 203771262
* Update turbine's experimental dep fixing suggestionsGravatar cushon2018-06-28
| | | | PiperOrigin-RevId: 202577988
* Remove unused strict deps module parameter.Gravatar Googler2018-06-27
| | | | | RELNOTES: none PiperOrigin-RevId: 202404085
* Make sure we pass the correct -encoding options to javacGravatar cushon2018-06-26
| | | | PiperOrigin-RevId: 202162534
* Replace //tools/defaults:jdk to //tools/jdk:*Gravatar dbabkin2018-06-26
| | | | | | | As //tools/defaults will be deprecated soon. All usages of //tools/defaults:jdk and //tools/defaults:java_toolchain should be replaced by corresponding targets in //tools/jdk/BUILD package RELNOTES:none PiperOrigin-RevId: 202114489
* Windows,Bazel client: check embedded tools fasterGravatar Laszlo Csomor2018-06-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | The Bazel client on Windows is now 50% faster to check the embedded tools than it was before. Results: - Linux: 20 ms -> 6 ms - Windows: 294 ms -> 133 ms Measurements were done with n=10 runs and a hot server, using blaze::GetMillisecondsMonotonic(). Previously the client performed the same tasks multiple times while trying to determine if a path was a good extracted binary. (E.g. converted the path to Windows format multiple times, checked if it was a directory twice, opened the path twice.) Now the client performes these tasks only once, e.g. it converts path once and stats only once. See https://github.com/bazelbuild/bazel/issues/5444 Closes #5445. PiperOrigin-RevId: 201913758
* Improve error message for invalid srcjar inputsGravatar cushon2018-06-17
| | | | | | | Fixes #5418 RELNOTES: N/A PiperOrigin-RevId: 200934846
* Update add_dep binary suggested by ImportDepsCheckerGravatar cushon2018-06-15
| | | | PiperOrigin-RevId: 200760220
* Include injecting rule kind in add_dep commandsGravatar cushon2018-06-15
| | | | | | add_dep uses this information for j_p_l rules. PiperOrigin-RevId: 200721230
* Make JavaBuilder use a unique coverage metadata directoryGravatar elenairina2018-06-08
| | | | | | | | | | | for each test instead of the same directory for all the tests. The previous implementation was using one directory for instrumenting the classes of a jar. For each each jar the metadata directory was deleted if it already existed. This is problematic for local execution when multiple tests are run in parallel because some threads will try to delete the directory and some will try to perform read/write operations on it. This is an important fix for Bazel coverage users. Fixes #4398. RELNOTES: Java coverage works now with multiple jobs. PiperOrigin-RevId: 199764483
* Print the target names of the problematic classes, for better description of ↵Gravatar cnsun2018-06-04
| | | | | | | the dependency problems. RELNOTES: None. PiperOrigin-RevId: 199170334
* Format all bzl files with buildifierGravatar vladmos2018-06-01
| | | | | | This CL aslo enables a presubmit check for correct formatting of all bzl files in //third_party/bazel. PiperOrigin-RevId: 198857055
* Resolve all super classes even if we have found missing super classes. This isGravatar cnsun2018-05-30
| | | | | | | | | necessary. If we stop resolving the super classes, then the checker will complain that some methods are missign. In fact, these methods exist, but their class is not resolved due to the existing early-break strategy. RELNOTES: none PiperOrigin-RevId: 198594008
* Always use `/` as the path separator for jar entriesGravatar cushon2018-05-25
| | | | | | Fixes #5260 PiperOrigin-RevId: 198110476
* Remove the flag --fail_on_errors.Gravatar cnsun2018-05-24
| | | | | RELNOTES:none. PiperOrigin-RevId: 197923013
* Wrap a comment line around 80 chars.Gravatar Googler2018-05-11
| | | | | RELNOTES: None. PiperOrigin-RevId: 196272337
* Records profiling information for ActionFS staging and updates.Gravatar shahan2018-05-11
| | | | PiperOrigin-RevId: 196266567
* Set Locale to English when uppercasing strings to match EnumsGravatar Jingwen Chen2018-05-11
| | | | | | | | | | | | | | | | | Fixes https://github.com/bazelbuild/bazel/issues/5157 If a user's default system locale is not `en`, `en_US` or `en_UK`, there may be a chance that `String#toUpperCase` will result in a string that does not exist in the Enum declaration. This is the case in #5157. To fix this, it's either 1) setting the Locale in the individual `toUpperCase` calls or 2) set Locale to English by default from `Bazel.java`. I chose the first because it seemed less intrusive, but I'm open to suggestions. Closes #5184. PiperOrigin-RevId: 196261078
* Flag indirect dependencies in ImportDepsChecker toolGravatar kmb2018-05-07
| | | | PiperOrigin-RevId: 195732395
* Clean up code that directly imports nested classes like Builder, Entry, etc.Gravatar jcater2018-05-02
| | | | PiperOrigin-RevId: 195090893
* Clean up code that directly imports nested classes like Builder, Entry, etc.Gravatar jcater2018-05-01
| | | | PiperOrigin-RevId: 195040539
* Fix a Bazel test.Gravatar cnsun2018-04-27
| | | | | RELNOTES:none. PiperOrigin-RevId: 194598332
* Add a silence mode to the deps checker. Now the checker can be used to dumpGravatar cnsun2018-04-27
| | | | | | | jdeps proto without emitting any warning or error. RELNOTES: none. PiperOrigin-RevId: 194593178
* Don't build Error Prone plugin during bootstrappingGravatar cushon2018-04-27
| | | | | | Follow-up to https://github.com/bazelbuild/bazel/commit/bdb75bba00dbe97e9bb99db04844096f135f59ad PiperOrigin-RevId: 194559167
* Normalize parameter name commentsGravatar cushon2018-04-27
| | | | PiperOrigin-RevId: 194512971
* Use VanillaJavaBuilder for bootstrappingGravatar cushon2018-04-26
| | | | PiperOrigin-RevId: 194504697
* Add support for native header outputs to VanillaJavaBuilderGravatar cushon2018-04-26
| | | | PiperOrigin-RevId: 194503531
* Emit jdeps proto, that is, the used jars on the regular classpath.Gravatar cnsun2018-04-26
| | | | | RELNOTES: PiperOrigin-RevId: 194461881
* Remove use of bare Immutable{List,Map,Set} Builder classes.Gravatar jcater2018-04-19
| | | | | | Always use the more-qualified class name for clarity at the site of use. There are too many classes named Builder. PiperOrigin-RevId: 193579440
* Fix a crash in javac-turbine transitive classpath fallbackGravatar cushon2018-04-18
| | | | | | | This code was failing to reset the SJD plugin before falling back, which caused a reference to a JimFS Path in the original filesystem to leak. PiperOrigin-RevId: 193421565
* 1. Avoid checking the primitive number types in annotations.Gravatar cnsun2018-04-17
| | | | | | | | 2. Remove incorrect assertion in AnnotationVisitor.visit(String, Object), and delegate the checking for arrays to visitArray(String). RELNOTES: n/a. PiperOrigin-RevId: 193256108
* Migrate to the new version of jarjarGravatar cushon2018-04-16
| | | | PiperOrigin-RevId: 193052121
* When normalizing -source and --release options, allow the last one to winGravatar cushon2018-04-13
| | | | | | | | | previously --release always took precedence. if/when Bazel defaults to using e.g. --release 9, legacy -source and -target javacopts should be respected. PiperOrigin-RevId: 192844963
* ignore made-up java/lang/Synthetic annotation that ASM sometimes insertsGravatar kmb2018-04-13
| | | | | | RELNOTES: None. PiperOrigin-RevId: 192844304