aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* ConfigurationFragmentPolicy: assume Skylark names, allow merging.Gravatar Michael Staib2016-01-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In preparation for allowing aspects to have their own configuration fragments specified, allow ConfigurationFragmentPolicy.Builder to merge with built policies more easily, setting up SetMultimaps in place of maps of sets. This changes how named (Skylark) fragments are declared in the RuleContext builder, hopefully to be a bit easier to write. In order to do this, make SkylarkModuleNameResolver the only name resolver in use (because it is the only name resolver which exists) so as to not worry about collisions of different name resolvers. This also changes isLegalConfigurationFragment's one-argument form to mean "legal in ANY configuration" rather than "legal in the target (NONE) configuration", as that is how it's used by TransitiveTargetFunction. Uses of it to mean the latter have been revised to be more explicit. Also in this CL: * refactor ConfigurationFragmentPolicy to enforce its contracts about which ConfigurationTransitions are legal * use containsEntry or containsValue rather than looking in get(key) or values() for the configuration fragment multimaps * add tests for ConfigurationFragmentPolicy * make SkylarkModuleNameResolver a static method -- MOS_MIGRATED_REVID=112191439
* Display parsing errors for WORKSPACE filesGravatar Kristina Chodorow2016-01-15
| | | | | | | | | | | | | Previously, for some types of errors, you'd just see "WORKSPACE file could not be parsed" if there was a syntax error (instead of what the syntax error was). Change-Id: Ia278cf23b79f8daba02917cdfb4cc515a87080b1 -- Change-Id: Ia278cf23b79f8daba02917cdfb4cc515a87080b1 Reviewed-on: https://github.com/bazelbuild/bazel/pull/774 MOS_MIGRATED_REVID=112190322
* fix some header guard pathsGravatar Thiago Farina2016-01-15
| | | | | | | | | They are not in third_party directory, so they should start with BAZEL. -- Change-Id: I68b561ef8d06f50e8223af432a4f8aceb1a9c09d Reviewed-on: https://bazel-review.googlesource.com/#/c/2670/ MOS_MIGRATED_REVID=112173485
* Skyfunctions can now catch up to five exceptions.Gravatar John Field2016-01-15
| | | | | | | This is a prerequisite to making some changes to PackageFunction that require handling another exception. -- MOS_MIGRATED_REVID=112172100
* Stop filtering out targets not in the graph in SkyQueryEnvironment. Instead, ↵Gravatar Janak Ramakrishnan2016-01-15
| | | | | | | | | | | | | | just warn if a target turns out to not be present. This means that queries may return unexpected results. For instance, if "query" means "bazel query --order_output=no ", then here are the results of two queries: query --universe_scope=//foo/... //foo:output_file //foo:output_file query --universe_scope=//foo/... deps(//foo:output_file) WARNING: Targets not in graph [//foo:output_file generated_file] //foo:output_file -- MOS_MIGRATED_REVID=112163475
* Optimize PackageIdentifier hash code implementation, which has shown up in ↵Gravatar Eric Fellheimer2016-01-15
| | | | | | | some recent profiling. -- MOS_MIGRATED_REVID=112161558
* Better error message for attempted builds of statically linked binaries ↵Gravatar Cal Peyser2016-01-15
| | | | | | | targeting Apple platforms. -- MOS_MIGRATED_REVID=112152418
* Propogate BAZEL_VERBOSE_FAILURES and BAZEL_SUBCOMMANDS to the execution ↵Gravatar Cal Peyser2016-01-15
| | | | | | | environments of runtime tools. -- MOS_MIGRATED_REVID=112149571
* Add a few other Label.resolveRepositoryRelative() calls to make select() ↵Gravatar Lukacs Berki2016-01-15
| | | | | | | | | | | statements work in remote repositories. This work is somewhat sisyphean; the principled thing to do would be to just do this resolution when labels are parsed. Fixes #783. -- MOS_MIGRATED_REVID=112137996
* Limit the number of parallel jobs in test Bazel instances so that running ↵Gravatar Lukacs Berki2016-01-15
| | | | | | | the tests (which spawn multiple tests in the outside Bazel instance with each its own inner Bazel instance which in turn have their own thread pool) doesn't grind the machine to a halt. -- MOS_MIGRATED_REVID=112132298
* Use general java jdk dependency for bazel debian packageGravatar Andrew Jorgensen2016-01-15
| | | | | | | | | Using java8-jdk will match both openjdk-8-jdk and oracle-java8-jdk similarly with java7-jdk. If either of them are installed on the system allowing bazel to be installed in either case. Also the jdk source is not needed to create the bazel deb pacakge. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/785 MOS_MIGRATED_REVID=112132285
* Stop recommending installing openjdk-sourceGravatar Damien Martin-Guillerez2016-01-15
| | | | | | | It isn't necessary anymore. -- MOS_MIGRATED_REVID=112132272
* Fix include for the cpp example on the websiteGravatar Emmanuel Jay2016-01-14
| | | | | | | | See https://groups.google.com/forum/#!topic/bazel-discuss/xPe-oaqWZ6s -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/787 MOS_MIGRATED_REVID=112129205
* Remove some dead code.Gravatar Ulf Adams2016-01-14
| | | | | | | | | | | | The ConfiguredTargetFunction can only throw a NoSuch{Target,Package}Exception if it's run for a non-existent target. However, it will never request a CT for a non-existent target: all labels are run through DependencyResolver in order to determine the configuration transition, which requires loading the target. If it doesn't exist, the label is never returned from the DependencyResolver, and errors are swallowed (we rely on the loading phase to report the error). -- MOS_MIGRATED_REVID=112127012
* Set external_correctness_test size to largeGravatar Damien Martin-Guillerez2016-01-14
| | | | | | | This test was timing out on ci.bazel.io: http://ci.bazel.io/job/Bazel/JAVA_VERSION=1.7,PLATFORM_NAME=linux-x86_64/298/console -- MOS_MIGRATED_REVID=112126463
* Grammar fix: "it follow" -> "it follows"Gravatar Googler2016-01-14
| | | | | -- MOS_MIGRATED_REVID=112099756
* Remove explicit GC calls in javac persistent worker.Gravatar Googler2016-01-14
| | | | | | | | | Testing seems to have shown that the original reason for this being needed (running out of file handles due to unclosed file streams) has been fixed, meaning we don't need the GC workaround anymore. -- MOS_MIGRATED_REVID=112088923
* Require all PackageSpecification objects to implement an asString method to ↵Gravatar Janak Ramakrishnan2016-01-14
| | | | | | | avoid silly stack overflow when getting the object's hash code or string representation. -- MOS_MIGRATED_REVID=112085348
* Include the new 'catastrophe' field in EvaluationResult.mergeFrom().Gravatar Googler2016-01-14
| | | | | | | This is necessary for propagating the catastrophic exception so that it is available at the top level. -- MOS_MIGRATED_REVID=112083848
* Use AutoProfiler in SkyQueryEnvironment#init. Also augment the ↵Gravatar Nathan Harmata2016-01-14
| | | | | | | WalkableGraphFactory interface with a hook to inform the factory when the WalkableGraph is done being used. -- MOS_MIGRATED_REVID=112074284
* For native rule classes, (de)serialize only explicit attrsGravatar Mark Schaller2016-01-14
| | | | | | | | | | | Native rule classes can provide default values for rules after they're deserialized, so there isn't a need to serialize those default values. This doesn't apply yet to rules with Skylark-defined rule classes, due to the non-serializablity of Skylark rule classes. -- MOS_MIGRATED_REVID=112066930
* Store excluded subdirectories as PathFragment instead of String inside ↵Gravatar Janak Ramakrishnan2016-01-14
| | | | | | | | | TargetPatternKey, since that is what is needed by callers. Also, since the PathFragments come from packages, they are guaranteed to be well-formed, so the checks we were doing were unnecessary. -- MOS_MIGRATED_REVID=112059930
* First steps towards implementing AndroidStudioInfoAspect in Skylark.Gravatar Dmitry Lomov2016-01-14
| | | | | -- MOS_MIGRATED_REVID=112042343
* Adding some links to skylark concepts g3docGravatar Googler2016-01-13
| | | | | -- MOS_MIGRATED_REVID=112039216
* Make package names in the package_group.packages attribute refer to the ↵Gravatar Lukacs Berki2016-01-13
| | | | | | | | | | | | | repository where the package group is. There is currently no way to refer to packages in other repositories and that doesn't seem to be useful, because visibility currently checks the repository name in the label and that can be changed in the main WORKSPACE file. If needed, it'd be pretty easy to implement, though. As a drive-by fix, made the parsing of the package name call into the same logic implemented in the cmdline package because code duplication is bad, mmmkay? Fixes #767. -- MOS_MIGRATED_REVID=112032508
* Use our java test runner in BazelGravatar Damien Martin-Guillerez2016-01-13
| | | | | | | | | RELNOTES[NEW]: A new java test runner that support XML output and test filtering is supported. It can be used by specifying --nolegacy_bazel_java_test or by speicifying the test_class attribute on a java_test. -- MOS_MIGRATED_REVID=112028955
* Correct a path in BUILD file comment.Gravatar Alex Humesky2016-01-13
| | | | | -- MOS_MIGRATED_REVID=112027856
* Make repository-local labels in visibility declarations actually be ↵Gravatar Lukacs Berki2016-01-13
| | | | | | | | | repository-local. Fixes #765. -- MOS_MIGRATED_REVID=112027627
* Open-source the JUnit test runner.Gravatar Damien Martin-Guillerez2016-01-13
| | | | | -- MOS_MIGRATED_REVID=112027454
* Use xcode_config build target for actions which need to resolve an xcode ↵Gravatar Chris Parsons2016-01-13
| | | | | | | version. -- MOS_MIGRATED_REVID=111978539
* cc_inc_library: Add CcSkylarkApiProvider infoGravatar Googler2016-01-13
| | | | | | | This will allow Skylark rules to interact nicely with cc_inc_library rules. -- MOS_MIGRATED_REVID=111969252
* Remove support for runtime deps artifactsGravatar Liam Miller-Cushon2016-01-13
| | | | | -- MOS_MIGRATED_REVID=111959966
* Test for extra rebuilds caused by empty files in http_archive etc.Gravatar Brian Silverman2016-01-13
| | | | | | | | | | | | | This used to cause spurious rebuilds because the timestamp (which was changed every server restart) is used for deciding whether the file changed or not. Closes #573 -- Change-Id: I0e95910353426b22b61a3573ca7465e1edcedaac Reviewed-on: https://bazel-review.googlesource.com/#/c/2390/ MOS_MIGRATED_REVID=111953023
* [scala] fix declared dependencies.Gravatar Damien Martin-Guillerez2016-01-13
| | | | | | | | | Without those dependencies, scala builds fails with sandboxing enabled -- Change-Id: I64d262ada6ab3df210e72eba53305febecfbdbaa Reviewed-on: https://bazel-review.googlesource.com/#/c/2660/ MOS_MIGRATED_REVID=111952523
* Fixing broken named anchors for common-attributes*.Gravatar Googler2016-01-13
| | | | | | | RELNOTES: -- MOS_MIGRATED_REVID=111951279
* Fix links to docs for other rules, Bazel User Manual, Build Reference, and MakeGravatar David Chen2016-01-13
| | | | | | | Variables docs for remaining Bazel rule classes. -- MOS_MIGRATED_REVID=111947479
* Doc typo: avaliable -> availableGravatar Laurent Le Brun2016-01-13
| | | | | -- MOS_MIGRATED_REVID=111946969
* Make the Bazel continuous build work again after the change that introduced ↵Gravatar Lukacs Berki2016-01-12
| | | | | | | apkbuilder. -- MOS_MIGRATED_REVID=111935178
* Don't break long words for debian control fieldsGravatar Andrew Jorgensen2016-01-12
| | | | | | | | | | | | | | | | | By default wrapping can split on `-` characters which creates the chance that any dependency with a `-` in it that falls near the wrap threshold will get split along two lines and render the control file invalid. > Text is preferably wrapped on whitespaces and right after the hyphens > in hyphenated words; only then will long words be broken if necessary, > unless TextWrapper.break_long_words is set to false. https://docs.python.org/3.1/library/textwrap.html#textwrap.TextWrapper.break_long_words Fixes #772. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/777 MOS_MIGRATED_REVID=111925490
* Reset state before test_fetchGravatar Kristina Chodorow2016-01-12
| | | | | | | | | | | | | In general the external integration tests shouldn't need to reset state between tests, but test_fetch is explicitly assuming a clean environment to start off with. Fixes #769 (I think, I can't actually test it due to #770). Change-Id: I63eef924c5b7bff3225c6b67a300d57a7675aeda -- Change-Id: I63eef924c5b7bff3225c6b67a300d57a7675aeda Reviewed-on: https://github.com/bazelbuild/bazel/pull/771 MOS_MIGRATED_REVID=111893662
* Simplifies passing the debug key to ApkBuilder.Gravatar Alex Humesky2016-01-12
| | | | | -- MOS_MIGRATED_REVID=111892954
* Adds ApkBuilder from the Android SDK to bazel's third_party with someGravatar Alex Humesky2016-01-11
| | | | | | | | | modifications to remove deprecation warnings, to create deterministic apks (removes timestamps), and to make calling ApkBuilder more convenient. RELNOTES: Timestamps within Android apks are removed to make apks deterministic. -- MOS_MIGRATED_REVID=111890659
* Use objective-C dependencies only for test that might requires them.Gravatar Damien Martin-Guillerez2016-01-11
| | | | | | | Fixes #770 to an acceptable extent. -- MOS_MIGRATED_REVID=111889925
* Fix bazel version for debian packageGravatar Damien Martin-Guillerez2016-01-11
| | | | | | | | | | 0.1.3 was transformed into 0.1.~3 instead of 0.1.3 Tested the regexp manually with: echo 0.1.3 | sed ... echo 0.1.3rc3 | sed ... -- MOS_MIGRATED_REVID=111884245
* Fix broken links in all Java rule documentation.Gravatar David Chen2016-01-11
| | | | | -- MOS_MIGRATED_REVID=111869417
* Provide rule class name to aspects.Gravatar Dmitry Lomov2016-01-11
| | | | | -- MOS_MIGRATED_REVID=111866202
* Fix compile warning for struct/class mismatchGravatar Kristina Chodorow2016-01-11
| | | | | | | | | | | | | | | | | | | | | ./compile.sh is giving: $ ./compile.sh build bazel-bin/src/bazel 🍃 Building Bazel with Bazel. INFO: Found 1 target... INFO: From Compiling src/main/cpp/blaze.cc: In file included from src/main/cpp/blaze.cc:58: ./src/main/cpp/blaze_globals.h:42:1: warning: 'GlobalVariables' defined as a struct here but previously declared as a class [-Wmismatched-tags] struct GlobalVariables { ^ ./src/main/cpp/blaze_abrupt_exit.h:23:1: note: did you mean struct here? class GlobalVariables; ^~~~~ struct 1 warning generated. -- MOS_MIGRATED_REVID=111863702
* Inside findTargetsBeneathDirectory(), invoke the callback with all targets ↵Gravatar Eric Fellheimer2016-01-11
| | | | | | | from the current package batch. -- MOS_MIGRATED_REVID=111858978
* Fix installer under OS XGravatar Damien Martin-Guillerez2016-01-11
| | | | | | | | | The installer was missing the StdRedirect.dylib after a recent change. This was breaking the Tutorial job on ci.bazel.io (and iOS builds using that installer). -- MOS_MIGRATED_REVID=111855462
* Allow to filter attributes based on the rule of the attribute.Gravatar Miguel Alcon Pinto2016-01-11
| | | | | -- MOS_MIGRATED_REVID=111854804
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-09 09:59:29 +0000