aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* allow skylark implicit output callbacks to use the rule name Gravatar Benjamin Peterson2017-02-01
| | | | | | | | | | | | | | | | | Skylark implicit output callbacks could use any nonconfigurable attribute of the rule except for "name". (As an implementation detail, "name" is easy to overlook because it's a special case in rule attribute map.) In practice, this isn't too much of a problem because the return value of a skylark implicit output callback has %{} substitutions applied to it, which do allow the rule name. However, it is weird and inconsistent to prevent implicit output callbacks from using the name. -- Change-Id: I13149b2e9689ef8b8056c612a29df9da32e39bf3 Reviewed-on: https://cr.bazel.build/8251 PiperOrigin-RevId: 146178693 MOS_MIGRATED_REVID=146178693
* Add type checking to select() keys.Gravatar Greg Estren2017-02-01
| | | | | | | | | Aside from making error messaging clearer, this stops Bazel from crashing on select({None: ...}) (a pretty anti-social error message). -- PiperOrigin-RevId: 146173043 MOS_MIGRATED_REVID=146173043
* CrosstoolCompilationSupport does not include .pch files in its module map.Gravatar Cal Peyser2017-02-01
| | | | | | -- PiperOrigin-RevId: 146169742 MOS_MIGRATED_REVID=146169742
* Refactor DirtyBuildingState to allow custom implementation on storing theGravatar Googler2017-02-01
| | | | | | | | dependencies used in last build -- PiperOrigin-RevId: 146169454 MOS_MIGRATED_REVID=146169454
* Turn on --experimental_j2objc_srcjar_processing by default.Gravatar Rumou Duan2017-02-01
| | | | | | -- PiperOrigin-RevId: 146162705 MOS_MIGRATED_REVID=146162705
* experimental_objc_library uses ImmutableSortedSet to avoid muddling inputGravatar Cal Peyser2017-02-01
| | | | | | | | order. -- PiperOrigin-RevId: 146159313 MOS_MIGRATED_REVID=146159313
* Remove apple_dynamic_library rule.Gravatar Chris Parsons2017-02-01
| | | | | | -- PiperOrigin-RevId: 146150539 MOS_MIGRATED_REVID=146150539
* Throw an exception when persistent workers are used to run tests with ↵Gravatar Kush Chakraborty2017-02-01
| | | | | | | | use_testrunner=0 -- PiperOrigin-RevId: 146150454 MOS_MIGRATED_REVID=146150454
* Add a flag to make fallback from direct to transitive classpaths an errorGravatar Liam Miller-Cushon2017-02-01
| | | | | | -- PiperOrigin-RevId: 146143641 MOS_MIGRATED_REVID=146143641
* Pass individual extdir inputs, instead of inferring a directoryGravatar Liam Miller-Cushon2017-02-01
| | | | | | | | | Corresponding JavaBuilder change: https://github.com/bazelbuild/bazel/blo[]fa9b24cb7b1e516f92a200d9087fd3ba561e5/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/JavaLibraryBuildRequest.java#L302 -- PiperOrigin-RevId: 146143519 MOS_MIGRATED_REVID=146143519
* Make the Bazel unified launcher alias point to unified_launcher_head.Gravatar Adam Michael2017-02-01
| | | | | | -- PiperOrigin-RevId: 146142811 MOS_MIGRATED_REVID=146142811
* --Gravatar John Cater2017-02-01
| | | | | PiperOrigin-RevId: 146138214 MOS_MIGRATED_REVID=146138214
* Add a little more logging so that we have more data about gRPC communication ↵Gravatar Lukacs Berki2017-02-01
| | | | | | | | issues. -- PiperOrigin-RevId: 146127950 MOS_MIGRATED_REVID=146127950
* Update documentation to note that the shrinker behavior differs from the ↵Gravatar Andrew Pellegrini2017-02-01
| | | | | | | | Gradle version in that it removes values resources instead of only minifying them. -- PiperOrigin-RevId: 146124871 MOS_MIGRATED_REVID=146124871
* Moved bazelrc and version.txt to scripts/packages to be more effectively shared.Gravatar John Cater2017-02-01
| | | | | | | | -- Change-Id: I8c6d5cdbe9e2fc19ca6a626bea26944efa36e4db Reviewed-on: https://cr.bazel.build/8550 PiperOrigin-RevId: 146120078 MOS_MIGRATED_REVID=146120078
* A minor refactoring of the way the test infrastructure gets the FileSystem ↵Gravatar Lukacs Berki2017-02-01
| | | | | | | | implementation for integration tests. -- PiperOrigin-RevId: 146114082 MOS_MIGRATED_REVID=146114082
* Simplify the Spawn interfaceGravatar Ulf Adams2017-02-01
| | | | | | | | | | | | | | | | | | | | | | | | Remove getSpawnInfo and asShellCommand, which are never really overridden in a useful way. asShellCommand moves to the Spawns class, and getSpawnInfo is only ever called by SpawnAction, and the implementation moves there. I'm considering using Spawn as the general lower-level abstraction for both local and remote execution. It sort of is that already, except it's not used consistently - we often pass a tuple of (args, env) plus possibly input and output files through parameter-heavy method call hierarchies instead of using this existing abstraction. However, I'm concerned about the amount of baggage it's carrying as well as the number of implementations for what is supposed to be a simple interface (or possibly even a simple value class), and this is an attempt to slim it down a bit. This should have no visible effects on builds. -- PiperOrigin-RevId: 146109838 MOS_MIGRATED_REVID=146109838
* Rename inputsExemptFromDiscovery to prunableMandatoryInputs, which seems to ↵Gravatar Lukacs Berki2017-02-01
| | | | | | | | be a saner name. -- PiperOrigin-RevId: 146109129 MOS_MIGRATED_REVID=146109129
* Rollback of commit 00ac342f386be8b8ce1bdb11515c7828e86903c0.Gravatar Yun Peng2017-01-31
| | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Roll forward commit bbfa9fa5ad1dd66ecedcb136a4ff3d0f8d397b9b with fix *** Original change description *** Automated [] rollback of commit bbfa9fa5ad1dd66ecedcb136a4ff3d0f8d397b9b. *** Reason for rollback *** Wrong submit with unresolved issues *** Original change description *** Java template windows performance Address issue #2426 Closes #2427. -- PiperOrigin-RevId: 146108597 MOS_MIGRATED_REVID=146108597
* Bazel can now be built on Windows with MSVCGravatar Laszlo Csomor2017-01-31
| | | | | | | | | | | | | | | | | | | | | | | | bazel build //src:bazel --cpu=x64_windows_msvc now succeeds, hooray! This change adds empty implementations for build-runfiles and process-wrapper to make that possible. This means we can now build a bazel binary that doesn't depend on MSYS. The resulting binary is not yet functional because many methods are still to be implemented, and they just write "TODO: implement" or something similar. But still this is great news, because now we can add compile tests to the CI for MSVC! See https://github.com/bazelbuild/bazel/issues/2107 -- PiperOrigin-RevId: 146106178 MOS_MIGRATED_REVID=146106178
* Simplify action input discovery by removing ↵Gravatar Lukacs Berki2017-01-31
| | | | | | | | | | Action#getInputsWhenSkippingInputDiscovery(). This has the side effect of always allowing new inputs to be discovered when Action#discoversInputs() return true, but since those actions are very few and have mostly to do with C++, I think it's an acceptable tradeoff for th ecode being that much simpler. -- PiperOrigin-RevId: 146098150 MOS_MIGRATED_REVID=146098150
* //src/main/cpp:client now compiles with MSVCGravatar Laszlo Csomor2017-01-31
| | | | | | | | | | | | Add a missing method definition to (and delete two dead ones from) file_windows.cc, so we can now build it with --cpu=x64_windows_msvc. See https://github.com/bazelbuild/bazel/issues/2107 -- PiperOrigin-RevId: 146095459 MOS_MIGRATED_REVID=146095459
* Install guide: add known issues; Windows doc fixesGravatar Laszlo Csomor2017-01-31
| | | | | | | | | | | | | | | Add a list of known issues (currently only on Windows) when trying to build from source. Also update the Windows run/compile requirements. Motivated by: https://github.com/bazelbuild/bazel/issues/2431 https://github.com/bazelbuild/bazel/issues/2449 -- PiperOrigin-RevId: 146091804 MOS_MIGRATED_REVID=146091804
* Create a tool for building resource jarsGravatar Liam Miller-Cushon2017-01-31
| | | | | | | | | Move the functionality for building resources jars out of JavaBuilder, in preparation for building resource jars as a separate action. -- PiperOrigin-RevId: 146086774 MOS_MIGRATED_REVID=146086774
* Don't add the output directory to the classpathGravatar Liam Miller-Cushon2017-01-31
| | | | | | | | | This was a work-around for a javac bug, and is unnecessary now that we're setting locations using the API. -- PiperOrigin-RevId: 146079935 MOS_MIGRATED_REVID=146079935
* Don't short-circuit runfiles creation in tests if the output MANIFEST file ↵Gravatar Janak Ramakrishnan2017-01-31
| | | | | | | | is a symlink. That may indicate that it points to the input manifest, and so comparing the manifests in this case would be useless. -- PiperOrigin-RevId: 146048132 MOS_MIGRATED_REVID=146048132
* Fix test breakage, which tests build flags to be canonical, by maintaining ↵Gravatar Andrew Pellegrini2017-01-31
| | | | | | | | | | --android_resource_shrinking and --experimental_android_resource_shrinking as separate flags that affect the same behavior, instead of utilizing the 'oldName' feature of Options. RELNOTES: -- PiperOrigin-RevId: 146024304 MOS_MIGRATED_REVID=146024304
* Bazel bootstrapping: make it work on Windows againGravatar Laszlo Csomor2017-01-31
| | | | | | | | | | | | | | | | | | | | | In this change: (1) add a sanity check to verify that GNU bintools are on the PATH (2) correct the PATH on Windows if (1) failed (3) use "<user>/My Documents/Temp" as the default temp directory instead of "%windir%/Temp", because the latter is non-writable Motivated by: https://github.com/bazelbuild/bazel/issues/2431 https://github.com/bazelbuild/bazel/issues/2449 -- PiperOrigin-RevId: 146006796 MOS_MIGRATED_REVID=146006796
* Global cleanup change.Gravatar Googler2017-01-31
| | | | | | -- PiperOrigin-RevId: 146005461 MOS_MIGRATED_REVID=146005461
* Move debian package building into its own package. Gravatar John Cater2017-01-31
| | | | | | | | | | | | | | | As more package options are added, it's confusing that the debian package is generated in scripts/package/BUILD, but scripts/package/debian/ contains the related files (and isn't itself a Bazel package). This change makes the file locations more predictable, and also makes it easier to see what is happening in scripts/packages. -- Change-Id: Id8c445fc164a1a4aa09c52559a5143578cfdea88 Reviewed-on: https://cr.bazel.build/8510 PiperOrigin-RevId: 146003934 MOS_MIGRATED_REVID=146003934
* Split transitions that return an empty list of options do not suppress ↵Gravatar Cal Peyser2017-01-30
| | | | | | | | | | dynamic ruleclass transitions. -- PiperOrigin-RevId: 146000375 MOS_MIGRATED_REVID=146000375
* When the apple crosstool transition is being used (set with ↵Gravatar Cal Peyser2017-01-30
| | | | | | | | --apple_crosstool_transition), the APPLE_CROSSTOOL distinguisher does not modify output directory. -- PiperOrigin-RevId: 145999133 MOS_MIGRATED_REVID=145999133
* Change depset conversion to stringsGravatar Vladimir Moskva2017-01-30
| | | | | | | | | | RELNOTES[INC]: Depsets (former sets) are converted to strings as "depset(...)" instead of "set(...)". -- PiperOrigin-RevId: 145990995 MOS_MIGRATED_REVID=145990995
* Fix the translation of names of implicit or latebound attributes to their ↵Gravatar Florian Weikert2017-01-30
| | | | | | | | | | Skylark equivalent (from '$attr' and ':attr' to '_attr'). This CL eliminates duplicate code and makes sure that attribute names in SkylarkClassObjects are properly translated. -- PiperOrigin-RevId: 145986380 MOS_MIGRATED_REVID=145986380
* Bazel client: platform-specific JoinPath Gravatar László Csomor2017-01-30
| | | | | | | | | | | | | This allows joining paths on "\" instead of "/" when building for Windows. See https://github.com/bazelbuild/bazel/issues/2107 -- Change-Id: I417ba40af6530650be2394db4bd445f0883d40e5 Reviewed-on: https://cr.bazel.build/8495 PiperOrigin-RevId: 145961689 MOS_MIGRATED_REVID=145961689
* Fix //src/test/cpp/util:logging_test on Windows Gravatar László Csomor2017-01-30
| | | | | | | | | | | | | | | Set $TMP to $TEST_TMPDIR, so that the CaptureStderr can safely call SetTempPathA and not get C:\Windows\ back as a result, which is unfortunately read-only. See https://github.com/bazelbuild/bazel/issues/2107 -- Change-Id: If63cb028f677d9a0d9597f83afc9e08f2e5d2529 Reviewed-on: https://cr.bazel.build/8494 PiperOrigin-RevId: 145961529 MOS_MIGRATED_REVID=145961529
* Update dict docsGravatar Jon Brandvein2017-01-30
| | | | | | -- PiperOrigin-RevId: 145859025 MOS_MIGRATED_REVID=145859025
* Expands the number of attributes that XcodeVersionProperties provides to ↵Gravatar Sergio Campama2017-01-30
| | | | | | | | Skylark. -- PiperOrigin-RevId: 145836240 MOS_MIGRATED_REVID=145836240
* Remove --ios_multi_cpus (simulator & device) restriction on the ↵Gravatar Chris Parsons2017-01-30
| | | | | | | | objc_bundle_library rule -- PiperOrigin-RevId: 145834899 MOS_MIGRATED_REVID=145834899
* Add intellij_plugin_debug_target rule.Gravatar Googler2017-01-30
| | | | | | | | This rule allows deploying more than just a single jar. It can also read structure from pkgfilegroup, allowing deployment of non-single-jar plugins. -- PiperOrigin-RevId: 145828461 MOS_MIGRATED_REVID=145828461
* Tiny cleanup: narrow the scope of two variable declarations.Gravatar Greg Estren2017-01-30
| | | | | | -- PiperOrigin-RevId: 145827720 MOS_MIGRATED_REVID=145827720
* Fix error handling in WorkspaceFile/WorkspaceASTGravatar Kristina Chodorow2017-01-30
| | | | | | -- PiperOrigin-RevId: 145818492 MOS_MIGRATED_REVID=145818492
* Switch to RunfilesSuppliers for communicating runfilesGravatar Michajlo Matijkiw2017-01-30
| | | | | | | | | | | | | | | | | | | | | | | ActionSpawn/SpawnAction now deal exclusively in RunfilesSuppliers, manifests maps are no more. There is some lingering awkwardness, in particular: - Manifests still need to be tracked in some places, we can work out if this is still necessary on a case by case basis. - Skylark makes actions' runfiles available via 'resolve_command' where they are consumed by 'action'. I've updated the documentation, though the name isn't entirely accurate anymore. That being said these interfaces _are_ marked as experimental, so we _should_ be able to be flexible here. Overall, I think the benefits consolidating runfiles into suppliers, from both code cleanliness and performance perspectives (no longer needing to parse manifests), outweights the awkwardnesses. RELNOTES: resolve_command/action's input_manifest return/parameter is now list -- PiperOrigin-RevId: 145817429 MOS_MIGRATED_REVID=145817429
* Fix the images in the recursive WS design docGravatar Kristina Chodorow2017-01-30
| | | | | | | | | | | Somehow they were all uploaded as 0 bytes, but that's okay because the URLs in the design doc were wrong, anyway. Relavant design doc: https://bazel.build/designs/2016/09/19/recursive-ws-parsing.html, issue #1943. -- PiperOrigin-RevId: 145799866 MOS_MIGRATED_REVID=145799866
* Create a base implementation of GenRule that can be used by both Bazel andGravatar John Cater2017-01-30
| | | | | | | | internal Google code. -- PiperOrigin-RevId: 145795255 MOS_MIGRATED_REVID=145795255
* Framework resource deduping (framework resources are kept in the framework ↵Gravatar Chris Parsons2017-01-30
| | | | | | | | bundle, not the top level) -- PiperOrigin-RevId: 145795138 MOS_MIGRATED_REVID=145795138
* Update print() doc to admonish use in production codeGravatar Jon Brandvein2017-01-30
| | | | | | -- PiperOrigin-RevId: 145792618 MOS_MIGRATED_REVID=145792618
* Bazel client: platform-dependent `strerror` Gravatar László Csomor2017-01-27
| | | | | | | | | | | | | | Move `strerror` calls into errors_<platform>. We have to get rid of direct `errno` reading too, because it doesn't work on Windows native. Fixes https://github.com/bazelbuild/bazel/issues/2411 -- Change-Id: I69ff502487d698aa9e9147f02fd0bc5253e94e64 Reviewed-on: https://cr.bazel.build/8490 PiperOrigin-RevId: 145777524 MOS_MIGRATED_REVID=145777524
* Unify CppCompileActionContext#{getScannedIncludeFiles,findAdditionalInputs}.Gravatar Lukacs Berki2017-01-27
| | | | | | | | They differed only in reporting action state and the way they reported "no include scanning happened" so there was no reason to have both of them around. -- PiperOrigin-RevId: 145773972 MOS_MIGRATED_REVID=145773972
* Create aliases for tools for upcoming android_device rule.Gravatar Adam Michael2017-01-27
| | | | | | | | Note that these aliases are intentionally not yet functional. Nothing should be trying to build them. -- PiperOrigin-RevId: 145746166 MOS_MIGRATED_REVID=145746166
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-02 09:03:52 +0000