aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Release script: add a --force_rc command to override the candidate numberGravatar Damien Martin-Guillerez2016-11-21
| | | | | | | -- Change-Id: I9eb4897dd65e1f63fb4a1ff59ba901f81cd2e6c0 Reviewed-on: https://cr.bazel.build/7336 MOS_MIGRATED_REVID=139580860
* Implement 'output_groups' provider.Gravatar Dmitry Lomov2016-11-21
| | | | | | | | | | This behavior - that 'output_groups' is a provider available on targets and aspects - has been accidental, but people already depend on it. This CL keeps that behavior, while fixing the bug that two aspects could not both provide output groups. -- MOS_MIGRATED_REVID=139578378
* Move Bazel-specific functions in a separate file.Gravatar Laurent Le Brun2016-11-21
| | | | | | | | "type", "set" and "select" should not be part of the standalone Skylark library. -- MOS_MIGRATED_REVID=139578095
* The fully link action in experimental_objc_binary has crosstool inputs.Gravatar Cal Peyser2016-11-21
| | | | | -- MOS_MIGRATED_REVID=139576152
* Add a test verifying that bazel can be bootstrapped from the distfileGravatar Klaus Aehlig2016-11-21
| | | | | | | | | | To verify that the distribution artifact is complete, add a test that tries to bootstrap bazel from that artifact. -- Change-Id: I40ea0054efee9a4fa11f2c9088a076ad07d03ff2 Reviewed-on: https://bazel-review.googlesource.com/#/c/7452 MOS_MIGRATED_REVID=139575188
* Add a design doc on how to invalidate (Skylark) remote repositoriesGravatar Damien Martin-Guillerez2016-11-21
| | | | | | | -- Change-Id: I86660a0101261b42a06bb94afe0bc9f0bc5e5528 Reviewed-on: https://cr.bazel.build/6697 MOS_MIGRATED_REVID=139574326
* Allow labels in the '--aspects' parameter.Gravatar Dmitry Lomov2016-11-21
| | | | | -- MOS_MIGRATED_REVID=139573590
* compile_windows.sh: Fix zipping Windows Bazel binaryGravatar Yun Peng2016-11-18
| | | | | -- MOS_MIGRATED_REVID=139573133
* compile_windows.sh: Remove .exe extension when copying ./bazel-bin/src/bazelGravatar Yun Peng2016-11-18
| | | | | -- MOS_MIGRATED_REVID=139572117
* Remove --workspace_status_command from windows bootstrapGravatar Yun Peng2016-11-18
| | | | | | | On Windows, passing a shell script to this command will lead to a crash. -- MOS_MIGRATED_REVID=139570957
* Fix up documentation for Actions APIGravatar Jon Brandvein2016-11-18
| | | | | -- MOS_MIGRATED_REVID=139569372
* Bazel client: create a wrapper around Unix pipesGravatar Laszlo Csomor2016-11-18
| | | | | | | | | This allows implementing pipe-handling in a platform-specific way. Windows also supports pipes but through its own API. -- MOS_MIGRATED_REVID=139564316
* Add # support for LabelValidator as discussed in #2006Gravatar Meng Zhang2016-11-18
| | | | | | | | | | | | As suggested by @damienmg in #2006 send this out to run it with internal test. Closes #2059 . Progress towards #374. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/2059 MOS_MIGRATED_REVID=139562084
* Fix JAVA_HOME format on WindowsGravatar Yun Peng2016-11-18
| | | | | | | fixed https://github.com/bazelbuild/bazel/issues/2102 -- MOS_MIGRATED_REVID=139562049
* Mark pkg_tar dependencies as Python 3 compatibleGravatar Damien Martin-Guillerez2016-11-18
| | | | | | | This should allow to use pkg_tar from project that use python 3 (e.g. TensorFlow). -- MOS_MIGRATED_REVID=139561406
* Bazel client: reduce dependency on <unistd.h>Gravatar Laszlo Csomor2016-11-18
| | | | | | | | | | | | | | | | | | In this change: - rename WriteFileToStreamOrDie to WriteFileToStderrOrDie (since we only ever used it for stderr) - replace open/write/read/close operations with blaze_util::ReadFile/WriteFile - wrap ToString(getpid()) in a utility function - move SyncFile to file_<platform> -- MOS_MIGRATED_REVID=139560397
* Extract the integration setup to a new class IntegrationMock.Gravatar Ulf Adams2016-11-18
| | | | | -- MOS_MIGRATED_REVID=139558919
* Pass caller information manually to logger when logging in ↵Gravatar Janak Ramakrishnan2016-11-18
| | | | | | | InvocationPolicyEnforcer. This showed up in profiling. -- MOS_MIGRATED_REVID=139521927
* Add bitcode linker flagsGravatar Dmitry Shevchenko2016-11-18
| | | | | | | | | | * Adds a link time option to embed bitcode, in addition to the existing compile time option. * This does not handle Bitcode symbols, just hides them. RELNOTES: -- MOS_MIGRATED_REVID=139520095
* Remove unused SupportData.getUsedDirectDeps().Gravatar Carmi Grushko2016-11-18
| | | | | -- MOS_MIGRATED_REVID=139514666
* Initializes BuildViewTestCase's configuration factory with ruleClassProvider'sGravatar Greg Estren2016-11-18
| | | | | | | | | | | fragments. This lets the master test configs include custom fragments that can get injected in an overridden getRuleClassProvider(). Also adds ability to run BuildViewTestCases in any dynamic configuration mode. -- MOS_MIGRATED_REVID=139513822
* Introduce a failFast mode to OutputFormatterCallback#close.Gravatar Nathan Harmata2016-11-18
| | | | | -- MOS_MIGRATED_REVID=139508838
* Adds J2Objc providers to experimental_objc_library.Gravatar Cal Peyser2016-11-18
| | | | | -- MOS_MIGRATED_REVID=139503899
* Adding an option to set the digest function that everything uses. Minor ↵Gravatar Ola Rozenfeld2016-11-18
| | | | | | | | | | | | | refactoring: enabling potential fast digest computation of more than one digest function type. Usage: bazel --host_jvm_args="-Dbazel.DigestFunction=SHA1" build ... Ugliness: using a system property (a static non-final variable), because the better way to do it (a flag) would result in a much, much larger refactoring. More ugliness: I have updated the minimal amount of tests. A lot of tests are still relying on the default value of MD5. Ideally, they need to be updated as well. -- MOS_MIGRATED_REVID=139490836
* Run the analysis phase with as many threads as the user wants. In order to ↵Gravatar Janak Ramakrishnan2016-11-18
| | | | | | | | | avoid memory blow-up intra-configured-target analysis, use a semaphore to ensure that CPU-bound work only occurs on #CPU-many threads. RELNOTES: Use --loading_phase_threads to control the number of threads used during the loading/analysis phase. -- MOS_MIGRATED_REVID=139477645
* Don't get output service or action input prefetcher if not running a "build" ↵Gravatar Janak Ramakrishnan2016-11-18
| | | | | | | command, to save time on the critical path of a build. -- MOS_MIGRATED_REVID=139477157
* build_event_stream_test: write stream files to temp dirGravatar Klaus Aehlig2016-11-17
| | | | | | | | | | | | In the build_event_stream_test write the files documenting the stream of events to a directory obtained from `mktemp -d`; in this way, we have a place where we can write even if run in a strictly sandboxed environment. Fixes #2084. -- Change-Id: Ia5c13e302f65704839ea6f9bf5e996caa0f1b35d Reviewed-on: https://bazel-review.googlesource.com/#/c/7374 MOS_MIGRATED_REVID=139467980
* Stop including the size of the action cache file in our crash message. I've ↵Gravatar Janak Ramakrishnan2016-11-17
| | | | | | | never seen a case it was useful, and it adds to startup latency by putting a file stat on the critical path of every command. -- MOS_MIGRATED_REVID=139467038
* Introduce support for 'expand_if_all_available' for flag_groups in CROSSTOOLGravatar Marcel Hlopko2016-11-17
| | | | | | | | | | With the recent addition of structured variables to CROSSTOOL we now need a way how to conditionally expand various flag_groups depending on the presence of particular build variable or its fields. This cl adds this support to flag groups. -- MOS_MIGRATED_REVID=139466070
* Propertly join multiple arguments to jar filter.Gravatar Googler2016-11-17
| | | | | | | Also add test to make sure jar filter handles multiple source jars correctly (which it already did). -- MOS_MIGRATED_REVID=139462526
* Add ctx.coverage_instrumented function to SkylarkGravatar Googler2016-11-17
| | | | | | | | | | | | | | | Skylark already has ctx.configuration.coverage_enabled to determine if coverage data collection is on for an entire run. But that does not reveal which targets specifically are supposed to be instrumented (based on the values of --instrumentation_filer and --instrument_test_targets). This is inefficient for languages which add coverage instrumentation at compile-time, though correct coverage output can still be produced by instrumenting everything and filtering later. By default, this function returns whether the rule represented by ctx should be instrumented. If a Skylark Target (e.g. from a label or label_list attribute in ctx.attr) is passed to the function, it instead returns whether that Target is a rule whose sources should be instrumented. Rules that directly incorporate source-files from their dependencies before compilation (e.g. header files) may need to know if those source files need to be instrumented when compiled. Expanded the documentation of instrumented_files to be a more general section on implementing code coverage instrumentation in Skylark. Also tweaked the code comment and variable names for the version of shouldIncludeLocalSources that takes a TransitiveInfoCollection. RELNOTES: Add ctx.coverage_instrumented function to Skylark, to indicate whether a specific targets should be instrumented for code coverage data collection. -- MOS_MIGRATED_REVID=139460989
* compile_windows.sh: use ${BOOTSTRAP_BAZEL}Gravatar Klaus Aehlig2016-11-17
| | | | | | | | | | | ...as compile.sh from a plain checkout won't work in the future (an unpacked distribution archive would be necessary, but using the bootstrap bazel is easier for CI). -- Change-Id: I186a9422bb1a092ced7396f396a8a158aa67e0f4 Reviewed-on: https://bazel-review.googlesource.com/#/c/7352 MOS_MIGRATED_REVID=139458547
* ObjcCompileAction does not signal to skyframe that it discovers inputs.Gravatar Cal Peyser2016-11-17
| | | | | | | | | | | Instead, it skips discovery (include scanning), but provides all headers to action execution to allow for re-adding pruned sources in a sandbox. This means that mis-capitalization errors will only break a build if --objc_use_dotd_pruning is one. -- MOS_MIGRATED_REVID=139456194
* Correct maven_server rule docs to use valid workspace nameGravatar David Jarvis2016-11-17
| | | | | | | | | | | | | The current documentation for maven_server uses a rule name of `my-server`, which is not a legal rule name due to its use of a hyphen. This commit changes the hyphen to an underscore and changes all instances of `my-server` to `my_server` Closes #2087. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/2087 MOS_MIGRATED_REVID=139452335
* Enable worker support for Closure in Bazel by default.Gravatar Philipp Wollermann2016-11-17
| | | | | -- MOS_MIGRATED_REVID=139448254
* Bazel client: no longer needs <utime.h>Gravatar Laszlo Csomor2016-11-17
| | | | | | | | | | | | Also remove a lot of unused header files. The only remaining header file not available on Windows is <unistd.h>, but cutting that dependency will be more complicated because we use read/write and similar I/O functions from it. -- MOS_MIGRATED_REVID=139439791
* Bazel client: no more `stat` usageGravatar Laszlo Csomor2016-11-17
| | | | | -- MOS_MIGRATED_REVID=139436876
* Support gold linkerGravatar Marcel Hlopko2016-11-17
| | | | | | -- Reviewed-on: https://bazel-review.googlesource.com/c/7372/ MOS_MIGRATED_REVID=139432850
* Respect --incremental_dexing flag in host configuration.Gravatar Googler2016-11-17
| | | | | -- MOS_MIGRATED_REVID=139400647
* Roll forward commit 4e8e67bcf25ea4e06c16104fc7f4db528a16508fGravatar Liam Miller-Cushon2016-11-17
| | | | | -- MOS_MIGRATED_REVID=139399869
* Fix a javac-turbine tree pruning bugGravatar Liam Miller-Cushon2016-11-17
| | | | | | | | | | | | When rewriting blocks to `{ throws new AssertionError(); }`, use a fully-qualified name for `java.lang.AssertionError` in case we're inside the declaration of a type with the same simple name. Also, only add the throws expression statement when rewriting lambda body blocks, since that's the only place it matters. -- MOS_MIGRATED_REVID=139397324
* Cache all previously computed values in ↵Gravatar Janak Ramakrishnan2016-11-17
| | | | | | | | | SkyQueryEnvironment#beforeEvaluateQuery if possible to save on latency for small queries. This assumes that if the graph is up to date, then the data in SkyQueryEnvironment is also up to date. It also assumes that a ForkJoinPool remains usable until #shutdownNow is called. -- MOS_MIGRATED_REVID=139386363
* Fix test_maven_aar_skylark with the new merger.Gravatar Adam Michael2016-11-17
| | | | | | | | | | | The AndroidManifest.xml for the android_binary did not specify a minSdkVersion, but the AAR that it depended on specified minSdkVersion=9. The legacy manifest merger was OK with this, the new one is not. See https://github.com/bazelbuild/bazel/issues/2086 -- MOS_MIGRATED_REVID=139384477
* Use num files in directory instead of num links to file in testjobs_testGravatar Mark Schaller2016-11-17
| | | | | | | | | | | | | | | | | Adding and removing hard links to a file from several processes simultaneously appears to occasionally fail on macOS. This commit changes the testjobs's test's strategy of keeping track of the number of tests running in parallel. Instead of counting the number of links to a shared file, it now counts the number of files in a shared directory. Instead of each test run adding and removing a link to a shared file, each run adds and removes a file from a directory. -- Change-Id: Idc0a9a9cf1c2f5b03221fcd991e4bf0155e62841 Reviewed-on: https://bazel-review.googlesource.com/c/7392/ MOS_MIGRATED_REVID=139384412
* Update comments in Bazel WORKSPACE regarding running maven_skylark_test.Gravatar Adam Michael2016-11-17
| | | | | | | | | | | test_maven_aar_skylark is essentially an android_integration_test and as such requires that android_sdk_for_testing and android_ndk_for_testing be properly set up. See https://github.com/bazelbuild/bazel/issues/2086 -- MOS_MIGRATED_REVID=139384309
* fix typo in example in aspects docsGravatar Evan Martin2016-11-17
| | | | | | | | | | The attribute for the source list is "srcs", not "src". Closes #2098. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/2098 MOS_MIGRATED_REVID=139380743
* Corrects some tests that fail with trimmed dynamic configurations butGravatar Greg Estren2016-11-17
| | | | | | | not untrimmed ones. -- MOS_MIGRATED_REVID=139376735
* resource_extractor.py should preserve the timestamps of entries of the input JARGravatar Adam Michael2016-11-17
| | | | | | | RELNOTES: -- MOS_MIGRATED_REVID=139370787
* "File" is capitalized in doc filenameGravatar Googler2016-11-17
| | | | | -- MOS_MIGRATED_REVID=139364083
* Rollback of commit 2153790fbebaed4aef6544fea3a85a01749b0d11.Gravatar Carmi Grushko2016-11-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Causes NPEs in tests that use AutoValue, on Kokoro and CI. Bazel uses TestRunner_deploy.jar to run tests. To save time, we use the latest Bazel release to run tests. Therefore, we use a TestRunner_deploy.jar with an AutoValue 1.2 embedded. If the test requires AV itself, we use the one from HEAD, which is 1.4-rc1, therefore causing one-definition rule violations. Once we release a TestRunner without AV (commit 90b5b19927540fc1e1c9e1a7fbd05c816ae0e4e2), we can roll forward. error: @AutoValue processor threw an exception: java.lang.NullPointerException abstract static class AutoValuedClass implements TransitiveInfoProvider { ^ at com.google.auto.value.processor.AutoValueProcessor.getFieldOfClasses(AutoValueProcessor.java:566) at com.google.auto.value.processor.AutoValueProcessor.allMethodExcludedAnnotations(AutoValueProcessor.java:818) at com.google.auto.value.processor.AutoValueProcessor.defineVarsForType(AutoValueProcessor.java:763) at com.google.auto.value.processor.AutoValueProcessor.processType(AutoValueProcessor.java:488) at com.google.auto.value.processor.AutoValueProcessor.process(AutoValueProcessor.java:195) at com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:803) at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:715) at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$2000(JavacProcessingEnvironment.java:93) at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1023) at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1130) at com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1141) at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:832) at com.sun.tools.javac.main.Main.compile(Main.java:253) at com.google.devtools.build.buildjar.javac.BlazeJavacMain.compile(BlazeJavacMain.java:140) at com.google.devtools.build.buildjar.javac.BlazeJavacMain.compile(BlazeJavacMain.java:132) at com.google.devtools.build.buildjar.AbstractJavaBuilder$1.invokeJavac(AbstractJavaBuilder.java:66) at com.google.devtools.build.buildjar.ReducedClasspathJavaLibraryBuilder.compileSources(ReducedClasspathJavaLibraryBuilder.java:81) at com.google.devtools.build.buildjar.AbstractJavaBuilder.compileJavaLibrary(AbstractJavaBuilder.java:69) at com.google.devtools.build.buildjar.AbstractJavaBuilder.run(AbstractJavaBuilder.java:108) at com.google.devtools.build.buildjar.BazelJavaBuilder.processRequest(BazelJavaBuilder.java:92) at com.google.devtools.build.buildjar.BazelJavaBuilder.runPersistentWorker(BazelJavaBuilder.java:70) at com.google.devtools.build.buildjar.BazelJavaBuilder.main(BazelJavaBuilder.java:47) *** Original change description *** Bazel to use AutoValue 1.4-rc1. The big improvement is the addition of @AutoValue.CopyAnnotations, which allows AutoValue classes to be exposed to Skylark via @SkylarkModule. -- MOS_MIGRATED_REVID=139361042