aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Introduce Root class.Gravatar tomlu2018-01-17
| | | | | | | | | | | This class represents a root (such as a package path or an output root) used for file lookups and artifacts. It is meant to be as opaque as possible in order to hide the user's environment from sky keys and sky functions. Roots are used by RootedPaths and ArtifactRoots. This CL attempts to make the minimum number of modifications necessary to change RootedPath and ArtifactRoot to use these fields. Deprecated methods and invasive accessors are permitted to minimise the risk of any observable changes. RELNOTES: None PiperOrigin-RevId: 182271759
* Suggest 'bazel clean --expunge' to fix Xcode errors in AppleCcToolchain.Gravatar ruperts2018-01-17
| | | | | RELNOTES: None. PiperOrigin-RevId: 182271042
* Add deprecation warning message to mobile-install classic mode.Gravatar Googler2018-01-17
| | | | | | | | | We've notified the top classic users by email that classic mode is deprecated. As we are no longer actively supporting classic mode, we'd like users to move over to skylark. RELNOTES: None. PiperOrigin-RevId: 182268733
* Fix forbidding of If statements in BUILD filesGravatar brandjon2018-01-17
| | | | | | | | | The bug also permitted For statements in BUILD files so long as they were contained within an If statement (i.e. not at the top level). Also add minor guidance to error messages. RELNOTES: None PiperOrigin-RevId: 182236172
* [Autocodec] Add a ImmutableSetCodec. ImmutableCollections have a deterministicGravatar Googler2018-01-17
| | | | | | iteration order so we should be okay. PiperOrigin-RevId: 182235068
* http_archive: test patch files are trackedGravatar Klaus Aehlig2018-01-17
| | | | | | | | | | Add a test verifying that changes to the patch file trigger a a rebuild of the external repository. Ensures soundness of the fix for Issue #3395. Change-Id: Ida3823b7cddbe3bb54f0f0e24074e3854055f6e1 PiperOrigin-RevId: 182226112
* Fix blaze crashes with running under JDK9.Gravatar tomlu2018-01-17
| | | | | RELNOTES: None PiperOrigin-RevId: 182223038
* Demontrate that http_archive can pick up a missing build fileGravatar Klaus Aehlig2018-01-17
| | | | | | | | | | | | The http_archive command from @bazel_tools can add a BUILD file to an external repository. Add a test ensuring that changes to that file, in particular the addition of a previously missing file, are tracked properly. Provides a workaround for #3637. Change-Id: Ibd6a3336834686a13eaa1f9ce7d4c6223410b222 PiperOrigin-RevId: 182221653
* Migrate Apple providers to abide by Native Declared Provider best practices.Gravatar cparsons2018-01-17
| | | | | | | This has the effect of documenting exposed struct fields on these providers. RELNOTES: None. PiperOrigin-RevId: 182221042
* Actually run ExternalPackageUtilTest.Gravatar John Cater2018-01-17
| | | | | | | Fixes #4443. Change-Id: I8a30823eff87457e3ef2568efbe667f29c644ed4 PiperOrigin-RevId: 182208767
* Filter out generated proto extension registry loader from instrumentation APK.Gravatar Googler2018-01-16
| | | | | RELNOTES: None PiperOrigin-RevId: 182145172
* Codec for Location.Gravatar shahan2018-01-16
| | | | | | * Moves SingletonCodec to third_party. PiperOrigin-RevId: 182143153
* Normalize javacopts for javac-turbineGravatar cushon2018-01-16
| | | | PiperOrigin-RevId: 182130131
* Have UnixGlob explicitly handle RuntimeExceptions encountered by individual ↵Gravatar nharmata2018-01-16
| | | | | | | glob tasks. RELNOTES: None PiperOrigin-RevId: 182125500
* Add an additional attempt to get a heap histogram since jmap on Bazel CI ↵Gravatar janakr2018-01-16
| | | | | | appears to be flaky in connecting to the JVM. PiperOrigin-RevId: 182118581
* If a compilation uses both -source and --release, prefer --releaseGravatar cushon2018-01-16
| | | | | | | | javac does not allow both -source and --release to be set, which makes it difficult to migrate to --release when javacopts are combined from multiple sources. PiperOrigin-RevId: 182113897
* Fix parsing for public.xml file when using aapt2.Gravatar Googler2018-01-16
| | | | | RELNOTES: none PiperOrigin-RevId: 182110722
* Add assets support to aar_import.Gravatar ajmichael2018-01-16
| | | | | | | | | Fixes https://github.com/bazelbuild/bazel/issues/4439. Empty assets are handled by writing out an empty file named "assets/empty_asset_generated_by_bazel~", which will silently be ignored by AAPT. RELNOTES: aar_import now supports assets. PiperOrigin-RevId: 182110400
* Remove mtime field from FileStateValue.Gravatar janakr2018-01-16
| | | | | | We stopped treating empty files specially in the execution phase after unknown commit. So this code is mostly if not entirely orphaned. The only scenario in which this would lead to a semantic difference that I can think of is if the user is running with --nouse_action_cache and a running Bazel server, and they have an action they want to re-run when an empty input file changes, which isn't something we need to be concerned about. PiperOrigin-RevId: 182109952
* Default to filtering resources in analysisGravatar Googler2018-01-16
| | | | | RELNOTES: none PiperOrigin-RevId: 182100169
* Also support es-r419 as a locale.Gravatar Googler2018-01-16
| | | | | RELNOTES: none PiperOrigin-RevId: 182099868
* Remove ConfigurationTransitionProxy.NULLGravatar gregce2018-01-16
| | | | PiperOrigin-RevId: 182099803
* Remove EventBus from SkyframeActionExecutorGravatar ulfjack2018-01-16
| | | | | | Post to the Skyframe Environment instead. PiperOrigin-RevId: 182096559
* Enable incremental dexing of proguarded Android binaries in Bazel (one ↵Gravatar kmb2018-01-16
| | | | | | | | | dexbuilder action by default). Binaries can opt in by adding "incremental_dexing = 1" attribute. RELNOTES: Proguarded Android binaries can be built with incremental dexing. PiperOrigin-RevId: 182092699
* Move RootedPathCodec to an inner class of RootedPath.Gravatar tomlu2018-01-16
| | | | PiperOrigin-RevId: 182087153
* Create ndk wrong path in TMPDIR, not SRCDIRGravatar George Gensure2018-01-16
| | | | | | | | | | | | test_android_ndk_repository_wrong_path presumes the wrong ndk path 'some_dir' to not exist. This test will work initially, but break if run incrementally, because of the some_dir remaining in the TEST_SRCDIR (the runfiles root for this test). Switching this over to use the ephemeral TEST_TMPDIR instead. Closes #4465. PiperOrigin-RevId: 182083666
* Add cfg = "host" to implicit executable aspect attribute because it is ↵Gravatar dannark2018-01-16
| | | | | | | required for all attributes marked executable. RELNOTES: None PiperOrigin-RevId: 182082917
* Rename Root to ArtifactRoot.Gravatar tomlu2018-01-16
| | | | | | This is slightly more descriptive, and we will potentially want to use the name Root for a broader concept shared between ArtifactRoot and RootedPath. PiperOrigin-RevId: 182082367
* HOME missing from the action env (despite mentioned in the docs)Gravatar Gursewak2018-01-16
| | | | | | | | Issue #4401 Closes #4437. PiperOrigin-RevId: 182067976
* Update pin for bazel-toolchains to latest versionGravatar xingao2018-01-16
| | | | | | https://github.com/bazelbuild/bazel-toolchains/releases/tag/f3b0970 PiperOrigin-RevId: 182058527
* Fix value collision in builtins registryGravatar brandjon2018-01-16
| | | | | | | If two values compared equal (e.g., MethodLibrary#bool and SkylarkAttr#bool), we were dropping one of them in favor of the other. RELNOTES: None PiperOrigin-RevId: 182057611
* Support array fields in AutoCodec. To do this, introduceGravatar cpeyser2018-01-16
| | | | | | | SerializationCodeGenerator, which is a generalization of Marshaller that supports primitive and array values. PiperOrigin-RevId: 182053617
* Refactor py_wrap_cc to go through CcLibraryHelper.Gravatar plf2018-01-16
| | | | | RELNOTES:none PiperOrigin-RevId: 182051418
* Fix copy-paste error in py_test docsGravatar Rodrigo Queiro2018-01-16
| | | | | Change-Id: I5fa8412fe0673b71a6e17adb39be0a208ee54f63 PiperOrigin-RevId: 182048035
* C++: Fixes linkstamp not compiled with PIC.Gravatar plf2018-01-16
| | | | | RELNOTES:none PiperOrigin-RevId: 182044727
* Change the mnemonic of C++ link stamp compile actions so that extra actions ↵Gravatar lberki2018-01-16
| | | | | | | can be attached to C++ compile actions without tickling the bug that makes Blaze crash when extra actions are attached to shared actions that do input discovery. RELNOTES: None. PiperOrigin-RevId: 182044169
* Automated rollback of commit dafe71390340224e06eab0ac7afcebb2f5219f5a.Gravatar dslomov2018-01-16
| | | | | | | | | | | | | | *** Reason for rollback *** Breaks Bazel CI (https://ci.bazel.build/job/bazel-tests/1722/) *** Original change description *** Report unsuccessful error code if bazel fetch fails in "keep going" mode. Fixes #3234. PiperOrigin-RevId: 182042503
* http_archive: support programmatic patchingGravatar Klaus Aehlig2018-01-16
| | | | | | | | | | | Support applying a sequence of commands to an http_archive, after the patch files are applied. In this way, tasks like shebang-fixes can easily be added. Fixes #3395. Change-Id: Ifdad584a852efd425c436d57ef71a0d681488629 PiperOrigin-RevId: 182037265
* C++: Updates documentation for cc_library.Gravatar plf2018-01-16
| | | | | RELNOTES:none PiperOrigin-RevId: 182033773
* Report unsuccessful error code if bazel fetch fails in "keep going" mode.Gravatar Dmitry Lomov2018-01-16
| | | | | | | Fixes #3234. Change-Id: I1bfbe856d35b98995f5a0684fe47c7566b8dd093 PiperOrigin-RevId: 182029085
* Create function createJavaInfo with new API. Implement JavaSourceJarsProvider.Gravatar dbabkin2018-01-16
| | | | | | | | | | Added tests for checking JavaSourceJarsProvider state. All other providers will be implemented in next CLs. previous CL with JavaCompilationArgsProvider implementation is https://github.com/bazelbuild/bazel/commit/32dff21d00ad7d1bdf50e8761d675a6e7e002de9 RELNOTES:none PiperOrigin-RevId: 182028182
* java,runfiles: runfiles library in @bazel_toolsGravatar Laszlo Csomor2018-01-16
| | | | | | | | | | | | | | Also make most targets in `//src/tools/runfiles` private. The user should depend on `@bazel_tools//tools/runfiles:$LANG-runfiles` instead. See https://github.com/bazelbuild/bazel/issues/4460 RELNOTES[NEW]: java,runfiles: You can now depend on `@bazel_tools//tools/runfiles:java-runfiles` to get a platform-independent runfiles library for Java. See JavaDoc of https://github.com/bazelbuild/bazel/blob/master/src/tools/runfiles/java/com/google/devtools/build/runfiles/Runfiles.java for usage information. Change-Id: Iba9113453222ae74ce42a324272711f613104891 PiperOrigin-RevId: 182022851
* Remove use of Root#asDerivedRoot where the derived root == exec root.Gravatar tomlu2018-01-15
| | | | | | | | This method violates the invariant that derived roots are never equal to the exec root. Only source roots can be equal to the exec root. Note that this method was only used in tests, so this CL should be completely safe as long as its tests pass. PiperOrigin-RevId: 181998483
* Remove test methods from ArtifactFactory and Root that violate root invariants.Gravatar tomlu2018-01-15
| | | | | | In this case, the invariant violated is creating derived roots at the exec root. PiperOrigin-RevId: 181994080
* Fix typo in example codeGravatar Googler2018-01-15
| | | | | RELNOTES: None. PiperOrigin-RevId: 181990193
* Deletes unused code: ArtifactIdRegistry, ArtifactSerializer / Deserializer.Gravatar shahan2018-01-15
| | | | PiperOrigin-RevId: 181975994
* Support patches in http_archiveGravatar Klaus Aehlig2018-01-15
| | | | | | | | | | | Support applying a sequence of patches for external repositories imported via http_archive. (Note that we only support the version from @bazel_tools, not the deprecated native rules.) Works towards #3395. Change-Id: I96c746acc04790b051eb686856c04a3ff3c90059 PiperOrigin-RevId: 181975322
* Export the runfiles path of the JVM executable to Skylark.Gravatar lberki2018-01-15
| | | | | RELNOTES: None. PiperOrigin-RevId: 181973847
* Disable test_actions_deleted_after_execution_nobatch_keep_analysisGravatar dslomov2018-01-15
| | | | | RELNOTES: None. PiperOrigin-RevId: 181971087
* Regression test for #3656.Gravatar Dmitry Lomov2018-01-15
| | | | | Change-Id: Id3d6e6da60aca3c02c7cf3e9e727ecbf177dde66 PiperOrigin-RevId: 181971084