aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Clean up obcj rules by removing ObjcActionsBuilder.Gravatar Peter Schmitt2015-05-15
| | | | | | | | Moved the last remaining logic to its corresponding support class (XcodeSupport). -- MOS_MIGRATED_REVID=93462899
* Allow "attr = glob([*]) + select({...})" intermixing inGravatar Greg Estren2015-05-15
| | | | | | | an attribute assignment. -- MOS_MIGRATED_REVID=93460093
* Make ObjcBundleLibrary use the "families" attribute.Gravatar David Santiago2015-05-15
| | | | | | | | | | | | | | | | | | | | | | Currently the ObjcBundleLibrary#create() function creates a BundleSupport object with the default "iphone" target family. An ObjcBundleLibrary is a descendant of a Bundle, which has a "families" attribute, so the information is available. Currently, ObjcBundleLibrary will unconditionally use "iphone" as the target device family. This commit updates ObjcBundleLibrary to use the "families" attribute. It does this by making BundleSupport control the "families" attribute, and then provide access to it for the other classes that use it, like ObjcBundleLibrary. The other classes are changed to get their target device family information from their BundleSupport objects. -- Change-Id: I4a5be2849315dabfe7f2975c006a2092a56027af Reviewed-on: https://bazel-review.googlesource.com/#/c/1260/3 MOS_MIGRATED_REVID=93456579
* Description redacted.Gravatar Googler2015-05-15
| | | | | -- MOS_MIGRATED_REVID=93454041
* Refine duplicate label checking for embedded selects. Before, we wereGravatar Greg Estren2015-05-15
| | | | | | | | | | | | | | | | | | | coarsely checking for duplicates *anywhere*, e.g.: select({':a': ['a.cc'], ':b': ['a.cc']}) + select({':a': ['b.cc'], ':b': ['b.cc']}) would fail. But this case is okay because these duplicates are in mutually exclusive select paths (so they could never appear together anyway). The new checking logic is: - Duplicates can appear in different paths of the same select. - Duplicates can *not* appear within the same path of a select. - Duplicates can *not* appear across multiple selects (no matter what path - this is still stricter than we need to be, but there's no strong case for refining this case now). -- MOS_MIGRATED_REVID=93447979
* Add a genrule that generates a dummy J2ObjC dead code removal script in ↵Gravatar Googler2015-05-15
| | | | | | | tools/objc/BUILD. -- MOS_MIGRATED_REVID=93447039
* Support --objc_generate_debug_symbols when --ios_multi_cpus is set.Gravatar Philipp Wollermann2015-05-15
| | | | | | | | | | | | | | | | | | | | When an ios_application is built, Bazel now collects the .breakpad files for each architecture and tweaks the first line of each file to reflect the name of the app, instead of the name of the binary: MODULE mac arm64 5A70922132B738E194DDBC456F90F43F0 PrenotCalculatorBinary_bin becomes MODULE mac arm64 5A70922132B738E194DDBC456F90F43F0 PrenotCalculator Bazel also correctly renames the files to end with their architecture, so that the crash server can use them: armv7/.../PrenotCalculatorBinary.breakpad becomes PrenotCalculator_armv7.breakpad -- MOS_MIGRATED_REVID=93419816
* Add debugging for NPE in GroupedList#toSet.Gravatar Janak Ramakrishnan2015-05-15
| | | | | -- MOS_MIGRATED_REVID=93417885
* Remove left over code.Gravatar Laurent Le Brun2015-05-15
| | | | | -- MOS_MIGRATED_REVID=93416921
* Remove dead code in SkylarkTypeGravatar Laurent Le Brun2015-05-15
| | | | | -- MOS_MIGRATED_REVID=93415666
* Cleanup: Remove unused GetMountpoint() function.Gravatar Thiago Farina2015-05-15
| | | | | | | | | This was found by building 'client' target with -Wall. -- Change-Id: If14355813b83b9e29b36411eaf597de8d57bda6e Reviewed-on: https://bazel-review.googlesource.com/#/c/1290 MOS_MIGRATED_REVID=93415497
* Make local TestStrategy bits rely less on runfiles manifestsGravatar Michajlo Matijkiw2015-05-15
| | | | | | | | | | | TestStrategy#getLocalRunfilesDirectory(...) was using manifest names to infer if the runfiles symlinks were created by comparing the name of manifests. This is a bit confusing and adds unnecessary reliance on manifests which we'd like to reduce. Instead get whether or not we created the symlinks from the boolean that determines it. -- MOS_MIGRATED_REVID=93414150
* Update include guards.Gravatar Han-Wen Nienhuys2015-05-15
| | | | | -- MOS_MIGRATED_REVID=93413161
* Test for existence of $HOME before writing ~/.bazelrc in compile.shGravatar Damien Martin-Guillerez2015-05-15
| | | | | | | Without that change, the compile.sh script fails when $HOME is unset. -- MOS_MIGRATED_REVID=93412872
* We are trying to merge same copies of the aspect, when target is declared in ↵Gravatar Marian Lobur2015-05-15
| | | | | | | different attributes, to which we have attached aspect. -- MOS_MIGRATED_REVID=93412457
* Fix order of method call in test-setupGravatar Damien Martin-Guillerez2015-05-15
| | | | | -- MOS_MIGRATED_REVID=93401974
* Fix path to test-env.sh in //src/test/shell/bazel:bazel_sandboxing_testGravatar Damien Martin-Guillerez2015-05-15
| | | | | | | Note that this test still fails on my machine. -- MOS_MIGRATED_REVID=93401330
* Fix race condition in MemoizingEvaluatorTest#cycleAndErrorAndReady.Gravatar Janak Ramakrishnan2015-05-15
| | | | | | | | | If otherTop did not enqueue its dep for evaluation before errorKey threw, its dep would never be enqueued and therefore never signal. This used to be ok because we didn't shut the threadpool down as aggressively. The fix is just to delay the actual throwing of errorKey until otherTop is signaled. -- MOS_MIGRATED_REVID=93349168
* Don't reference cc_public_library in the Bazel build encyclopedia.Gravatar Greg Estren2015-05-15
| | | | | -- MOS_MIGRATED_REVID=93332951
* RELNOTES: Set XCode build setting USE_HEADERMAP to NO for Bazel-generated ↵Gravatar Googler2015-05-15
| | | | | | | XCode project files. Bazel-generated XCode projects contain all necessary header search paths to resolve header imports. Header map is not needed. -- MOS_MIGRATED_REVID=93329329
* RELNOTES: The --skyframe flag is now deprecated and will be removed in an ↵Gravatar Janak Ramakrishnan2015-05-15
| | | | | | | upcoming release. -- MOS_MIGRATED_REVID=93328637
* Optimize AggregatingAttributeMapper.visitAttribute (which returnsGravatar Greg Estren2015-05-15
| | | | | | | | | | | | | | | | | | | | | | | | | every possible value an attribute can take) for attributes with multiple selects: Given attr = select({':a': 'w', ':b': 'x'}) + select({':a': 'y', ':b': 'z'} the naive approach is to combine every possible value of the first select with every possible value of the second select (producing 4 possible values from 2^2 visitations). But since these selects have the same exact conditions, only two values are actually possible ("wy", "xz") from 2 visitations. This change efficiently considers that case. More generally, given n concatenated selects with the same conditions, it brings evaluation time down from O(2^n) to O(n) (assuming two conditions per select). It also works for partial matches: given a concatenation of 6 selects where 1, 3, and 5 have the same conditions and 2, 4, and 6 have the same conditions, evaluation time goes from O(2^6) to O(2^2). -- MOS_MIGRATED_REVID=93325787
* Documentation for the fetch commandGravatar Kristina Chodorow2015-05-15
| | | | | | | I'm expecting some complaints once it's required. -- MOS_MIGRATED_REVID=93318895
* Don't refer to deprecated dynamically linked protoc.Gravatar Han-Wen Nienhuys2015-05-11
| | | | | -- MOS_MIGRATED_REVID=93314155
* Open-source J2ObjcConfiguration and J2ObjcCommandLineOptions.Gravatar Googler2015-05-11
| | | | | -- MOS_MIGRATED_REVID=93308663
* Grouping further more java tests in test_suiteGravatar Damien Martin-Guillerez2015-05-11
| | | | | | | Added skyframe and foundations test_suite -- MOS_MIGRATED_REVID=93308651
* Add .gitattributes to mark BUILD/bzl as python.Gravatar Han-Wen Nienhuys2015-05-11
| | | | | | | Fixes #72. -- MOS_MIGRATED_REVID=93308235
* Add missing anchors to the Skylark documentation.Gravatar Laszlo Csomor2015-05-11
| | | | | -- MOS_MIGRATED_REVID=93306731
* Clarify the zip example from the actions documentation.Gravatar Googler2015-05-11
| | | | | -- MOS_MIGRATED_REVID=93305006
* Get the code cache directory for stub application from the Context instead ↵Gravatar Lukacs Berki2015-05-11
| | | | | | | | | | | of hard-coding it and move the incremental deployment directory from /sdcard/incrementaldeployment to /data/local/tmp/incrementaldeployment. The first is necessary because if the app is not run under the default user profile (e.g. Android For Work), the default location is not writable, thus, sadness, the second is necessary because /sdcard is not accessible from the non-default profile. This also makes it possible to eventually install .so files there, because the +x bit can be set under /data/local/tmp (unlike under /sdcard). -- MOS_MIGRATED_REVID=93287264
* RELNOTES: Fix linking order for Bazel-generated XCode projects.Gravatar Googler2015-05-11
| | | | | -- MOS_MIGRATED_REVID=93170106
* Add a --javac_extdir flag to enable configuring the javac -extdirs flagGravatar Liam Miller-Cushon2015-05-11
| | | | | | | | | | | | | | | The -extdirs flag sets a search path to the directory containing the JDK's extension classes, and should always be set explicitly when cross-compiling. If it is unset, the ext directory of the host JDK will be used instead. javac requires that -extdirs be a list of directories. The blaze --javac_extdir flag takes the label of a filegroup with the 'path' attribute set, and passes the directory path through to JavaBuilder. RELNOTES: N/A -- MOS_MIGRATED_REVID=93147656
* Allow .ld extension for linker scripts.Gravatar Onath Claridge2015-05-11
| | | | | | | -- Change-Id: I523f31cf2179521847f644c426235bdf76e9d497 Reviewed-on: https://bazel-review.googlesource.com/#/c/1262/ MOS_MIGRATED_REVID=93146490
* Revert commit 49e14 (github) to fix issue in generated Xcode projectsGravatar David Santiago2015-05-11
| | | | | | | | | | | | | The commit this reverts caused generated Xcode projects to fail to find their files, as apparently the project.pbxproj file format does not expand $() variables in the mainGroup element. This commit simply restores the original xcodeproj generation logic, so files are found by Xcode. -- Change-Id: Id3cc57498384cc212ef41c30e9c5a4e5d3065e42 Reviewed-on: https://bazel-review.googlesource.com/#/c/1120 MOS_MIGRATED_REVID=93140923
* Tell git to ignore files generated for/by IntelliJ Idea IDE.Gravatar Thiago Farina2015-05-08
| | | | | | | | | | | bazel.iml is generated by scripts/setup-intellij.sh and .idea is generated by IntelliJ Idea IDE after you open bazel project on it. `git status` stops showing these when ran. -- Change-Id: I2adc4a32ffb20d174b45be2b53deb098b6ef7fd9 MOS_MIGRATED_REVID=93139152
* Build language: Add str.format function.Gravatar Laurent Le Brun2015-05-08
| | | | | | | | | 'x{key}x'.format(key = 2) == 'x2x' It is a very simplified version of the Python format. -- MOS_MIGRATED_REVID=93130656
* Build language: Support 'not in' operator.Gravatar Laurent Le Brun2015-05-08
| | | | | -- MOS_MIGRATED_REVID=93129861
* Rewrite of ZipCombiner to improve performance and maintainabilityGravatar Googler2015-05-08
| | | | | | | | | | | Poorly performing features of the API have been deprecated in favor of better alternatives: - use addZip(File) over addZip(InputStream) or addZip(String, InputStream) - use addFile(ZipFileEntry) over addFile(String, Date, InputStream, DirectoryEntryInfo) New zip package for high performance ZIP file manipulation. Can directly work with compressed ZIP entry data and has support for Zip64 (forces Zip32 by default). -- MOS_MIGRATED_REVID=93128639
* Fix info-keys help output.Gravatar Thiago Farina2015-05-08
| | | | | | | | | | | | | | Tested on Linux with the following command line: $ bazel help info-keys | sort | uniq -c And compared the output before and after. Fixes #175 -- Change-Id: Ia879796abf6f5b6b5742bfc9574d64fe53a650a3 MOS_MIGRATED_REVID=93127869
* Remove extra copy of info-keys from helpGravatar Kristina Chodorow2015-05-08
| | | | | | | Fixes #175. -- MOS_MIGRATED_REVID=93127118
* Small fixes for C++ docsGravatar Kristina Chodorow2015-05-08
| | | | | -- MOS_MIGRATED_REVID=93125695
* Remove declaration of **environ from blaze.cc.Gravatar Thiago Farina2015-05-08
| | | | | | | | | | | | The one we need is already in option_processor.cc. Tested on Linux with the following command line: $ ./bootstrap_test.sh all -- Change-Id: I5cdd781d0c2e20242773db1ccb7e9eccd2980a78 MOS_MIGRATED_REVID=93122461
* Fix the remaining 'seperated' typos.Gravatar Thiago Farina2015-05-08
| | | | | | | | | | | | | I forgot to look at the header file when doing https://github.com/google/bazel/commit/a0592a13c8801f395a17641579f16a3c3bc4587e. Now I ran the following command line to make sure I didn't miss any: $ git grep seperated -- Change-Id: Id834f87667135e91bd0c3024e0a99e52954a7038 MOS_MIGRATED_REVID=93120398
* Skylark: type of None is NoneType (instead of None), for consistency with ↵Gravatar Laurent Le Brun2015-05-08
| | | | | | | Python. -- MOS_MIGRATED_REVID=93120393
* Make cc_* rules be able to depend on linker script in their deps attribute.Gravatar Lukacs Berki2015-05-08
| | | | | -- MOS_MIGRATED_REVID=93110537
* Description redacted.Gravatar Keefer Taylor2015-05-08
| | | | | -- MOS_MIGRATED_REVID=93066384
* Return all mappings in one Map from Runfiles#getRunfilesInputs(...)Gravatar Michajlo Matijkiw2015-05-08
| | | | | | | | | We wind up combining them anyway in the manifest file and it seems that this is consistent with how we read them back. Return them all at once to avoid tedious duplication in handling of them. -- MOS_MIGRATED_REVID=93058482
* Add plugin support to experimental_ios_testGravatar Daniel Wagner-Hall2015-05-08
| | | | | -- MOS_MIGRATED_REVID=93051778
* If effective user id != user id, force us to act as the effective user idGravatar Daniel Wagner-Hall2015-05-08
| | | | | | | /bin/bash clobbers euid with uid, which is undesirable when process-wrapper is a setuid binary being used for isolation. -- MOS_MIGRATED_REVID=93051178
* Switch to stat64/lstat64Gravatar Kristina Chodorow2015-05-08
| | | | | | | Better fix for #174. -- MOS_MIGRATED_REVID=93045666