| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119960754
|
|
|
|
|
|
|
| |
It appears as though the --objc_generate_debug_symbols flag generates a viable dSYM bundle before the build is failed by this stub script. This change makes the stub a warning instead of an error so that users can utilize the generated dSYM to do debugging.
--
MOS_MIGRATED_REVID=119958618
|
|
|
|
|
|
|
| |
c++ rule implementation backend and an OSX crosstool.
--
MOS_MIGRATED_REVID=119954578
|
|
|
|
|
|
|
|
|
|
|
|
| |
Optionally support a target width for the experimental state tracker;
if given, it will try to produce a status bar with lines shorter than
that limit, if possible, so that the status bar does not have to be
broken.
--
Change-Id: Ic5843285300ec10cf3e21b9b7402a6557f6bdb5e
Reviewed-on: https://bazel-review.googlesource.com/#/c/3374
MOS_MIGRATED_REVID=119954289
|
|
|
|
|
|
|
|
| |
This hashes together a user name and an workspace directory, and
uses less bits from MD5 hash to make the path much shorter.
--
MOS_MIGRATED_REVID=119952145
|
|
|
|
|
|
|
|
|
|
| |
After this fix, we can run shell test, python test and cpp
test with msvc toolchain on Windows using bazel test command
--
Change-Id: I61e3984b6df2c4aef8762037a91a0f3a29d01691
Reviewed-on: https://bazel-review.googlesource.com/#/c/3385
MOS_MIGRATED_REVID=119950353
|
|
|
|
|
|
|
|
|
|
|
| |
Since commit e87849b8d39: ("Remove base_workspace from bazel setup"),
this directory is not created anymore and thus we don't have to
have an entry for it in .gitignore.
--
Change-Id: I71229e2b7762e2cc7f03e8852cbd06a4461ad168
Reviewed-on: https://bazel-review.googlesource.com/c/3340/
MOS_MIGRATED_REVID=119950175
|
|
|
|
|
|
|
|
|
|
| |
...by only starting the new line, if needed and not already if the last
usable character of the line is written.
--
Change-Id: I86519389fe64fe74ba9045be07483ce5f55d5e9a
Reviewed-on: https://bazel-review.googlesource.com/#/c/3384
MOS_MIGRATED_REVID=119949042
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This still has a number of issues, including, but not limited to:
- When switching between gRPC and AF_UNIX mode, you need to do a manual shutdown
- The console is spammed with "connection refused" messages on server startup
- When in gRPC mode, server also starts up an AF_UNIX server even though it's not necessary and concurrent requests probably make Bazel crash and burn
- I have no idea how concurrent gRPC requests are handled and now many threads gRPC creates
- Not tested except under Linux
- The request/response cookies are written in an odd format (negative bytes are not handled correctly). This is only a cosmetic issue, since the data content of the string is the same either way.
Can be tested with the --grpc_port=0 (or a valid port number) startup option.
--
MOS_MIGRATED_REVID=119948959
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When generating output targeted for a specific terminal width, it is
important to know the current position in order to appropriately shorten
the message still to be added to the current line. So make it possible to
add this functionality to the terminal writer itself, to avoid too many
lengthy position computations at call site.
--
Change-Id: I03400b9544c32567fc6ea7ab35e742c4ccd7b610
Reviewed-on: https://bazel-review.googlesource.com/#/c/3373
MOS_MIGRATED_REVID=119946982
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is important for packaging Python code in a way which is compatible
with the way Bazel builds its standard runfiles directory.
Refs #671
--
Change-Id: Ica2adab481cfecabb84b608cd952b0cae5a8653c
Reviewed-on: https://bazel-review.googlesource.com/#/c/2900/
MOS_MIGRATED_REVID=119945845
|
|
|
|
|
|
|
| |
communication alongside AF_UNIX.
--
MOS_MIGRATED_REVID=119943481
|
|
|
|
|
|
|
|
|
|
| |
In this way, it can be used for other tests as well. While there, also
unify the two almost identical private LoggingTerminalWriter classes.
--
Change-Id: I9cdf9eb235110a0ad6b9514012a92a923d219b53
Reviewed-on: https://bazel-review.googlesource.com/#/c/3372
MOS_MIGRATED_REVID=119943441
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119942803
|
|
|
|
|
|
|
|
|
| |
This is triggering some weird errors on ci.bazel.io where it tries to look at files under the convenience symlink.
Instead just glob files on the top-level path, the other files are all in sub-package anyway.
--
MOS_MIGRATED_REVID=119941636
|
|
|
|
|
|
|
|
|
| |
LabelVisitor is only used in BlazeQueryEnvironment#buildTransitiveClosure(), which takes care of this.
Very preliminary work for #1140.
--
MOS_MIGRATED_REVID=119933021
|
|
|
|
|
|
|
|
|
| |
The BlazeDirectories are also needed for loading the WORKSPACE file, so inject
them as part of preparePackageLoading rather than in createConfigurations,
which is too late.
--
MOS_MIGRATED_REVID=119931633
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old implementation cached the timestamp when the workspace status
action is created, which may be much earlier then the action gets
executed and end up leaving stale timestamp in volatile-status.
Close #1103
--
Change-Id: I0f09ac66681a134aeb10daf2455f3c3f98d8cd8f
Reviewed-on: https://bazel-review.googlesource.com/#/c/3221/
MOS_MIGRATED_REVID=119930493
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119920313
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119902657
|
|
|
|
|
|
|
|
|
| |
cc_* targets, CcLibraryHelper will not process objc source files, which may have been provided accidentally though a filegroup.
Note: This is note intended to prevent illegal sources for cc_* targets - that will be implemented in a different CL. This will involve making changes to filtering occuring in CcCommon, which for now will permit objc source.
--
MOS_MIGRATED_REVID=119897621
|
|
|
|
|
|
|
|
|
| |
It is probably more efficient in the common case where the Iterable is a collection. String and list handling in Skylark results in a *lot* of calls to this method, and the use of addAll should reduce the amount of copying and GCing that needs to occur.
An alternative would be to change the underlying type of SkylarkList from ArrayList to LinkedList, which would reduce the copying and GCing due to list concatenation even more. There is probably a downside to that but it is not clear if it is significant.
--
MOS_MIGRATED_REVID=119891128
|
|
|
|
|
|
|
| |
processing.
--
MOS_MIGRATED_REVID=119873729
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119868282
|
|
|
|
|
|
|
|
|
| |
on Windows
--
Change-Id: I0048202b431ca05b88f67153389ca40c1542b1d5
Reviewed-on: https://bazel-review.googlesource.com/#/c/3371
MOS_MIGRATED_REVID=119861292
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119848254
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119843072
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119832385
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that the presence of server/grpc_port does not guarantee that the server actually listens to it and we can't guarantee it, either, because it can always be kill -9'd.
I haven't decided yet how the transition between AF_UNIX and gRPC will work. For now, I'm happy that we can start up a Java server.
The way to get the kernel-chosen port is truly awful, but it is apparently impossible to do so in a different way:
https://github.com/grpc/grpc-java/issues/72
--
MOS_MIGRATED_REVID=119828354
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Contributor finds some bugs and after fixing some bugs there are more bugs to fix now.
*** Original change description ***
Mount whole directories into the sandbox when possible
This halves the overhead with sandboxing enabled vs disabled for a test
that basically only mounts a bunch of files out of a directory, and
slows that same test with a single extra file added to the directory
(but not mounted) by only ~4%.
The test is <https://gist.github.com/bsilver8192/10527a862ce16bb7f79a>
with 30000 inputs moved to a subdirectory and on...
***
ROLLBACK_OF=119138157
--
MOS_MIGRATED_REVID=119828267
|
|
|
|
|
|
|
|
|
|
|
|
| |
While the timing assumptions in those tests were quite generous (a sleep
10 should not take 15s, an event supposed to happen every second should
be observed at least once in a 3 second interval), it seems that under
really heavily loaded test environments those assumptions do not hold
true. So remove the tests, as it is better to not have integration tests
for timing properties than to have flaky ones.
--
MOS_MIGRATED_REVID=119826405
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119813568
|
|
|
|
|
|
|
| |
Remove ArtifactFile, which is rendered obsolete by TreeFileArtifact.
--
MOS_MIGRATED_REVID=119789154
|
|
|
|
|
|
|
| |
skylark native access to ObjcProvider instances.
--
MOS_MIGRATED_REVID=119782586
|
|
|
|
|
|
|
|
|
| |
third_party.
I'm confused that Bazel has the concept of third_party, but as long as it does, let's exploit it.
--
MOS_MIGRATED_REVID=119779306
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks ci.bazel.io
While the basics for fixing the build is easy (just a few typos in packages building), fixing the test is a bit more tricky. I see only one solution for fixing the test: use a select statement that would select the good bazel version but that would always pull JavaBuilder as an external dependency when we do test.
Better roll this back then check the JavaBuilder 0.1.0 as a binary in third_party before rolling forward (a similar change is still needed to decouple running the test and building the binary for JDK 7)
*** Original change description ***
Refactor build for JDK 7
Now the JDK 7 tuning happens all in Bazel, removing logic
from the CI script. It uses remote repositories to access
JDK 7 dependencies.
--
MOS_MIGRATED_REVID=119773123
|
|
|
|
|
|
|
| |
rolled back in commit 1250fdac4c7769cfa200af8b4f9b061024356fea. There was nothing wrong with that change.
--
MOS_MIGRATED_REVID=119756383
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119755803
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
src/main/java/com/google/devtools/build/lib/exec/SymlinkTreeHelper.java:
enable --windows_compatible flag on Windows to make build-runfiles.exe work.
scritps/bootstrap/compile.sh:
--windows_compatible will also be passed to a dummy build-runfiles.exe defined in complie.sh.
Which is actully a batch script, modify it to make it work.
-----
With the changes above, we are able to build bazel with bazel. But when you try to
run ./compile.sh compile /path/to/bazel again without clean up tmp directory, it will fail with
a permission deny error. The reason seems to be that you can't use build-runfile.exe to build the
same hard link twice, still trying to solve that.
--
Change-Id: I93340b1ba9fa415f6db963b106e264799e33ede3
Reviewed-on: https://bazel-review.googlesource.com/#/c/3334
MOS_MIGRATED_REVID=119751076
|
|
|
|
|
|
|
| |
RELNOTES: java_import now allows its 'jars' attribute to be empty.
--
MOS_MIGRATED_REVID=119749103
|
|
|
|
|
|
|
|
|
|
|
| |
Whenever an event has to be reported to the scroll-back buffer, the old progress
bar has to be removed first. Afterwards, it is redrawn. In a setting without
cursor control, this, however, litters the log with lots status bars. Therefore,
only redraw the progress bar after an event if cursor control is available. Note
that the refresh thread will eventually ensure an up-to-date progress bar anyway.
--
MOS_MIGRATED_REVID=119737382
|
|
|
|
|
|
|
| |
rules.
--
MOS_MIGRATED_REVID=119737046
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the experimental UI, show the most recent finished test in the (long) progress bar.
For failed test, immediately write an entry to the scroll-back buffer. In this
way, the user can get an already investigate test failures while other tests are
still running.
--
Change-Id: I5df29dc55b979c8547e99e9ac3f60563736b48e8
Reviewed-on: https://bazel-review.googlesource.com/#/c/3351
MOS_MIGRATED_REVID=119732631
|
|
|
|
|
|
|
|
|
|
|
| |
When running tests, a useful information to know is the number of tests
that have passed and failed already. Hence subscribe to the relevant events
and provide this information in the progress bar as well.
--
Change-Id: I6fabec3f4585500f096b820dbbd5e8e6897647fa
Reviewed-on: https://bazel-review.googlesource.com/#/c/3350
MOS_MIGRATED_REVID=119727962
|
|
|
|
|
|
|
| |
c++ rule implementation backend and an OSX crosstool.
--
MOS_MIGRATED_REVID=119660101
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119655452
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119653212
|
|
|
|
|
|
|
|
|
|
|
| |
The last version of the status bar will drop into the scroll-back
buffer. Hence it should really represent the final state. To achieve
this, ignore the refresh limit on the progress bar for its final update.
--
Change-Id: I50b327dca80c12c9373e59a8702063369b18c461
Reviewed-on: https://bazel-review.googlesource.com/#/c/3333
MOS_MIGRATED_REVID=119637626
|
|
|
|
|
|
|
|
|
| |
--sandbox_debug and --verbose_failures are on. See discussion in #1049.
RELNOTES:
--
MOS_MIGRATED_REVID=119635080
|
|
|
|
|
|
|
|
|
|
|
| |
Now the JDK 7 tuning happens all in Bazel, removing logic
from the CI script. It uses remote repositories to access
JDK 7 dependencies.
--
Change-Id: Iff590c6642ca5b2343aa15096f8fd837d1c80787
Reviewed-on: https://bazel-review.googlesource.com/#/c/3327
MOS_MIGRATED_REVID=119634530
|