| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
| |
Don't encode paths as UTF-8 to md5sum them (the map keys are Strings derived
from Paths, for which Fingerprint.addPath() takes the same shortcut).
Remove defensive copy from the constructor (which did not need to be public).
Remove redundant call to Fingerprint.reset().
--
MOS_MIGRATED_REVID=126682477
|
|
|
|
|
|
|
|
|
| |
So people don't redistribute the binaries without the sources.
--
Change-Id: Ia3f91285d40669f8aa367633bb54214e9fdf1454
Reviewed-on: https://bazel-review.googlesource.com/#/c/3954
MOS_MIGRATED_REVID=126681605
|
|
|
|
|
|
| |
This makes the regeneration instruction in much simpler (since now they do publish 64-bit Linux binaries), and more importantly, fixes a race condition between a client request and the gRPC server timeout thread.
Change-Id: I9c8b628530fa0192804f8e67b285963ac26110c4
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The stopUpdateThread() method tries to stop the update thread
by calling the interrupt() and join() methods on that thread.
When getting interrupted while waiting for the thread to join,
do not ignore the exception, instead try again to make sure
we don't leave that method before the other thread is actually
stopped.
While there, also clean up the synchronized blocks for the thread
handling: all blocks that handle multiple global variables like
buildComplete, updateThread, etc, are synchronized while the actual
thread-manipulating operations are outside those blocks.
--
MOS_MIGRATED_REVID=126679343
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126673732
|
|
|
|
|
|
|
|
|
| |
This is in preparation for splitting up the rules into per-language modules.
We'll also add test coverage to make sure each module is individually useful,
so that it's possible to build a Bazel binary with a reduced set of rules.
--
MOS_MIGRATED_REVID=126672702
|
|
|
|
|
|
|
|
|
|
| |
This java test is fixable after Bazel no longer append .exe as suffix
to .so cc_binary target on Windows.
--
Change-Id: I3a377839f00cf1e372f1ecb25692e86807e1ad43
Reviewed-on: https://bazel-review.googlesource.com/#/c/3964
MOS_MIGRATED_REVID=126637503
|
|
|
|
|
|
|
|
|
| |
The test was failing because IdlClass can't handle file path with back-slash
--
Change-Id: Ica72da756fd4bd9b4f8d907ff795549a59edc8be
Reviewed-on: https://bazel-review.googlesource.com/#/c/3966
MOS_MIGRATED_REVID=126636692
|
|
|
|
|
|
|
| |
--
Change-Id: Ic474eff981328b0a467606a01f88d72c26dfff74
Reviewed-on: https://bazel-review.googlesource.com/#/c/3965
MOS_MIGRATED_REVID=126636071
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126633568
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126631881
|
|
|
|
|
|
|
|
| |
We have some modules that assume 1:1 correspondence between servers and
workspaces, which I'd like to fix.
--
MOS_MIGRATED_REVID=126628292
|
|
|
|
|
|
|
|
|
| |
Subprocesses now get killed if the Bazel server itself is killed and so do their subprocesses.
Also implemented Subprocess#close() so that we get a little more control over when the native structures are cleaned up.
--
MOS_MIGRATED_REVID=126628000
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126620866
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
types.
Fixes #921
Certain parameters, such as the `executable` and `command` parameters of
ctx.action, allow multiple types. However, the allowed types are not enumerated
in the SkylarkSignature annotation, causing the generated Skylark Library
document to not display any type information for those params.
This change adds a new field, `allowedTypes`, to `SkylarkSignature` that is a
list of `ParamType` objects. If the param can accept multiple types, then
`type` is set to `Object.class`, and `allowedTypes` is set to the list of types
that can be accepted.
--
MOS_MIGRATED_REVID=126617047
|
|
|
|
|
|
|
|
|
| |
An instance of the builder is passed to all modules, which can each add / set
things on the builder. This reduces the BlazeModule API surface, while also
being more flexible for future changes.
--
MOS_MIGRATED_REVID=126613981
|
|
|
|
|
|
|
|
|
|
| |
The solution is setting RUNFILES_MANIFEST_ONLY=1 in template file
if only runfile manifest feature is enabled.
--
Change-Id: I6c96cc1212818bd57adcdfb59fa0de66d2d38037
Reviewed-on: https://bazel-review.googlesource.com/#/c/3960
MOS_MIGRATED_REVID=126577520
|
|
|
|
|
|
| |
This review was merged at the wrong patchset leaving some change behind.
Change-Id: I018accd516c73cc63cd9368df2daa9c389c93bc3
|
|
|
|
|
|
|
|
|
|
| |
Those source jars comes from
javac.jar = https://github.com/google/error-prone-javac/archive/1.9.0-dev-r2644-2.zip
javac7.jar = https://github.com/google/error-prone-javac/archive/1.9.0-dev-r2973-2.zip
As a consequence also updated the version in third_party readme.
Change-Id: I4c9d749d2b4acb1254cd65efbabf4e6515924414
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke some targets
--
MOS_MIGRATED_REVID=126574275
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126572660
|
|
|
|
|
|
|
|
|
| |
Also remove some bashism to fix #1456.
--
Change-Id: I374f1290a3eb9e9e5bcc48e19a1c0ab1c5bdaa99
Reviewed-on: https://bazel-review.googlesource.com/#/c/3952/
MOS_MIGRATED_REVID=126572632
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126571069
|
|
|
|
|
|
|
| |
We should really do something about the mess that is loading our JNI libraries -- io.bazel.EnableJNI is mentioned eight times in the code in various diverse contexts. This change is not the right place to do it, though.
--
MOS_MIGRATED_REVID=126570481
|
|
|
|
|
|
|
|
|
| |
style path
--
Change-Id: I219bce744a73333ff3a79bedc78ee78c415629e8
Reviewed-on: https://bazel-review.googlesource.com/#/c/3961
MOS_MIGRATED_REVID=126569740
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126566280
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks CI, see, e.g., http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=ubuntu_15.10-x86_64/92/console
*** Original change description ***
C++ reimplementation of singlejar tool: first checkin.
--
MOS_MIGRATED_REVID=126565472
|
|
|
|
|
|
|
|
|
| |
what CreateProcess() does.
Test cases don't need to be changed because this issue was caught by CreateProcess() instead.
--
MOS_MIGRATED_REVID=126560893
|
|
|
|
|
|
|
| |
It seems like the Bazel server dies (or isn't reused) between the first and the second "bazel build" in test_input_digests.
--
MOS_MIGRATED_REVID=126511647
|
|
|
|
|
|
|
| |
last build's deps. This is only an issue with cycles, since there we try to maintain the invariant that a parent is not done before its children by removing its deps on its children before we construct its cycle value.
--
MOS_MIGRATED_REVID=126494009
|
|
|
|
|
|
|
| |
was unnecessary.
--
MOS_MIGRATED_REVID=126457804
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Such functions have to list their required attributes as parameters.
def _callback_func(attr_map):
do_something(attr_map.my_attr)
becomes
def _callback_func(my_attr):
do_something(my_attr)
RELNOTES[INC]:Skylark rules: if you set "outputs" or an attribute to a function, this function must now list its required attributes as parameters (instead of an attribute map).
--
MOS_MIGRATED_REVID=126445849
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126434299
|
|
|
|
|
|
|
| |
by the Gradle resource shrinker in resources.txt.
--
MOS_MIGRATED_REVID=126420534
|
|
|
|
| |
MOS_MIGRATED_REVID=126410490
|
|
|
|
|
|
|
|
|
|
|
| |
to Windows process management.
With this change, Bazel can build itself using native Windows process management and Ctrl-C works in server mode as expected. Yay!
Flipping the flag will come in a separate change that's easy to roll back if need be.
--
MOS_MIGRATED_REVID=126408264
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To be used by a later CL where we use this more
complete picture of all the resource items to
generate our own R.java/class without invoking
AAPT (and split out AAPT to a separate action
that is off the java builder critical path).
Technically aapt creates R.id.foo for attr
<enum name="foo" ... /> and flag as well, but
I haven't seen code that actually relies on that.
Currently off-by-default (only exercised by tests).
--
MOS_MIGRATED_REVID=126407838
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...instead of cleaning up the last one once for each tmpdir.
Commit 63e8d6321 changed the command registered atexit from
an explict "rm -rf '${DIR}'" to a call to a cleanup_tempdir
function, with the function containing the remove command.
As, however, the function name is not unique (in fact, it is
a constant), that function will get overridden at each invocation
of the tempdir function. The fact that the function is registered
several times with atexit doesn't help, as it will always remove
the last created temporary directory. Fix this, by creating function
names that encode the directory to be removed in the name. Fixes #1466.
--
Change-Id: I833aef8ee5423412f058e74c8c9e2f4bb53a0cba
Reviewed-on: https://bazel-review.googlesource.com/#/c/3955
MOS_MIGRATED_REVID=126406196
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126405595
|
|
|
|
|
|
|
| |
in Skylark rule context.
--
MOS_MIGRATED_REVID=126405174
|
|
|
|
|
|
|
| |
implementation can eventually be plugged in.
--
MOS_MIGRATED_REVID=126404913
|
|
|
|
|
|
|
|
|
|
|
| |
missing file to it.
We need to activate this check on presubmits
--
Change-Id: Ia95e92d3816ce92bb69bc0e2cf56e9c60b68d970
Reviewed-on: https://bazel-review.googlesource.com/#/c/3949/
MOS_MIGRATED_REVID=126404792
|
|
|
|
|
|
|
|
|
|
| |
Declare openjdk-9-jdk as Conflicts
Progress towards #1456
--
Change-Id: I67c17b78f90f81dbcc9c39bf6f3915789662fa94
Reviewed-on: https://bazel-review.googlesource.com/#/c/3951
MOS_MIGRATED_REVID=126402113
|
|
|
|
| |
Change-Id: Iaa7f2263aa2a2d8792618ff564e1eee818b5b982
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126391895
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the progress bar cannot be updated in place, every additional writing
of the progress bar clutters up the log. Of course, this could be controlled
by adding --show_progress_rate_limit or even --noshow_progress options to the
invocation; however, it turns out that users expect a bazel to just automatically
reduce its output rate. Therefore, specify a minimal value for the progress rate
limit of 2 seconds if the progress bar cannot be updated in place. Also, increase
the time rate for purely time-based updates to 20s in this case.
Moreover, only automatically redraw the progress bar after an INFO/WARNING/... message,
if it can be updated in place.
--
Change-Id: I7d06aa04acec457ec0a5d20ac32ede4cf80f7170
Reviewed-on: https://bazel-review.googlesource.com/#/c/3944
MOS_MIGRATED_REVID=126387987
|
|
|
|
|
|
|
|
|
| |
We have the source so build from sources instead. This was
causing strange behavior were the input file was conflicting
with the output file of the corresponding java_library but
was matched by the glob.
Change-Id: Ie0b70215d1862627747bd7b83f075743c904c967
|
|
|
|
|
|
| |
We don't use them and one of the test file contains a space that we don't support in label.
Change-Id: I4752860788bd20455ba659a89586e66e2896863d
|
|
|
|
|
|
| |
Also correctly cite this dependency in the README file
Change-Id: I2bca5102b3c7871a2f6a735103273bc25f853c9d
|
|
|
|
|
|
|
| |
Android split transitions.
--
MOS_MIGRATED_REVID=126378169
|