aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* BuildEventStreamer: clear a pending BuildStarted event firstGravatar Klaus Aehlig2017-10-16
| | | | | | | | | | | | | | | | | | | | If we receive an event indicating that the build is over, we first post that event and then clear up all pending event by stating that their prerequisite event was aborted (which we can safely assert, as we know we will not process any further events). Now, if a build is aborted (e.g., user interruption) before the build starting event is generated, the streamer can receive a build-finished event while still having an event (e.g., the raw command line) blocked on the build-starting event. So the canonical order of clearing the stream would send a build-finished event before the build-starting event, which can be confusing to consumers of the stream. Therefore, if have to generate an artificial aborted build-starting event, do so first (including clearing the events blocked on the build-starting event) and only afterwards post the build-finished event in the stream. Change-Id: Ib33f16f74b7bee7a963df94bbcad7a56db9f07e3 PiperOrigin-RevId: 172305114
* BEP: explicitly report failures associated with a label as suchGravatar Klaus Aehlig2017-10-16
| | | | | | | | | | There is a conceptual difference between the (maybe unsuccessful) completion of a top-level target and a label as the root cause for a failure (i.e., a missing source file). Indicate that difference as such, by having a separate message for failures associated with an unconfigured label. Change-Id: I3f2e20d4dc85782eb11b104a7baf089e66d972e7 PiperOrigin-RevId: 172299938
* Export apple_host_system_env and target_apple_env through apple_common (as ↵Gravatar lberki2017-10-16
| | | | | | | | | opposed to only through ctx.fragments.apple) Progress towards #3424. RELNOTES: None. PiperOrigin-RevId: 172299240
* Windows,docs: info about 0.6.0 boostrapping bugGravatar László Csomor2017-10-16
| | | | | | | | | Remove info about older versions' bootstrapping bugs, because we want people to use the latest version. Change-Id: I0639824b9557077062e380996cfc9d2b974778e2 PiperOrigin-RevId: 172297572
* Some tests depend on the target pattern evaluation strategy used.Gravatar aehlig2017-10-16
| | | | | | | Make them specify the target pattern evaluator they need. RELNOTES: None PiperOrigin-RevId: 172296001
* Removing the USER variable from test environment, unless explicitly provided.Gravatar olaola2017-10-16
| | | | | | TESTED=added remote test RELNOTES: Fixes #2574 PiperOrigin-RevId: 172294781
* Add a missing argument to the code in ↵Gravatar lberki2017-10-16
| | | | | | | | | https://github.com/bazelbuild/bazel/commit/aee6fb8d21e17c855025f0db6bb52e2cd7a2f642. Progress towards #3424. RELNOTES: None. PiperOrigin-RevId: 172293805
* Remove the uses_protobuf attribute from objc_proto_library.Gravatar kaipi2017-10-16
| | | | PiperOrigin-RevId: 172199420
* Extract more RuleContext error-related methods into RuleErrorConsumerGravatar cparsons2017-10-16
| | | | | | | This will make it easier to pass only error-handling functionality into support classes. RELNOTES: None. PiperOrigin-RevId: 172148072
* Properly report errors as errors.Gravatar nharmata2017-10-16
| | | | | RELNOTES: None PiperOrigin-RevId: 172133468
* Add callcount system for blaze developers.Gravatar tomlu2017-10-16
| | | | | | | | | | | This simple system allows blaze developers to insert instrumentations in particular methods that they want to know: 1. How often are they called? 2. From which call sites are they called, with full call stack The output is a pprof file that can then be analysed offline. PiperOrigin-RevId: 172128440
* Make option conflicts less spammy.Gravatar ccalvarin2017-10-16
| | | | | | | Remove an unnecessary warning and make all warnings for option conflicts print only if the option values are not equal. RELNOTES: None. PiperOrigin-RevId: 172124261
* Fix src/test/shell/bazel/bazel_bootstrap_distfile_test.Gravatar tomlu2017-10-16
| | | | | | | | | We added a proto to third_party, and protos aren't compiled as per normal during bootstrapping. We add a pointer from our protobuf into third_party for pprof so bootstrapping can work. Verified that this fixes test by exporting a repo and running bazel test. PiperOrigin-RevId: 172122010
* Define protos for the Skylark debug server.Gravatar allevato2017-10-16
| | | | PiperOrigin-RevId: 172115471
* Flip the --incompatible_list_plus_equals_inplace flag by defaultGravatar vladmos2017-10-16
| | | | | | | | | RELNOTES[INC]: += on lists now mutates them. `list1 += list2` is now equivalent to `list1.extend(list2)` and not equivalent to `list1 = list1 + list2` anymore. Fixes #2350. PiperOrigin-RevId: 172111899
* Simplify ApplicationManifest by inlining createApk and simplifying the ↵Gravatar corysmith2017-10-16
| | | | | | | builder code. RELNOTES: None PiperOrigin-RevId: 172109520
* Update documentation on objc_proto_library rule, and disable the passing of ↵Gravatar kaipi2017-10-16
| | | | | | direct files into the deps attribute, only proto_library and objc_proto_library targets are allowed. PiperOrigin-RevId: 172107133
* Don't follow globs in rbuildfiles. Globs request the FILE node for symlinks ↵Gravatar shreyax2017-10-16
| | | | | | which causes the package containing the reference to be visited in rbuildfiles (which isn't the intended behaviour of rbuildfiles). Also add tests to guard against other types of inclusions. PiperOrigin-RevId: 172106051
* BEP: link structured command lineGravatar Klaus Aehlig2017-10-16
| | | | | | | | | | Change ceb1013c1ca0238188e2714442fcfb2efb16bc6a added an event for the structured command line to the BEP. Announce that event as a child of the build-starting event so that it gets properly chained and does not have to be chained in by a progress event. Change-Id: I6aeb46b748a536da58a916b9c4e0b1b66bbd40b0 PiperOrigin-RevId: 172100341
* Some tests depend on the target pattern evaluation strategy used.Gravatar aehlig2017-10-16
| | | | | | | Make them specify the target pattern evaluator they need. RELNOTES: None PiperOrigin-RevId: 172100319
* Apply suggested fixes that were missed in ↵Gravatar jcater2017-10-16
| | | | | | http://https://github.com/bazelbuild/bazel/commit/5b4b7a3ebb83a8c93d8f68ade7bf1242c8590256 PiperOrigin-RevId: 172099288
* Improve private skylark attribute error messagingGravatar cparsons2017-10-16
| | | | | RELNOTES: None. PiperOrigin-RevId: 172087232
* Deprecate methods in ConfigurationEnvironment that give access to ↵Gravatar lberki2017-10-16
| | | | | | | ConfigurationFragmentFactory instances to contents of BUILD files and to the file system. RELNOTES: None. PiperOrigin-RevId: 172086610
* Simplify the SpawnExecException constructorGravatar ulfjack2017-10-16
| | | | | | | Whether or not there was a catastrophic error is stored in the SpawnResult, so we can just use that instead of passing in an additional boolean. PiperOrigin-RevId: 172083752
* Add allocation-instrumenter to third_party.Gravatar Tomas Lundell2017-10-16
| | | | | | | | | This will be used for memory profiling. The jar is necessary both to compile against and for users to run with as a java agent. Obtained from https://github.com/google/allocation-instrumenter. Change-Id: If819d780abb42470b982b4aafc530c6078e76718
* Update checker framework dataflow and javacutils to 2.1.14Gravatar Liam Miller-Cushon2017-10-16
| | | | Change-Id: I62ad827fc4bbd54d022097003af63e351e44b98c
* Put the platform version from the options into the output directory name ↵Gravatar lberki2017-10-13
| | | | | | | instead of the one computed based on xcode_config. RELNOTES: None. PiperOrigin-RevId: 172064337
* Merge [] compilation classpaths using singlejarGravatar cushon2017-10-13
| | | | PiperOrigin-RevId: 172053593
* Disable some tests that can't currently run in special internal execution mode.Gravatar janakr2017-10-13
| | | | PiperOrigin-RevId: 172007131
* Desugar-singlejar integration tests for double-checking default methods.Gravatar kmb2017-10-13
| | | | PiperOrigin-RevId: 171980809
* Skylint: add categories for issues.Gravatar fzaiser2017-10-13
| | | | | | | Having a short canonical name for each kind of finding (the category) makes it easier to document all the lints and for users to find the documentation for each lint. RELNOTES: none PiperOrigin-RevId: 171972645
* Fix osx_cc_wrapper to also update dylibsGravatar hlopko2017-10-13
| | | | | | | | | | | | | | | In https://github.com/bazelbuild/bazel/commit/f426544e67170d31b9d228ecf4cdc4b6ce1ba00d I updated osx_cc_wrapper to work correctly in case both precompiled .so and cc_library-made .so are linked into a single binary. This cl makes osx_cc_wrapper work also when a precompiled .dylib is provided. This is roll-forward of https://github.com/bazelbuild/bazel/commit/0257c29f496719bb8414d012334155de6bbefa11. Fixes #3450 again for dylibs Fixes #407 One step closer to finishing #1576 RELNOTES: None. PiperOrigin-RevId: 171969333
* Remove the deprecated set constructor from SkylarkGravatar vladmos2017-10-13
| | | | | | | | | | The `set` constructor used to be deprecated, but it was still possible to use it by providing --incompatible_disallow_set_constructor=false. RELNOTES[INC]: The flag --incompatible_disallow_set_constructor is no longer available, the deprecated `set` constructor is not available anymore. PiperOrigin-RevId: 171962361
* Fix NPE thrown by java_common.compile when no sources are specified.Gravatar elenairina2017-10-13
| | | | PiperOrigin-RevId: 171960869
* Clarify the direction of visibility in the tutorialGravatar Peter Laird2017-10-13
| | | | | | | | The original text makes it sound like greeter target needs visibility to the runner target. It is the other way around. Closes #3866. PiperOrigin-RevId: 171958509
* Expand implicitRequirements in the location of the option that required it.Gravatar ccalvarin2017-10-13
| | | | | | | | | | | Removes the special casing of implicit requirements. Accumulating them and parsing them at the end of the parse() function was never enough to actually guarantee that the value not be replaced. I've gone through all options with implicit requirements to make sure that the expectation is checked after options parsing, so this change should be relatively safe. Implicit requirements is still a broken concept - they don't actually expand based on the value given, so a user that is explicitly NOT setting a flag might unwittingly be setting all the requirements for that unset flag. Removing it fully requires redesigning or removing the flags that set it, though, so for now we are standardizing the behavior so that it behaves like any other expansion options, just one with a value. Also consolidate the deprecated wrapper option behavior into the expansion work. It will soon be removed entirely, but for now it can get grouped in with the expansion logic, so that its differences are more explicit. RELNOTES: None. PiperOrigin-RevId: 171957502
* Remove some no-op flags.Gravatar ajmichael2017-10-13
| | | | | | | The transition period is over, these features have now been rolled out. RELNOTES: --experimental_use_parallel_android_resource_processing and --experimental_android_use_nocompress_extensions_on_apk are removed. These features are fully rolled out. PiperOrigin-RevId: 171957383
* Fix local repository detection when the repository path is absolute.Gravatar John Cater2017-10-13
| | | | | | | Fixes #3874. Change-Id: Ibbe3ea27b77426f551e2f70f082478edb2234749 PiperOrigin-RevId: 171957230
* Remove deprecated legacy string representations of Skylark objectsGravatar vladmos2017-10-13
| | | | | | | | RELNOTES[INC]: The flag --incompatible_descriptive_string_representations is no longer available, old style string representations of objects are not supported anymore. PiperOrigin-RevId: 171952621
* Only delete the current execroot in clean.Gravatar Benjamin Peterson2017-10-13
| | | | | | | | | | | | | I noticed a problem where if you have a workspace with basename "server", clean will rudely delete the server's pid file and cause it to commit suicide. This is because clean deletes the deep and non-deep execroot, presumably temporarily as part of the deep execroot migration. --deep_execroot has been enabled for more than a year now, so hopefully we can safely remove this aggressive deleting. --expunge can take care of old execroots if needed. Change-Id: I445b0d7cedf2fb9a6a365eacc85b75428a981640 PiperOrigin-RevId: 171948100
* Skylint: set module docstring location to just the first lineGravatar fzaiser2017-10-13
| | | | | | | Previously, the location of the warning was the whole file. Now it is 1:1-2:1. This doesn't make sense if the file is empty but I think it's good enough since that's an edge case. RELNOTES: none PiperOrigin-RevId: 171942703
* Make skylark_git_repository_test executable.Gravatar jcater2017-10-12
| | | | PiperOrigin-RevId: 171933076
* Update the Apple rules according to the new API because it was deemed better toGravatar lberki2017-10-12
| | | | | | | | | put the environment data behind apple_common as opposed to xcode_config. Progress towards https://github.com/bazelbuild/bazel/issues/3424 . RELNOTES: None. PiperOrigin-RevId: 171931324
* Throw a checked exception if there's an error reading /proc/meminfo, and ↵Gravatar janakr2017-10-12
| | | | | | handle it properly. PiperOrigin-RevId: 171906091
* Expose ActionLogBufferPathGenerator in SkyframeExecutor.Gravatar janakr2017-10-12
| | | | PiperOrigin-RevId: 171906076
* Remove synchronization from FileSystem implementations.Gravatar tomlu2017-10-12
| | | | PiperOrigin-RevId: 171905267
* Add some debugging in TestResultAnalyzer: make crash message more ↵Gravatar janakr2017-10-12
| | | | | | informative if the number of summaries and the number of test targets don't agree. My guess is somehow we have duplicate configured targets? PiperOrigin-RevId: 171904831
* Make blaze dump docs external.Gravatar tomlu2017-10-12
| | | | | | The dump command is readily available from bazel, so I don't see why the docs should be closed. PiperOrigin-RevId: 171904287
* add option to singlejar to double-check correct default and static interface ↵Gravatar kmb2017-10-12
| | | | | | | | method desugaring for Android. RELNOTES: none PiperOrigin-RevId: 171891682
* Add follow-symlinks parameter to FileSystemUtils#copyTreesBelow, so that all ↵Gravatar janakr2017-10-12
| | | | | | the tool setup we do in tests doesn't necessarily have to be copied if we copy a workspace over. PiperOrigin-RevId: 171864170
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-14 03:40:39 +0000