aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Jarjar the third-party dependencies of the Jacoco test runner.Gravatar Lukacs Berki2017-01-17
| | | | | | | | | | This is the second encore of commit 823091f7516abf7d854021edc765daf1467f1647. The first one failed because jarjar tried to write to C:\WINDOWS , the second one failed because cygpath does not always return a proper temp directory, the third one failed because the bash quoting doesn't handle $ signs in directories (fixed in commit 35a37e0429add201342dd1d005bc9286c53c02c3). Fourth time is the charm! -- PiperOrigin-RevId: 144689400 MOS_MIGRATED_REVID=144689400
* Add a comment to clarify why we set the mtime on the install base.Gravatar Lukacs Berki2017-01-17
| | | | | | -- PiperOrigin-RevId: 144688363 MOS_MIGRATED_REVID=144688363
* Add ability to specify required aspect providers for aspects.Gravatar Dmitry Lomov2017-01-17
| | | | | | | | It is just a specification yet, it does nothing. -- PiperOrigin-RevId: 144687428 MOS_MIGRATED_REVID=144687428
* C++ test: test with Debian stretch Gravatar Damien Martin-Guillerez2017-01-17
| | | | | | | | | | Fixes #2360. -- Change-Id: I33dcfa1128b74f20dde14c5b5e095790a8961bd5 Reviewed-on: https://cr.bazel.build/8219 PiperOrigin-RevId: 144685099 MOS_MIGRATED_REVID=144685099
* Move the mobile_install command to a separate package and moduleGravatar Ulf Adams2017-01-17
| | | | | | | | | | | The mobile_install command has a hard dependency on the Android rules. For mu-Bazel, we're trying to build a minimally useful Bazel binary, and that should not contain the Android rules. Moving the mobile install command implementation to a separate package is one step towards that. -- PiperOrigin-RevId: 144680452 MOS_MIGRATED_REVID=144680452
* Initial implementation of java_runtime and java_runtime_suiteGravatar Liam Miller-Cushon2017-01-17
| | | | | | | | | These rules can be used to configure JDKs, as an alternative to the filegroups and filegroups-of-filegroups used currently. -- PiperOrigin-RevId: 144655277 MOS_MIGRATED_REVID=144655277
* Remove --javawarnGravatar Liam Miller-Cushon2017-01-17
| | | | | | | | | | Resolves #2363 RELNOTES: Remove support for --javawarn; use e.g. --javacopt=-Xlint:all instead -- PiperOrigin-RevId: 144652008 MOS_MIGRATED_REVID=144652008
* Changes the Windows Java stub template so that it handles $ characters in ↵Gravatar Lukacs Berki2017-01-17
| | | | | | | | | | | | | | the argv (including argv[0]). This is necessary because Bazel 0.4.3 can have $ in its output base (fixed in commit b64349e91debe8abb8a218c6e8888dc9b42fdea3), and if that happens, built Java binaries won't be executable because bash will understand that as a variable to be interpolated. laszlocsomor says that the quoting is otherwise alright. I'm not sure what happens with other special characters (e.g. @!{}%#'"), but at least we don't put those in the output base ourselves. See: https://github.com/bazelbuild/bazel/issues/2306 . -- PiperOrigin-RevId: 144640441 MOS_MIGRATED_REVID=144640441
* Add the output_licenses attribute to java_toolchain and make Bazel use it ↵Gravatar Lukacs Berki2017-01-17
| | | | | | | | when it's reached through a :java_toolchain attribute. -- PiperOrigin-RevId: 144638966 MOS_MIGRATED_REVID=144638966
* Shard skylark_repository_test Gravatar Damien Martin-Guillerez2017-01-17
| | | | | | | | | | Also test_build_repo set-up that starts failing with sharding -- Change-Id: I9b950f1569737c52f9a4608eaad68db01f30ac82 Reviewed-on: https://cr.bazel.build/8144 PiperOrigin-RevId: 144631720 MOS_MIGRATED_REVID=144631720
* Rollback of commit 56328986232dfe4d92f738ab3bbd26d89236a428.Gravatar Vladimir Moskva2017-01-16
| | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks Bazel build for Windows using Java 1.8 http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=windows-x86_64/1188/ *** Original change description *** Jarjar the third-party dependencies of the Jacoco test runner. This is the second encore of commit 823091f7516abf7d854021edc765daf1467f1647. The first one failed because jarjar tried to write to C:\WINDOWS , the second one failed because cygpath doesn't work for some reason on our CI machines and I hope that the "jarjar_bin cannot found" error message was only a fluke. Otherwise, this'll be fixed online. -- PiperOrigin-RevId: 144630946 MOS_MIGRATED_REVID=144630946
* Delete the cmd_helper.template function.Gravatar Laurent Le Brun2017-01-16
| | | | | | | | | | | | | | | cmd_helper is deprecated and planned for deletion. RELNOTES[INC]: Removed the cmd_helper.template function. The function was equivalent to: def template(items, template): return [template.format(path = i.path, short_path = i.short_path) for i in items] -- PiperOrigin-RevId: 144628429 MOS_MIGRATED_REVID=144628429
* Adding output_licenses to bazel's java_plugin.Gravatar Irina Iancu2017-01-16
| | | | | | | | Fixes #2286. -- PiperOrigin-RevId: 144627152 MOS_MIGRATED_REVID=144627152
* Jarjar the third-party dependencies of the Jacoco test runner.Gravatar Lukacs Berki2017-01-16
| | | | | | | | | | This is the second encore of commit 823091f7516abf7d854021edc765daf1467f1647. The first one failed because jarjar tried to write to C:\WINDOWS , the second one failed because cygpath doesn't work for some reason on our CI machines and I hope that the "jarjar_bin cannot found" error message was only a fluke. Otherwise, this'll be fixed online. -- PiperOrigin-RevId: 144625508 MOS_MIGRATED_REVID=144625508
* Windows, JNI, refactor: move a methodGravatar Laszlo Csomor2017-01-16
| | | | | | | | | | This change moves AsExecutablePathForCreateProcess to windows_util. This is a follow-up to unknown commit. -- PiperOrigin-RevId: 144623760 MOS_MIGRATED_REVID=144623760
* Windows, JNI, refactor: prepare moving a functionGravatar Laszlo Csomor2017-01-16
| | | | | | | | | | | | | | Prepare moving AsExecutableForCreateProcess into a shared location where the Bazel client code can also access it, since this logic is needed there too. This change is a simple refactor, it doesn't affect any logic. -- PiperOrigin-RevId: 144623656 MOS_MIGRATED_REVID=144623656
* Remove separation of interface and implementation dependencies again. TheGravatar Googler2017-01-16
| | | | | | | | | implementation has never been fully complete and it turns out that this isn't necessary. We can re-add if it becomes useful at some point. -- PiperOrigin-RevId: 144618513 MOS_MIGRATED_REVID=144618513
* Windows, JNI: make it work with long pathsGravatar Laszlo Csomor2017-01-16
| | | | | | | | | | | | | | When spawning a new process with CreateProcessA, convert argv0 to a 8dot3 style short path so we can support longer paths than MAX_PATH. This is the same approach we did in commit 44ecf9a0c7c25496a43f59f1c8f20df9527e12cb. See https://github.com/bazelbuild/bazel/issues/2107 See https://github.com/bazelbuild/bazel/issues/2181 -- PiperOrigin-RevId: 144613589 MOS_MIGRATED_REVID=144613589
* Adding Java compilation to java_lite_proto_library Skylark version.Gravatar Irina Iancu2017-01-16
| | | | | | -- PiperOrigin-RevId: 144608820 MOS_MIGRATED_REVID=144608820
* Rollback of commit 2300f8a3e88d720f7eae90a80456142363850c5c.Gravatar Liam Miller-Cushon2017-01-16
| | | | | | | | | | | | | | | | | *** Reason for rollback *** bazelbuild/bazel#2123 is fixed *** Original change description *** Fix JavaLibraryBuildRequest for java 7 Bazel still supports java 7. This cl fixes a java 8-only construct introduced by commit 3c5e55ff8e058b624ce26e803ff00434c70d4b91. Liam, feel free to fix it to your liking afterwards. -- PiperOrigin-RevId: 144511670 MOS_MIGRATED_REVID=144511670
* Fix a typoGravatar Liam Miller-Cushon2017-01-16
| | | | | | -- PiperOrigin-RevId: 144511168 MOS_MIGRATED_REVID=144511168
* Be very deliberate about the concept of a TargetPattern's "directory".Gravatar Nathan Harmata2017-01-16
| | | | | | -- PiperOrigin-RevId: 144494739 MOS_MIGRATED_REVID=144494739
* Fix warnings in Bazel Swift example libraryGravatar Dmitry Shevchenko2017-01-16
| | | | | | | | * Require callers to use argument labels so that the call site looks the same in Swift 2 and 3. -- PiperOrigin-RevId: 144484042 MOS_MIGRATED_REVID=144484042
* Global cleanup change.Gravatar Googler2017-01-16
| | | | | | -- PiperOrigin-RevId: 144474876 MOS_MIGRATED_REVID=144474876
* Handle top-level exceptions in javacGravatar Liam Miller-Cushon2017-01-16
| | | | | | | | | | javac's main catches all exceptions and returns an exit code, the API does not. This restores error handling that was lost when we migrated to the API in commit 3c5e55ff8e058b624ce26e803ff00434c70d4b91. -- PiperOrigin-RevId: 144457176 MOS_MIGRATED_REVID=144457176
* Read srcjars using zipfs, instead of extracting themGravatar Liam Miller-Cushon2017-01-16
| | | | | | | | | | | | This allows JavaBuilder to support srcjars containing entries that differ only in case, even if the platform filesystem is case insensitive. Also, simplify srcjar handling and remove the SourceJarEntryListener abstraction since it wasn't pulling its weight. -- PiperOrigin-RevId: 144456040 MOS_MIGRATED_REVID=144456040
* Rollback of commit aad9b44898cf1562765755d475463145466ea7ae.Gravatar Liam Miller-Cushon2017-01-16
| | | | | | | | | | | | | | | | *** Reason for rollback *** bazelbuild/bazel#2123 is fixed *** Original change description *** Add explicit type annotations in BlazeJavacArguments.java Fixes bazel-tests for java 7 after commit 3c5e55ff8e058b624ce26e803ff00434c70d4b91 -- PiperOrigin-RevId: 144453400 MOS_MIGRATED_REVID=144453400
* Add a to_list() method to depsetsGravatar Jon Brandvein2017-01-16
| | | | | | | | | | | | This is the preferred way to test for membership in, or iterate over, depsets (aka nested sets, aka plain old set()). The old way of doing membership tests or iterations over the raw depset itself is deprecated and may be removed in the future. Note that membership testing in a depset was always an O(n) operation, perhaps contrary to the user's expectation, so using to_list() does not make things asymptotically worse. It just makes things more explicit. RELNOTES: To iterate over or test for membership in a set, prefer using the new to_list() method. E.g., "for x in myset.to_list():", or "print(x in myset.to_list())". Iteration/membership-test on the raw set itself is deprecated. -- PiperOrigin-RevId: 144452510 MOS_MIGRATED_REVID=144452510
* SubprocessBuilder: document argv contractGravatar Laszlo Csomor2017-01-16
| | | | | | | | | | | | Make it part of the interface contract that the argv[0] must be either absolute or just a file name. The only caller has been adhering to this contract already, but document it explicitly still. -- PiperOrigin-RevId: 144447641 MOS_MIGRATED_REVID=144447641
* Remove TRANSITIVE_MODULE_MAPS feature logic. This was only meant to be used forGravatar Googler2017-01-16
| | | | | | | | a transition and is completely unused by now. -- PiperOrigin-RevId: 144446659 MOS_MIGRATED_REVID=144446659
* Open sourcing LicensingTests.Gravatar Irina Iancu2017-01-16
| | | | | | -- PiperOrigin-RevId: 144445429 MOS_MIGRATED_REVID=144445429
* Fix a null check in ActionMetadataHandler.Gravatar Kush Chakraborty2017-01-16
| | | | | | -- PiperOrigin-RevId: 144444493 MOS_MIGRATED_REVID=144444493
* Rollback of commit 156adeec613ab140a91d73e1147bc688689bcfb7.Gravatar Lukacs Berki2017-01-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks Bazel on JDK 7: http://ci.bazel.io/view/Dashboard/job/bazel-tests/BAZEL_VERSION=HEAD-jdk7,PLATFORM_NAME=linux-x86_64/475/console *** Original change description *** Automated [] rollback of commit 5163ec2c0db8fbdc7f367bb4aca5b6d7ae6d80b0. *** Reason for rollback *** See unknown commit *** Original change description *** Automated [] rollback of commit c9dbd4c1a4a4b4345c0b3924f86e01612ae12807. *** Reason for rollback *** Breaks bazel-docker-tests http://ci.bazel.io/view/Dashboard/job/bazel-docker-tests/lastCompletedBuild/BAZEL_VERSION=HEAD,PLATFORM_NAME=docker/console *** Original change description *** Enable header compilation by default -- PiperOrigin-RevId: 144443446 MOS_MIGRATED_REVID=144443446
* Merge the action input prefetcher into the ExecutorBuilder.Gravatar Ulf Adams2017-01-13
| | | | | | | | | This should be a no-op change, primarily intended to improve the BlazeModule API. The code simplification in the distributor code path is incidental. -- PiperOrigin-RevId: 144441458 MOS_MIGRATED_REVID=144441458
* Tell Python binaries the location of their runfiles tree using the ↵Gravatar Lukacs Berki2017-01-13
| | | | | | | | | | | | RUNFILES_DIR environment variable. Note that this is slightly different from the Java launcher (where the same is JAVA_RUNFILES) Fixes #2339. -- PiperOrigin-RevId: 144439111 MOS_MIGRATED_REVID=144439111
* Make the server commit suicide if its PID file vanishes.Gravatar Lukacs Berki2017-01-13
| | | | | | -- PiperOrigin-RevId: 144434688 MOS_MIGRATED_REVID=144434688
* When the server doesn't return an exit code, add the location of the server ↵Gravatar Lukacs Berki2017-01-13
| | | | | | | | | | log file to the error message. Helps with #2309. Hopefully. -- PiperOrigin-RevId: 144431711 MOS_MIGRATED_REVID=144431711
* Remove a superfluous "return null" from JvmConfigurationLoader.Gravatar Lukacs Berki2017-01-13
| | | | | | | | RedirectChaser needs to load the target to check if it's a bind/alias rule so it's not possible that it's not loaded yet by the time we get there. -- PiperOrigin-RevId: 144429298 MOS_MIGRATED_REVID=144429298
* Also add the duration as the test process time.Gravatar Ulf Adams2017-01-13
| | | | | | | | | | | | | | | | | | | | | Technically, this code is incorrect, because we're calling into spawn strategy, which might do any amount of additional waiting (e.g., to acquire local resources). We should change spawn strategy to return structured information about the subprocess execution, including the wall time, and use that to set the test information. But for now, this seems good enough. Fixes #1748. Effectively a rollback of the rollback, but with a manual fix. The problem was that the code was assuming exactly one process time, which is incorrect in at least the case where the proto comes from a previous Bazel version, because that didn't set the process time at all. We're now copying over all the values, which should work in all cases. -- PiperOrigin-RevId: 144425125 MOS_MIGRATED_REVID=144425125
* Log the IOException when an output was not successfully created. It's ↵Gravatar Janak Ramakrishnan2017-01-13
| | | | | | | | possible the exception has information we've been suppressing. -- PiperOrigin-RevId: 144405370 MOS_MIGRATED_REVID=144405370
* Fix CancellableRequestFactoryTest so it passes on JUnit 4.12.Gravatar Googler2017-01-13
| | | | | | | | JUnit 4.12 has more strict validation checks about test classes being public. -- PiperOrigin-RevId: 144398872 MOS_MIGRATED_REVID=144398872
* Avoid materializing the nested set for filegroup srcsGravatar Liam Miller-Cushon2017-01-13
| | | | | | | | and then wrapping it in another nested set. -- PiperOrigin-RevId: 144398091 MOS_MIGRATED_REVID=144398091
* Improve recursive deletion in JavaBuilderGravatar Liam Miller-Cushon2017-01-13
| | | | | | | | to use nio, and remove unused features. -- PiperOrigin-RevId: 144396133 MOS_MIGRATED_REVID=144396133
* Support Paths in JarCreater and JarHelperGravatar Liam Miller-Cushon2017-01-13
| | | | | | | | | Instead of passing strings representing paths in the default filesystem. -- PiperOrigin-RevId: 144395118 MOS_MIGRATED_REVID=144395118
* AppleCrosstoolTransition is also applied to any incoming edge to a rule classGravatar Cal Peyser2017-01-13
| | | | | | | | | | | that may contain objc source. This only works with dynamic configurations turned on. This ensures that objc dependencies of non-objc targets use the apple crosstool. -- PiperOrigin-RevId: 144384483 MOS_MIGRATED_REVID=144384483
* Rollback of commit 117197000692fd7391962ef968228a31bf97399a.Gravatar Adam Michael2017-01-13
| | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Rollforward with fix for AarImportTest. The test failed previously due to a difference in the configuration because getConfiguredTarget("//a:bar") does not invoke the android split transition, so the artifact paths did not exactly match. *** Original change description *** Automated [] rollback of commit 7fc35ae6890f4130b4d99a6c5007dcee91c5a8cc. *** Reason for rollback *** Breaks //src/test/java/com/google/devtools/build/lib:bazel-rules-tests http://ci.bazel.io/view/Dashboard/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/lastCompletedBuild/console *** Original change description *** aar_import provides JavaCompilationArgsProvider for DexArchiveAspect. -- PiperOrigin-RevId: 144370584 MOS_MIGRATED_REVID=144370584
* Move mocking logic for AndroidSdkRepositoryTest into the test itself.Gravatar Adam Michael2017-01-13
| | | | | | -- PiperOrigin-RevId: 144370558 MOS_MIGRATED_REVID=144370558
* Move the serialize and write functionality from UnwrittenMergedAndroidData ↵Gravatar Googler2017-01-13
| | | | | | | | to ParsedAndroidData. This improves reuse. -- PiperOrigin-RevId: 144369566 MOS_MIGRATED_REVID=144369566
* Log if dangling symlink is found. This is an odd choice of thing to log, but ↵Gravatar Janak Ramakrishnan2017-01-13
| | | | | | | | shouldn't come up very often, except in the linked bug. -- PiperOrigin-RevId: 144367142 MOS_MIGRATED_REVID=144367142
* Coalesce JavaBuilder class hierarchyGravatar Liam Miller-Cushon2017-01-13
| | | | | | | | Some of these abstract classes used to have more than one subtype. -- PiperOrigin-RevId: 144366452 MOS_MIGRATED_REVID=144366452