| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
|
|
| |
This is the second encore of commit 823091f7516abf7d854021edc765daf1467f1647. The first one failed because jarjar tried to write to C:\WINDOWS , the second one failed because cygpath does not always return a proper temp directory, the third one failed because the bash quoting doesn't handle $ signs in directories (fixed in commit 35a37e0429add201342dd1d005bc9286c53c02c3).
Fourth time is the charm!
--
PiperOrigin-RevId: 144689400
MOS_MIGRATED_REVID=144689400
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144688363
MOS_MIGRATED_REVID=144688363
|
|
|
|
|
|
|
|
| |
It is just a specification yet, it does nothing.
--
PiperOrigin-RevId: 144687428
MOS_MIGRATED_REVID=144687428
|
|
|
|
|
|
|
|
|
|
| |
Fixes #2360.
--
Change-Id: I33dcfa1128b74f20dde14c5b5e095790a8961bd5
Reviewed-on: https://cr.bazel.build/8219
PiperOrigin-RevId: 144685099
MOS_MIGRATED_REVID=144685099
|
|
|
|
|
|
|
|
|
|
|
| |
The mobile_install command has a hard dependency on the Android rules. For
mu-Bazel, we're trying to build a minimally useful Bazel binary, and that
should not contain the Android rules. Moving the mobile install command
implementation to a separate package is one step towards that.
--
PiperOrigin-RevId: 144680452
MOS_MIGRATED_REVID=144680452
|
|
|
|
|
|
|
|
|
| |
These rules can be used to configure JDKs, as an alternative to
the filegroups and filegroups-of-filegroups used currently.
--
PiperOrigin-RevId: 144655277
MOS_MIGRATED_REVID=144655277
|
|
|
|
|
|
|
|
|
|
| |
Resolves #2363
RELNOTES: Remove support for --javawarn; use e.g. --javacopt=-Xlint:all instead
--
PiperOrigin-RevId: 144652008
MOS_MIGRATED_REVID=144652008
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the argv (including argv[0]).
This is necessary because Bazel 0.4.3 can have $ in its output base (fixed in commit b64349e91debe8abb8a218c6e8888dc9b42fdea3), and if that happens, built Java binaries won't be executable because bash will understand that as a variable to be interpolated.
laszlocsomor says that the quoting is otherwise alright. I'm not sure what happens with other special characters (e.g. @!{}%#'"), but at least we don't put those in the output base ourselves.
See: https://github.com/bazelbuild/bazel/issues/2306 .
--
PiperOrigin-RevId: 144640441
MOS_MIGRATED_REVID=144640441
|
|
|
|
|
|
|
|
| |
when it's reached through a :java_toolchain attribute.
--
PiperOrigin-RevId: 144638966
MOS_MIGRATED_REVID=144638966
|
|
|
|
|
|
|
|
|
|
| |
Also test_build_repo set-up that starts failing with sharding
--
Change-Id: I9b950f1569737c52f9a4608eaad68db01f30ac82
Reviewed-on: https://cr.bazel.build/8144
PiperOrigin-RevId: 144631720
MOS_MIGRATED_REVID=144631720
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks Bazel build for Windows using Java 1.8
http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=windows-x86_64/1188/
*** Original change description ***
Jarjar the third-party dependencies of the Jacoco test runner.
This is the second encore of commit 823091f7516abf7d854021edc765daf1467f1647. The first one failed because jarjar tried to write to C:\WINDOWS , the second one failed because cygpath doesn't work for some reason on our CI machines and I hope that the "jarjar_bin cannot found" error message was only a fluke.
Otherwise, this'll be fixed online.
--
PiperOrigin-RevId: 144630946
MOS_MIGRATED_REVID=144630946
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cmd_helper is deprecated and planned for deletion.
RELNOTES[INC]:
Removed the cmd_helper.template function.
The function was equivalent to:
def template(items, template):
return [template.format(path = i.path, short_path = i.short_path)
for i in items]
--
PiperOrigin-RevId: 144628429
MOS_MIGRATED_REVID=144628429
|
|
|
|
|
|
|
|
| |
Fixes #2286.
--
PiperOrigin-RevId: 144627152
MOS_MIGRATED_REVID=144627152
|
|
|
|
|
|
|
|
|
|
| |
This is the second encore of commit 823091f7516abf7d854021edc765daf1467f1647. The first one failed because jarjar tried to write to C:\WINDOWS , the second one failed because cygpath doesn't work for some reason on our CI machines and I hope that the "jarjar_bin cannot found" error message was only a fluke.
Otherwise, this'll be fixed online.
--
PiperOrigin-RevId: 144625508
MOS_MIGRATED_REVID=144625508
|
|
|
|
|
|
|
|
|
|
| |
This change moves AsExecutablePathForCreateProcess
to windows_util. This is a follow-up to
unknown commit.
--
PiperOrigin-RevId: 144623760
MOS_MIGRATED_REVID=144623760
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prepare moving AsExecutableForCreateProcess into a
shared location where the Bazel client code can
also access it, since this logic is needed there
too.
This change is a simple refactor, it doesn't
affect any logic.
--
PiperOrigin-RevId: 144623656
MOS_MIGRATED_REVID=144623656
|
|
|
|
|
|
|
|
|
| |
implementation has never been fully complete and it turns out that this isn't
necessary. We can re-add if it becomes useful at some point.
--
PiperOrigin-RevId: 144618513
MOS_MIGRATED_REVID=144618513
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When spawning a new process with CreateProcessA,
convert argv0 to a 8dot3 style short path so we
can support longer paths than MAX_PATH. This is
the same approach we did in commit 44ecf9a0c7c25496a43f59f1c8f20df9527e12cb.
See https://github.com/bazelbuild/bazel/issues/2107
See https://github.com/bazelbuild/bazel/issues/2181
--
PiperOrigin-RevId: 144613589
MOS_MIGRATED_REVID=144613589
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144608820
MOS_MIGRATED_REVID=144608820
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
bazelbuild/bazel#2123 is fixed
*** Original change description ***
Fix JavaLibraryBuildRequest for java 7
Bazel still supports java 7. This cl fixes a java 8-only construct introduced by commit 3c5e55ff8e058b624ce26e803ff00434c70d4b91.
Liam, feel free to fix it to your liking afterwards.
--
PiperOrigin-RevId: 144511670
MOS_MIGRATED_REVID=144511670
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144511168
MOS_MIGRATED_REVID=144511168
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144494739
MOS_MIGRATED_REVID=144494739
|
|
|
|
|
|
|
|
| |
* Require callers to use argument labels so that the call site looks the same in Swift 2 and 3.
--
PiperOrigin-RevId: 144484042
MOS_MIGRATED_REVID=144484042
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144474876
MOS_MIGRATED_REVID=144474876
|
|
|
|
|
|
|
|
|
|
| |
javac's main catches all exceptions and returns an exit code, the API does not.
This restores error handling that was lost when we migrated to the API in
commit 3c5e55ff8e058b624ce26e803ff00434c70d4b91.
--
PiperOrigin-RevId: 144457176
MOS_MIGRATED_REVID=144457176
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows JavaBuilder to support srcjars containing entries that
differ only in case, even if the platform filesystem is case insensitive.
Also, simplify srcjar handling and remove the SourceJarEntryListener
abstraction since it wasn't pulling its weight.
--
PiperOrigin-RevId: 144456040
MOS_MIGRATED_REVID=144456040
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
bazelbuild/bazel#2123 is fixed
*** Original change description ***
Add explicit type annotations in BlazeJavacArguments.java
Fixes bazel-tests for java 7 after commit 3c5e55ff8e058b624ce26e803ff00434c70d4b91
--
PiperOrigin-RevId: 144453400
MOS_MIGRATED_REVID=144453400
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the preferred way to test for membership in, or iterate over, depsets (aka nested sets, aka plain old set()). The old way of doing membership tests or iterations over the raw depset itself is deprecated and may be removed in the future.
Note that membership testing in a depset was always an O(n) operation, perhaps contrary to the user's expectation, so using to_list() does not make things asymptotically worse. It just makes things more explicit.
RELNOTES: To iterate over or test for membership in a set, prefer using the new to_list() method. E.g., "for x in myset.to_list():", or "print(x in myset.to_list())". Iteration/membership-test on the raw set itself is deprecated.
--
PiperOrigin-RevId: 144452510
MOS_MIGRATED_REVID=144452510
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make it part of the interface contract that the
argv[0] must be either absolute or just a file
name. The only caller has been adhering to this
contract already, but document it explicitly
still.
--
PiperOrigin-RevId: 144447641
MOS_MIGRATED_REVID=144447641
|
|
|
|
|
|
|
|
| |
a transition and is completely unused by now.
--
PiperOrigin-RevId: 144446659
MOS_MIGRATED_REVID=144446659
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144445429
MOS_MIGRATED_REVID=144445429
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144444493
MOS_MIGRATED_REVID=144444493
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks Bazel on JDK 7: http://ci.bazel.io/view/Dashboard/job/bazel-tests/BAZEL_VERSION=HEAD-jdk7,PLATFORM_NAME=linux-x86_64/475/console
*** Original change description ***
Automated [] rollback of commit 5163ec2c0db8fbdc7f367bb4aca5b6d7ae6d80b0.
*** Reason for rollback ***
See unknown commit
*** Original change description ***
Automated [] rollback of commit c9dbd4c1a4a4b4345c0b3924f86e01612ae12807.
*** Reason for rollback ***
Breaks bazel-docker-tests
http://ci.bazel.io/view/Dashboard/job/bazel-docker-tests/lastCompletedBuild/BAZEL_VERSION=HEAD,PLATFORM_NAME=docker/console
*** Original change description ***
Enable header compilation by default
--
PiperOrigin-RevId: 144443446
MOS_MIGRATED_REVID=144443446
|
|
|
|
|
|
|
|
|
| |
This should be a no-op change, primarily intended to improve the BlazeModule
API. The code simplification in the distributor code path is incidental.
--
PiperOrigin-RevId: 144441458
MOS_MIGRATED_REVID=144441458
|
|
|
|
|
|
|
|
|
|
|
|
| |
RUNFILES_DIR environment variable.
Note that this is slightly different from the Java launcher (where the same is JAVA_RUNFILES)
Fixes #2339.
--
PiperOrigin-RevId: 144439111
MOS_MIGRATED_REVID=144439111
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144434688
MOS_MIGRATED_REVID=144434688
|
|
|
|
|
|
|
|
|
|
| |
log file to the error message.
Helps with #2309. Hopefully.
--
PiperOrigin-RevId: 144431711
MOS_MIGRATED_REVID=144431711
|
|
|
|
|
|
|
|
| |
RedirectChaser needs to load the target to check if it's a bind/alias rule so it's not possible that it's not loaded yet by the time we get there.
--
PiperOrigin-RevId: 144429298
MOS_MIGRATED_REVID=144429298
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Technically, this code is incorrect, because we're calling into spawn strategy,
which might do any amount of additional waiting (e.g., to acquire local
resources). We should change spawn strategy to return structured information
about the subprocess execution, including the wall time, and use that to set
the test information. But for now, this seems good enough.
Fixes #1748.
Effectively a rollback of the rollback, but with a manual fix.
The problem was that the code was assuming exactly one process time,
which is incorrect in at least the case where the proto comes from a previous
Bazel version, because that didn't set the process time at all. We're now
copying over all the values, which should work in all cases.
--
PiperOrigin-RevId: 144425125
MOS_MIGRATED_REVID=144425125
|
|
|
|
|
|
|
|
| |
possible the exception has information we've been suppressing.
--
PiperOrigin-RevId: 144405370
MOS_MIGRATED_REVID=144405370
|
|
|
|
|
|
|
|
| |
JUnit 4.12 has more strict validation checks about test classes being public.
--
PiperOrigin-RevId: 144398872
MOS_MIGRATED_REVID=144398872
|
|
|
|
|
|
|
|
| |
and then wrapping it in another nested set.
--
PiperOrigin-RevId: 144398091
MOS_MIGRATED_REVID=144398091
|
|
|
|
|
|
|
|
| |
to use nio, and remove unused features.
--
PiperOrigin-RevId: 144396133
MOS_MIGRATED_REVID=144396133
|
|
|
|
|
|
|
|
|
| |
Instead of passing strings representing paths in the default
filesystem.
--
PiperOrigin-RevId: 144395118
MOS_MIGRATED_REVID=144395118
|
|
|
|
|
|
|
|
|
|
|
| |
that may contain objc source. This only works with dynamic configurations
turned on.
This ensures that objc dependencies of non-objc targets use the apple crosstool.
--
PiperOrigin-RevId: 144384483
MOS_MIGRATED_REVID=144384483
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rollforward with fix for AarImportTest. The test failed previously due to a difference in the configuration because getConfiguredTarget("//a:bar") does not invoke the android split transition, so the artifact paths did not exactly match.
*** Original change description ***
Automated [] rollback of commit 7fc35ae6890f4130b4d99a6c5007dcee91c5a8cc.
*** Reason for rollback ***
Breaks //src/test/java/com/google/devtools/build/lib:bazel-rules-tests
http://ci.bazel.io/view/Dashboard/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/lastCompletedBuild/console
*** Original change description ***
aar_import provides JavaCompilationArgsProvider for DexArchiveAspect.
--
PiperOrigin-RevId: 144370584
MOS_MIGRATED_REVID=144370584
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144370558
MOS_MIGRATED_REVID=144370558
|
|
|
|
|
|
|
|
| |
to ParsedAndroidData. This improves reuse.
--
PiperOrigin-RevId: 144369566
MOS_MIGRATED_REVID=144369566
|
|
|
|
|
|
|
|
| |
shouldn't come up very often, except in the linked bug.
--
PiperOrigin-RevId: 144367142
MOS_MIGRATED_REVID=144367142
|
|
|
|
|
|
|
|
| |
Some of these abstract classes used to have more than one subtype.
--
PiperOrigin-RevId: 144366452
MOS_MIGRATED_REVID=144366452
|