aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Add option to dump command lines of actions in dump.Gravatar twerth2018-03-07
| | | | | RELNOTES: None PiperOrigin-RevId: 188164754
* Don't use computeIfAbsent in action graph dumping.Gravatar twerth2018-03-07
| | | | | | | | | | | | | | | computeIfAbsent may throw (on best effort basis) a ConcurrentModificationException if you change the underlying Map in the computeIfAbsent call, for example when you call computeIfAbsent recursively in the mappingFunction. NestedSets are an inherent recursive structure, so we need to call computeIfAbsent recursively in the action graph dump. Since computeIfAbsent doesn't throw the exception all the time, it's hard to come up with a reliable test case. RELNOTES: None PiperOrigin-RevId: 188151283
* C++: Makes sure ltoBitcodeFiles get merged when merging compilation outputs.Gravatar plf2018-03-07
| | | | | RELNOTES: PiperOrigin-RevId: 188149648
* C++ providers: Removes C++ providers from JavaWrapCcGravatar plf2018-03-07
| | | | | | | They are now wrapped by a JavaWrapCc specific provider. RELNOTES:none PiperOrigin-RevId: 188140909
* Post PatternExpandingError from the skyframe target pattern evaluator as needed.Gravatar Benjamin Peterson2018-03-07
| | | | | | | | | This fixes https://github.com/bazelbuild/bazel/issues/4731. Also, add test coverage for posting of ParsingFailedEvent and handling of cycles in LoadingPhaseRunnerTest. Change-Id: I88c9d33417b9c3c7a06c92a6137d58f37b991b0c PiperOrigin-RevId: 188138972
* Filter out non-.flat files while linking.Gravatar corysmith2018-03-06
| | | | | RELNOTES: None PiperOrigin-RevId: 188121571
* Use -isystem instead of -I for NDK header search paths.Gravatar jingwen2018-03-06
| | | | | | | | | | | | | | This suppresses warnings from the NDK headers from users. This also fixes the correct include search paths, because -isystem dirs are searched _after_ -I dirs. https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html#Directory-Options "You can use -I to override a system header file, substituting your own version, since these directories are searched before the standard system header file directories. However, you should not use this option to add directories that contain vendor-supplied system header files; use -isystem for that. The -isystem and -idirafter options also mark the directory as a system directory, so that it gets the same special treatment that is applied to the standard system directories." RELNOTES[FIX]: Fixed NDK r15/r16 system include search paths to use -isystem instead of -I. PiperOrigin-RevId: 188111072
* Expose an actions provider on RuleConfiguredTarget instances.Gravatar cparsons2018-03-06
| | | | | | | | | Given a target (for example from a skylark aspect), one will be able to access a list of actions that the target generated using "target.actions". This is without additional memory footprint. Actions themselves are not fully exposed to skylark (and thus there isn't much meaning to gather from them in skylark yet). Access methods will follow soon. RELNOTES: None. PiperOrigin-RevId: 188098079
* Adding async proto or text logging utility class.Gravatar olaola2018-03-06
| | | | | | | WANT_LGTM=buchgr TESTED=unit tests, 500 runs per test RELNOTES: None PiperOrigin-RevId: 188093043
* @AutoCodec File{State}Value.Gravatar janakr2018-03-06
| | | | PiperOrigin-RevId: 188085895
* Use new android_tools_defaults_jar in tests.Gravatar Adam Michael2018-03-06
| | | | | | | | | | | | | | //tools/defaults:android_jar is a synthetic target that is being replaced by the regular target @bazel_tools//tools/android:android_jar in Bazel 0.11 and later. See cf097e4. Change-Id: I2cfc38a0dcd25f43985e75b386f9f1cadec86320 RELNOTES: None Closes #4785. Change-Id: I2cfc38a0dcd25f43985e75b386f9f1cadec86320 PiperOrigin-RevId: 188080503
* Make the builtins registry thread-safeGravatar brandjon2018-03-06
| | | | | | | | | | | | | | It was previously assumed that safety wasn't needed because 1) all builtins should be registered in static initializer blocks, and 2) all retrievals should occur during Skylark evaluation, after static initialization completes. It turns out these assumptions aren't actually true (Who would've thunk it!). SkylarkActionFactory has been observed to be initialized as late as analysis time, and retrievals occur as early as constructing a PackageFactory (when scanning the native module). The failure mode is particularly ugly: Random Skylark method lookups will fail non-deterministically. This change guards against this by making the builtins registry implement a form of freezing. Before freezing, reads and writes are allowed and are synchronized. After freezing, only reads are allowed and they are unsynchronized for performance. BlazeRuntime is responsible for flipping the bit, and for ensuring classes like SkylarkActionFactory run their initialization by that point. Unit tests don't need to worry, since they just stay unfrozen and synchronized throughout. RELNOTES: None PiperOrigin-RevId: 188080136
* Don't display remote exec failed message on interrupt. Fixes #4783Gravatar olaola2018-03-06
| | | | | | TESTED=manually RELNOTES: None PiperOrigin-RevId: 188079436
* Add proper serialization constructor and equals/hashCode for EnvironmentLabels.Gravatar janakr2018-03-06
| | | | PiperOrigin-RevId: 188078054
* @AutoCodec TransitiveTraversalValue, DirectoryListingStateValue.Gravatar janakr2018-03-06
| | | | PiperOrigin-RevId: 188077900
* Do not expose platform-related providers to Skylark.Gravatar John Cater2018-03-06
| | | | | | | | | | | | This prevents both creation and access to platform providers from Skylark. This is needed so we can load platforms directly from platform-rule targets without needing a full configured target, and to effiently distinguish platform providers from non-platform providers. Change-Id: I6b61f9ee7518d5e9311232908a922596e18fe32f PiperOrigin-RevId: 188070457
* Add documentation for JavaInfo constructor.Gravatar dbabkin2018-03-06
| | | | | RELNOTES:none PiperOrigin-RevId: 188066111
* Convert a bunch of non-AutoCodec classes to use @AutoCodec: ↵Gravatar janakr2018-03-06
| | | | | | BuildConfiguration, BuildOptions, CollectTargetsUnderDirectoryValue. PiperOrigin-RevId: 188059815
* Fix incomplete documentation changeGravatar brandjon2018-03-06
| | | | | | | | | This finishes a partial change erroneously submitted as part of https://github.com/bazelbuild/bazel/commit/864ac520951821bd197a02490d2b04f6246be7fa. The full outputs map behavior is still not fully described because its implementation is too complex. That requires a separate discussion. RELNOTES: None PiperOrigin-RevId: 188049028
* Release 0.11.1 (2018-03-06)Gravatar Bazel Release System2018-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Baseline: 00d781ae78a8bd51d3c61b621d79f0bb095aff9e Cherry picks: + ea2d4c475febdbd59ca0e0ba46adc7be759f84e0: Update stub_finds_runfiles_test to be a real sh_test. + d855d8133f4efb73ebd5e82c54a9afb4c7565d46: java,runfiles: fix bugs in runfiles library + 56aeb04a064218b845ecc193d530c341c6ec854d: Fixing #4585: broken re-execution of orphaned actions. + cf3f81aef7c32019d70cbce218a64a03276268f0: remote: Add support for HTTP Basic Auth + 28bd997c1c8793973f63dcae4c22bbae49e7d8b7: Fixing test-setup.sh occasionally missing stdout/stderr, on systems where "tail --pid" is supported. + 109e4b4dc9e786e3a2d8d7cb245d18320dbe9216: Automated rollback of commit 7e6837cc1d1aa4259f5c27ba3606b277b5f6c3e9. + b3d52b1b6d46a0f23cc91125c1d522e9d13433b4: Fix incorrect include directories when -no-canonical-prefixes is passed to clang + 1001141f0674ff4b611814edcb00a5183680ef4a: Roll forward of https://github.com/bazelbuild/bazel/commit/3904ac33a983fd8faebba1 b52bcac5a3ff942029 (https://github.com/bazelbuild/bazel/commit/3904ac33a983fd8faebba 1b52bcac5a3ff942029). Fix #4625 by running the test process in a sub-shell. + fc98b44b6181fa4c3efd8613d887970629468d74: android,windows: bugfix in aar_resources_extractor Important changes: - Fixes regression building Android rules on Windows.
* Automated rollback of commit f43df1e29765f75e02838e4139417e914b3ee812.Gravatar cparsons2018-03-06
| | | | | | | | | | | | | *** Reason for rollback *** Breaks external cc_proto_library. See https://github.com/bazelbuild/bazel/issues/4780 RELNOTES: None. *** Original change description *** Fixing issue with external j2objc protos PiperOrigin-RevId: 188041921
* Add a command line option to disallow vardef()s with three arguments.Gravatar lberki2018-03-06
| | | | | RELNOTES: None. PiperOrigin-RevId: 188038131
* Add wildcard support to AutoCodec.Gravatar mjhalupka2018-03-06
| | | | PiperOrigin-RevId: 188034513
* Implement support for sourceFiles parameter in JavaInfo constructor.Gravatar dbabkin2018-03-06
| | | | | RELNOTES:none PiperOrigin-RevId: 188026038
* Replace instances of XCode with Xcode which is the proper casing for the name.Gravatar Sergio Campama2018-03-06
| | | | | | Closes #4640. PiperOrigin-RevId: 188022228
* Fix query page table of contents.Gravatar dannark2018-03-06
| | | | | RELNOTES: None PiperOrigin-RevId: 188019651
* Internal changeGravatar hlopko2018-03-06
| | | | PiperOrigin-RevId: 188013147
* Bump jgit to 4.10 and jsch to 1.54Gravatar David Ostrovsky2018-03-06
| | | | | | | | | | | | | Fixes: #4762. GitHub recently removed weak crypto algorithm and the older versions of JGit/JSch were affected. https://githubengineering.com/crypto-removal-notice Change-Id: I985fea98c67c4374fb9ef0cd59cd0f95ed77db33 Closes #4771.
* Split up action graph cache into multiple classes for cleaner code.Gravatar twerth2018-03-06
| | | | | RELNOTES: None PiperOrigin-RevId: 187997144
* Remove cc_inc_library from bazelGravatar hlopko2018-03-06
| | | | | | | | | | | | | It shouldn't be open sourced at all, since it solves a very specific internal use case, and for external use cc_library with its includes, include_prefix, and strip_include_prefix attributes can be used to perfectly replace cc_inc_library. RELNOTES: Removed cc_inc_library, please use cc_library instead Use includes, include_prefix, and strip_include_prefix attributes of cc_library to replace the behavior of cc_inc_library with cc_library. PiperOrigin-RevId: 187991313
* Internal changeGravatar hlopko2018-03-06
| | | | PiperOrigin-RevId: 187988936
* Re-evaluate workspace status when clientEnv changesGravatar Justin Santa Barbara2018-03-06
| | | | | | | | | | | | We pass the clientEnv to the workspace status command, and it may use environment variables to influence status. We must therefore reevaluate the workspace status command whenever the clientEnv changes. Fixes #4222 Closes #4705. PiperOrigin-RevId: 187988847
* Internal changeGravatar hlopko2018-03-06
| | | | PiperOrigin-RevId: 187986062
* Also get build-runfiles as an ActionInput for the symlink tree spawnGravatar ulfjack2018-03-06
| | | | | | | This isn't strictly necessary since we disable caching and require local execution. PiperOrigin-RevId: 187985476
* Remove references to the "message_log" from Bazel.Gravatar ruperts2018-03-05
| | | | | RELNOTES: None. PiperOrigin-RevId: 187974423
* @AutoCodec RepositoryName.Gravatar janakr2018-03-05
| | | | PiperOrigin-RevId: 187956593
* Serialize Path using AutoCodec.Gravatar janakr2018-03-05
| | | | PiperOrigin-RevId: 187945746
* Cache SkylarkLookupImportValues in memory so that we don't recompute them ↵Gravatar shreyax2018-03-05
| | | | | | multiple times. PiperOrigin-RevId: 187941859
* Add --experimental_fix_deps_tool flag to BazelGravatar Googler2018-03-05
| | | | | RELNOTES: None PiperOrigin-RevId: 187936071
* remote: Add interceptor for logging gRPC calls during remote execution/cachingGravatar Googler2018-03-05
| | | | | | | | | | This provides a io.grpc.ClientInterceptor implementation that can be used to log gRPC call information. The interceptor can select a logging handler to use based on the gRPC method being called (Watch, Execute, Write, etc) to build a LogEntry, which can then be logged after the call has finished. Unit tests for the interceptor are included. In this change, the interceptor is never invoked, nor are there any handlers implemented for any gRPC methods. The interceptor also never tries to log any entries. To avoid circular dependency issues (Remote library will depend on logger which depends on remote library for utils), I've factored out the utility classes from the remote library into their own directory/package as part of this change. PiperOrigin-RevId: 187926516
* @AutoCodec for TypeGravatar shahan2018-03-05
| | | | | | Needed for Attribute serialization. PiperOrigin-RevId: 187907727
* Fix missing singlejar on arm and windowsGravatar Pascal Terjan2018-03-05
| | | | | | | | This was broken by the jar being renamed from SingleJar_deploy.jar to bazel-singlejar_deploy.jar in commit 6705b508fe069147c853ca9669363342f3527689 (Fixes #3988) Closes #4642. PiperOrigin-RevId: 187880736
* Fix CppToolchainProvider to get unfiltered compiler flags from theGravatar John Cater2018-03-05
| | | | | | | actual toolchain, not the CppConfiguration. Change-Id: I9cb74a883d3041ee2c31d294c0a1a36df578f738 PiperOrigin-RevId: 187880704
* Fixed broken links to user manual in docsGravatar Jingwen Chen2018-03-05
| | | | | | | | The user manual filename has been renamed from `bazel-user-manual.html` to `user-manual.html`. Closes #4662. PiperOrigin-RevId: 187877241
* Preserve the source directory tree in the RPM BUILD directoryGravatar mmikitka2018-03-05
| | | | | | | | Previously, there was a risk of filename collisions, since all data files were flattened into the BUILD directory. Closes #4747. PiperOrigin-RevId: 187870196
* Recommend to use the Visual C++ Build Tools 2015.Gravatar Philipp Wollermann2018-03-05
| | | | | | Closes #4743. PiperOrigin-RevId: 187869648
* Automated rollback of commit 96145511b34a2d7be834e3eb05927674e875c813.Gravatar janakr2018-03-05
| | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Fixed issue that led to rollback. RELNOTES: None *** Original change description *** Automated rollback of commit eee53d3a33dde441f7e7adaecde81ef2d3db7c1b. *** Reason for rollback *** breaks Blaze_CorpTest *** Original change description *** @AutoCodec ConfiguredTargetValue. PiperOrigin-RevId: 187869560
* Document the VC++ redistributable dependencyGravatar John Maguire2018-03-05
| | | | | | | | Fixes #4740 Closes #4768. PiperOrigin-RevId: 187868625
* Add log line to show that we're scanning for ObjectCodecs.Gravatar janakr2018-03-05
| | | | PiperOrigin-RevId: 187868296
* Move action graph dump methods into the ActionGraphDump class.Gravatar twerth2018-03-05
| | | | | RELNOTES: None PiperOrigin-RevId: 187865083