aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Bug: Skylark performs action consistency check even if actions are dropped.Gravatar Ulf Adams2016-02-02
| | | | | -- MOS_MIGRATED_REVID=113524029
* Add a test that asserts aspects propagating along implicit deps.Gravatar Dmitry Lomov2016-02-02
| | | | | | | Fix a minor bug in the process. -- MOS_MIGRATED_REVID=113519574
* Implement proper error handling for interleaved loading and analysis.Gravatar Ulf Adams2016-02-02
| | | | | | | | Add test coverage by re-running BuildViewTest with the new Skyframe loading phase runner. -- MOS_MIGRATED_REVID=113517509
* Remove the ALLOW_CC_INCLUDE_SCANNING constant since it is not being used ↵Gravatar Luis Fernando Pino Duque2016-02-02
| | | | | | | anymore. -- MOS_MIGRATED_REVID=113512761
* Use labels in load statementsGravatar Damien Martin-Guillerez2016-02-02
| | | | | | | | | | | | This will fix some issue with loading skylark rules from @bazel_tools. Tested with ./compile.sh all and also a project that use pkg_tar from @bazel_tools (which is broken at HEAD). -- Change-Id: Iffbb7134ef5fee497890c4d01b85084973d45ad0 Reviewed-on: https://bazel-review.googlesource.com/2800 MOS_MIGRATED_REVID=113508661
* Report source position information for Error Prone crashesGravatar Liam Miller-Cushon2016-02-01
| | | | | -- MOS_MIGRATED_REVID=113492679
* Fix wrapping of GlobList into SkylarkListGravatar Francois-Rene Rideau2016-02-01
| | | | | | | | | | | Make sure to wrap a GlobList into a MutableList in convertToSkylark. Indeed, GlobList is somehow a SkylarkValue, but is not actually acceptable as a Skylark value. Until this is cleaned up, tweak convertToSkylark. Also, robustify ClassObject by eagerly calling convertToSkylark on values. -- MOS_MIGRATED_REVID=113421790
* Allow AutoProfiler to not log if below a caller-specified threshold, and set ↵Gravatar Janak Ramakrishnan2016-02-01
| | | | | | | the threshold to 100 ms for two common local actions to avoid spamming the INFO log too much. I would be happy to set the threshold even higher. -- MOS_MIGRATED_REVID=113413914
* Contractually document BuildConfiguration.Fragment as immutable and strengthenGravatar Greg Estren2016-02-01
| | | | | | | | | | | | | | | the immutability interfaces of existing implementations. Eventually we want all implementations to comply, but right now CppConfiguration is a glaring exception due to FDO/LIPO support. We don't want more exceptions to arise. This is prep work for pre-trimming ConfigurationFragment.key's BuildOptions input to just the options needed by the fragment. That implies fragments can be shared across configurations, so that needs to be safe. -- MOS_MIGRATED_REVID=113408041
* Add CppCompileAction's environment variables to its computeKey methodGravatar Chris Parsons2016-02-01
| | | | | -- MOS_MIGRATED_REVID=113407051
* Improve the error message on a missing implicit dep. The old error message ↵Gravatar Nathan Harmata2016-02-01
| | | | | | | didn't include the reason why the target was missing, and it also spammed Blaze users with a "tip" that's only relevant to Blaze developers debugging newly written integration tests. -- MOS_MIGRATED_REVID=113401767
* Redesign xcode_config rule to be evaluated at the level of configuration ↵Gravatar Chris Parsons2016-02-01
| | | | | | | instead of target depss -- MOS_MIGRATED_REVID=113398355
* Reinstate mutable SkylarkDictGravatar Francois-Rene Rideau2016-02-01
| | | | | | | | | | Add <String, Object> annotation to optionMap invocation in SkylarkAttr, to make JDK 1.7 happy. Give the visible name "aspect" to class SkylarkAspect. -- MOS_MIGRATED_REVID=113394826
* Clang linker invocations for objc link system libraries before frameworks on ↵Gravatar Cal Peyser2016-02-01
| | | | | | | "--includes_prioritize_system_libs" flag. -- MOS_MIGRATED_REVID=113387488
* RELNOTES[INC]: Remove JAVAC "Make" variableGravatar Liam Miller-Cushon2016-02-01
| | | | | | | | | | | | | | The JAVAC "Make" variable is the javac packaged with the host JDK, which is not necessarily the same version used to compile java_library rules. Users should typically use java_library directly. If a manual javac invocation is required, BazelJavac uses the same javac version and flags as java_library. In the rare cases where the host JDK's compiler is actually desired, prefer `$(JAVABASE)/bin/javac` to `$(JAVAC)` for clarity. -- MOS_MIGRATED_REVID=113386241
* Turn down the log level for AarGeneratorAction's timing information. It's ↵Gravatar Googler2016-02-01
| | | | | | | | | | not useful in the general case and just contributes to Android build logspam. R_FUTURE=apell CC=blaze-devel+cl -- MOS_MIGRATED_REVID=113379242
* Infer minimum OS for plist merging from the bundling object instead of the ↵Gravatar Chris Parsons2016-02-01
| | | | | | | | | current rule's configuration. The bundling object may be for a child rule which had different configuration values than in the current rule context. -- MOS_MIGRATED_REVID=113377636
* Add test for side-effecting a list contained in a dictGravatar Francois-Rene Rideau2016-02-01
| | | | | -- MOS_MIGRATED_REVID=113369821
* Remove extra spacesGravatar Kristina Chodorow2016-02-01
| | | | | -- MOS_MIGRATED_REVID=113366155
* Rollback of commit c0a8c58b9230a1f5d76269eb7dc6b11e18f19686.Gravatar Damien Martin-Guillerez2016-01-29
| | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Break Java 1.7 builds of Bazel. See http://ci.bazel.io/job/Bazel/JAVA_VERSION=1.7,PLATFORM_NAME=linux-x86_64/327/console Test: git clone ... && git revert c0a8c58 && export JAVA_VERSION=1.7 && export BAZEL_COMPILE_TARGET=compile && bash -c "source scripts/ci/build.sh; bazel_build" *** Original change description *** Make Skylark dicts mutable Represent Skylark dict using a new subclass SkylarkDict<K, V> of Map<K, V>. Back it with a TreeMap to provide a deterministic iteration order. Also make SkylarkList generic in its element type <E>. Have Artifact implement Comparable<Object> so it can be used as TreeMap key. -- MOS_MIGRATED_REVID=113359718
* Parse the workspace name when a repository is loadedGravatar Kristina Chodorow2016-01-29
| | | | | | | | | Moved RepositoryValue to RepositoryDirectoryValue so that it could be cached (and not re-downloaded) even if the WorkspaceAST caused a Skyframe restart (as mentioned in https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java#L130-L133). -- MOS_MIGRATED_REVID=113358489
* Handle JAVA_HOME with spacesGravatar Dmitry Lomov2016-01-29
| | | | | -- MOS_MIGRATED_REVID=113356411
* Limit command line length to accomodate Windows.Gravatar Dmitry Lomov2016-01-29
| | | | | -- MOS_MIGRATED_REVID=113350910
* Use label syntax that is immune to MSYS path mangling in bootstrap scripts.Gravatar Dmitry Lomov2016-01-29
| | | | | | | | | | | On Windows, MSYS will mangle all arguments that resemble Unix paths when executing (exec*()) non-msys executables (in an attempt to convert them to Windows paths). This affects ``//src:bazel`` (it becomes ``/src:bazel``) but not ``src:bazel``. This CL converts to the latter in bootstrapping shell scripts to work around this issue. -- MOS_MIGRATED_REVID=113349821
* Merge Dmitry's jury-rigged WindowsFileSystem to decrease the number of ↵Gravatar Lukacs Berki2016-01-29
| | | | | | | | | changes between his branch and HEAD. This code will need some JNI to make it work properly, but for now, it will do. -- MOS_MIGRATED_REVID=113349143
* Use correct file path separator.Gravatar Dmitry Lomov2016-01-29
| | | | | -- MOS_MIGRATED_REVID=113349046
* Adds v13 support library in the default android repository template.Gravatar Takeshi Hagikura2016-01-29
| | | | | | | | | | | | v13 library doesn't have resources like v4 library. So adding only the jar dependency should work. That fixes https://github.com/bazelbuild/bazel/issues/827 -- Change-Id: I1b8e5e2a359472ab9525a1910ac5050c4fb2c9a7 Reviewed-on: https://bazel-review.googlesource.com/#/c/2790/ MOS_MIGRATED_REVID=113344673
* Small refactoring of SkyframeBuildView to reduce the diff for the next change.Gravatar Ulf Adams2016-01-29
| | | | | -- MOS_MIGRATED_REVID=113338481
* Parallelize top-level invalidation. No need to do all of these in sequence.Gravatar Eric Fellheimer2016-01-29
| | | | | -- MOS_MIGRATED_REVID=113313675
* Parallelize Package retrieval during Sky-query operation. To maintain ↵Gravatar Eric Fellheimer2016-01-29
| | | | | | | type-safety, we now must pass in the exception type of the callback. -- MOS_MIGRATED_REVID=113313312
* Rollback of commit e379f28f464faacc4db21f4fed3a48fa6d4d23f0.Gravatar Googler2016-01-29
| | | | | | | | | | | | | *** Reason for rollback *** The new test apparently breaks some targets. Rolling back to fix the build. *** Original change description *** Include .dwp file in the runfiles for cc_test when building with Fission. -- MOS_MIGRATED_REVID=113310353
* Update appengine repository rule namesGravatar Kristina Chodorow2016-01-29
| | | | | | | Use _ instead of -. -- MOS_MIGRATED_REVID=113307540
* Clear up some confusion about glob prefetching (the old comment was wrong). ↵Gravatar Nathan Harmata2016-01-29
| | | | | | | | | Also add some TODOs for potentially improving package loading performance. This CL has no semantic impact. -- MOS_MIGRATED_REVID=113301656
* Include .dwp file in the runfiles for cc_test when building with Fission.Gravatar Googler2016-01-29
| | | | | -- MOS_MIGRATED_REVID=113295790
* Remove AllTests from ↵Gravatar Carmi Grushko2016-01-29
| | | | | | | | | | third_party/bazel/src/tools/generate_workspace/src/test/java/com/google/devtools/build/workspace, and use regular java_test instead. I argue that these targets don't add anything, but require code and maintenance. Hudson just runs all JUnit tests it can find. -- MOS_MIGRATED_REVID=113286294
* Make Skylark dicts mutableGravatar Francois-Rene Rideau2016-01-29
| | | | | | | | | | Represent Skylark dict using a new subclass SkylarkDict<K, V> of Map<K, V>. Back it with a TreeMap to provide a deterministic iteration order. Also make SkylarkList generic in its element type <E>. Have Artifact implement Comparable<Object> so it can be used as TreeMap key. -- MOS_MIGRATED_REVID=113277489
* Rollback of commit 14cf67863d56bab1eef11687a881adf323ba55ad.Gravatar Kristina Chodorow2016-01-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Issue that caused the rollback (#819) is resolved *** Original change description *** Automated [] rollback of []. *** Reason for rollback *** Prerequisite for rolling back j2objc base workspace change *** Original change description *** Remove base_workspace from bazel setup I also removed a couple places the documentation referred to it incorrectly. There are still a couple of blog posts that mention it, but that seemed okay. RELNOTES: A bazelrc with --package_path set is no longer required for Bazel to find its tools. This also means that building //...... -- MOS_MIGRATED_REVID=113259357
* Rollback of commit 464caa54500f65fa4dad1c3031602f4338cd1b23.Gravatar Kristina Chodorow2016-01-28
| | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Issue that caused the rollback (#819) is resolved *** Original change description *** Automated [] rollback of []. *** Reason for rollback *** Breaks genrule referencing //pkg from @bazel_tools *** Original change description *** Add @bazel_tools prefix to objc tools This is in preparation for removing the requirement that base_workspace be in bazel's package_path. -- MOS_MIGRATED_REVID=113259199
* Refactor DependencyResolver to collect and return loading errors.Gravatar Ulf Adams2016-01-28
| | | | | | | | | This should never be triggered in production, where we always run a loading phase first and only analyze targets that load successfully. I.e., this is just plumbing which will be hooked up in a subsequent change. -- MOS_MIGRATED_REVID=113258593
* Resolve repository-relative labels within the current repositoryGravatar Kristina Chodorow2016-01-28
| | | | | | | | | | | Using $(location //foo) from an external repository was resolving to @//foo, not @repo//foo, which generally wouldn't be in the main repository. This may also fix other cases where getRelative was resolving incorrectly. Fixes #819. -- MOS_MIGRATED_REVID=113256854
* Stop wrapping SkylarkList-s into new MutableList-sGravatar Francois-Rene Rideau2016-01-28
| | | | | | | | Fix convertToSkylark that was wrapping List-s into new MutableList-s, which became wrong since SkylarkList now implements List. -- MOS_MIGRATED_REVID=113256638
* Don't display irrelevant line in --verbose_explanations of cc compile.Gravatar Googler2016-01-28
| | | | | -- MOS_MIGRATED_REVID=113251721
* Rename native.rule and native.rules to {existing_rule,existing_rules}Gravatar Han-Wen Nienhuys2016-01-28
| | | | | | | | | | | | This is to avoid confusion between rule(), which declares a new build rules, and native.rule(), which can only be used in macros to inspect the BUILD file processed so far. native.{rule,rules} is maintained and marked deprecated to smooth the transition for early adopters. -- MOS_MIGRATED_REVID=113250194
* Remove unused ${SYNOPSIS} variable from Bazel native rule inline documentation.Gravatar David Chen2016-01-28
| | | | | | | | | | This variable is no longer used because the docgen template directly calls RuleDocumentationAttribte.getSynopsis() instead of using the SYNOPSIS variable, and RuleDocumentationAttribute.getHtmlDocumentation() resolves the SYNOPSIS variable to the empty string. -- MOS_MIGRATED_REVID=113249993
* Fix link to Google Corporate CLA.Gravatar David Chen2016-01-28
| | | | | | | Fixes #820 -- MOS_MIGRATED_REVID=113245306
* Inject the TOOLS_REPOSITORY constant in the RuleClassProvider instead of ↵Gravatar Luis Fernando Pino Duque2016-01-28
| | | | | | | | | | | using Constants.java It also includes one example on how to use the new mechanism in BazelCppRuleClasses. This is the first phase for the removal of the TOOLS_REPOSITORY constant. -- MOS_MIGRATED_REVID=113244399
* Minor formatting fixes in code listings in Bazel CI blog post.Gravatar David Chen2016-01-28
| | | | | | | Removes extraneous '\' characters before shell script comments. -- MOS_MIGRATED_REVID=113239711
* Fix a couple of broken linksGravatar Liam Miller-Cushon2016-01-28
| | | | | -- MOS_MIGRATED_REVID=113236916
* Pass "--working_dir ." to the compile_protos scriptGravatar Chris Parsons2016-01-28
| | | | | -- MOS_MIGRATED_REVID=113200224
* workspace() is now documented in its annotationGravatar Kristina Chodorow2016-01-28
| | | | | | | ...and this documentation is incorrect. -- MOS_MIGRATED_REVID=113198846