aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* | Shard android_ndk_integration_test.Gravatar ajmichael2017-11-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this CL with --runs_per_test=10 on 2015 Macbook Pro INFO: Elapsed time: 622.222s, Critical Path: 314.33s //src/test/shell/bazel/android:android_ndk_integration_test TIMEOUT in 10 out of 10 in 314.3s Stats over 10 runs: max = 314.3s, min = 306.1s, avg = 308.9s, dev = 3.5s After this CL with --runs_per_test=10 on 2015 Macbook Pro INFO: Elapsed time: 875.356s, Critical Path: 148.11s //src/test/shell/bazel/android:android_ndk_integration_test PASSED in 148.1s Stats over 60 runs: max = 148.1s, min = 25.3s, avg = 70.2s, dev = 38.7s RELNOTES: None PiperOrigin-RevId: 177048666
* | Never allow local_resource_files in single-process testsGravatar Googler2017-11-27
| | | | | | | | | | RELNOTES: None PiperOrigin-RevId: 177048616
* | Consistently pluralize arch_flags in toolchain docsGravatar Jacob Parker2017-11-27
| | | | | | | | | | | | Closes #4159. PiperOrigin-RevId: 177033307
* | Support nested set serialization.Gravatar tomlu2017-11-27
| | | | | | | | PiperOrigin-RevId: 177032673
* | Fix link and usage of ToolchainInfo in docsGravatar Jacob Parker2017-11-27
| | | | | | | | | | | | Closes #4158. PiperOrigin-RevId: 177028468
* | (Minor) Use consistent indentation in toolchain docsGravatar Jacob Parker2017-11-27
| | | | | | | | | | | | Closes #4160. PiperOrigin-RevId: 177028049
* | Fix bug in SkyQuery's 'rbuildfiles' implementation where we were incorrectly ↵Gravatar nharmata2017-11-27
| | | | | | | | | | | | | | | | | | using FileValue, rather than FileStateValue, nodes as the roots of the rdep traversal. This is incorrect e.g. when a .bzl file is a target of a symlink that is load'd from a BUILD file. RELNOTES: None PiperOrigin-RevId: 177018264
* | Automated rollback of commit a6ed4c01d374bcf98bf39c1efc12a0f4f20fe313.Gravatar elenairina2017-11-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks //javatests/com/google/devtools/intellij/blaze/plugin/aspect/java/soygenrule:SoyGenruleTest *** Original change description *** Create the output source jar in java_common.compile and expose transitive source jars to Skylark. Slightly refactor java classes to take in specific host javabase inputs and host java executable for creating the source jar, instead of always relying on fetching them from native java rules specific attributes. Creating the output source jar in java_common.compile makes the behavior more similar to java_library. Exposing the transitive_source_jars to Skylark helps with the Skylark migration fr... *** RELNOTES: None. PiperOrigin-RevId: 177015958
* | Update to ASM 6.0Gravatar Liam Miller-Cushon2017-11-27
| | | | | | | | Change-Id: I3deb9b30136f5e5019dca6413251427c0a85ef62
* | bazel: s/ctx.run()/ctx.actions.run()/Gravatar Googler2017-11-27
| | | | | | | | | | | | | | I can't find whether ctx.run() actually exists. https://docs.bazel.build/versions/master/skylark/lib/ctx.html implies it doesn't. RELNOTES: None. PiperOrigin-RevId: 177005229
* | Migrate some Skylark tests outside of Blaze.Gravatar laurentlb2017-11-27
| | | | | | | | | | RELNOTES: None. PiperOrigin-RevId: 177004853
* | Release 0.8.0 (2017-11-27)Gravatar Bazel Release System2017-11-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Baseline: cff0dc94f6a8e16492adf54c88d0b26abe903d4c Cherry picks: + 8a49b156c4edf710e3e1e0acfde5a8d27cc3a086: Fix ImportError on tools.android for junction_lib + 275ae45b1228bdd0f912c4fbd634b29ba4180383: Automated rollback of commit 4869c4e17d5b1410070a1570f3244148d8f97b5d. + d0bf589f2716b3d139c210930371a684c6e158eb: Add a random number to action temp dir + 9738f35abddb7ef7a7ef314b5d2a52a3be1b830a: CcProtoLibrary: Don't add dynamic librarys to filesToBuild on Windows + 0d6ff477099fdf6c8c1c7d4e2104f9184afe0a2b: Automated rollback of commit 0ebb3e54fc890946ae6b3d059ecbd50e4b5ec840. Incompatible changes: - ctx.fragments.apple.{xcode_version,ios_minimum_os} is not supported anymore. The same information is accessible through the target @bazel_tools//tools/osx:current_xcode_config: point an implicit attribute to it (i.e. attr.label(default=Label("@bazel_tools//tools/osx:current_xcode_co nfig")) then use ctx.attr._xcode_config[apple_common].XcodeVersionConfig]. - ctx.fragments.apple.minimum_os_for_platform_type is not supported anymore. The same information is accessible through the target @bazel_tools//tools/osx:current_xcode_config: point an implicit attribute to it (i.e. attr.label(default=Label("@bazel_tools//tools/osx:current_xcode_co nfig")) then use ctx.attr._xcode_config[apple_common].XcodeVersionConfig].minimum_o s_for_platform_type . - ctx.fragments.apple.sdk_version_for_platform is not supported anymore. The same information is accessible through the target @bazel_tools//tools/osx:current_xcode_config: point an implicit attribute to it (i.e. attr.label(default=Label("@bazel_tools//tools/osx:current_xcode_co nfig")) then use ctx.attr._xcode_config[apple_common].XcodeVersionConfig].sdk_versi on_for_platform . - --javabase=<absolute path> and --host_javabase=<absolute path> are not supported anymore. If you need this functionality java_runtime_suite(name="suite", default=":runtime") java_runtime(name="runtime", java_home=<path to the JDK>) is an alternative. - The flag --incompatible_descriptive_string_representations is no longer available, old style string representations of objects are not supported anymore. - The flag --incompatible_disallow_set_constructor is no longer available, the deprecated `set` constructor is not available anymore. - += on lists now mutates them. `list1 += list2` is now equivalent to `list1.extend(list2)` and not equivalent to `list1 = list1 + list2` anymore. - the target_apple_env and apple_host_system_env methods on ctx.fragments.apple are not supported anymore. The same information is accessible through apple_common.target_apple_env and apple_common.apple_host_system_env . They need the Xcode configuration as an argument, which can be obtained by declaring an implicit dependency on it (i.e. attr.label(default=Label("@bazel_tools//tools/osx:current_xcode_co nfig")) and then calling e.g. apple_common.apple_host_system_env(ctx.attr._xcode_config[apple_co mmon.XcodeVersionConfig]). - C++ toolchain identifiers are not in the name of the output directory anymore. - Selecting on "xcode_version" and "{ios,tvos,macos,watchos}_sdk_version" is not supported anymore. What was config_setting(values={"$FOO_version": $VALUE}) is now config_setting(flag_values={"@bazel_tools//tools/osx:$FOO_version_ flag": $VALUE}). - Selecting on "xcode_version" and "{ios,tvos,macos,watchos}_sdk_version" is not supported anymore. What was config_setting(values={"$FOO_version": $VALUE}) is now config_setting(flag_values={"@bazel_tools//tools/osx:$FOO_version_ flag": $VALUE}). - The flag --incompatible_disallow_set_constructor is no longer available, the deprecated `set` constructor is not available anymore. - Selecting on "xcode_version" and "{ios,tvos,macos,watchos}_sdk_version" is not supported anymore. What was config_setting(values={"$FOO_version": $VALUE}) is now config_setting(flag_values={"@bazel_tools//tools/osx:$FOO_versi... New features: - runfiles, sh: Shell scripts may now depend on //src/tools/runfiles:runfiles_sh_lib and source runfiles.sh. The script defines the `rlocation` function which returns runfile paths on every platform. - In addition to $(location), Bazel now also supports $(rootpath) to obtain the root-relative path (i.e., for runfiles locations), and $(execpath) to obtain the exec path (i.e., for build-time locations) Important changes: - android_binary now supports custom debug keys via the debug_key attribute. - Updated Android proguard to 5.3.3. It now works with android-24+. - --experimental_use_parallel_android_resource_processing and --experimental_android_use_nocompress_extensions_on_apk are removed. These features are fully rolled out. - Fixes #2574 - Fixes #3834 - Enable experimental UI by default. - . RELNOTES: None. RELNOTES: No. - Add memory profiler. - [Bazel] {java,cc}_proto_library now look for dependencies in @com_google_protobuf, instead of in @com_google_protobuf_$LANG - Improved merge.sh script in cookbook. - Fixing regression to --experimental_remote_spawn_cache - Support for linker scripts in NativeDepsHelper (e.g., android_binary) - Skylark semantics flags now affect WORKSPACE files and repository rules. - ctx.outputs.executable is deprecated. Use DefaultInfo(executable = ...) instead. - Update "mirror.bazel.build" urls to use https. - Improve --config logging when --announce_rc is present. - Document interaction between test_suite and target exclusions - Replace version numbers for Bazel installers with "<version>" (because this will change often) - Published command lines should have improved lists of effective options. - --incremental_dexing_binary_types has been removed. All builds are supported by incremental dexing (modulo proguard and some blacklisted dx flags). - Document --host_javabase, --host_java_toolchain
* | Shape sharing for Skylark providers.Gravatar Benjamin Peterson2017-11-27
| | | | | | | | | | | | | | | | | | | | Add CompactSkylarkInfo, which stores its values as an array instead of a map. The space savings will probably not be dramatic because providers usually have a limited amount of keys. But, there are a lot of them! Change-Id: Idd452a5e3982f773b1c5202c73f3d7031ec022c6 PiperOrigin-RevId: 176995376
* | Use more precise categories for missing docstring.Gravatar laurentlb2017-11-27
| | | | | | | | | | | | | | Split missing-docstring into missing-module-docstring and missing-function-docstring. RELNOTES: None. PiperOrigin-RevId: 176993716
* | Add Linter & Skylark spec to the website menuGravatar laurentlb2017-11-27
| | | | | | | | | | RELNOTES: None. PiperOrigin-RevId: 176993543
* | Automatic code cleanup.Gravatar cushon2017-11-27
| | | | | | | | PiperOrigin-RevId: 176987812
* | Improve error message for 'missing-return-value' check.Gravatar laurentlb2017-11-25
| | | | | | | | | | RELNOTES: None. PiperOrigin-RevId: 176899549
* | py_proto_library implicit dependency update.Gravatar Googler2017-11-24
| | | | | | | | | | RELNOTES: None. PiperOrigin-RevId: 176877525
* | Add six to deps of has_services=1 py_proto_librarys.Gravatar Googler2017-11-24
| | | | | | | | | | | | RELNOTES: Add six to deps of has_services=1 py_proto_librarys. PiperOrigin-RevId: 176873598
* | Remove useless abstractions in C++ rules after internal cleanupGravatar hlopko2017-11-24
| | | | | | | | | | RELNOTES: PiperOrigin-RevId: 176844836
* | Create the output source jar in java_common.compileGravatar elenairina2017-11-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and expose transitive source jars to Skylark. Slightly refactor java classes to take in specific host javabase inputs and host java executable for creating the source jar, instead of always relying on fetching them from native java rules specific attributes. Creating the output source jar in java_common.compile makes the behavior more similar to java_library. Exposing the transitive_source_jars to Skylark helps with the Skylark migration from the old 'java' provider to JavaInfo. Progress on #2614. RELNOTES: transitive_source_jars is now exposed on JavaInfo. PiperOrigin-RevId: 176844750
* | Add //tools/jdk:current_java_runtime / tools/jdk:current_host_java_runtime ↵Gravatar lberki2017-11-24
| | | | | | | | | | | | | | | | | | | | | | to rules that use the $(JAVA) or the $(JAVABASE) Make variable. This is necessary because a future Blaze version will require this for rules that use said Make variables. This incompatible change can be tested today by adding the --noexperimental_enable_jvm_configuration_make_variables command line option to Blaze. This change is part of a large-scale change ([] RELNOTES: None. PiperOrigin-RevId: 176834987
* | Update depset documentation to the new depset API.Gravatar Dmitry Lomov2017-11-24
| | | | | | | | | | Change-Id: I23754fa72d8f1fbd54fb37df470bc9ccaf0a2849 PiperOrigin-RevId: 176831430
* | Remove usages of $singlejar in Java rules.Gravatar elenairina2017-11-24
| | | | | | | | | | | | The "$singlejar" attribute was removed in unknown commit. PiperOrigin-RevId: 176826579
| * The surrounding quotes actually unquote this. Remove or escape them.Gravatar Androbin2017-11-23
| |
| * Argument mixes string and array. Use * or separate argument.Gravatar Androbin2017-11-23
| |
| * Quote the grep pattern so the shell won't interpret it.Gravatar Androbin2017-11-23
| |
| * Use "${var:?}" to ensure this never expands to /* .Gravatar Androbin2017-11-23
| |
* | Add Skylark specification.Gravatar laurentlb2017-11-23
|/ | | | | | | | | | | | This specification is based on Alan Donovan's document: https://github.com/google/skylark/blob/master/doc/spec.md It removes implementation-specific changes and extensions. It matches better the Java implementation, and is therefore more useful for Bazel users. It may also be used by other build systems that intend to be compatible with Bazel files. RELNOTES: None. PiperOrigin-RevId: 176783658
* Add regression test for breakage caused by ↵Gravatar philwo2017-11-23
| | | | | | https://github.com/bazelbuild/bazel/commit/0ebb3e54fc890946ae6b3d059ecbd50e4b5ec840. PiperOrigin-RevId: 176774887
* Remove uses of ar_flag and uses_action_config_for_arGravatar hlopko2017-11-23
| | | | | | | Bazel is not reading its value anyway. RELNOTES: None PiperOrigin-RevId: 176768851
* Fix typos in java_toolchain documentation.Gravatar eaftan2017-11-23
| | | | PiperOrigin-RevId: 176759562
* Use valid name for local_repository example in external project docsGravatar Akira Baruah2017-11-23
| | | | | | | | Addresses #4018 Closes #4020. PiperOrigin-RevId: 176750087
* Enable aapt2 for robolectric when available.Gravatar corysmith2017-11-22
| | | | | RELNOTES: None PiperOrigin-RevId: 176700595
* Move CppConfiguration's treatment of pic, --start-lib/--end-lib, and fission toGravatar cpeyser2017-11-22
| | | | | | | | | | | CppHelper. In CppHelper, CcToolchainProvider and CppConfiguration are used sepereately, allowing toolchain information to be removed from CppConfiguration. This is necessary to introduce hermetic toolchains, which require that toolchain information be seperated from the configuration, into the c++ rules. PiperOrigin-RevId: 176694160
* Put more information in failure message of occasionally flaky test, and ↵Gravatar janakr2017-11-22
| | | | | | deduplicate code. PiperOrigin-RevId: 176686795
* Don't propagate resources when neverlink is specified and manifest is notGravatar Googler2017-11-22
| | | | | | | | | We already handle this properly in the normal case. However, when no attributes from the new implementation of resource processing are specified, we fall back to the old version, which didn't handle this. RELNOTES: none PiperOrigin-RevId: 176672081
* Fix canonical option list for options that implicitly require options with ↵Gravatar ccalvarin2017-11-22
| | | | | | | | | allowMultiple=true Was filtering for the implicit options in SingleOptionValue, but forgot the check in RepeatableOptionValue. This is now fixed. RELNOTES: None. PiperOrigin-RevId: 176669853
* Fix typo in `user-manual.html`Gravatar timm-gs2017-11-22
| | | | | | | | And adjust macOS name Closes #4019. PiperOrigin-RevId: 176665076
* Add platform data into to the ToolchainContext unconditionally.Gravatar John Cater2017-11-22
| | | | | | | Part of #4128. Change-Id: I1e043e7290912de5b246dbb8748cb2ad865ce38c PiperOrigin-RevId: 176664440
* Move CppConfiguration#isLLVMcompiler, #isLLVMOptimizedFdo, #isLipoOptimization,Gravatar cpeyser2017-11-22
| | | | | | | | | and #getDynamicMode to CcToolchainProvider and CppHelper. Moving toolchain info out of CppConfiguration is required to use platform-based toolchain resolution in the c++ rules. PiperOrigin-RevId: 176662686
* Automated rollback of commit 0ebb3e54fc890946ae6b3d059ecbd50e4b5ec840.Gravatar dmarting2017-11-22
| | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Cause rare case of test hanging. To cherry-pick for #3772 *** Original change description *** Attempting to fix an occasionally missing stdout from test.xml. In hello-world_test, when executed inside a docker container, for about 2% of the runs the test.xml has an empty CDATA, instead of the expected "Hello, world!". I'm not sure still what exactly was the bug, but in any case this change simplifies the test execution code line, so if this doesn't fix it, at least further debugging will be easier. I ran the test in a loop 1360 times, and the error did not reproduce once, which hints to... *** PiperOrigin-RevId: 176662654
* Prevent blaze from crashing on invalid resource locations.Gravatar corysmith2017-11-22
| | | | | RELNOTES: None PiperOrigin-RevId: 176659616
* Add proper test coverage for filtering resource depsGravatar Googler2017-11-22
| | | | | RELNOTES: none PiperOrigin-RevId: 176659117
* Check if win_def_file attribute exists before getting its valueGravatar Yun Peng2017-11-22
| | | | | | | | | | | Because CcProtoAspect.java also uses CcLibraryHelper.java to generate linking action, but cc_proto_library doesn't have win_def_file attribute. Fix https://github.com/bazelbuild/bazel/issues/4126 Change-Id: I1b819c926c8025a49fea756bcaeb237824cb098e PiperOrigin-RevId: 176653922
* Fix resource filteringGravatar Googler2017-11-22
| | | | | | | | The ResourceDependencies constructor takes in two NestedSet<Artifact> objects, and I was putting them in the wrong order. RELNOTES: none PiperOrigin-RevId: 176648259
* Clarify `srcs` description to make it obvious what file types are accepted.Gravatar spomorski2017-11-22
| | | | PiperOrigin-RevId: 176647103
* Windows CROSSTOOL: Define DEBUG in fastbuild and dbg modeGravatar pcloudy2017-11-22
| | | | | RELNOTES: None PiperOrigin-RevId: 176646230
* Move override check to the createAndOverrideRule functionGravatar Damien Martin-Guillerez2017-11-22
| | | | | | | | | So we actually test for override also from skylark repositories. Fixes #3908. Change-Id: I7650a17834a6915a73c89df46989f72aa2f56920 PiperOrigin-RevId: 176645218
* Improve error message when missing default_toolchain in CROSSTOOLGravatar hlopko2017-11-22
| | | | | RELNOTES: None. PiperOrigin-RevId: 176643685