aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Avoid list copy in BuildingState.getNextDirtyDirectDepsGravatar Mark Schaller2015-12-09
| | | | | | | | | Also, in GroupedList, short-circuit expensive group equality check with a reference check, saving time and garbage when groups are the same object. -- MOS_MIGRATED_REVID=109795332
* Open source IncrementalLoadingTest.Gravatar Ulf Adams2015-12-09
| | | | | -- MOS_MIGRATED_REVID=109795225
* Add a --deep_execroot startup option that puts the execroot under ↵Gravatar Lukacs Berki2015-12-09
| | | | | | | | | $OUTPUT_BASE/execroot/<workspace name> instead of $OUTPUT_BASE/<workspace name>. This makes it possible to run Bazel in directories whose name clashes with one of the pre-existing files in the output base. Note that this option is turned off by default for now. -- MOS_MIGRATED_REVID=109791053
* Don't symlink {examples/tools}/BUILD in the base_workspace.Gravatar Lukacs Berki2015-12-09
| | | | | | | This is useful because they have rules that depend on rules in the subpackages of examples and tools thus negating the benefit of not descending into them when running "bazel build //...". -- MOS_MIGRATED_REVID=109774976
* Adding Guice to Bazel's third_partyGravatar Damien Martin-Guillerez2015-12-09
| | | | | -- MOS_MIGRATED_REVID=109770581
* Refactor external repository support significantly to solve a number of issues.Gravatar Lukacs Berki2015-12-09
| | | | | | | | | | | | | | | In particular: - Separate the implementation of maven_server into a RepositoryFunction and one that creates the MavenServerValue (ideally, maven_server wouldn't exist but we'll have to make to for the time being) - Refactor the logic of determining whether an external repository needs to be re-fetched to RepositoryDelegatorFunction - Make RepositoryFunctions not be SkyFunctions anymore (they are called from RepositoryDelegatorFunction, though, who *is* a SkyFunction) - Add a Skyframe dirtiness checker that makes --nofetch RepositoryValues not be cached - Add a bunch of test cases and javadoc There is only one wart that I know of that remains: changes to BUILD files of new_* repository rules that weren't refetched when their RepositoryValue was initiall created on server restart won't take effect. This is because we don't add those BUILD files to the created RepositoryValue. This will fix itself once the ExternalFilesHelper refactoring is submitted. -- MOS_MIGRATED_REVID=109768345
* Better error for invalid --ios_sdk_version.Gravatar Googler2015-12-08
| | | | | -- MOS_MIGRATED_REVID=109722614
* Improve scalac: use ijar and download scalacGravatar oscar2015-12-08
| | | | | | | -- Change-Id: I22fb6cc5a37f5c6c216dc3abbc915d1be3fd5e6b Reviewed-on: https://bazel-review.googlesource.com/#/c/2410/ MOS_MIGRATED_REVID=109717610
* Plmerge receives arguments by a protobuf, introduces variable substitutions ↵Gravatar Googler2015-12-08
| | | | | | | | | to plmerge. As of this change plmerge can consume either a protobuf or command line arguments. Once bazel uses plmerge strictly with protobufs, the command line arguments will be deprecated. -- MOS_MIGRATED_REVID=109716003
* Find frameworks in System/ instead of in Developer/ for ios sdks 9.0 and laterGravatar Chris Parsons2015-12-08
| | | | | -- MOS_MIGRATED_REVID=109715685
* Fail build gracefully if an action discovers unexpected inputs.Gravatar Janak Ramakrishnan2015-12-08
| | | | | | | | | | | | | | | | | | | Blaze discovers inputs for some actions when running with some strategies. Those actions should not discover additional inputs when they run, regardless of the strategy they end up using. There are now no known legitimate cases of such additional input discovery, so we should reinstate this check and find new ones :) We also change the failure mode to be a normal error rather than a crash. This error does indicate a tooling issue, and a small chance of incorrect builds, but it doesn't create such an inconsistent state that a crash is warranted. -- Change-Id: I5d498d2fc1c5e23bfb5d77971f866c2027cbf03a Reviewed-on: https://bazel-review.googlesource.com/#/c/2500/3 MOS_MIGRATED_REVID=109703508
* Follow-up on f9fdc8dfced8b2b14561720623126a91e04b22cb -- reinstate ↵Gravatar Janak Ramakrishnan2015-12-08
| | | | | | | short-circuit check when all package paths have good diff information and no external files have been seen. -- MOS_MIGRATED_REVID=109703164
* Don't print "Building complete" (and save the action caches) if we're about ↵Gravatar Janak Ramakrishnan2015-12-08
| | | | | | | to crash or exit abruptly. It just confuses users and could potentially cause other problems. -- MOS_MIGRATED_REVID=109702171
* Fix skylark aspect issues.Gravatar Dmitry Lomov2015-12-08
| | | | | -- MOS_MIGRATED_REVID=109690378
* Rollback of commit ca1b21ac6d8a58041db822725b42de151b163dee.Gravatar Ulf Adams2015-12-08
| | | | | | | | | | | | | | | | | *** Reason for rollback *** Broke some alipo builds. I had to leave in the change to TransitiveTargetFunctionTest, which is relied upon by follow-up CLs. *** Original change description *** Pre-trim build options for all remaining calls to ConfigurationFragment.key. Move the trimming logic into key() itself to: a) eliminate code redundancy b) guarantee all future calls to key() also do this. -- MOS_MIGRATED_REVID=109683849
* Simplify & speed-up the check whether sandbox related shell tests can run.Gravatar Philipp Wollermann2015-12-08
| | | | | -- MOS_MIGRATED_REVID=109683354
* Added Guice 4.0 binaries to third_party.Gravatar Damien Martin-Guillerez2015-12-08
|
* Make "//..." do not find packages in the base workspace.Gravatar Lukacs Berki2015-12-08
| | | | | | | | | This is a temporary hack until the base workspace goes away. Fixes #652. -- MOS_MIGRATED_REVID=109677574
* Don't treat external files as immutableGravatar Kristina Chodorow2015-12-08
| | | | | | | | | Fixes #352. RELNOTES: Files in external repositories are now treated as mutable, which will make the correctness guarantees of using external repositories stronger (existent), but may cause performance penalties. -- MOS_MIGRATED_REVID=109676408
* Open source CompileOneDependencyTransformerTest.Gravatar Ulf Adams2015-12-08
| | | | | -- MOS_MIGRATED_REVID=109673753
* Fix sandbox .params files being left aroundGravatar Brian Silverman2015-12-08
| | | | | | | | | They accumulate indefinitely and take up space. -- Change-Id: I74c7ffd795b21793f8654e0e30785e1b8ba99ca4 Reviewed-on: https://bazel-review.googlesource.com/#/c/2510/ MOS_MIGRATED_REVID=109656651
* Presize AttributeSerializer collectionsGravatar Michajlo Matijkiw2015-12-08
| | | | | -- MOS_MIGRATED_REVID=109649366
* Change xcode_version flag to build category so it shows up in blaze ↵Gravatar Dmitry Shevchenko2015-12-07
| | | | | | | auto-complete flags -- MOS_MIGRATED_REVID=109595089
* Refactor android_tools_defaults_jarGravatar Liam Miller-Cushon2015-12-07
| | | | | -- MOS_MIGRATED_REVID=109587887
* Open source the TargetPatternEvaluator tests.Gravatar Ulf Adams2015-12-07
| | | | | -- MOS_MIGRATED_REVID=109581214
* Avoid autoboxing on potential hot paths in LineNumberTableGravatar Michajlo Matijkiw2015-12-07
| | | | | | | | We wind up hitting this code path each time we call a user defined function to calculate a pretty string for profiling purposes. -- MOS_MIGRATED_REVID=109580385
* Cleanup: use int instead of Integer in the RecursiveFilesystemTraversal classes.Gravatar Laszlo Csomor2015-12-07
| | | | | -- MOS_MIGRATED_REVID=109579490
* RecursiveFilesystemTraversalFunction now tracks changes in symlinked directory.Gravatar Laszlo Csomor2015-12-07
| | | | | | | | | | | | We achieve this by computing the directory symlink's metadata hash, which the Google-internal Fileset rule writes in the fileset_manifest file, from the hashes of all files under it. This adds complexity but is necessary, because the symlink's FileStateValue remains the same even if the directory's contents change, so the FileStateValue alone is inadequate to compute the metadata for the fileset_manifest. -- MOS_MIGRATED_REVID=109577723
* Open-sourced tests from lib/profiler.Gravatar Florian Weikert2015-12-07
| | | | | -- MOS_MIGRATED_REVID=109577273
* Fast-path sky-query environment in the case where we have no dependency ↵Gravatar Eric Fellheimer2015-12-07
| | | | | | | | | filter on edge types (eg, implicit deps). In this case we can avoid doing an iteration over a potential reverse dependency's dependencies, since all edges are assumed to be valid. -- MOS_MIGRATED_REVID=109575545
* Tweak BE page footer.Gravatar David Chen2015-12-07
| | | | | -- MOS_MIGRATED_REVID=109571074
* Remove the unchecked exceptions RuleConfigurationException, InvalidAssetPath ↵Gravatar Lukacs Berki2015-12-07
| | | | | | | | | | | and InvalidResourcePath. Mainly to make the error handling in the Android code more similar to the rest of the code. There are a few more if statements, but I think the fact that AndroidIdeInfoProvider#addResourceSource didn't catch this unchecked exception vindicates this decision. DIFFBASE=108487079 -- MOS_MIGRATED_REVID=109566747
* Add a ~ between the version candidate and the release candidate qualifier ↵Gravatar Damien Martin-Guillerez2015-12-07
| | | | | | | | | for debian package Fixes #687 -- MOS_MIGRATED_REVID=109565904
* Refactor: ResolvedFile.getMetadata is now .getMetadataHash.Gravatar Laszlo Csomor2015-12-07
| | | | | | | | | | This is a subtle change that'll go a long way: there's a bug in the handling of directory symlinks (changes in the link target are not picked up) which I'll fix by combining the metadata hashes of all items in the directory, and use that as the directory symlink's metadata hash. -- MOS_MIGRATED_REVID=109564943
* RecursiveFilesystemTraversalFunction: introduce ResolvedFileFactoryForTesting.Gravatar Laszlo Csomor2015-12-07
| | | | | | | | Using this class it's easier to create ResolvedFile instances for tests that don't care about metadata eqality. -- MOS_MIGRATED_REVID=109562578
* Open-source runfiles_test integration testGravatar Damien Martin-Guillerez2015-12-07
| | | | | -- MOS_MIGRATED_REVID=109561975
* Migrated base test classes to JUnit 4 and deleted their temporary *ForJunit4 ↵Gravatar Florian Weikert2015-12-07
| | | | | | | | | | | | versions: devtools/build/lib/analysis/util/AnalysisTestCase.java devtools/build/lib/analysis/util/BuildViewTestCase.java devtools/build/lib/packages/util/PackageLoadingTestCase.java devtools/build/lib/testutil/FoundationTestCase.java -- MOS_MIGRATED_REVID=109560679
* Refactor ResolvedFile implementors: remove unnecessary Optional<> wrappers.Gravatar Laszlo Csomor2015-12-07
| | | | | | | Also remove unnecessary `type` members; they are constant. -- MOS_MIGRATED_REVID=109560348
* Upstream some basic changes from dslomov windows branch.Gravatar Dmitry Lomov2015-12-07
| | | | | | | | | The code changes are mostly due to dslomov, not me, although I refactored the Jvm class a bit based on his changes. I set dslomov as the author. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/688 MOS_MIGRATED_REVID=109536553
* Fix android_library resources handlingGravatar Googler2015-12-07
| | | | | | | RELNOTES: Fix resource handling for exported android_library rules -- MOS_MIGRATED_REVID=109532253
* Remove deleted WORKSPACE.go-toolchain from srcs.Gravatar David Chen2015-12-07
| | | | | | | TESTED: bazel test //src/test/... -- MOS_MIGRATED_REVID=109481372
* Migrate ProtoSourcesProvider to @AutoValue.Gravatar Carmi Grushko2015-12-07
| | | | | | | As a prerequisite, AnalysisUtils.checkProvider now accepts non-final classes, as long as they have a private/package-private parameterless constructor, which offers similar protection - the provider can't be subclassed outside of its package. -- MOS_MIGRATED_REVID=109447292
* Allow @AutoValue-ed classes as provider keys. Also, reject the generated ↵Gravatar Carmi Grushko2015-12-07
| | | | | | | AutoValue_* classes from being provider keys. -- MOS_MIGRATED_REVID=109440137
* Release 0.1.2 (2015-11-20)Gravatar Bazel Release System2015-12-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Baseline: ee0ade3 + 1e66ccd: RELNOTES: Symlink dirents of directories containing a file named "DONT_FOLLOW_SYMLINKS_WHEN_TRAVERSING_THIS_DIRECTORY_VIA _A_RECURSIVE_TARGET_PATTERN" will *not* be traversed for transitive target patterns. The motivation here is to allow directories that intentionally contain wonky symlinks (e.g. foo/bar -> foo) to opt out of being consumed by Blaze. For example, given + f5773fc: Set the ijar MAX_BUFFER_SIZE to 256 MB New features: - java_library now supports the proguard_specs attribute for passing Proguard configuration up to Android (not Java) binaries. - http_file can specify "executable" to make the downloaded file runnable. - Debian and tar packaging is now supported (see tools/build_defs/pkg/README.md). - cpxx_builtin_include_directory specifications allow more flexibility. - accept %crosstool_top% in cxx_builtin_include_directory - android_binary now supports proguard_apply_mapping to re-use a previously generated proguard mapping. Important changes: - remove webstatusserver (--use_webstatusserver). - Add support for objc textual headers, which will not be compiled when modules are enabled. - actoolzip, momczip and swiftstdlibtoolzip have all been made into bash scripts and have been renamed to actoolwrapper, momcwrapper and swiftstdlibtoolwrapper respectively. The old versions will be deleted in a later change. - [rust] Add rust_bench_test and rust_doc_test rules and improve usability of rust_test tule. - Java rules now support a resource_strip_prefix attribute that allows the removal of path prefixes from Java resources. - [docker_build] incremental loading is default now. Specify explicitly //package:target.tar (with the .tar extension) to obtain the full image. - --ios_signing_cert_name allows specifying a cert for iOS app signing - Go rules for Bazel. - [jsonnet] Update to Jsonnet 0.8.1. - [jsonnet] Add vars and code_vars attributes to jsonnet_to_json to allow passing external variables to Jsonnet via --var and --code_var. - Adds --override_workspace_root blaze flag to hand-set workspace_root and mainGroup in xcodeproj. - Allow dots in package names. - When used as a forwarding rule (i.e., has no sources), android_library will also forward any exported_plugins in its dependencies. - Add support for Windows-created zip files with non-posix permissions. - [jsonnet] Add jsonnet_to_json_test rule for testing Jsonnet code. - C++ compile actions run in a sandbox now on systems that support sandboxed execution. - The names of the clang compilers in the Android NDK crosstool no longer reference gcc. - 420 dpi is now a valid density for andoid_binary.densities. - Bazel does strict validation of include files now to ensure correct incremental builds. If you see compilation errors when building C++ code, please make sure that you explicitly declare all header files in the srcs or hdrs attribute of your cc_* targets and that your cc_* targets have correct "deps" on cc_library's that they use. - [jsonnet] Fix jsonnet_to_json rule to read code_vars from code_vars instead of vars. - Tests, genrules, and Skylark actions without the "requires-network" tag will no longer be able to access the network. - C++ libraries no longer need includes = ["."] (or similar copts) to include paths relative to a remote repository's root. - Support exports attribute for android_library - Symlink dirents of directories containing a file named "DONT_FOLLOW_SYMLINKS_WHEN_TRAVERSING_THIS_DIRECTORY_VIA_A_RECURSI VE_TARGET_PATTERN" will *not* be traversed for transitive target patterns. The motivation here is to allow directories that intentionally contain wonky symlinks (e.g. foo/bar -> foo) to opt out of being consumed by Blaze.
* Fix a bug in which the main process of j2objc wrapper blocks indefinitely if ↵Gravatar Rumou Duan2015-12-04
| | | | | | | spawned threads fail. -- MOS_MIGRATED_REVID=109423785
* Refactoring: get rid of RecursiveFilesystemTraversalValue.ResolvedFileUtilsGravatar Laszlo Csomor2015-12-04
| | | | | -- MOS_MIGRATED_REVID=109420721
* docker_build: Properly handle / as data_pathGravatar Kamal Marhubi2015-12-04
| | | | | | | | | | | | | | | | | | | | The handling in _compute_data_path would incorrectly result in an empty strip_prefix being passed to _dest_path. The outcome was all files would end up at the top of directory, instead of nested according to the repository structure. This change brings the behavior in line with the documentation, which states: > This path can be absolute from the workspace root if starting with a > `/` or relative to the rule's directory. Fixes https://github.com/bazelbuild/bazel/issues/677 -- Change-Id: Ifdab97ed0e851cf6cabc7bd3206343766861b725 Reviewed-on: https://bazel-review.googlesource.com/#/c/2480 MOS_MIGRATED_REVID=109418486
* TestSuiteBuilder should include TautologyTest only in empty test suites.Gravatar Florian Weikert2015-12-04
| | | | | | | Previously, TautologyTest was added to all test suites in order to prevent empty one. However, this was done regardless of whether the suite was actually empty or not. -- MOS_MIGRATED_REVID=109413743
* Rename AbstractDistributorDriverTest to UserUtilsTestGravatar Michajlo Matijkiw2015-12-04
| | | | | | | Old name is vestigial, new home makes more sense. -- MOS_MIGRATED_REVID=109410381
* Use load() to add external repositories for Skylark rules.Gravatar David Chen2015-12-04
| | | | | -- MOS_MIGRATED_REVID=109405753