aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Little refactorings on resource management stuff:Gravatar Philipp Wollermann2016-02-28
| | | | | | | | | | - Remove unneeded abstract override AbstractAction#getResourceConsumption() - Remove comments justifying returning ResourceSet.ZERO from getResourceConsumption() - instead document it once on the base method. - Replace ResourceSet.create(0, 0, 0) with ResourceSet.ZERO. - Make sure no one ever returns null from getResourceConsumption() and then simplify the code in SkyframeActionExecutor to not check for it. -- MOS_MIGRATED_REVID=115739250
* Fix references to @bazel_tools// repository in Go rules.Gravatar David Chen2016-02-28
| | | | | | | Issue #976 -- MOS_MIGRATED_REVID=115720030
* Stop using preprocessed .aidl files for types in the same android_library.Gravatar Michael Staib2016-02-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes very little sense, because we only do this when compiling them within a rule. The preprocessed files are not shipped to other rules, meaning we treat things differently depending on the dependency structure. And, worst of all, this can lead to a bug in the aidl compiler, which causes the preprocessed definition to take precedence over the input file, which causes certain modifiers to be stripped away. Also, Gradle doesn't do it, and that's proof enough that this is no longer the way to go, if ever it was. Unfortunately, this causes a problem: the preprocessing had an effect, in that all preprocessed types are available without the use of imports. This means that .aidl files which were previously legal before this change may now be broken, if they relied on this behavior. But, those .aidl files are actually not legal according to the .aidl specification. Unfortunate, but the right thing to do. This CL also updates the idl documentation. Which, let's face it, could probably have used some improvement. RELNOTES[INC]: .aidl files correctly require import statements for types defined in the same package and the same android_library. -- MOS_MIGRATED_REVID=115718918
* Add Ascend.io and XIOSim to our user list.Gravatar Damien Martin-Guillerez2016-02-28
| | | | | -- MOS_MIGRATED_REVID=115710924
* Check that `python` file is a regular file and is executable.Gravatar David Chen2016-02-28
| | | | | | | | | | | Currently, the Python launcher does not ensure that the `python` file it finds in a search directory is an actual executable file. As a result, if it finds a directory called `python`, it thinks that it has found the `python` binary. Fixes #981 -- MOS_MIGRATED_REVID=115710677
* Let ActionContextConsumer#getActionContexts() return a Multimap instead of a ↵Gravatar Philipp Wollermann2016-02-28
| | | | | | | | | | | Map. This makes it possible to request multiple implementations of the same ActionContext to be available via Executor#getContext(). Currently, specialized SpawnActionContexts like the sandbox or the worker strategy that might have to do a fallback each instantiate their own private copy of e.g. the StandaloneSpawnStrategy. With this change, they can instead get a global instance from the Executor. -- MOS_MIGRATED_REVID=115705811
* Global cleanup change.Gravatar Googler2016-02-28
| | | | | -- MOS_MIGRATED_REVID=115695111
* Improve the error message when the ParallelEvaluator is unable to create a ↵Gravatar Luis Fernando Pino Duque2016-02-28
| | | | | | | SkyFunction -- MOS_MIGRATED_REVID=115671161
* Rename SpawnActionContext#isRemotable() to more appropriate ↵Gravatar Philipp Wollermann2016-02-28
| | | | | | | willExecuteRemotely(). Remove unused parameter "mnemonic". -- MOS_MIGRATED_REVID=115666410
* Pass the source path -> Artifact mapping into FdoSupport from a provider ↵Gravatar Lukacs Berki2016-02-28
| | | | | | | | | instead of special-casing it. This removes the need to deserialize artifacts in FdoSupport, which in turn removes the need to support artifact deserialization at all, which makes our lives simpler and Thoreauvian programming is good. -- MOS_MIGRATED_REVID=115660698
* Skylark aspects should always output to bin directory.Gravatar Dmitry Lomov2016-02-28
| | | | | -- MOS_MIGRATED_REVID=115659763
* experimental UI: only refresh progress bar if neededGravatar Klaus Aehlig2016-02-28
| | | | | | | | | | | | | The handle(Event event) method of the ExperimentalEventHandler does not produce UI changes for every event observed. Still, it used to clear and re-add the progress bar unconditionally. Move those operations into the individual cases that do produce output, so that in the ignored events nothing is sent to the terminal. -- Change-Id: I31fd8df0ee2feeb53b6686fe7350848be2a53b6a Reviewed-on: https://bazel-review.googlesource.com/#/c/3025 MOS_MIGRATED_REVID=115656142
* Adds an executable argument to repository_ctx.file and repository_ctx.templateGravatar Damien Martin-Guillerez2016-02-28
| | | | | | | | | | We sometime want to execute the created file. The executable argument permit to control the executable bit on the created file. Issue #893 -- MOS_MIGRATED_REVID=115653127
* Simplifies AbstractWriteFileAction to pass the ActionExecutionContext ↵Gravatar Alex Humesky2016-02-26
| | | | | | | directly to newDeterministicWriter. -- MOS_MIGRATED_REVID=115626619
* Allow outputting the progress of Bazel's build.Gravatar Julio Merino2016-02-26
| | | | | | | | | | | | Rename run_silent to run and add a global VERBOSE variable that tunes whether the run function prints its output or not. This is for better debugging possibilities of Bazel's self-build, though compile.sh remains silent as before and only displays the command's output in case of an error. -- MOS_MIGRATED_REVID=115599355
* Remove spaces from ios_test rule that break doc generation.Gravatar Peter Schmitt2016-02-26
| | | | | -- MOS_MIGRATED_REVID=115581742
* Add Watch and TV to list of platforms.Gravatar Dave MacLachlan2016-02-26
| | | | | -- MOS_MIGRATED_REVID=115577068
* Improve handling of exit routines to ensure we respect the exit status.Gravatar Julio Merino2016-02-26
| | | | | | | | | | As part of this, change atexit to receive the name of a function instead of just a chunk of code. This way, we can also control the return value of each individual atexit function and report it to the user, should these routines fail when the program apparently succeeded. -- MOS_MIGRATED_REVID=115575895
* Uses xcodebuild's and xcrun's -version flag in order to generate the variablesGravatar Anastasios Kakalis2016-02-25
| | | | | | | | | needed for the Info.plist. RELNOTES: -- MOS_MIGRATED_REVID=115564028
* Fix broken Bazel build due to missing dependency.Gravatar Philipp Wollermann2016-02-25
| | | | | | | | | | | | | ERROR: /home/ci/workspace/Bazel/JAVA_VERSION/1.8/PLATFORM_NAME/linux-x86_64/src/main/java/com/google/devtools/build/lib/BUILD:404:1: Couldn't build file src/main/java/com/google/devtools/build/lib/libjava-toolchain-parser.jar: Java compilation in rule '//src/main/java/com/google/devtools/build/lib:java-toolchain-parser' failed: namespace-sandbox failed: error executing command /home/ci/.cache/bazel/_bazel_ci/5f3cd5a16c8c04003810da50910b348c/linux-x86_64/_bin/namespace-sandbox ... (remaining 8 argument(s) skipped). src/main/java/com/google/devtools/build/lib/rules/java/JavaToolchainData.java:40: error: [strict] Using type javax.annotation.Nullable from an indirect dependency (TOOL_INFO: "//third_party:jsr305"). See command below ** @Nullable private final Iterable<String> bootclasspath; ^ 1 error ** Please add the following dependencies: //third_party:jsr305 to //src/main/java/com/google/devtools/build/lib:java-toolchain-parser -- MOS_MIGRATED_REVID=115559988
* Update ANDROID_DEFAULT_CROSSTOOL to default to //external:android/crosstool. ↵Gravatar Luis Fernando Pino Duque2016-02-25
| | | | | | | Remove the constant. -- MOS_MIGRATED_REVID=115555161
* Experimental UI: report ERROR/WARNING/INFO as usualGravatar Klaus Aehlig2016-02-25
| | | | | | | | | | | While the eventual goal is to improve the reporting of those events, for the time being, report them as usual, so that the experimental UI is minimally usable for building. -- Change-Id: Ib26deaa70feb3be08d0827dbf1012d38e7d28b1c Reviewed-on: https://bazel-review.googlesource.com/#/c/3017 MOS_MIGRATED_REVID=115551806
* Make process_headers_in_dependencies work for cc_binary und cc_test targets.Gravatar Googler2016-02-25
| | | | | -- MOS_MIGRATED_REVID=115550466
* Fix typoGravatar Dmitry Lomov2016-02-25
| | | | | -- MOS_MIGRATED_REVID=115550407
* Keep track of actions currently runningGravatar Klaus Aehlig2016-02-25
| | | | | | | | | | | | | Subscribe to start and completion events of actions to keep track of which actions are currently running. In the progress bar show up to 3 actions currently running, giving preference to the ones that started the most early. Also keep track of completion of analysis and build. -- Change-Id: I9183a84821abca85e2331baa059e1f636d756caf Reviewed-on: https://bazel-review.googlesource.com/#/c/3016 MOS_MIGRATED_REVID=115549337
* Testing correct invalidation of Skylark Remote RepositoriesGravatar Damien Martin-Guillerez2016-02-25
| | | | | | | | | | | | | | | | | | A Skylark remote repository should be invalidated only when the WORKSPACE file change, or one of its dependency or the Skylark file change. This change include two fixes: - The path of the RepositoryDirectoryValue was incorrect when the directory root is a symlink and the repository is not local (and not refetching). This was never triggered before because the only rule that were symlinking their root were the local one. - Directories were unitialized for the SkylarkRepositoryFunction (was forgotten as part of a refactor when introducing it). -- MOS_MIGRATED_REVID=115547540
* Pass through STDOUT and STDERR eventsGravatar Klaus Aehlig2016-02-25
| | | | | | | | | | | These events explicitly tell out to produce a well-defined message on stdout or stderr. Also in the new UI, honor those requests. -- Change-Id: I4188c6cb3a2e277b5b805b3d4f4c96c2cdc7b51c Reviewed-on: https://bazel-review.googlesource.com/#/c/3015 MOS_MIGRATED_REVID=115546439
* Add a state tracker and show a progress barGravatar Klaus Aehlig2016-02-25
| | | | | | | | | | | Add a state tracking class that is capable of keeping track of the internal state of the computation. Use it to provide a status bar at the lower end of the terminal. -- Change-Id: I39c17a80a238b3bc0d94527652b56a793f580d02 Reviewed-on: https://bazel-review.googlesource.com/#/c/3014 MOS_MIGRATED_REVID=115538418
* Add an interface for append-only access to an AnsiTerminalGravatar Klaus Aehlig2016-02-25
| | | | | | | | | | | | Providing only access to this interface rather than handing out a full AnsiTerminal allows a more controlled access. In particular, it will be easier to track the state the terminal will end up in. -- Change-Id: Ic47b14a045ece2a84113698632a61daf7948c3b4 Reviewed-on: https://bazel-review.googlesource.com/#/c/3013 MOS_MIGRATED_REVID=115533760
* Report the completion of the loading PhaseGravatar Klaus Aehlig2016-02-25
| | | | | | | | | | Once loading is completed, report this fact. Also report the number of targets for later reference. -- Change-Id: Ibffbaa7add9fed48107d8fb320bd2349b1fac503 Reviewed-on: https://bazel-review.googlesource.com/#/c/3012 MOS_MIGRATED_REVID=115533328
* Update the glob documentation to reflect a semantic change made a very long ↵Gravatar Nathan Harmata2016-02-25
| | | | | | | | | | | time ago where glob(['**'], exclude_directories = 0) doesn't match the package's directory. Also add tests for this behavior. Also update Skyframe globbing to have these semantics. Any discrepancy has always been problematic, but now that we have Skyframe-hybrid globbing it's a lot more dangerous and consequential. Alternatives considered: do this the other way around (keep the stale documentation as-is and instead update legacy globbing). This would potentially require changing existing usages from stuff like 'data = glob(["**"], exclude_directories = 0)' to 'data = [x for x in glob(["**"], exclude_directories = 0) where x != '']'. I think this is too messy, so long as there is a valid use-case for globs matching directories in the first place. -- MOS_MIGRATED_REVID=115511504
* Don't report targets as broken when they were actually skipped because of ↵Gravatar Florian Weikert2016-02-25
| | | | | | | no[test_]keep_going. -- MOS_MIGRATED_REVID=115506435
* Expose information about transitive exports.Gravatar Dmitry Lomov2016-02-25
| | | | | | | | | Also implement handling of exports in Skylark aspects and enable remaining tests (except PackageManifest and deprecated non-hermetic stuff). -- MOS_MIGRATED_REVID=115496333
* Problem:Gravatar Googler2016-02-25
| | | | | | | | | | | | | | | The --help option is currently broken when allow residue is false as the --help option cannot be parsed and results in exit(2) after emitting the unhelpful message: Error parsing command line: Unrecognized option: --help Try --help. In this case, --help is never reached, and so cannot be used. Solution: In the proposed code, if any argument is --help, the --help message will be preferred over emitting parsing errors. The process will now exit(0) prior to parsing any other arguments if --help is passed. -- MOS_MIGRATED_REVID=115495600
* Expose Android resources in Skylark API.Gravatar Dmitry Lomov2016-02-25
| | | | | | | | Also expose functionality to calculate resource source directory from Android resource artifact. -- MOS_MIGRATED_REVID=115492705
* Fix load() examples to use build targets instead of file paths.Gravatar Googler2016-02-25
| | | | | -- MOS_MIGRATED_REVID=115492703
* Add syntax for referencing docs in other rule families.Gravatar David Chen2016-02-25
| | | | | | | | | | | | This CL implements a new `${link rule.attribute}` syntax which can be used to reference the documentation of rules and attributes of other rule families. For example, `${link cc_library.deps}` will generate a link to the documentation for the `deps` attribute of the `cc_library` rule. Similarly, this syntax can also be used to reference sections of static documentation, for example `${link common-definitions.label-expansion}`. -- MOS_MIGRATED_REVID=115492361
* Handle http <-> https redirectsGravatar Michajlo Matijkiw2016-02-25
| | | | | | | | | | | Support all 301 and 302 redirect handling in bazel. Only support absolute Location redirects (this is the spec, we can revisit if we find a lot of servers are doing it wrong). Fixes #959. -- MOS_MIGRATED_REVID=115490327
* Add bootclasspath and extdir configuration to java_toolchainGravatar Liam Miller-Cushon2016-02-25
| | | | | | | | Once this is released we can phase out --javac_bootclasspath and --javac_extdir. -- MOS_MIGRATED_REVID=115478455
* Part 1 of 5: Optimize the resource merge process, Introductions.Gravatar Googler2016-02-24
| | | | | | | | | | | | Introduces the AndroidDataSet, a holder for DataResources, that will be the building blocks of the revised merging system. Also introduces a DataResource implementations: * FileDataResource, which represent non-value resources. These do not need to derive the resource symbols they provide. This will replace the current ResourceSet, ResourceMerger, and ResourceMergerWriter with more efficient (e.g. fewer copied files) operations. -- MOS_MIGRATED_REVID=115455426
* Make the Windows tempdir default to something under the CI directory and ↵Gravatar Lukacs Berki2016-02-24
| | | | | | | | | explicitly create it. Turns out, mktemp doesn't like being passed a non-existent directory. -- MOS_MIGRATED_REVID=115454169
* Register the EventHandler with the EventBusGravatar Klaus Aehlig2016-02-24
| | | | | | | -- Change-Id: I68f9f8c897c65b6d51bd21262e25ad6a93ee794f Reviewed-on: https://bazel-review.googlesource.com/#/c/3011 MOS_MIGRATED_REVID=115454025
* Expose to Skylark information about whether a target defines any Android ↵Gravatar Dmitry Lomov2016-02-24
| | | | | | | | | | | | resources. In Java code, it is a shared logic in LocalResourceContainer.definesAndroidResources (that method has a fair number of usages). This CL exposes that information on AndroidIdeInfoProvider and futher on AndroidSkylarkInforProvider. -- MOS_MIGRATED_REVID=115453472
* Support full logging of handled events in the experimental UIGravatar Klaus Aehlig2016-02-24
| | | | | | | | | | | To allow debugging and faster development of the new experimental UI, add an additional option telling the experimental UI to log each event available to the handler. -- Change-Id: Ib14c42d2afa5f52f6c444592274c8eaeeda15a81 Reviewed-on: https://bazel-review.googlesource.com/#/c/3010/2 MOS_MIGRATED_REVID=115453031
* Change the path of gcc for Windows to c:\tools\msys64 , because that's where ↵Gravatar Lukacs Berki2016-02-24
| | | | | | | | | Chocolatey installs msys2. This is only a temporary hack to get our continuous build up and running, because we can't assume that everyone will install their C++ compiler there. But then again, msys2 is not a very useful target for Windows, so maybe we should fix that first. -- MOS_MIGRATED_REVID=115449817
* Add zlib-devel to the set of pacman packages we ask people to install on ↵Gravatar Lukacs Berki2016-02-24
| | | | | | | | | Windows. Also make windows.md a bit nicer in general. -- MOS_MIGRATED_REVID=115449272
* Allow overriding Javac options on android_library rules.Gravatar Ulf Adams2016-02-24
| | | | | | | | | | | | | | Any -target and -source options specified in javacopts are currently ignored as they are overwritten with the hard-coded default -target 7 -source 7. This seems more reasonable to me - there are valid use cases for doing so, and if someone wants to shoot themselves in the foot, there are already plenty of other ways of doing so. A small step towards #844. -- MOS_MIGRATED_REVID=115449058
* Description redacted.Gravatar Tobias Werth2016-02-24
| | | | | -- MOS_MIGRATED_REVID=115448892
* Expose IDL information about Android targets to Skylark.Gravatar Dmitry Lomov2016-02-24
| | | | | | | Make more tests pass for Skylark IDE info aspect implementation. -- MOS_MIGRATED_REVID=115448483
* Exclude weirdly-named files from the JDK.Gravatar Lukacs Berki2016-02-24
| | | | | | | This remotes one stumbling block from bootstrapping on Windows. -- MOS_MIGRATED_REVID=115447112
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-05 03:10:22 +0000