aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Add @bazel_tools prefix to Java toolsGravatar Kristina Chodorow2016-01-20
| | | | | | | | This is in preparation for removing the requirement that base_workspace be in bazel's package_path. -- MOS_MIGRATED_REVID=112477785
* Create a wrapper script which looks for an executable in the workspaceGravatar Brian Silverman2016-01-20
| | | | | | | | | | | | | | | | | This executable in the workspace can be another Bazel binary whose version will change with the code it's next to, or a shell script which downloads a fixed version from some location. RELNOTES: A tools/bazel script in the workspace will be executed as an opportunity to use a fixed version of Bazel (not implemented for the homebrew recipe yet). Fixes #521 -- Change-Id: Id06177d9c2b259cd9d6fd62edb5abe541342dd05 Reviewed-on: https://bazel-review.googlesource.com/2620 MOS_MIGRATED_REVID=112477232
* Replace %{product} in option help texts too.Gravatar Han-Wen Nienhuys2016-01-20
| | | | | | | Fixes #730. -- MOS_MIGRATED_REVID=112475309
* Remove the warning for duplicated directories -- they are allowed.Gravatar Googler2016-01-19
| | | | | -- MOS_MIGRATED_REVID=112474631
* Skylark IDE info aspect: sources and dependencies.Gravatar Dmitry Lomov2016-01-19
| | | | | | | | | | | | | | 1. Refactored IntelliJSkylarkAspectTest. Eventually that test will be merged with AndroidStudioInfoAspect test to validate implementation equivalence. 2. Exposed ``root`` and ``is_source`` on Artifacts to Skylark. 3. Skylark aspect implementation outputs sources and dependencies information. -- MOS_MIGRATED_REVID=112473407
* Add variant of Preconditions.checkArgument that takes int placeholder.Gravatar Janak Ramakrishnan2016-01-19
| | | | | -- MOS_MIGRATED_REVID=112472854
* Avoid auto-unboxing in Preconditions check that has string then two integer ↵Gravatar Janak Ramakrishnan2016-01-19
| | | | | | | arguments (seems too messy for a family of functions). -- MOS_MIGRATED_REVID=112472644
* Fileset (Google internal): code cleanup.Gravatar Laszlo Csomor2016-01-19
| | | | | -- MOS_MIGRATED_REVID=112466264
* cpp: document the |start| parameter at the callsites of ConnectToServer()Gravatar Thiago Farina2016-01-19
| | | | | | | | | | | It is counter-intuitive to read ConnectToServer(false). By having /*start=*/ in front of the boolean parameter the intention gets clear (i.e., if it should or not start the Java server). -- Change-Id: I74847deb6ec7daba62facd7a746d418943448182 Reviewed-on: https://bazel-review.googlesource.com/#/c/2680 MOS_MIGRATED_REVID=112466249
* Use a separate XML_OUTPUT_FILE for unittest.bash testsGravatar Damien Martin-Guillerez2016-01-19
| | | | | | | The current set-up was overwriting the XML_OUTPUT_FILE of unittest_test, leading to weird error on ci.bazel.io. -- MOS_MIGRATED_REVID=112462362
* Remove javac/testing from the public tree.Gravatar Lukacs Berki2016-01-19
| | | | | | | It is currently unused and messes up IDEs because it requires a few dependencies that are not in the source tree (most notably, jimfs) -- MOS_MIGRATED_REVID=112461226
* Rewrite SkylarkAspectsTest to inherit AnalysisTestCase.Gravatar Ulf Adams2016-01-19
| | | | | | | | | | | | | | | | | | While BuildViewTestCase now has an update() function, it also has a lot of legacy cruft that doesn't match how the code is used in production. This also makes the test code a bit simpler. Also add a couple missing fail() statements. This is in preparation for adding a couple more tests; we don't have good test coverage for interaction between Skylark aspects and native rules and vice versa, especially for error scenarios. I may reuse some of the AspectTest code, but that inherits AnalysisTestCase. Inheriting AnalysisTestCase here also makes that easier. -- MOS_MIGRATED_REVID=112460142
* Make setup-intellij.sh work again.Gravatar Lukacs Berki2016-01-19
| | | | | | | | | Somewhat. The generated IntelliJ project is still somewhat broken and you need to manually exclude a few directories to use it and there is a mystical error about a missing method on truth.MapSubject, but at least now it fails in a less spectacular way. Fixes #796. -- MOS_MIGRATED_REVID=112458948
* General cleanup for the configured target / aspect creation code.Gravatar Ulf Adams2016-01-19
| | | | | | | | | | | | | | - update some comments - add some comments to make it easier to follow - delete some dead code, in particular the SkyframeDependencyResolver can never be null; remove an non-applicable @Nullable annotation I'm trying to figure out how the error handling code works, in order to add support for interleaved loading+analysis, which requires handling loading errors in this code path. -- MOS_MIGRATED_REVID=112456674
* Use --nolegacy_bazel_java_test when launching test.Gravatar Damien Martin-Guillerez2016-01-19
| | | | | | | This will create a non-dummy XML file for all our java_test. -- MOS_MIGRATED_REVID=112449480
* Set test_class for java_test test target where it is neededGravatar Damien Martin-Guillerez2016-01-19
| | | | | | | | | This make those test target compatible with --nolegacy_bazel_java_test. -- Change-Id: I2316c9aa53327b417ecce5fd5dab95ec726da11d Reviewed-on: https://bazel-review.googlesource.com/#/c/2690 MOS_MIGRATED_REVID=112446514
* Load `appengine_war` rule in `BUILD`Gravatar Tetsuo Kiso2016-01-19
| | | | | | | | Because `appengine_war` is not defined by default, `bazel build` fails unless loading. It would be nice to add the code to load the rule in the tutorial. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/794 MOS_MIGRATED_REVID=112415835
* Remove Truth 0.27 since 0.28 is there since quite a while.Gravatar Lukacs T. Berki2016-01-19
| | | | Change-Id: I99487b78a4f9a564c0618209f638425e2e39baa6
* Generate a default dummy XML file when the test runner does not.Gravatar Damien Martin-Guillerez2016-01-18
| | | | | -- MOS_MIGRATED_REVID=112409554
* Fix Bazel bootstrapping with JDK 7Gravatar Damien Martin-Guillerez2016-01-18
| | | | | | | | | | | With latest change to the bootstrap compilation, some options were wrongly moved around. Tested with `source scripts/ci/build.sh; bazel_build` for JAVA_VERSION 1.7 and 1.8. -- MOS_MIGRATED_REVID=112409496
* Inlined RepositoryFunction#getExternalPackageGravatar Damien Martin-Guillerez2016-01-18
| | | | | | | | | | This method was used only twice. Now there is only one entry point for requesting a rule in the external package (RepositoryFunction#getRule(String, Environment)). This is a step towards supporting loading skylark rules in the workspace file from remote repository. -- MOS_MIGRATED_REVID=112407797
* Use only the Bazel server for bootstrappingGravatar Damien Martin-Guillerez2016-01-18
| | | | | | | This remove all C++ compilation in bootstrapping itself. -- MOS_MIGRATED_REVID=112407516
* Fix #757: Bazel does not copy xml test output from sandbox.Gravatar Philipp Wollermann2016-01-18
| | | | | -- MOS_MIGRATED_REVID=112404257
* Use JavaIoFileSystem during the bootstrapping, removing JNI compilation.Gravatar Damien Martin-Guillerez2016-01-18
| | | | | | | Another step towards no C++ compilation outside of Bazel for bootstrapping. -- MOS_MIGRATED_REVID=112399835
* Replaced process-wrapper by a dummy version for bootstrappingGravatar Damien Martin-Guillerez2016-01-18
| | | | | | | | process-wrapper is a C++ tool, replacing by a dummy shell version to reduce the number of C++ compiler calls during the bootstrap process. -- MOS_MIGRATED_REVID=112398152
* Use a dummy build-runfiles in the bootstrap binaryGravatar Damien Martin-Guillerez2016-01-18
| | | | | -- MOS_MIGRATED_REVID=112397181
* Inline bazel_bootstrap in compile.shGravatar Damien Martin-Guillerez2016-01-18
| | | | | | | This method is used only once now so inline. -- MOS_MIGRATED_REVID=112396086
* Make the second example load() statement a label, too.Gravatar Lukacs Berki2016-01-18
| | | | | -- MOS_MIGRATED_REVID=112394770
* Do not use sandboxing when bootstrappingGravatar Damien Martin-Guillerez2016-01-18
| | | | | | | | This simplify the bootstrap process and remove a C++ tool from the bootstrap binary. -- MOS_MIGRATED_REVID=112394555
* Description redacted.Gravatar Googler2016-01-18
| | | | | -- MOS_MIGRATED_REVID=112394431
* Update the documentation of the load() statement because now bare paths are ↵Gravatar Lukacs Berki2016-01-18
| | | | | | | deprecated. -- MOS_MIGRATED_REVID=112392227
* Disallow loads from external repos in WORKSPACE files. Currently, attempting ↵Gravatar John Field2016-01-18
| | | | | | | | | to do such a load will result in a skyframe circular dependency exception. As a side effect of this change, SkylarkImportFailedExceptions thrown by SkylarkImportLookupFunction are now caught by PackageFunction and wrapped and rethrown as a PackageFunctionException. Previously, the first exception wasn't caught, generating an uncaught exception error at top level. -- MOS_MIGRATED_REVID=112328755
* support hidden --java_optimization_mode flag in java_test rule.Gravatar Googler2016-01-18
| | | | | -- MOS_MIGRATED_REVID=112290581
* Remove unnecessary modifiers from interface fieldsGravatar Kristina Chodorow2016-01-18
| | | | | -- MOS_MIGRATED_REVID=112285296
* Remove unecessary value nulling from ResourceShrinker.Gravatar Andrew Pellegrini2016-01-18
| | | | | -- MOS_MIGRATED_REVID=112284252
* Don't append the class output dir to the classpathGravatar Liam Miller-Cushon2016-01-15
| | | | | -- MOS_MIGRATED_REVID=112280234
* Increase the size of some tests that time out on ci.bazel.ioGravatar Damien Martin-Guillerez2016-01-15
| | | | | | | See http://ci.bazel.io/job/Bazel/JAVA_VERSION=1.7,PLATFORM_NAME=darwin-x86_64/302/console -- MOS_MIGRATED_REVID=112280018
* More runtime dependency artifact cleanupGravatar Liam Miller-Cushon2016-01-15
| | | | | -- MOS_MIGRATED_REVID=112273574
* Enable Aspects to specify their configuration fragment dependencies.Gravatar Michael Staib2016-01-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Note: This specification currently does not have any effect, but soon... In the default mode, when an aspect does not call any of the configuration fragment methods on its AspectDefinition.Builder, the old behavior will persist; aspects can only access fragments their associated rule has access to, and have no guarantee as to what those fragments are. This mode will become deprecated with a future CL. If an aspect does call a configuration fragment method, it will have a configuration fragment policy. In a future CL, this will mean it will be restricted to accessing only those fragments, but will be understood as requiring access to them for the purposes of dynamic configuration, even if the rule it is attached to or created by does not otherwise require them. Eventually, all aspects will be required to declare their configuration fragments this way. Skylark aspects may also declare configuration fragments as of this CL. Two new parameters are added to the aspect() function, fragments and host_fragments, mirroring the similar parameters for rules. If both of these parameters are empty or unspecified, the default mode is used, as with normal aspects. Also in this CL: * Minor javadoc fixes for AspectDefinition. * Additional tests for AspectDefinition. -- MOS_MIGRATED_REVID=112271713
* Fix documentation for some ios_test attributes that got lost in refactoring.Gravatar Peter Schmitt2016-01-15
| | | | | -- MOS_MIGRATED_REVID=112267385
* Adds support for invocation policy to the canonicalize-flags command.Gravatar Alex Humesky2016-01-15
| | | | | -- MOS_MIGRATED_REVID=112267123
* Fix documentation on cc_library includes attributeGravatar Kristina Chodorow2016-01-15
| | | | | | | Fixes #637 -- MOS_MIGRATED_REVID=112261246
* Libc top for the host should take its value only from --host_grte_top or the ↵Gravatar Googler2016-01-15
| | | | | | | | | host crosstool. RELNOTES[NEW]: --grte_top no longer also sets --host_grte_top in the absence of the latter -- MOS_MIGRATED_REVID=112258796
* Add native.rule(NAME), which returns the attributes of a previously defined ↵Gravatar Han-Wen Nienhuys2016-01-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | rule. Add native.rules(), which returns all previously defined rules. These primitives can be used to write Skylark extensions that aggregate over the contents of a BUILD file, eg. def instantiate_if_needed(name): n = name + "_wrapped" if not native.rule(n): py_test(name = n , ... ) def archive_cc_src_files(tag): all_src = [] for r in native.rules().values(): if tag in r["tags"] and r["kind"] == "cc_library": all_src.append(r["srcs"]) native.genrule(cmd = "zip $@ $^", srcs = all_src, outs = ["out.zip"]) RELNOTES: Support aggregation over existing rules in Skylark extensions through native.rules and native.rule. -- MOS_MIGRATED_REVID=112249050
* Update skylark docs for grammar and clarity.Gravatar Alex Humesky2016-01-15
| | | | | -- MOS_MIGRATED_REVID=112248853
* Refactor action output dumping to go through a single method.Gravatar Ulf Adams2016-01-15
| | | | | | | | | | | | | This is in preparation for moving the output dumping to the Reporter for two reasons: - we're currently relying on there being a Reporter which locks on itself; i.e., this code is tightly coupled with the Reporter code - the current Blaze output is confusing; we first print an info event, then the actual output, and then an error event - putting the Reporter in control allows us to fix that -- MOS_MIGRATED_REVID=112240684
* Do not include bazel_tools in the bootstrap binaryGravatar Damien Martin-Guillerez2016-01-15
| | | | | | | | | Instead use the current tools from the repository. This simplifies the bootstrap binary and is a step towards no C++ compilation for the bootstrap binary. -- MOS_MIGRATED_REVID=112240524
* Fix bazel args in the bootstrap testGravatar Damien Martin-Guillerez2016-01-15
| | | | | -- MOS_MIGRATED_REVID=112239696
* Increase the size of some tests that time out on ci.bazel.ioGravatar Damien Martin-Guillerez2016-01-15
| | | | | | | See http://ci.bazel.io/job/Bazel/JAVA_VERSION=1.7,PLATFORM_NAME=linux-x86_64/301/console -- MOS_MIGRATED_REVID=112238153
* Add a method for getting the root of a rule workspace to the Label methodGravatar Damien Martin-Guillerez2016-01-15
| | | | | | | | This method is exposed to Skylark and will enable correct handling of protobuf skylark files. See #784 -- MOS_MIGRATED_REVID=112235357