aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Description redacted.Gravatar Googler2016-07-25
| | | | | -- MOS_MIGRATED_REVID=128258430
* Remove unneeded implicit dependency on proto runtimes in Java proto library ↵Gravatar Carmi Grushko2016-07-25
| | | | | | | | | rules. They're only needed for the compilation, which happens in the aspects, not the rules themselves. -- MOS_MIGRATED_REVID=128244113
* Rollback of commit ee36dd3f5db8e7ad129b2782a24eb97a0478fc42.Gravatar Sergio Campama2016-07-25
| | | | | | | | | | | | | *** Reason for rollback *** Prevent [] from burning up *** Original change description *** Make the proto bundling behavior the default when using the new library. -- MOS_MIGRATED_REVID=128226570
* Global cleanup change.Gravatar Googler2016-07-25
| | | | | -- MOS_MIGRATED_REVID=128209793
* Bump grpc-java lib to version 0.15.0 non-binariesGravatar dapengzhang02016-07-25
| | | | | | | -- Change-Id: I2da9049019b3965975fab9b7f606d099d6eab2ff Reviewed-on: https://bazel-review.googlesource.com/#/c/4040/ MOS_MIGRATED_REVID=128208129
* Be less naive with CcLibraryHelper precompiled library collision detection.Gravatar Michael Staib2016-07-25
| | | | | | | | | | The naive algorithm was O(n*m) where n = number of precompiled libraries and m = number of libraries linked during this rule. Ugly! This one provides hopefully much more reasonable performance. -- MOS_MIGRATED_REVID=128206057
* Remove gRPC-java v0.14.1 libraryGravatar dapengzhang02016-07-25
| | | | Change-Id: Iaebecdb172943e42f361139486b90b25caff18eb
* Update Error Prone to 2.0.11Gravatar Liam Miller-Cushon2016-07-25
| | | | | | | | http://repo1.maven.org/maven2/com/google/errorprone/error_prone_core/2.0.11/error_prone_core-2.0.11.jar http://repo1.maven.org/maven2/com/google/errorprone/error_prone_annotations/2.0.11/error_prone_annotations-2.0.11.jar http://repo1.maven.org/maven2/com/google/errorprone/error_prone_annotation/2.0.11/error_prone_annotation-2.0.11.jar Change-Id: I90d8d3f05d7aecf254d48db086cce0c7fa74706c
* Turn down deprecation warning.Gravatar Googler2016-07-22
| | | | | -- MOS_MIGRATED_REVID=128202272
* Description redacted.Gravatar Googler2016-07-22
| | | | | -- MOS_MIGRATED_REVID=128199284
* Add missing inlcudeGravatar Kristina Chodorow2016-07-22
| | | | | -- MOS_MIGRATED_REVID=128195657
* Bring PackageSpecification docs up-to-date, clean up its interfaceGravatar Mark Schaller2016-07-22
| | | | | | | | Focuses on documenting the Strings that PackageSpecifications can be translated from and to. -- MOS_MIGRATED_REVID=128195540
* Fixes typo in Javadoc.Gravatar Googler2016-07-22
| | | | | -- MOS_MIGRATED_REVID=128192249
* RELNOTES: Improve Android split transition handling.Gravatar Googler2016-07-22
| | | | | -- MOS_MIGRATED_REVID=128184440
* Remove two commented out lines of code that I accidentally submitted previously.Gravatar Chris Parsons2016-07-22
| | | | | -- MOS_MIGRATED_REVID=128181372
* Add a resource merger state -> R class writer.Gravatar Googler2016-07-22
| | | | | | | | | | | | | | | | Collects the R class fields from the new merger's internal state, and then writes out either an R.java or R.class. TBD which to use. One concern is that users may want the javadoc. If so, perhaps this could generate the R.class, and then aapt could generate the srcjar off of the build critical path. Refactor the RClassGenerator to make it easier to use from merger state (vs from R.txt). -- MOS_MIGRATED_REVID=128181306
* JavaBuilder: for jars that are produced by aspects (e.g., JavaProtoAspect), ↵Gravatar Carmi Grushko2016-07-22
| | | | | | | | | pass the name of the injecting rule (e.g., java_proto_library), if the rule registered it. Registration is done using AspectParameters and a specially-named key. -- MOS_MIGRATED_REVID=128179548
* Fix bash auto-completion for aliasesGravatar Damien Martin-Guillerez2016-07-22
| | | | | | | | | The label pattern was incorrectly passed around (the command was not translated into a target pattern) which resulted in the target not being completed. -- MOS_MIGRATED_REVID=128177563
* Create a symlink with the right workspace name under the execrootGravatar Kristina Chodorow2016-07-22
| | | | | | | | | | | | | | | | | | The execution root currently uses the basename of the workspace directory for the workspace name, not the name in the WORKSPACE file. (For example, if our sources were in /path/to/foo and our WORKSPACE file had workspace(name = "bar"), our execution root would look like execroot/foo.) This creates a symlink bar -> foo, so that accessing ../repo_name actually works for the main repository. RELNOTES[INC]: The main repository's execution root is under the main repository's workspace name, not the source directory's basename. This shouldn't have any effect on most builds, but it's possible it could break someone doing weird things with paths in actions. -- MOS_MIGRATED_REVID=128175455
* Clean up minor issues in C++/Java tutorialsGravatar David Herman2016-07-22
| | | | | | | | | | | | Hello, I work for Google but am currently contributing this as an individual. I'm interested in learning Bazel on the side, and as I'm going through the docs, I thought I'd submit code reviews for misc. Bazel site cleanup that I came across (especially for guides that act as a first impression for new users). Let me know if you'd prefer I submit this patch in a different way. Thanks! Closes #1530. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/1530 MOS_MIGRATED_REVID=128174882
* Fix crash when accessing transitive_runtime_deps/transitive_deps provider of ↵Gravatar Laurent Le Brun2016-07-22
| | | | | | | java_binary -- MOS_MIGRATED_REVID=128169058
* Rename MemcacheActionCache to ConcurrentMapActionCacheGravatar Dan Fabulich2016-07-22
| | | | | | | -- Change-Id: I7c36fcfee46f4340aa6d17c03b6599beef45f524 Reviewed-on: https://bazel-review.git.corp.google.com/#/c/4062/1 MOS_MIGRATED_REVID=128167039
* Simple REST URL cacheGravatar Dan Fabulich2016-07-22
| | | | | | | -- Change-Id: Ied34278c63c74aaf2db5ad90d5f076b3bddbe396 Reviewed-on: https://bazel-review.git.corp.google.com/#/c/4061/ MOS_MIGRATED_REVID=128165927
* Running all java tests passing on Windows on JenkinsGravatar Yun Peng2016-07-22
| | | | | | | -- Change-Id: I3a6f5a0bce24a4f6c42ef1811f0b1587fed1c8f5 Reviewed-on: https://bazel-review.googlesource.com/#/c/4130 MOS_MIGRATED_REVID=128154259
* Minor editorial changes:Gravatar Sasha Smundak2016-07-22
| | | | | | | Do not include err.h in token_stream.h, it is pulled in by diag.h. -- MOS_MIGRATED_REVID=128151081
* Generalize JavaBuilder's fixMessage string to a function.Gravatar Carmi Grushko2016-07-22
| | | | | | | This allows accommodating rules that generate jars using Aspects. -- MOS_MIGRATED_REVID=128106284
* Move cmdline lib to its own packageGravatar Kristina Chodorow2016-07-21
| | | | | -- MOS_MIGRATED_REVID=128097235
* When telling JavaBuilder what label produced a certain jar, also provide the ↵Gravatar Carmi Grushko2016-07-21
| | | | | | | | | Aspect's name that participated, if there is one. RELNOTES: -- MOS_MIGRATED_REVID=128085414
* Remove unused methodGravatar Kristina Chodorow2016-07-21
| | | | | -- MOS_MIGRATED_REVID=128080879
* Roll forward commit ff8ea95fb2e4c77104263bebbf21c7e4e7a00d00Gravatar Liam Miller-Cushon2016-07-21
| | | | | -- MOS_MIGRATED_REVID=128080654
* 5 of 5: Integrate with the AndroidResourceProcessorGravatar Googler2016-07-21
| | | | | -- MOS_MIGRATED_REVID=128074515
* Following commit 9c4629dafc3aafc10f952824efd448700ad3363e, specify that ↵Gravatar Jon Brandvein2016-07-21
| | | | | | | hashing is deterministic and uses a specific algorithm. -- MOS_MIGRATED_REVID=128070666
* Export xcode_locator's source file under tools/osx/ to make it available for ↵Gravatar Chris Parsons2016-07-21
| | | | | | | reference by future repository rules. Removes the xcode-locator binary file under tools/objc. Originally, the precompiled binary was going to be referenced, but it's easier to build from source in the repository rule. -- MOS_MIGRATED_REVID=128063694
* --Gravatar Jon Brandvein2016-07-21
| | | | MOS_MIGRATED_REVID=128060563
* Add //src/test/java/com/google/devtools/build/lib:windows-tests to the set ↵Gravatar Lukacs Berki2016-07-21
| | | | | | | of tests run on Jenkins on Windows. -- MOS_MIGRATED_REVID=128053672
* Rollback of commit 6b1856c0da95ccea97b13890b2617bd0635f4291.Gravatar Tobias Werth2016-07-21
| | | | | -- MOS_MIGRATED_REVID=128038062
* Make ijar_test nuke $TEST_TMPDIR on exit.Gravatar Lukacs Berki2016-07-21
| | | | | | | $TEST_TMPDIR is not deleted automatically and this can result in the accumulation of a bunch of large files on the CI machines of Bazel because this tests writes 2GB files for testing. -- MOS_MIGRATED_REVID=128037053
* Clean up minor spelling / grammar in Getting Started pageGravatar David Herman2016-07-21
| | | | | | | | | | | | Hello, I work for Google but am currently contributing this as an individual. I'm interested in learning Bazel on the side, and as I'm going through the docs, I thought I'd submit code reviews for misc. Bazel site cleanup that I came across (especially for guides that act as a first impression for new users). Let me know if you'd prefer I submit this patch in a different way. Thanks! Closes #1529. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/1529 MOS_MIGRATED_REVID=128035787
* Make [] happy again by adding a test with the same name as the one whose ↵Gravatar Tobias Werth2016-07-21
| | | | | | | deletion it did not notice, //third_party/bazel/tools/build_defs/test:swift_lib_test . -- MOS_MIGRATED_REVID=128033534
* Don't waste time formatting an assertion message we're not going to throw.Gravatar Googler2016-07-21
| | | | | -- MOS_MIGRATED_REVID=128016662
* Remove Rule's dependence on a RawAttributeMapper instanceGravatar Michajlo Matijkiw2016-07-21
| | | | | | | | | The things Rule needs it for aren't terribly complex. Instead inline functionality where sensible, and refactor into static methods where not. This reduces each Rule's memory footprint by 38%. -- MOS_MIGRATED_REVID=128011760
* Checks for Android SDK in the Android integration test by checking presence ↵Gravatar Adam2016-07-21
| | | | | | | | | | of `tools/android` `SDK Readme.txt` is not necessarily present in an SDK installation. -- Change-Id: I98569b7e480e3fa47b9458a0bc950d87712f89cc MOS_MIGRATED_REVID=127999306
* Prepare JavaBuilder to accept an Aspect's name, in addition to a label, of ↵Gravatar Carmi Grushko2016-07-21
| | | | | | | | | | | the owner of a jar. The motivation is strict-deps checking for Aspected rules such as java_proto_library. With this additional information, JavaBuilder will be able to better tell the user which rule is missing in the 'deps' attribute of the target being built. Note that the AspectParameters aren't passed right now, because (1) serializing them adds complexity and (2) they're unneeded for JavaBuilder right now. -- MOS_MIGRATED_REVID=127993845
* Stop input and output of cc_library from clobbering each other.Gravatar Michael Staib2016-07-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this change: Any given cc_library can only contribute one library with a given name to targets which depend on it. If an input library has the same name as the cc_library which it is an input to, the decision of which to use is based on the link mode. e.g., cc_library( name = "foo", srcs = ["foo.c", "libfoo.so"], ) will only contribute libfoo.a (a static library containing foo.o) in static mode, while it will only contribute libfoo.so (the precompiled shared library) in dynamic mode. This change alters cc_library's behavior in this case: * If libfoo.a would be empty (i.e., there are no linkable sources), then this is allowed. The libfoo.so from srcs is simply passed through. (Previously, the empty libfoo.a would be forwarded.) * Otherwise, this is an error. In the case where there are multiple libraries in the srcs with the same library identifier (lib[name].[a|so|lo]), cc_library will still choose one based on the link mode. This behavior has not changed. Similarly, cc_library will still choose one of its own outputs based on the link mode. That behavior has not changed either. RELNOTES[INC]: It is now an error to include a precompiled library (.a, .lo, .so) in a cc_library which would generate a library with the same name (e.g., libfoo.so in cc_library foo) if that library also contains other linkable sources. -- MOS_MIGRATED_REVID=127989348
* Minor backwards compatibility fixes:Gravatar Googler2016-07-21
| | | | | | | | * Account for the dataKey in MergeConflicts (whoops.) * When finding a conflict, always take the last value -- this matches the current merger strategy. -- MOS_MIGRATED_REVID=127980673
* RELNOTES: Add global hash() function for strings (only)Gravatar Jon Brandvein2016-07-21
| | | | | -- MOS_MIGRATED_REVID=127979748
* Use byte[] rather than ByteString for file digests.Gravatar Googler2016-07-20
| | | | | | | | | | | | | | | | | ActionInputFileCache: Change getDigest() to return the underlying byte[16] owned by each FileArtifactValue. Remove throws clause from getInputFromDigest(); this should be an in-memory operation, and no implementation actually throws. PerActionFileCache: Invert mapping from artifact to digest only if needed. Remove interner, as it was used only for the reverse map keys, not the returned values. This should be a significant cpu savings as eagerly constructing the reverse maps was a noticeable hotspot. -- MOS_MIGRATED_REVID=127972359
* Add target names for mergee manifests to generate more helpful error ↵Gravatar Andrew Pellegrini2016-07-20
| | | | | | | messages from manifest merging when using manifest_merger="android" on android_binary rules. -- MOS_MIGRATED_REVID=127962630
* Description redacted.Gravatar Googler2016-07-20
| | | | | -- MOS_MIGRATED_REVID=127962492
* Suggest using --user when the install directory isn't writable.Gravatar John Cater2016-07-20
| | | | | | | | | Fixes #1540. -- Change-Id: I0f16bde6496f2abef8ba3d3562e62a1534c177ca Reviewed-on: https://bazel-review.googlesource.com/#/c/4081/ MOS_MIGRATED_REVID=127960571