aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Windows: add blaze_util::AsAbsoluteWindowsPathGravatar laszlocsomor2017-07-24
| | | | | | | | | | | Replace blaze_util::AsWindowsPathWithUncPrefix with AsAbsoluteWindowsPath, which always returns an absolute path. Fixes https://github.com/bazelbuild/bazel/issues/2935 RELNOTES: none PiperOrigin-RevId: 162727218
* Make error message in case top-level aspect is missing clearer.Gravatar Dmitry Lomov2017-07-24
| | | | | | | Fixes #2874. Change-Id: I636e0f6b56a1e33adfc64e90f36f76d4254d0281 PiperOrigin-RevId: 162726099
* Remove an unused method.Gravatar lberki2017-07-24
| | | | | RELNOTES: None. PiperOrigin-RevId: 162725697
* Windows: blaze_util::ChangeDir. uses short pathsGravatar laszlocsomor2017-07-24
| | | | | | | | | | | | | | The current working directory may not be longer than MAX_PATH, otherwise SetCurrentDirectoryW fails. It may, but should not contain a "\\?\" prefix, otherwise the Java code won't be able to parse it. Therefore convert the path to a 8dot3 style path in blaze_util::ChangeDirectory and use SetCurrentDirectoryA. RELNOTES: none PiperOrigin-RevId: 162720636
* Windows: more robust path handling.Gravatar laszlocsomor2017-07-24
| | | | | | | | | | | | | | | In this change: - add support for absolute-on-current-drive paths (e.g. "\foo", meaning "c:\foo") - report error for relative-on-current-drive paths (e.g. "c:" and "c:foo") - report error for remote Windows paths (e.g. "\\servername\path\on\server") - update blaze_util::AsWindowsPath comments - update tests RELNOTES: none PiperOrigin-RevId: 162719763
* Make TestsInSuiteKey, TestSuiteExpansionKey implement SkyKeyGravatar ulfjack2017-07-24
| | | | PiperOrigin-RevId: 162715709
* Make all test cases pass with --noexperimental_separate_genfiles_directory.Gravatar lberki2017-07-24
| | | | | RELNOTES: None. PiperOrigin-RevId: 162715619
* Move all crosstool patches to CppActionConfigsGravatar hlopko2017-07-24
| | | | | | | | As the ordering in which features are defined matters, let's move all the crosstool patching logic to a single place in CppActionConfigs. RELNOTES: None. PiperOrigin-RevId: 162712170
* Clean up/improve docs across several Apple classes.Gravatar allevato2017-07-21
| | | | PiperOrigin-RevId: 162676133
* Update aspects documentation to the latest and greatest APIs.Gravatar Dmitry Lomov2017-07-21
| | | | | Change-Id: I76d785dbbcd2c5cf30ab5d130e82b2819931651a PiperOrigin-RevId: 162672358
* De-emphasize the note on internal providers.Gravatar Dmitry Lomov2017-07-21
| | | | | | | Fixes #3354. Change-Id: I1525b5fc6e44cce335744b1d5883be71812003ed PiperOrigin-RevId: 162672218
* ObjcProvider is propagated as a native declared provider.Gravatar cparsons2017-07-21
| | | | | | | This has the added benefit of improving ObjcProvider documentation generated in bazel docs. RELNOTES: None. PiperOrigin-RevId: 162658384
* Move ActionInputPrefetcher to the actions packageGravatar ulfjack2017-07-21
| | | | | | The plan is to add it to ActionExecutionContext, which is also there. PiperOrigin-RevId: 162656835
* Add all generated headers as mandatory inputs for compile actions.Gravatar rduan2017-07-21
| | | | | | | We previously only add those under genfiles root. But J2ObjC and objc proto headers are under the bin root, which we may also fix in the near future. RELNOTES: None. PiperOrigin-RevId: 162656166
* Updates XCTestAppProvider documentation to mention it's deprecated status.Gravatar kaipi2017-07-21
| | | | PiperOrigin-RevId: 162655959
* Fix #3416: catch the ALREADY_EXISTS status code on upload, and treat it as ↵Gravatar olaola2017-07-21
| | | | | | | | | success. This can happen per spec, if multiple builds try to upload the same blob concurrently. Also, added this to the RemoteWorker, per spec. PiperOrigin-RevId: 162647548
* Remove --experimental_android_use_singlejar_for_multidex.Gravatar ajmichael2017-07-21
| | | | | | | | This flag has been a no-op for a while with a deprecation warning that it will be removed. RELNOTES: Remove --experimental_android_use_singlejar_for_multidex. PiperOrigin-RevId: 162643922
* Automated rollback of commit 08e34e37663ec0fa2e957e44c7e1e0a2afc205ea.Gravatar Googler2017-07-21
| | | | | | | | | | | | | | | | *** Reason for rollback *** Rolling this back as it was the example BUILD file that was incorrect, not the tutorial itself. Submitted an updated BUILD file in commit 6abf4b9. *** Original change description *** the build file and bash example out of synch comparing to the latest code in the java tutorial repo Closes #3419. PiperOrigin-RevId: 162635241
* Use toolchain resolution in rule creation.Gravatar John Cater2017-07-21
| | | | | | | Part of #2219. Change-Id: Id4929d5ddcd57b4635af5e513eb9a09f16a78e71 PiperOrigin-RevId: 162634398
* Make isRunning protected.Gravatar janakr2017-07-21
| | | | PiperOrigin-RevId: 162630344
* Fold AndroidAaptBaseRule into AndroidBaseRule.Gravatar ajmichael2017-07-21
| | | | | | | This is a no-op, the same classes inherited from them. RELNOTES: None PiperOrigin-RevId: 162627873
* Support multiple --define's in config_setting.Gravatar gregce2017-07-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the problem that config_setting( name = "a_and_b", values = { "define": "a=c", "define": "b=d" }) doesn't work as expected because BUILD parsing removes duplicate dictionary keys in accordance with Pythonic behavior. Even worse, Skylark will soon enforce this more aggressively by making this an outright error. This change introduces the define_values attribute: config_setting( name = "a_and_b", values = { "normal_flag": "normal_value", }, define_values = { "a: "c", "b": "d" }) This is equivalent to "$ bazel build ... --normal_flag=normal_value --define a=c --define b=d" at the command line. Also tried to clean up some ConfigSetting naming for clarity around the different kind of flags. PiperOrigin-RevId: 162627180
* Improve documentation in MethodLibrary, add examples for builtins.Gravatar laurentlb2017-07-21
| | | | | RELNOTES: None. PiperOrigin-RevId: 162623144
* Reference `aspect` function from aspects documentation.Gravatar Dmitry Lomov2017-07-21
| | | | | Change-Id: Id97d526eaa94f27a0e030438bcfb2bf1527f7503 PiperOrigin-RevId: 162622496
* Tolerate injected nodes having deps.Gravatar janakr2017-07-21
| | | | | | | | | | We don't check explicitly that these are the only two ways, but this can happen if the error transience node is a dep of a node that's being injected, or if an injected node is an "external" file that needs to depend on an external package. The first possibility can happen if there was an IOException reading the node on the previous build. We handle the situation by just dirtying the node, not injecting it. Actual evaluation can handle the re-stat. PiperOrigin-RevId: 162622092
* Improve logging on batch stat issues.Gravatar felly2017-07-21
| | | | PiperOrigin-RevId: 162618754
* Add --toolchain_resolution_override to allow specifying the toolchain for a ↵Gravatar John Cater2017-07-21
| | | | | | | | | given type. Fixes https://github.com/katre/bazel/issues/6. Change-Id: I6c6e303384277b013bdc27eb80743aa51f2fb98a PiperOrigin-RevId: 162618674
* Allow the aapt2 code paths to be enabled by either flag or attribute.Gravatar corysmith2017-07-21
| | | | | RELNOTES: None PiperOrigin-RevId: 162613289
* Use new actions API in docs.Gravatar Dmitry Lomov2017-07-21
| | | | | Change-Id: Ibbc41193ca3f577fbbd1674e9dd1c7f04a246e93 PiperOrigin-RevId: 162612615
* Improve documentation for 'actions.write' and 'actions.expand_template'.Gravatar laurentlb2017-07-21
| | | | | RELNOTES: None. PiperOrigin-RevId: 162609583
* PiperOrigin-RevId: 162607273Gravatar plf2017-07-21
|
* Skylark documentation: Replace "set" and "List" plain-text return types with ↵Gravatar fwe2017-07-21
| | | | | | links to "deptset" and "list". PiperOrigin-RevId: 162607082
* Include the JavaPluginInforProvider from java_library in JavaProvider.Gravatar elenairina2017-07-21
| | | | PiperOrigin-RevId: 162606464
* Turn off checking for filegroup "data" attributes.Gravatar cpovirk2017-07-20
| | | | | | Evidently the blanket disabling for all "data" attributes doesn't apply there. PiperOrigin-RevId: 162602015
* Internal changeGravatar aehlig2017-07-20
| | | | PiperOrigin-RevId: 162601644
* Document bazelrc "import %workspace%/..."Gravatar Mike Morearty2017-07-20
| | | | | | | | Document that a bazelrc file can import from a path that is relative to the workspace root by writing "import %workspace%/..." Closes #3405. PiperOrigin-RevId: 162600010
* the build file and bash example out of synchGravatar Shlomi Shemesh2017-07-20
| | | | | | | | comparing to the latest code in the java tutorial repo Closes #3419. PiperOrigin-RevId: 162599972
* Automated rollback of commit b8514f533d4546d3bfbec3700012f2bbeffd1c37.Gravatar dmarting2017-07-20
| | | | | | | | | | | | | | | *** Reason for rollback *** Breaks XML format when there is weird characters in the output (Jenkins fails to read XML output for re2 test) *** Original change description *** Add stdout to default XML file and generate XML file on timeout This should fix #1027 and get better error result on Jenkins. Change-Id: I5ce30b64f634e01dd350af10748c4a9455a6bea8 PiperOrigin-RevId: 162598130
* Automated rollback of commit e5f970906594d9097bb7c3736b2de1750cc8655f.Gravatar dmarting2017-07-20
| | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Break apple test on darwin. *** Original change description *** Refactor docker tests to be buildable without docker. This make this build a bit non-deterministic since the way it will be built depend on wether docker is installed or not. We now use the docker_pull from bazelbuild/continuous-integration to generate the base docker images and generate a fake docker binary that just error out when docker is not found so test will fails. Note that the docker_pull is set to timeout after an hour and can be extremely slow... *** PiperOrigin-RevId: 162598046
* Windows, CROSSTOOL: add subsystem flag feature in theGravatar Laszlo Csomor2017-07-20
| | | | | | | | | BUILD file. They must use "-" instead of "/" otherwise Bazel believes the linkopts entry declares a (invalid) label. Change-Id: I6ad33c3f51c37f59e7d3b92be872fc4e2b27d434 PiperOrigin-RevId: 162597691
* Do not depend on the Java launcher if java_binary.create_executable=0 ↵Gravatar lberki2017-07-20
| | | | | | | because it's not used anyway. RELNOTES: None. PiperOrigin-RevId: 162589013
* Automated rollback of commit 01ddfb7bf418b371859de62f4eab2f41ea9a4a4a.Gravatar laszlocsomor2017-07-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a partial rollback. I restored the old flags (with PathListConverter), added the new ones, added deprecation warnings and annotations, and added code to concat the values of new and old. Existing released versions of Bazel should keep working with the new code until 2018-01-31, i.e. for the next ~6 months. After that I'll remove the old flags and the PathListConverter. *** Reason for rollback *** Fixed broken integration with release Blaze. *** Original change description *** Automated rollback of commit 5752463ece84ebb4fb074888cba57412ab8d86b3. *** Reason for rollback *** Broke too many targets. *** RELNOTES: none PiperOrigin-RevId: 162587548
* Windows: clean up error reportingGravatar Laszlo Csomor2017-07-20
| | | | | | | | | | | | | | | | | | | In this commit: - remove blaze::PrintError in favor of blaze_util::PrintError - remove Ijar's PrintLastErrorMessage in favor of blaze_util::PrintError - use pdie every time path conversion fails, because that indicates a fatal error (bad user input for a path flag, or downright bug) - remove explicitly printing GetLastErrror; pdie and PrintError do it already - unify the pdie/PrintError message formats Fixes https://github.com/bazelbuild/bazel/issues/2935 Change-Id: I5feaf73885cab95c43a28c529ada6942e037b162 PiperOrigin-RevId: 162587490
* Fix typos in messages.Gravatar dslomov2017-07-20
| | | | | RELNOTES: None. PiperOrigin-RevId: 162586748
* Automated rollback of commit 6e72f78e1c2e573787ec862e671f3b3b4c33dc96.Gravatar kush2017-07-20
| | | | | | | | | | | | | | *** Reason for rollback *** Causing TGP issues with tool failures: b/63839245 Was finally able to repro the issue at HEAD, and didn't occur without this change. *** Original change description *** Small changes to skyframe package. RELNOTES: None PiperOrigin-RevId: 162565994
* Deprecate dynamic config OFF and NOTRIM_PARTIAL modes.Gravatar gregce2017-07-20
| | | | | | | | | | | | | --experimental_dynamic_configs=off --experimental_dynamic_configs=notrim_partial are now aliases for --experimental_dynamic_configs=notrim (the default). Also remove outdated --nodistinct_host_configuration warning. PiperOrigin-RevId: 162549307
* Be more precise in which values we're looking for in the histogram: just ↵Gravatar janakr2017-07-20
| | | | | | GlobValue objects, not any others. PiperOrigin-RevId: 162533962
* Internal changeGravatar Googler2017-07-20
| | | | PiperOrigin-RevId: 162532778
* Reduce to one SequencedSkyframeExecutor#create method. The others were minor ↵Gravatar janakr2017-07-20
| | | | | | convenience methods that didn't (IMO) carry their weight. PiperOrigin-RevId: 162528716
* Add test framework for OptionsBase classes and their Converters.Gravatar mstaib2017-07-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because OptionsBase implements equals() as a final method, subclasses can only add fields in certain ways for OptionsBase to properly obey equals() semantics. Specifically, all fields must be public and @Option annotated. The OptionsTester checks for these two things. Additionally, Converters must make sure to always return equals() values on equals() (or equivalent) input. The OptionsTester includes a check that all Converters named by the OptionsBase subclass being tested have matching ConverterTesters, and if valid default values are specified (i.e., on Options which are not multi-valued or default null), that these defaults are among the values tested by the ConverterTesters. The ConverterTesters themselves are wrapped EqualsTesters, testing that the output of a Converter obeys equals() as expected for the same input (or equivalent ones), and is consistent across calls to the same Converter instance or different Converter instances. Between these two, OptionsBase subclasses can have reasonable certainty that two instances of themselves which were parsed equally - or underwent equivalent transformations - will be equal. This does not actually test any OptionsBase subclasses or Converter implementations; it merely adds a framework. Future changes will cover automatically testing all of the OptionsBase subclasses in a RuleClassProvider, but naturally, this requires writing test data for each Converter in the Bazel codebase first. RELNOTES: None. PiperOrigin-RevId: 162522445
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-03 00:37:00 +0000