aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Make the parser handle CRLF correctly.Gravatar Lukacs Berki2016-05-24
| | | | | | | Fixes #1300 . -- MOS_MIGRATED_REVID=123090421
* Fix typo in skylark cookbookGravatar Googler2016-05-24
| | | | | -- MOS_MIGRATED_REVID=123071294
* Pre-allocate memory at a few (non-exhaustive) sites that are on the exit ↵Gravatar Janak Ramakrishnan2016-05-24
| | | | | | | path after we OOM, in an attempt to make that path complete more quickly and successfully. -- MOS_MIGRATED_REVID=123040502
* Separate killing Bazel on OOM using -XX:OnOutOfMemoryError and ↵Gravatar Janak Ramakrishnan2016-05-24
| | | | | | | | | pessimistically OOMing when GC thrashing. The first seems to make us hang on OOM, which is kind of the opposite of what we want. These flags are now even more terribly named than they used to be, but a rename can wait until we actually know what we want. -- MOS_MIGRATED_REVID=123036704
* Tweak TransitiveTraversalValue's constructor's visibilityGravatar Michajlo Matijkiw2016-05-24
| | | | | -- MOS_MIGRATED_REVID=123035454
* Use a non-side-effectful PackageLookupValue#packageExists implementation for ↵Gravatar Nathan Harmata2016-05-24
| | | | | | | | | //external package lookups, but keep the current (incorrect) semantics for unsuccessful //external package lookups. Refactor some users of the old WorkspacePackageLookupValue. -- MOS_MIGRATED_REVID=123034174
* Remove unused legacyCollectCppAndJavaLinkOptions.Gravatar Carmi Grushko2016-05-24
| | | | | -- MOS_MIGRATED_REVID=123026183
* libtool wrapper script to isolate the unfortunate hacks we must make to get ↵Gravatar Chris Parsons2016-05-24
| | | | | | | around apple's buggy libtool tool -- MOS_MIGRATED_REVID=123024674
* Frameworks are propagated through host apps to search paths in tests, but ↵Gravatar Cal Peyser2016-05-24
| | | | | | | are not actually linked into test bundles. -- MOS_MIGRATED_REVID=123021058
* Assert batch existence of nodes in DirtyingNodeVisitor#visit.Gravatar Janak Ramakrishnan2016-05-24
| | | | | | | | | | | Now that we batch-prefetch the nodes, there is no reason to delay this check until the async Runnable runs, since we have more debugging information this way. -- Change-Id: Ic73d99ed8de184ba1e29f0dee5375f5d45b5379d Reviewed-on: https://bazel-review.googlesource.com/3680 MOS_MIGRATED_REVID=123018542
* Docs demonstrating a macro combining Skylark and native rules.Gravatar Googler2016-05-24
| | | | | -- MOS_MIGRATED_REVID=123016395
* Allow use of Exceptions to exit early out of configured-target creation, ↵Gravatar Chris Parsons2016-05-24
| | | | | | | | | | instead of passing and checking null in all helpers. Demonstrates this pattern usage in a few select rules (e.g. AndroidBinary) where this was particularly egregious. There are many places which can benefit from this pattern -- this change doesn't try to fix them all at once. -- MOS_MIGRATED_REVID=123012378
* Allow fail() function to accept any argumentGravatar Laurent Le Brun2016-05-24
| | | | | | | | | | e.g. fail(3) This is mostly useful for debugging (typical error messages will continue to use strings). -- MOS_MIGRATED_REVID=123008379
* Do not include generated sources in the IDE package manifests.Gravatar Googler2016-05-24
| | | | | | | | | | The IDE doesn't add generated sources. Including these causes execution of actions that generate sources, including building whatever tools they need. This is not necessary for the IDE stage. -- MOS_MIGRATED_REVID=123004127
* Rollback of commit 23c274dcd0174a9bf0f62f028ab62084e9ea440f.Gravatar Kristina Chodorow2016-05-23
| | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** This is a roll-forward of commit 009b48bcfaf4ebb17f9ab03bea9036cfa3c12ff0, making --bazelrc a no-op. *** Original change description *** Automated [] rollback of commit 009b48bcfaf4ebb17f9ab03bea9036cfa3c12ff0. *** Reason for rollback *** Broke bazel installation on ci.bazel.io, see http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel-Install/578/console This change should make --bazelrc a non-op first to remove it. *** Original change description *** Remove .bazelrc This hasn't been used in several releases. -- MOS_MIGRATED_REVID=122998537
* Make actual-less bind() rules work again.Gravatar Lukacs Berki2016-05-23
| | | | | -- MOS_MIGRATED_REVID=122995313
* Replace the occurrences of Constants.PRODUCT_NAME for a call toGravatar Luis Fernando Pino Duque2016-05-23
| | | | | | | | | BlazeRuntime#getProductName() or a reference to TestConstants.PRODUCT_NAME for tests. This CL prepares the codebase in order to delete the constant. -- MOS_MIGRATED_REVID=122993568
* Rollback of commit 009b48bcfaf4ebb17f9ab03bea9036cfa3c12ff0.Gravatar Yue Gan2016-05-23
| | | | | | | | | | | | | | | | | *** Reason for rollback *** Broke bazel installation on ci.bazel.io, see http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel-Install/578/console This change should make --bazelrc a non-op first to remove it. *** Original change description *** Remove .bazelrc This hasn't been used in several releases. -- MOS_MIGRATED_REVID=122993255
* Uses "zip -@" to avoid arguments with too many files. Fixes #1303.Gravatar Yue Gan2016-05-23
| | | | | -- MOS_MIGRATED_REVID=122990255
* Add framework support to ExperimentalObjcLibrary.Gravatar Cal Peyser2016-05-23
| | | | | -- MOS_MIGRATED_REVID=122988772
* Use setLoadingOrWorkspacePhase instead of setLoadingPhase where relevant,Gravatar Damien Martin-Guillerez2016-05-23
| | | | | | | | | | | commit 3fedf9e618cbce3dbdd00559b2de0bb8e2d43171 introduced the distinction between the loading phase and the workspace phase. This check broke the use of native.existing_rule(s) in skylark remote repository, added a regression test for it. Fixes #1277 -- MOS_MIGRATED_REVID=122988569
* JavaLibraryHelper: when collecting transitive source jars, look in the ↵Gravatar Carmi Grushko2016-05-23
| | | | | | | | | targets that were added using addDeps(), instead of looking in the "deps" attribute. This is currently a no-op, because collectTransitiveJavaSourceJars() is only called if noProviders() hasn't been called, which never happens in the current code in Blaze. -- MOS_MIGRATED_REVID=122985812
* JavaLibraryHelper: do not handle jars in deps.Gravatar Carmi Grushko2016-05-23
| | | | | | | To use jars in deps, wrap them in java_import. -- MOS_MIGRATED_REVID=122985072
* Make alias targets keep their own configuration.Gravatar Lukacs Berki2016-05-23
| | | | | | | | | This prevents the case of a rule acquiring the null configuration in case the alias points to an input file. Which, in turn, makes "bazel build" work for these targets. The reason it breaks is that TargetCompletionValue instances are created from the associated ConfiguredTarget in SkyframeExecutor#buildArtifacts(), which means that if the configurations do not match, TargetCompletionFunction requests a different ConfiguredTargetValue than it was created from. Fixes #1297. -- MOS_MIGRATED_REVID=122973526
* Remove a bunch of unnecessary files from the Bazel binary.Gravatar Ulf Adams2016-05-23
| | | | | | | This reduces the size of the Bazel binary by ~25%. -- MOS_MIGRATED_REVID=122971740
* Rollback of commit d3cccae7b663d5defea2943509b0d9d245279830.Gravatar Googler2016-05-23
| | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Rolling forward with api tolerance. *** Original change description *** Automated [] rollback of commit 941ef4d96d85e114eb6cca2fc0f646578ab0ef27. *** Reason for rollback *** Breaks Bazel due to internal patch for Round qualifier. *** Original change description *** * Adds handling for anydpi and watch, two unsupported qualifiers in FolderConfiguration. * Handles resources nested in directories. * Makes the resource processing resilient to invalid qualifiers. -- MOS_MIGRATED_REVID=122910358
* Improve fidelity of proto configured attribute serializationGravatar Michajlo Matijkiw2016-05-23
| | | | | -- MOS_MIGRATED_REVID=122889821
* Roll forward just the new unit test from commit ↵Gravatar Googler2016-05-23
| | | | | | | | | 8375185ee11d573562f98de14bed79a77fcfd728 that applies to already-existing code. -- MOS_MIGRATED_REVID=122869862
* When BuildOptions.get(Class<T> optionsClass) fails, include whichGravatar Greg Estren2016-05-23
| | | | | | | | | fragment was requested in the NullPointerException message. This helps diagnose dynamic configuration errors. -- MOS_MIGRATED_REVID=122855814
* Change the way protos report their output.Gravatar Googler2016-05-23
| | | | | -- MOS_MIGRATED_REVID=122846987
* Remove .bazelrcGravatar Kristina Chodorow2016-05-23
| | | | | | | This hasn't been used in several releases. -- MOS_MIGRATED_REVID=122844213
* Add test coverage for label visitation over computed defaults in ↵Gravatar Greg Estren2016-05-23
| | | | | | | | | | | | | | | AggregatingAttributeMapper. Recall that computed defaults have the ability to read all nonconfigurable attributes and whatever configurable attributes they declare in their constructors. I mistakenly thought that AggregatingAttributeMapper.visitLabels was skipping computed defaults that didn't declare configurable deps. While everything was, in fact, fine, this cl properly enforces expectations. In the process, I created a custom rule class in AggregatingAttributeMapperTest, which forced AbstractAttributeMapperTest to inherit BuildViewTestCase. That offered some code cleanup opportunity that makes up the rest of this cl. -- MOS_MIGRATED_REVID=122838948
* Store the hash code of the Environment in the RuleClass object. When a ↵Gravatar Janak Ramakrishnan2016-05-23
| | | | | | | | | RuleClass is deserialized as part of a Skylark rule, the Environment is currently not present, but it is needed to detect changes to the rule. Also precompute and store the Environment's hash code, and do a drive-by clean-up of a bunch of warnings in the Environment code. -- MOS_MIGRATED_REVID=122838588
* Adds a translation layer for ObjcProvider values between java and skylark to ↵Gravatar Cal Peyser2016-05-23
| | | | | | | allow for the exposure of values that are not typed as skylark primatives. -- MOS_MIGRATED_REVID=122838580
* Remote worker to listen to a specific port for HazelcastGravatar Alpha Lam2016-05-20
| | | | | | | | | | | | This change allows starting remote worker with an embedded hazelcast server that listens to a specific port. This allows test to run reliably. Fixes #1271. -- Change-Id: I0bb36af5837f83cad3d76b8acb50f89cd599ee87 Reviewed-on: https://bazel-review.googlesource.com/c/3650/ MOS_MIGRATED_REVID=122829898
* Move the command line arguments for C++ preprocessor defines to a feature.Gravatar Lukacs Berki2016-05-20
| | | | | | | | | | | | This required a few assorted changes: - The FDO build stamp is not special-cased anymore, it is treated as a preprocessor define like any other. - When compiling a .pcm file, use interfaceContext instead of the regular context when setting up the build variables. This is a bit more consistent and would be a good cause for a future bug. This is a retry of commit 7841a6ab100fc35a67600f1ce1a70d293c51350e, which made some bold changes to LIPO that didn't work out well. -- MOS_MIGRATED_REVID=122829825
* Invalidate external repositories when their names changeGravatar Brian Silverman2016-05-20
| | | | | | | | | | | | | | Without this, old repositories are still cached across the change to give a name in the WORKSPACE file, which results in annoying warnings. This should have been included in a7fea8a1467a89adde75e67bc99bf0e040f71fe9. Fixes #1166. -- Change-Id: I831b842dc07b4ca7925f003b68f4838d083b1166 Reviewed-on: https://bazel-review.googlesource.com/c/3660/ MOS_MIGRATED_REVID=122829553
* Rollback of commit 8375185ee11d573562f98de14bed79a77fcfd728.Gravatar Philipp Wollermann2016-05-20
| | | | | -- MOS_MIGRATED_REVID=122825908
* Change some weird formating.Gravatar Cal Peyser2016-05-20
| | | | | -- MOS_MIGRATED_REVID=122824226
* Rollback of commit 7841a6ab100fc35a67600f1ce1a70d293c51350e.Gravatar Lukacs Berki2016-05-20
| | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** breaks [] *** Original change description *** Move the command line arguments for C++ preprocessor defines to a feature. This required a few assorted changes: - The LIPO compilation context is not merged anymore. Include paths for auxiliary files are apparently taken from the profile files, so it is not necessary. - The FDO build stamp is not special-cased anymore, it is treated as a preprocessor define like any other. - When compiling a .pcm file, use interfaceContext instead of the regular context when setting up the build variables. Th... *** -- MOS_MIGRATED_REVID=122823591
* experimental UI: improve message shorteningGravatar Klaus Aehlig2016-05-20
| | | | | | | | | | | | | | | | | When a progress message has to be shortened, as it does not fit in a line in the progress bar, add a new first attempt: if the message the path implicit to the label, only shorten that path within the message (if that gets short enough, leaving a reasonable part of the path); usually, the additional information is more useful than having a longer part of the path present. While there, also fix incorrect length computation in a different case of message shortening. -- Change-Id: Ied80e03cace1b249fc0f4e11bce41f2b4207b6ad Reviewed-on: https://bazel-review.googlesource.com/#/c/3670 MOS_MIGRATED_REVID=122818198
* Update Bazel native rule documentation to use new ${link} syntax.Gravatar David Chen2016-05-20
| | | | | -- MOS_MIGRATED_REVID=122772973
* Use correct rule name for $java_import_base attribute documentation.Gravatar David Chen2016-05-20
| | | | | -- MOS_MIGRATED_REVID=122772865
* Propagate Apple Watch extensions dSYMs to parent ios_application.Gravatar Dmitry Shevchenko2016-05-20
| | | | | -- MOS_MIGRATED_REVID=122769355
* Accurately document java_*.depsGravatar Liam Miller-Cushon2016-05-20
| | | | | -- MOS_MIGRATED_REVID=122755869
* Consider /src/ in the path when locating the java root directory,Gravatar Googler2016-05-19
| | | | | | | | | | to support cases like src/com/google/java, where the root is just src. Also check for nested /src/ directories. This allows "blaze analyze" to understand the classes provided by such "double src" rules and match them up to java imports. -- MOS_MIGRATED_REVID=122748028
* fix Docker rules link in a simple wayGravatar Jeff Hodges2016-05-19
| | | | | | | | | | Updates #1236 This doesn't fix the real problem (`README.md` seems to be turning into `README.html` during the render process), but, depending on how much time others have to look at the document generator, this might be worth submitting. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/1237 MOS_MIGRATED_REVID=122747784
* Rollback of commit 941ef4d96d85e114eb6cca2fc0f646578ab0ef27.Gravatar Googler2016-05-19
| | | | | | | | | | | | | | | *** Reason for rollback *** Breaks Bazel due to internal patch for Round qualifier. *** Original change description *** * Adds handling for anydpi and watch, two unsupported qualifiers in FolderConfiguration. * Handles resources nested in directories. * Makes the resource processing resilient to invalid qualifiers. -- MOS_MIGRATED_REVID=122747030
* ipa_post_processor for ios_extensions uses PlugIns directory instead of Payload Gravatar Googler2016-05-19
| | | | | | | CLEANUP=<fixing documentation> -- MOS_MIGRATED_REVID=122743083
* Make ide_build_info work again with targets that have configurable attributes.Gravatar Lukacs Berki2016-05-19
| | | | | | | This fixed some fallout from commit 7894c18dbaf237a1c02d76beabe6ca54faf5039a. I also audited all the sites that change introduced ImmutableMap.Builder at. -- MOS_MIGRATED_REVID=122738945