aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Use FeatureConfiguration to compute value of CC_FLAGS make variableGravatar hlopko2017-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | This cl introduces new action_config type for Crosstool named 'generic'. This can be used to set the value of CC_FLAGS make variable using much more expressive mechanism (action_configs + features) than previous make_variable Crosstool messages. This has been requested by the C++ LPT. However, as FeatureConfiguration needs RuleContext, CC_FLAGS cannot be computed using configuration only anymore. Also, FeatureConfiguration is C++ rules specific class, and Bazel build-base cannot depend on it. Therefore we cannot use FeatureConfiguration for ExtraActions, for example. Because it cannot be made perfect, this cl is not updating all the possible places that expand make variables but limits the scope to: * genrule (the only widely used rule that often expands make variables) * *_test (CC_FLAGS is used by Tensorflow in the 'args' attribute) * cc_rules (people sometimes set 'copts' to something like: "-DCC_STRING=\\\"$(CC)\\\" -DCC_FLAGS_STRING=\"$(CC_FLAGS)\"" The long term plan is to use Skylark C++ API to get C++ command lines, so CC_FLAGS together with this inconsistent solution will be removed. RELNOTES: CC_FLAGS can be defined using 'generic' action_config in CROSSTOOL PiperOrigin-RevId: 157202883
* Use the correct extension_safe copt for extension_safe attributeGravatar cparsons2017-05-26
| | | | | | | The previous copt was in error, and was not caught due to only causing warnings to be omitted. Tests are now updated to throw an error in such cases of warning. RELNOTES: None. PiperOrigin-RevId: 157150798
* Make platform providers creatable from Skylark.Gravatar John Cater2017-05-26
| | | | | | | This will allow custom rules to interact more fully with the platform system. Change-Id: I22dd2efab55b1c6e6129b1ba99fb5f0aa9c2d6b2 PiperOrigin-RevId: 157145828
* Remove workspace tree under correct nameGravatar kchodorow2017-05-26
| | | | | | Actual fix for #2819. PiperOrigin-RevId: 157142420
* Remove no-op use_singlejar_for_proguard_libraryjars flag - it was removed ↵Gravatar Googler2017-05-26
| | | | | | | from global .blazerc in unknown commit RELNOTES: n/a PiperOrigin-RevId: 157133716
* Expose creation method for DottedVersion to skylark.Gravatar cparsons2017-05-26
| | | | | RELNOTES: Skylark support (apple_common.dotted_version(string)) for building DottedVersion objects to interface with native apple rules PiperOrigin-RevId: 157131109
* Use nested sets for configured target runfiles instead of flattened lists.Gravatar Googler2017-05-26
| | | | | RELNOTES: None PiperOrigin-RevId: 157124371
* Clean up SkylarkToolchainConstructor's argument handling.Gravatar John Cater2017-05-26
| | | | | Change-Id: I0604355801bd7e4f77a93bfc38e970713a1392c5 PiperOrigin-RevId: 157116222
* Added an implicit output target to j2objc_libraryGravatar Googler2017-05-26
| | | | | | This implicit output is similar to objc_library's fully linked static library. For j2objc_library targets, we can use this output to trigger transpilation and generate a fully linked static library. PiperOrigin-RevId: 157062831
* Modify misleading TODO.Gravatar ccalvarin2017-05-26
| | | | | | Unfortunately, we aren't ready to turn logging on by default, so cannot convert die/pdie to FATAL log messages. PiperOrigin-RevId: 157041142
* Automated g4 rollback of commit e2edf2e141a09c025a958d580c7cac7b57c70d83.Gravatar Googler2017-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Rollforward with fix. *** Original change description *** Automated g4 rollback of commit c78c947e6a8cbb323304f872a3dcabb989a3d76b. *** Reason for rollback *** Breaks android targets in the nightly - see [] *** Original change description *** Do not retain transitive data in AndroidLocalTestBase... *** ROLLBACK_OF=156745610 RELNOTES: None PiperOrigin-RevId: 157028029
* For static interface method, when we move it to the companion class,Gravatar cnsun2017-05-26
| | | | | | | | append a suffix to the method name, so as to avoid name clash in the companion class. RELNOTES: n/a PiperOrigin-RevId: 157021961
* process-tools: Fail silently when we can't install a signal handler.Gravatar philwo2017-05-26
| | | | | | | | | | | | | | | | | | | | | | | linux-sandbox expects InstallSignalHandler to fail silently when called for a signal that doesn't allow one to install a signal handler. This behavior was accidentally lost and changed into a DIE() on sigaction failure when unifying the signal handling code with process-wrapper in https://github.com/bazelbuild/bazel/commit/f5900474b8bce417c3ef4c3e06af6da5ed57b929. This CL restores the previous behavior. The issue results in this failure: $ linux-sandbox -- /bin/true third_party/bazel/src/main/tools/process-tools.cc:112: "sigaction": Invalid argument We do have tests for linux-sandbox and Bazel's usage of the linux-sandbox strategy. None of these actually started failing when the linux-sandbox stopped working, due to our automatic fallback logic that we added in order to not annoy users / CI on platforms that don't support the Linux sandbox :( Bazel silently falls back to the processwrapper-sandbox strategy and disables the entire linux-sandbox test suite, but signals to CI that it passed (because we don't support a "Skipped" test status). Well, congrats. What an epic fail. I will have to rework this next week. PiperOrigin-RevId: 157021455
* Root GenObjcBundledProtos input filelist under the appropriate build ↵Gravatar cparsons2017-05-26
| | | | | | | configuration RELNOTES: None. PiperOrigin-RevId: 157017608
* Add one version enforcement to android_robolectric_testGravatar Googler2017-05-26
| | | | | RELNOTES: add one-version enforcement to android_local_test PiperOrigin-RevId: 157014802
* Add toolchains attribute to aspect.Gravatar John Cater2017-05-26
| | | | | | | Part of #2219. Change-Id: I39ced1f3e2605154771df9424d6ed2f971820baf PiperOrigin-RevId: 157002268
* Don't throw runtime exception on interruption - since we know the future is ↵Gravatar Googler2017-05-26
| | | | | | already done, we should leave the thread in an interrupted state and proceed. This fixes a blaze crash when a 'genquery' execution is interrupted at the right time. PiperOrigin-RevId: 157000269
* Fix bug with combining resource attributes. Attributes were reporting that ↵Gravatar apell2017-05-26
| | | | | | | they were over-writable in all cases instead of differentiating by attribute type. RELNOTES: None. PiperOrigin-RevId: 156999284
* Add tear down for external_integration_testGravatar kchodorow2017-05-26
| | | | | | For #2409. PiperOrigin-RevId: 156986600
* Migrate tests to Truth.Gravatar lberki2017-05-26
| | | | | RELNOTES: None. PiperOrigin-RevId: 156983366
* Migrate tests to Truth.Gravatar lberki2017-05-26
| | | | | RELNOTES: None. PiperOrigin-RevId: 156979845
* Migrate tests to Truth.Gravatar lberki2017-05-26
| | | | | RELNOTES: None. PiperOrigin-RevId: 156979705
* Migrate tests to Truth.Gravatar lberki2017-05-26
| | | | | RELNOTES: None. PiperOrigin-RevId: 156979038
* Let MSVC wrapper recongnize -DEFAULTLIB:library optionGravatar Yun Peng2017-05-26
| | | | | | | | | | | | | If MSVC wrapper is removed, users cannot put flags like `-Wl,ws2_32.lib` in linkopts of C++ rules on Windows. Instead, they should do `-DEFAULTLIB:ws2_32.lib`. This change is to make the wrapper script also accpet -DEFAULTLIB:library option. https://msdn.microsoft.com/en-us/library/229a6ysd.aspx Change-Id: I0cf9f5529f833470166488100b70fb497384e083 PiperOrigin-RevId: 156978364
* cpp: remove blaze_util::sys_ioprio_set() call from FreeBSD portGravatar Thiago Farina2017-05-24
| | | | | | | Currently sys_ioprio_set() is only implemented for Linux. Change-Id: Iadacf8fd48a804b981274e92ca3066a403c467fb PiperOrigin-RevId: 156977281
* Fix msvc_cl.py for cuda compilationGravatar Yun Peng2017-05-24
| | | | | | | Passing /MT or /MD option using --compiler_options to nvcc Change-Id: Idf02ca0a4abf25bced397f5fffc1bc10ff0c160f PiperOrigin-RevId: 156976225
* Remove /W3 from compiler_flag from MSVC CROSSTOOLGravatar pcloudy2017-05-24
| | | | | | | | | The default warning level will become /W1 which only display severe warnings. https://msdn.microsoft.com/en-us/library/thxezb7y.aspx RELNOTES: None PiperOrigin-RevId: 156972872
* Improve error messages for malformed Android SDK/NDK.Gravatar ajmichael2017-05-24
| | | | | | | | | | | | | Currently, if the user has an SDK/NDK that is missing required directories, we print out an InconsistentFileSystemException. This CL will give a better error, indicating which directory is missing (or is not a directory). Implementation is roughly taken from NewLocalRepositoryFunction. Followup to https://github.com/bazelbuild/bazel/issues/2739. RELNOTES: None PiperOrigin-RevId: 156913532
* Actually run DataResourceXmlTest with Bazel.Gravatar ajmichael2017-05-24
| | | | | | | Removes references com.google.common.io.MoreFiles because it is not in //third_party/guava/guava-21.0-20161101.jar which we use for the JDK7 builds. RELNOTES: None PiperOrigin-RevId: 156912922
* Remove outdated documentation about appcompat library.Gravatar ajmichael2017-05-24
| | | | | | | The documentation for the current iteration of this feature is under android_sdk_repository. RELNOTES: None PiperOrigin-RevId: 156909364
* Remove possibility of circular initialization errors inGravatar John Cater2017-05-24
| | | | | | | SkylarkType.Simple. Change-Id: I7d6898bcba1689fee9e730b6134b659948501dae PiperOrigin-RevId: 156903849
* Set --experimental_enable_objc_cc_deps by default in the blaze binary.Gravatar cpeyser2017-05-23
| | | | PiperOrigin-RevId: 156896360
* Automated g4 rollback of commit c4134802dd15d6ef5cca6521f6bf6aac395ee2ad.Gravatar kchodorow2017-05-23
| | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Roll forward of directory name change *** Original change description *** Automated g4 rollback of commit 1d9e1ac90197b1d3d7b137ba3c1ada67bb9ba31b. *** Reason for rollback *** Breaks //src/test/shell/integration:force_delete_output_test *** Original change description *** Symlink output directories to the correct directory name If the workspace directory is /path/to/my/proj and the name in the WORKSPACE file is "floop", this will symlink the output directories to output_base/execroot/floop instead of output_base/execroot/proj. More prep for #1262, fixes #1681. PiperOrigin-RevId: 156892980
* cpp: change PrintError() to print "ERROR:"Gravatar Thiago Farina2017-05-23
| | | | | | | | | | | As it was suggested in https://bazel-review.googlesource.com/#/c/10875/3/src/main/cpp/util/errors.cc@58 This is because that way it's consistent with the warnings/errors that the Bazel server displays. Change-Id: I65ee961ac4db5b21461fa7f7864e7f3c94a6e4f3 PiperOrigin-RevId: 156884812
* Automated g4 rollback of commit 7f520a8286c39c5145b6d816cd0be5a6b7b18250.Gravatar elenairina2017-05-23
| | | | | | | | | | | | | | | | | | *** Reason for rollback *** This broke Bazel CI on freebsd: http://ci.bazel.io/view/Dashboard/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=freebsd-11/1516/console# *** Original change description *** Refactor process-wrapper code so the spawn/wait code is pluggable. In an upcoming change I'll reintroduce the new platform-specific implementations that can kill and wait for all descendant processes spawned by the wrapped process. This has no functional changes. PiperOrigin-RevId: 156884488
* Make PackageOrException.get() public + make loadPackages() variant.Gravatar carmi2017-05-23
| | | | | RELNOTES: None PiperOrigin-RevId: 156876531
* Add functionality from the old shell-based coverage runner script to the new ↵Gravatar lberki2017-05-23
| | | | | | | | | | | | | one. This isn't a principled solution, but since it depends on /usr/bin/lcov, it should never be relied on at all. It's mostly a courtesy to people who came to use C++ coverage in Bazel before we removed it. Fixes #2685. Progress on #1118. RELNOTES: None. PiperOrigin-RevId: 156866370
* Add a new action for generating reconciled R classes for Robolectric.Gravatar corysmith2017-05-23
| | | | | | | | | This includes some refactoring: * Move the symbol deserialization our of the merger and into the ParsedAndroidData (probably move again.) * Change the FailedFutureAggregator generics to work more callables RELNOTES: None PiperOrigin-RevId: 156863698
* Update remote caching / execution docsGravatar ulfjack2017-05-23
| | | | | | Progress on #904. PiperOrigin-RevId: 156862823
* Make sure Copyright year is always up to date.Gravatar steren2017-05-23
| | | | | | | | | | In a document comment, xam@ said it was OK to have the copyright year showing the current date. Instead of using a fixed date, I used the technique described at http://www.adamwadeharris.com/get-current-year-in-jekyll/ I tested the change locally. RELNOTES: None PiperOrigin-RevId: 156861876
* Remove unused .css file.Gravatar steren2017-05-23
| | | | | | | The website's style is coming from css/main.scss, which itself uses _sass/style.css. The file at styles/main.css is never used. Tested: locally. PiperOrigin-RevId: 156856307
* Add an integration test that verifies that the source file of a C++ compile ↵Gravatar lberki2017-05-23
| | | | | | | | | | | action is present in extra actions attached to it. Also rename cc_inc_library test to something that reflects better what it does (there was already a test case that did not have anything to do with cc_inc_library) Fixes #2790 . RELNOTES: None. PiperOrigin-RevId: 156854584
* Make Desugar work for relative dumpDirectory paths.Gravatar Googler2017-05-23
| | | | | | | | | | | | | Before CL 155913466, Desugar was not working when dumpDirectory was a relative path because of an extra/incorrect resolve() that ended up duplicating such a relative path. CL 155913466 fixed this by converting Desugar's dumpDirectory to an absolute path. However, CL 156257767 introduced a check that Desugar's dumpDirectory must match the one in Java's InnerClassLambdaMetafactory, which broke the case of a relative path again. Therefore, this CL undoes the conversion to absolute path again (so that Desugar's path matches that in InnerClassLambdaMetafactory). Instead, to make relative paths work, it drops the unnecessary/incorrect call to resolve(). A regression test is left for a future CL (I don't have a dev environment set up that would allow me to easily write one). RELNOTES: None. PiperOrigin-RevId: 156852882
* Refactor process-wrapper code so the spawn/wait code is pluggable.Gravatar philwo2017-05-23
| | | | | | | | In an upcoming change I'll reintroduce the new platform-specific implementations that can kill and wait for all descendant processes spawned by the wrapped process. This has no functional changes. PiperOrigin-RevId: 156849610
* experimental UI: Support limiting consoleGravatar Klaus Aehlig2017-05-23
| | | | | | | | | | | | Add an option allowing to set a hard limit on the number of characters bazel will write to stdout/stderr (combined). In this way, it can be avoided to overwhelm the user with information (especially, if the invocation of bazel is wrapped in some way). Once the limit is approaching, bazel will try hard to meaningfully reduce the output, but will ultimately resort to just dropping output completely. Change-Id: I49cce96cc6a025c9753632dd489021766df81077 PiperOrigin-RevId: 156849105
* BEP: explicitly mark the important outputs as deprecatedGravatar aehlig2017-05-23
| | | | | | | | While the fact that they are only added temporarily is obvious from the comment, a machine-readable deprecation annotation is more likely to be honored. So add it. PiperOrigin-RevId: 156846712
* Don't de-duplicate linkopts from two different configured targets that have ↵Gravatar lberki2017-05-23
| | | | | | | the same value. RELNOTES: None. PiperOrigin-RevId: 156837699
* Add a #hashCode() method to WorkspaceStatusAction implementations as is ↵Gravatar lberki2017-05-23
| | | | | | | | | | | advisable when overriding #equals(). Intricacies within Skyframe prevented us from adding this method before, but whatever those were are not a problem anymore. This was empirically proven by making the change, looking at the set of tests that failed when I last tried this, then finding that they don't fail. The reason for the original failures will stay obscured by the mists of time forever. RELNOTES: None. PiperOrigin-RevId: 156835875
* Fix typos in android_device.system_image attribute documentationGravatar Googler2017-05-23
| | | | | RELNOTES: None PiperOrigin-RevId: 156827893
* Store the features enabled for each targetGravatar Googler2017-05-23
| | | | | | | ctx.features has already merged the package-level and rule-level feature sets. RELNOTES: None. PiperOrigin-RevId: 156811464
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-03 10:39:53 +0000