| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
| |
This path type is a local file path as a wrapper around a string. It works much the same as java.io.File, but without its file operations.
For the most part, FilePath shouldn't add much overhead compared to using plain strings. Strings do get normalised on the way in, but no extra objects are allocated unless the path actually needs normalisation.
PiperOrigin-RevId: 178798497
|
|
|
|
|
|
|
| |
Tests on my local machine show that the Hyperthreading multiplier is significantly hurting our builds times.
RELNOTES: Set build jobs equivalent to number of logical processors by default. Should improve build times significantly.
PiperOrigin-RevId: 178795078
|
|
|
|
|
|
|
|
|
|
| |
This flag is set to true by default. If `--checkHashMismatch IGNORE` is passed, ZipFilterEntryFilter will filter duplicate files based on filenames and not do the check for different content hashes.
This is used for Android instrumentation tests: classes already in the target APK are removed from the instrumentation APK to prevent runtime crashes in ART.
GITHUB: #903
RELNOTES: Added --checkHashMismatch flag to ZipFilterAction. Valid values are IGNORE, WARN and ERROR. --errorOnHashMismatch is deprecated, please use this flag instead.
PiperOrigin-RevId: 178787292
|
|
|
|
| |
PiperOrigin-RevId: 178785887
|
|
|
|
|
|
| |
set to 'small'. Also add to bazel build files.
PiperOrigin-RevId: 178777977
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 178765624
|
|
|
|
|
|
|
|
|
|
|
| |
local local variables), the current implementation deletes n local slots, which is wrong when the local variable to delete is of type category 2.
This CL deletes local variables instead of local slots.
Another change is using the Label objects to identify uninitialized values, instead of the offsets of labels, because the offsets of labels might not be computed.
RELNOTES:n/a.
PiperOrigin-RevId: 178762969
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows libstdc++ to be statically linked, which is normally only
possible when invoking GCC as `g++` with the `-static-libstdc++` flag.
Fixes https://github.com/bazelbuild/bazel/issues/2840
See https://github.com/envoyproxy/envoy/issues/415 for additional
background and context.
cc @htuch (for Envoy) and @calpeyser @hlopko (who I talked to earlier about this)
I'm only doing this in the Linux toolchain because MacOS doesn't do static linking of system libs anyway, and I don't know enough about Windows or FreeBSD to test on those platforms.
Closes #4031.
PiperOrigin-RevId: 178762357
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 178760403
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rollforward of https://github.com/bazelbuild/bazel/commit/c861c0afd9a4df283936218b9e5b33c452b07c95 after fixing fake link actions.
*** Original change description ***
Rollback of 178106899.
RELNOTES: Linkstamping is now a separate and full-blown CppCompileAction, it's
no longer a part of linking command.
PiperOrigin-RevId: 178760072
|
|
|
|
|
|
|
|
| |
1. Allowing .lib as interface library, which is necessary on Windows
2. Documenting cc_improt by giving specific example use cases.
Change-Id: Ia50850495a1e91fe913ad69f9119753c32f9b4a7
PiperOrigin-RevId: 178754145
|
|
|
|
|
|
|
| |
instead of the rule name.
RELNOTES: None.
PiperOrigin-RevId: 178747070
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 178745230
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is set to "1"
By default when xcode is installed on darwin bazel will pick a toolchain that
supports both C++ and ObjC. This cl allows the user to pick C++ only
toolchain even when Xcode is installed.
Fixes #4231.
RELNOTES: None.
PiperOrigin-RevId: 178745218
|
|
|
|
| |
PiperOrigin-RevId: 178731961
|
|
|
|
| |
PiperOrigin-RevId: 178704585
|
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 178693605
|
|
|
|
|
|
| |
make cmdline and vfs depend on serialization. This allows a class to have a pointer to its codec, which simplifies automatic recursive composite codecs.
PiperOrigin-RevId: 178683500
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Design change, 2 boolean flags instead of 1 enum flag
*** Original change description ***
Add --incremental_state_retention_strategy
This option is intended to replace some of the uses of --batch. It lets users specify that builds should not be incremental, and how eagerly to discard the state that is kept around for incrementality. Note that for both values discard_eargerly and keep_for_life_of_build, the build graph is kept around until the next build. This may change.
Will add tests for keep_for_life_of_build in a later change, for now it will warn that that feature is experimen...
***
ROLLBACK_OF=178661777
RELNOTES: None.
PiperOrigin-RevId: 178681472
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 178664333
|
|
|
|
|
|
|
|
|
| |
This option is intended to replace some of the uses of --batch. It lets users specify that builds should not be incremental, and how eagerly to discard the state that is kept around for incrementality. Note that for both values discard_eargerly and keep_for_life_of_build, the build graph is kept around until the next build. This may change.
Will add tests for keep_for_life_of_build in a later change, for now it will warn that that feature is experimental.
RELNOTES: --[no]keep_incrementality_data is gone, replaced by the enum-valued --incremental_state_retention_strategy
PiperOrigin-RevId: 178661777
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests on my local machine show that the Hyperthreading multiplier is significantly hurting our builds times. Running with 8 logical cores is 11% faster than running with 4.8 cores when doing builds on my Mac.
macOS 10.12
MacBookPro 2017 (1 CPU, 4 core, 8 hyperthreaded)
1434.259 with --jobs = 5
1274.459 with --jobs = 8
I'll do some similar tests on Linux to see if it makes sense there.
PiperOrigin-RevId: 178654477
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 178641317
|
|
|
|
|
|
| |
Closes #4272.
PiperOrigin-RevId: 178638248
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 178622747
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 178618888
|
|
|
|
| |
Change-Id: I7096349f21b5ef2d86d709d98c676d92d9ff78fb
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 178618216
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To reproduce: run a failing test with --experimental_remote_spawn_cache or with --spawn_strategy=remote and no executor. Expected: test log is uploaded.
Desired behavior:
- regardless of whether a spawn is cacheable or not, its artifacts should be uploaded to the remote cache.
- the spawn result should only be set if the spawn is cacheable *and* the action succeeded.
- when executing remotely, the do_not_cache field should be set for non-cacheable spawns, and the remote execution engine should respect it.
This CL contains multiple fixes to ensure the above behaviors, and adds a few tests, both end to end and unit tests. Important behavior change: it is no longer assumed that non-cacheable spawns should use a NO_CACHE SpawnCache! The appropriate test case was removed. Instead, an assumption was added that all implementations of SpawnCache should respect the Spawns.mayBeCached(spawn) property. Currently, only NO_CACHE and RemoteSpawnCache exist, and they (now) support it.
TESTED=remote build execution backend.
WANT_LGTM: philwo,buchgr
RELNOTES: None
PiperOrigin-RevId: 178617937
|
|
|
|
| |
Change-Id: I28977bf62e893a8907accc17cec2532f15b68187
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
support it
This makes Bazel work nicer with VC++ version prior to VC++ 2015, but it
doesn't mean we fully support them. For example, /WHOLEARCHIVE doesn't
work with versions older that VC++ 2015, either.
Fixed https://github.com/bazelbuild/bazel/issues/3109
Fixed https://github.com/bazelbuild/bazel/issues/4240
Change-Id: Iab7280bea241a203cb04dc9ca0a7b3bce518fb64
PiperOrigin-RevId: 178615516
|
|
|
|
|
|
|
| |
There's no lexer for `grammar` supported by Jekyll, custom styles such as
`{.good}` are also not supported.
PiperOrigin-RevId: 178615029
|
|
|
|
|
|
|
|
|
|
| |
Make sure the actual binary recieves exactly the same argument passed to
Windows exe launcher.
Fixed https://github.com/bazelbuild/bazel/issues/4001
Change-Id: I5db2d7c2f78de8865abc04a2d5b65d69685d43db
PiperOrigin-RevId: 178610493
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 178609245
|
|
|
|
|
|
|
| |
There's no lexer for `grammar` supported by Jekyll, custom styles such as
`{.good}` are also not supported.
PiperOrigin-RevId: 178607733
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes https://github.com/bazelbuild/bazel/issues/4262
A specific browser view width range causes the navigation bar to be stacked on top of the documentation content, therefore requiring a bit of scrolling to get to it.
This fix changes col-lg-* to col-md-*, which reduces the view width threshold at which the columns are restyled using `@media queries`.
Tested locally on Chrome & Safari. This is also testable by going to the production site and changing the CSS classes in the inspector.
Closes #4263.
PiperOrigin-RevId: 178605473
|
|
|
|
|
|
|
|
|
| |
passes.
Fixes #4268 .
RELNOTES: None.
PiperOrigin-RevId: 178604877
|
|
|
|
|
|
|
|
|
|
|
|
| |
MiddlemanFactory wants to check if the middleman inputs set is empty
or singleton. A NestedSet can answer both queries efficiently if the
right APIs are used.
My ultimate goal here is to avoid the expansion of runfiles artifacts
nested sets until execution.
Change-Id: I29a269df757ef41b1410bbb492cf24c926df6114
PiperOrigin-RevId: 178600943
|
|
|
|
|
|
|
| |
Also remove a TODO that was addressed in unknown commit.
RELNOTES: None
PiperOrigin-RevId: 178489151
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 178448614
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 178426166
|
|
|
|
|
|
|
| |
statistics to SpawnResults, and add cumulative getters for these in ActionResults.
RELNOTES: None.
PiperOrigin-RevId: 178426142
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, if the default_value is not set, but the flag
has been given a value by a configuration transition, that value
is used and no error is produced.
If the default_value is not set and the flag has not been given
a value by a configuration transition, the rule produces an
error (as it did before, but now the error is different).
config_feature_flags with default_values behave as they did before.
(use the default value if no configured value is set, otherwise use
the configured value)
Also transition the Optional used in feature flags from Guava to
Java 8.
RELNOTES: config_feature_flag's default_value is optional. It is
only an error to have a config_feature_flag with no default_value
if that config_feature_flag has not been set in the configuration
it is being evaluated in.
PiperOrigin-RevId: 178418907
|
|
|
|
|
|
| |
This implementation requires adding an interned list of LabelAndConfiguration objects to each RuleConfiguredTarget ('implicit' is an attribute describer, not a dep describer so filtering needs to happen while attribute information still exists).
PiperOrigin-RevId: 178411882
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 178408662
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 178407067
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 178406494
|
|
|
|
|
|
|
|
| |
aapt2 always gets the complete, unfiltered resources, and then filters them in
execution. Save time by not uselessly filtering in analysis.
RELNOTES: none
PiperOrigin-RevId: 178397137
|
|
|
|
| |
PiperOrigin-RevId: 178384991
|
|
|
|
|
|
| |
properly executable shell and correct test outputs.
PiperOrigin-RevId: 178376681
|