| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
| |
We are still unable to turn this on to write to files, but there are currently 2 logging systems in use in the client: the inactive one, and the print-to-stderr option triggered by --client_debug. Combine these, so we can use the same logging format for both.
Also combine it with the VerboseLogging functionality - it was not documented anywhere and seems redundant.
RELNOTES: None.
PiperOrigin-RevId: 189979051
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 189973158
|
|
|
|
| |
PiperOrigin-RevId: 189971511
|
|
|
|
| |
PiperOrigin-RevId: 189970123
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 189949312
|
|
|
|
|
|
|
|
|
| |
allocation done by Attribute#hashCode.
Attribute#hashCode is called a lot by the visitation done by e.g. Rule#getTransition.
RELNOTES: None
PiperOrigin-RevId: 189947421
|
|
|
|
|
|
| |
general, but especially necessary because OutputFileConfiguredTarget (which is not a RuleConfiguredTarget) contains a reference to its generating configured target, so all the optimizations needed for RuleConfiguredTarget apply to OutputFileConfiguredTarget.
PiperOrigin-RevId: 189942424
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 189938838
|
|
|
|
|
|
|
| |
WANT_LGTM=all
TESTED=RBE, unit tests
RELNOTES: None
PiperOrigin-RevId: 189938345
|
|
|
|
|
|
|
| |
All SDKs now have aapt2 in them.
RELNOTES: None.
PiperOrigin-RevId: 189935587
|
|
|
|
|
|
|
|
|
| |
@SkylarkSignature more closely.
Also clarify the method representation in these error messages is for the attempted method *call*, not the actual method signature.
RELNOTES: None.
PiperOrigin-RevId: 189935148
|
|
|
|
|
|
|
| |
No relnotes, because deletion was already announced.
RELNOTES: None.
PiperOrigin-RevId: 189934041
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Break bazel ci.
*** Original change description ***
Assume toolchain supportsDynamicLinker from presence of "dynamic_linking_mode" feature
Toolchains no longer have to provide linking_mode_flags { mode: DYNAMIC } to
state that they support dynamic linking mode. It is enough to provide a feature.
This is part of ongoing work to get rid of linking_mode_flags from the
CROSSTOOL.
RELNOTES: None.
PiperOrigin-RevId: 189928991
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dynamically configured resource filtering was never turned on, as dynamic
configuration turned out to be too slow.
While we're at it, do a bit of related cleanup (remove the unused flag that
controlled resource filtering in analysis, and switch from a now-two-valued
enum to a boolean to specify whether resources should be filtered in analysis).
RELNOTES: none
PiperOrigin-RevId: 189923588
|
|
|
|
|
|
|
| |
https://github.com/bazelbuild/bazel/commit/5cee7f4afbadf8f463b33cf47dcd2fde096c6a4b#diff-76ac2009811ac59b4f76dcfb6d17be2b
RELNOTES: None.
PiperOrigin-RevId: 189917189
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks on windows: https://www.google.com/url?sa=D&q=https%3A%2F%2Fbuildkite.com%2Fbazel%2Fgoogle-bazel-presubmit%2Fbuilds%2F624%234a68440b-948b-437b-a633-4f0595721bab
*** Original change description ***
Automated rollback of commit 3c5a1098af0c5ae80d4e3b1fc52dd1fef6027d43.
*** Reason for rollback ***
Breaks bazel ci: https://github.com/bazelbuild/bazel/issues/4894#event-1533040075
*** Original change description ***
Add crosstool_lib.bzl and crosstool_utils.bzl
These will be used to rewrite current crosstool autoconfiguration into
action_configs and features.
RELNOTES: None.
PiperOrigin-RevId: 189906675
|
|
|
|
| |
PiperOrigin-RevId: 189906038
|
|
|
|
| |
PiperOrigin-RevId: 189905795
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks bazel ci: https://github.com/bazelbuild/bazel/issues/4894#event-1533040075
*** Original change description ***
Add crosstool_lib.bzl and crosstool_utils.bzl
These will be used to rewrite current crosstool autoconfiguration into
action_configs and features.
RELNOTES: None.
PiperOrigin-RevId: 189901308
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, generated NDK `cc_toolchain.all_files` filegroups do not glob the STL's static and dynamic runtime libraries, which includes important files like `libandroid_support.a` and `libc++.{so, a}`. This introduces sandboxed link time errors as @steeve discovered at https://github.com/bazelbuild/bazel/issues/3923#issuecomment-372750002
This PR adds the two filegroups to the respective toolchain's `all-files` filegroup to make them part of the toolchain's output in the sandbox. This generates a BUILD.bazel file like this: https://gist.github.com/jin/7d9fcf924fa33ab8fbc4c43c97676ab3
Fixes https://github.com/bazelbuild/bazel/issues/4864
Closes #4866.
PiperOrigin-RevId: 189900428
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To simplify the transition for existing repositories, we keep the property
that paths to true source files in your own repository may be hard-coded.
Add a test verifying that we keep this property.
Also add a test checking that this property is true, if the same repository
is built as a remote repository. But disable this test, as this property
does not hold yet; we plan to make it true with a change of the execroot
layout.
Change-Id: I0fb961f8ddb8feb98a6309533fc82f2acd9afd0d
PiperOrigin-RevId: 189898773
|
|
|
|
|
|
| |
Closes #4851.
PiperOrigin-RevId: 189897065
|
|
|
|
|
|
|
| |
No need to pass instance of PackageProvider there as two more general interfaces required separately.
RELNOTES:none
PiperOrigin-RevId: 189895042
|
|
|
|
|
|
|
|
|
|
|
|
| |
When this change is released, we can refactor compiler_output_flags feature to
use output_file build variable in place of output_object_file,
output_preprocess_file, and output_assembly_file for generating -o flag. We
still need output_preprocess_file and output_assembly_file to add -S and -E, but
we can get rid of output_object_file, and what's better we can stop caring about
extension when constructing build variables for compile actions.
RELNOTES: None.
PiperOrigin-RevId: 189892917
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"dynamic_linking_mode" feature
Toolchains no longer have to provide linking_mode_flags { mode: DYNAMIC } to
state that they support dynamic linking mode. It is enough to provide a feature.
This is part of ongoing work to get rid of linking_mode_flags from the
CROSSTOOL.
RELNOTES: None.
PiperOrigin-RevId: 189890583
|
|
|
|
|
|
| |
Closes #4872.
PiperOrigin-RevId: 189889623
|
|
|
|
|
|
|
|
| |
These will be used to rewrite current crosstool autoconfiguration into
action_configs and features.
RELNOTES: None.
PiperOrigin-RevId: 189888171
|
|
|
|
|
|
|
|
|
|
| |
```
ERROR: Query expressions involving 'buildfiles' or 'loadfiles' cannot be used with --output=location
```
Closes #4835.
PiperOrigin-RevId: 189888124
|
|
|
|
|
|
|
|
| |
Explicitly set local test jobs to 0 (= default, use local resources instead),
as otherwise this test will fail if --local_test_jobs is set in a system-wide
bazelrc.
PiperOrigin-RevId: 189887918
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
breaks building //src:bazel
*** Original change description ***
runfiles,C++: move to //tools/cpp/runfiles
Move the C++ runfiles library to the location of
the rest of the C++ tools.
Also change the C++ namespace to reflect the
directory hierarchy.
We have not yet announced nor released the C++
runfiles library so these refactorings are fine.
See https://github.com/bazelbuild/bazel/issues/4460
Closes #4873.
PiperOrigin-RevId: 189883066
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the C++ runfiles library to the location of
the rest of the C++ tools.
Also change the C++ namespace to reflect the
directory hierarchy.
We have not yet announced nor released the C++
runfiles library so these refactorings are fine.
See https://github.com/bazelbuild/bazel/issues/4460
Closes #4873.
Change-Id: I1732ef1eaff880cae05b7d218a3b1c0461a6b029
PiperOrigin-RevId: 189874201
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new package that'll host the Bash runfiles
library.
See https://github.com/bazelbuild/bazel/issues/4460
Closes #4882.
PiperOrigin-RevId: 189871255
|
|
|
|
|
|
|
| |
provider as an input.
RELNOTES:
PiperOrigin-RevId: 189868401
|
|
|
|
|
|
|
| |
flaky.
RELNOTES: None.
PiperOrigin-RevId: 189833678
|
|
|
|
| |
PiperOrigin-RevId: 189830623
|
|
|
|
|
|
| |
TESTED=unit
RELNOTES: None
PiperOrigin-RevId: 189818481
|
|
|
|
|
|
|
|
|
|
| |
empty.
Since EnumMap.equals() ignores the key type when the maps are empty [1], we could just return a canonical empty EnumMap, but that seems to depend on implementation details in a hacky and potentially subtly broken way. The Unsafe method will hopefully break spectacularly if it goes wrong.
[1] http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/687fd7c7986d/src/share/classes/java/util/EnumMap.java#l685
PiperOrigin-RevId: 189803280
|
|
|
|
|
|
| |
easy name access. This is useful for cquery output formatters.
PiperOrigin-RevId: 189794125
|
|
|
|
|
|
| |
always be the case.
PiperOrigin-RevId: 189792299
|
|
|
|
|
|
|
|
| |
Previously, usage was fairly inconsistent.
From now on, if the @Param is mandatory, use defaultValue = "" instead.
RELNOTES: None.
PiperOrigin-RevId: 189777905
|
|
|
|
|
|
|
|
|
| |
Clarify that the IMMUTABLE Mutability should only be used for deeply immutable things, not tuples. Created a new SHALLOW_IMMUTABLE Mutability for them.
Note that the new shallow-freezing functionality marks things as deeply IMMUTABLE without traversing its contents. I.e., it lies, and it is up to the caller to ensure this doesn't cause problems.
RELNOTES: NONE
PiperOrigin-RevId: 189767422
|
|
|
|
|
|
|
|
|
| |
We want to simplify/remove this API, but let's document it in the meantime.
Also fix harmless bug that annoyed me. It used rawTemplate instead of formatStr when there are no placeholders. This would theoretically fail to properly escape % symbols, except that the code path luckily short-circuits later on if there are no placeholders.
RELNOTES:
PiperOrigin-RevId: 189760809
|
|
|
|
|
|
| |
boolean getters in "isFoo" form.
PiperOrigin-RevId: 189753768
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Temporarily remove the Python runfiles library
from @bazel_tools and so prevent releasing it in
Bazel 0.12.0.
Motivation: https://github.com/bazelbuild/bazel/issues/4878
Fixing that bug *after* the python library is in
release Bazel would be harder because users would
need to update their code and BUILD files.
Fixing that bug before the library is released is
a lot easier because nobody depends on it yet, and
we can release the library when it's in the right
place.
Closes #4879.
Change-Id: I8adc219410571f9e2a4c8060f5b3239b957fbd5f
PiperOrigin-RevId: 189744985
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes #2054.
Allow users to be able to specify user specific paths. With this option
we can now commit bazel configuration file and force local action cache
activation per default:
$ cat tools/bazel.rc
build --experimental_local_disk_cache_path=~/.gerrit/bazel-cache/cas
build --experimental_local_disk_cache
build --experimental_strict_action_env
Test Plan:
$ bazel test //src/test/java/com/google/devtools/build/lib:util_test
Closes #4852.
PiperOrigin-RevId: 189744599
|
|
|
|
| |
Change-Id: I23465de72f19e8b11fafe64bb345a3ee6a4f0b97
|
|
|
|
|
|
| |
https://github.com/bazelbuild/bazel/issues/4883
Change-Id: I23257cbde6f24df2b7af27c5ce37281202651ed1
|
|
|
|
|
|
|
| |
This re-enables support for add_deps.
RELNOTES: None
PiperOrigin-RevId: 189737607
|
|
|
|
|
|
|
|
|
|
| |
Object file path will no longer be derived from source file path directly.
This is a preparation change for[]
Related issue https://github.com/bazelbuild/bazel/issues/4149
RELNOTES: None
PiperOrigin-RevId: 189722421
|