aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* * Adds handling for anydpi and watch, two unsupported qualifiers in ↵Gravatar Googler2016-05-19
| | | | | | | | | | FolderConfiguration. * Handles resources nested in directories. * Makes the resource processing resilient to invalid qualifiers. -- MOS_MIGRATED_REVID=122688529
* Write a -gensrc.jar even if the compilation failedGravatar Liam Miller-Cushon2016-05-19
| | | | | | | The generated sources are useful for debugging annotation processors. -- MOS_MIGRATED_REVID=122683781
* Use BufferedOutputStream for zipping / jar.Gravatar Googler2016-05-19
| | | | | | | | | | | | | | | | | | | | | | | | | This is for the resources.zip and the srcjar and aar. For the srcjar this is only slightly faster (100ms), but we might as well? Perhaps this is because the files are quite large anyway. Not sure if there would be smaller writes with compression. For the resources.zip it seems to make a bigger difference: > 1s when run locally. Perhaps this is because there are more small files. Didn't benchmark aar at all, just noticed it. Kevin mentioned the Buffering on one of the issues, so I happened to notice this when using similar code for prototype of R.class jar creation (seemed to be > 1s faster in that case, but that was also compressing). -- MOS_MIGRATED_REVID=122663374
* For tests that check against output paths, provide the ability to strip out ↵Gravatar Greg Estren2016-05-19
| | | | | | | | | | | | | | | | | the C++-contributed fragment. e.g. provide the ability to translate: bazel-out/gcc-X-glibc-Y-x86-fastbuild/ to: bazel-out/fastbuild/ This applies to artifacts built with dynamic configurations for targets with no C++ fragments in their configuration. -- MOS_MIGRATED_REVID=122643518
* Fix #837: worker_verbose flag has no effect.Gravatar Philipp Wollermann2016-05-19
| | | | | | | Due to reusing an old Reporter instead of grabbing the current one for each build, verbose messages were lost and not printed to the console. Also adds a test for this feature. -- MOS_MIGRATED_REVID=122639383
* Always restrict aspects to only access requested configuration fragments.Gravatar Michael Staib2016-05-19
| | | | | | | | | | | This completes the introduction of aspect configuration fragment enforcement for static configuration builds; as of this change, it is no longer possible to fall back to the base rule's set of requested configuration fragments. This sort of fallback may become possible later, likely in a more controlled way. -- MOS_MIGRATED_REVID=122638152
* Remove testing-only constructor for RuleClass from non-testing code.Gravatar Janak Ramakrishnan2016-05-19
| | | | | -- MOS_MIGRATED_REVID=122635220
* LoadingProgressReceiver: provide pending packagesGravatar Klaus Aehlig2016-05-19
| | | | | | | | | | When reporting on the progress state while loading packages, also report the number of packages currently being loaded simultaneously. -- Change-Id: I5e46c6f392e1e583b752560878f4c42c160f12d2 Reviewed-on: https://bazel-review.googlesource.com/#/c/3643 MOS_MIGRATED_REVID=122632188
* Fix Windows issue in Path.getRelative, which wasn't handling backslashes.Gravatar Ulf Adams2016-05-19
| | | | | -- MOS_MIGRATED_REVID=122627792
* Precompute Label#hashCode and use it to implement a fast-path for #equals. ↵Gravatar Nathan Harmata2016-05-19
| | | | | | | | | Label#equals was a cpu hotspot revealed during profiling. The additional field for the precomputed hash code has no memory cost since each Label instance was already wasting 4 bytes due to object alignment requirements. -- MOS_MIGRATED_REVID=122626707
* Rollback of commit e37c55eccbd4516b2db7aaf58ef95209dfad3ed4.Gravatar Ulf Adams2016-05-19
| | | | | -- MOS_MIGRATED_REVID=122626656
* Turn the addition of -fPIC to the command line of PIC actions into a feature.Gravatar Lukacs Berki2016-05-19
| | | | | | | This is a resubmission of commit 45d48bf1fe7503acbbb0c095822b7f8f558881e8. It turns out that we also need -fPIC for *assembler* command line options, because some assembler sources are preprocessed and they can say "#ifdef __PIC__". -- MOS_MIGRATED_REVID=122626234
* Rollback of commit b8946eabd60a199a66a1892701d52d9801c7fb1a.Gravatar Ulf Adams2016-05-18
| | | | | -- MOS_MIGRATED_REVID=122620007
* Handle b+.{2}+{3,4} qualifiers, as well as mobile country code and mobile ↵Gravatar Googler2016-05-18
| | | | | | | network code qualifiers. -- MOS_MIGRATED_REVID=122591469
* Fix bug in lazy removal of reverse deps -- there was one remaining case ↵Gravatar Janak Ramakrishnan2016-05-18
| | | | | | | where we weren't checking to see if a reverse dep already existed when we declared a reverse dep. -- MOS_MIGRATED_REVID=122581019
* Add || true to increment so test doesn't exit earlyGravatar Kristina Chodorow2016-05-17
| | | | | | | | | The test is run with -e, so when ((wait_seconds++)) returns 1, it exits. This fixes #1271. -- MOS_MIGRATED_REVID=122567259
* Add a way to set USES_SWIFT flag from Skylark.Gravatar Dmitry Shevchenko2016-05-17
| | | | | | | RELNOTES: new_objc_provider can now set the USES_SWIFT flag. -- MOS_MIGRATED_REVID=122566589
* Remove reverse deps lazily, only when the node has finished building and we ↵Gravatar Janak Ramakrishnan2016-05-17
| | | | | | | | | | | discover that it no longer has certain deps. In the common case, where a node's deps do not change in the end, this reduces lock contention and CPU. The downside of this is that we now create a set of the previous reverse deps during each evaluation of a node. We don't store this set in order to conserve memory, so we pay for it in CPU. We will probably only construct it two or three times (most SkyFunctions don't have so many groups), so the cost shouldn't be so high, but we can try to mitigate if it shows up in profiling. -- MOS_MIGRATED_REVID=122566267
* Thread through a map of the attributes which we have serialized into ↵Gravatar Shreya Bhattarai2016-05-17
| | | | | | | postProcess(). -- MOS_MIGRATED_REVID=122542545
* Remove extraneous space added by commit 5e34a3d4ea30525971e320ce283ba8cd67c74e3cGravatar Nathan Harmata2016-05-17
| | | | | -- MOS_MIGRATED_REVID=122542339
* Batch package retrieval for rbuildfiles so that even if a single file has a ↵Gravatar Janak Ramakrishnan2016-05-17
| | | | | | | large number of rbuildfile dependencies, we retrieve them in batches of at most BATCH_CALLBACK_SIZE. -- MOS_MIGRATED_REVID=122540401
* Remove unnecessary aspect CC bloat.Gravatar Googler2016-05-17
| | | | | | | | | | | * Do not include cc info for non-C rules * Omit exported headers (unused on the IDE side) This CL reduces aspect output size (and memory footprint) by ~50MB for an example real-life project. -- MOS_MIGRATED_REVID=122537339
* Switch the qualifier parsing to use FolderConfiguration. There is some extra ↵Gravatar Googler2016-05-17
| | | | | | | processing due to the missing support for ll-{3,4}, which should be removed with the android-ide-common update. -- MOS_MIGRATED_REVID=122536342
* Cleanup swift.bzl.Gravatar Dmitry Shevchenko2016-05-17
| | | | | | | | | Removes an old code path that is not relevant anymore. RELNOTES: -- MOS_MIGRATED_REVID=122534499
* Fix compilation with JDK7Gravatar Alpha Lam2016-05-17
| | | | | | | | | Add a final keyword to make java compiler happy. -- Change-Id: If44881164d4e3e2485d0e7dc8074ca7171a6ceb6 Reviewed-on: https://bazel-review.googlesource.com/c/3630/ MOS_MIGRATED_REVID=122529756
* Support top-level packages in pkg_tarGravatar Kristina Chodorow2016-05-17
| | | | | | | | | | | | | Previously, _short_path_dirname would take a short path like "libfoo.jar", rfind would return -1, sp[:-1] would return "libfoo.ja", and then _dest_path would strip that prefix off of "libfoo.jar", leaving just "r". Also added some unit tests for these functions. Fixes #1253. -- MOS_MIGRATED_REVID=122527723
* Rollback of commit 45d48bf1fe7503acbbb0c095822b7f8f558881e8.Gravatar Lukacs Berki2016-05-17
| | | | | | | | | | | | | *** Reason for rollback *** Breaks //[]/go:all . *** Original change description *** Turn the addition of -fPIC to the command line of PIC actions into a feature. -- MOS_MIGRATED_REVID=122526799
* Add Skylark tests for intellij_info.bzlGravatar Dmitry Lomov2016-05-17
| | | | | | | This add a "testing framework" and reimplements first two tests from AndroidStudioInfoAspectTest. -- MOS_MIGRATED_REVID=122523803
* Improve progress message of the actions triggered by --precompile_python.Gravatar Googler2016-05-17
| | | | | | | | Typical output looks like: Compiling Python my/package/module.py -- MOS_MIGRATED_REVID=122522202
* Make the rule in the workspace package reference the correct Package object.Gravatar Lukacs Berki2016-05-17
| | | | | | | Fixes #1228. -- MOS_MIGRATED_REVID=122511655
* Add rule_or_page#heading syntax to RuleLinkExpander and support for expandingGravatar David Chen2016-05-17
| | | | | | | | | | rule_name_implicit_outputs. This change adds support for new syntax for referencing a heading for a rule or static BE page. -- MOS_MIGRATED_REVID=122509323
* Add -headerpad_max_install_names to darwin CROSSTOOL linker flags.Gravatar David Chen2016-05-17
| | | | | | | Fixes #1269 -- MOS_MIGRATED_REVID=122502116
* Turn the addition of -fPIC to the command line of PIC actions into a feature.Gravatar Lukacs Berki2016-05-17
| | | | | -- MOS_MIGRATED_REVID=122498464
* Add attribute to android binaries to explicitly control incremental dexing.Gravatar Googler2016-05-17
| | | | | -- MOS_MIGRATED_REVID=122473346
* Fix for combining resources so that the transitive, direct, and primary ↵Gravatar Googler2016-05-17
| | | | | | | | | | | | | | | | resources are combined for the primary writing. Example: transitive resource: styleable/RubADubDub has an attr of butcher direct resource: styleable/RubADubDub has an attr of baker primary resource: styleable/RubADubDub has an attr of candlestickmaker The merged resources should have: transitive resource: <no matching key> primary resource: styleable/RubADubDub has attrs of butcher, baker, candlestickmaker -- MOS_MIGRATED_REVID=122453026
* Export Objective-C header from swift_library.Gravatar Dmitry Shevchenko2016-05-17
| | | | | | | | | * Switches the rule to output to genfiles/, this makes C-headers it produces importable by depending targets. RELNOTES: swift_library now generates an Objective-C header for its @objc interfaces. -- MOS_MIGRATED_REVID=122448949
* Fix maven_jar documentation to use to the correct repository nameGravatar Kristina Chodorow2016-05-17
| | | | | | | Fixes #1230. -- MOS_MIGRATED_REVID=122439376
* Make AarGeneratorAction deterministic by zeroing zip entry timestamps.Gravatar Nicholas Lativy2016-05-17
| | | | | | | | ZipOutputStream#putNextEntry(ZipEntry) sets the modification time to the current time if no time is set on the ZipEntry passed to it. -- MOS_MIGRATED_REVID=122436300
* Add deprecation warning for --objc_generate_debug_symbols.Gravatar Dmitry Shevchenko2016-05-17
| | | | | | | RELNOTES: --objc_generate_debug_symbols is now deprecated. -- MOS_MIGRATED_REVID=122432600
* Adds information about resources referenced from AndroidManifest.xml toGravatar Alex Humesky2016-05-17
| | | | | | | the apk manifest. -- MOS_MIGRATED_REVID=122431761
* Always unzip paths ending in / as directoriesGravatar Kristina Chodorow2016-05-17
| | | | | | | | | | | | | Does file type mean nothing to people? Fixes #1263, also made some code hygiene improvements: * Added some tests. * Broke a java_test out of lib/BUILD. * Renamed ZipFunction so it doesn't look like a child of SkyFunction. -- MOS_MIGRATED_REVID=122431322
* Release 0.2.3 (2016-05-10)Gravatar Bazel Release System2016-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Baseline: 5a2dd7a Incompatible changes: - All repositories are now directly under the x.runfiles directory in the runfiles tree (previously, external repositories were at x.runfiles/main-repo/external/other-repo. This simplifies handling remote repository runfiles considerably, but will break existing references to external repository runfiles. Furthermore, if a Bazel project does not provide a workspace name in the WORKSPACE file, Bazel will now default to using __main__ as the workspace name (instead of "", as previously). The repository's runfiles will appear under x.runfiles/__main__/. - Bazel does not embed protocol buffer-related rules anymore. - It is now an error for a cc rule's includes attribute to point to the workspace root. - Bazel warns if a cc rule's includes attribute points out of third_party. - Removed cc_* attributes: abi / abi_deps. Use select() instead. New features: - select({"//some:condition": None }) is now possible (this "unsets" the attribute). Important changes: - java_import now allows its 'jars' attribute to be empty. - adds crunch_png attribute to android_binary - Replace --java_langtools, --javabuilder_top, --singlejar_top, --genclass_top, and --ijar_top with java_toolchain.{javac,javabuilder,singlejar,genclass,ijar} - External repository correctness fix: adding a new file/directory as a child of a new_local_repository is now noticed. - iOS apps are signed with get-task-allow=1 unless building with -c opt. - Generate debug symbols (-g) is enabled for all dbg builds of objc_ rules. - Bazel's workspace name is now io_bazel. If you are using Bazel's source as an external repository, then you may want to update the name you're referring to it as or you'll begin seeing warnings about name mismatches in your code. - Fixes integer overflow in J2ObjC sources to be Java-compatible. - A FlagPolicy specified via the --invocation_policy flag will now match the current command if any of its commands matches any of the commands the current command inherits from, as opposed to just the current command. - The key for the map to cc_toolchain_suite.toolchains is now a string of the form "cpu|compiler" (previously, it was just "cpu"). - Fix interaction between LIPO builds and C++ header modules. - Ctrl-C will now interrupt a download, instead of waiting for it to finish. - Proxy settings can now be specified in http_proxy and https_proxy environment variables (not just HTTP_PROXY and HTTPS_PROXY). - Skylark targets can now read include directories from ObjcProvider. - Expose parameterized aspects to Skylark. - Support alwayslink cc_library dependencies in objc binaries. - Import cc_library dependencies in generated Xcode project.
* Trim whitespace off of wc resultGravatar Kristina Chodorow2016-05-16
| | | | | | | Apparently Darwin's wc has a slightly different format. Fixes #1267. -- MOS_MIGRATED_REVID=122419982
* Prototype for remote execution using gRPC and Netty transportGravatar Alpha Lam2016-05-16
| | | | | | | | | | | | | | | | | | | This change implements a remote worker that executes work (build or test). Bazel will be a client of the remote worker. The communication uses gRPC and Netty as transport. A single remote worker has little advantage over running locally. Additional infrastructure is needed to run workers on multiple machines and distributing the work among them. This change provides the basic building blocks for a distributed build farm. (Mainly reformatting changes compared to https://bazel-review.googlesource.com/3110, some BUILD file changes.) -- Change-Id: If7d285444ef42a6823b59443af17b61b04b9ce6a Reviewed-on: https://bazel-review.googlesource.com/#/c/3110/ MOS_MIGRATED_REVID=122376861
* Memory Optimizations:Gravatar Googler2016-05-16
| | | | | | | | * Cache the FullyQualifiedName instances. Due to a very high number of duplicated resource keys, all FullyQualifiedNames should be effectively interned. * Presume xliff in all resources. Inlining the xmlns is a bit costly. -- MOS_MIGRATED_REVID=122375955
* Honor a whitelist of dx flags in incremental dexingGravatar Googler2016-05-16
| | | | | -- MOS_MIGRATED_REVID=122342484
* Adds configuration fragment requirements for intellij_info_aspect.Gravatar Michael Staib2016-05-16
| | | | | | | | | | | | | In the near future, aspect RuleContexts will enforce that they only access the configuration fragments they have declared as required, in order to prepare for the eventual migration to dynamic configurations (where only configuration fragments which are actually necessary for a particular build are loaded for that build). This change adds those declarations to intellij_info_aspect. -- MOS_MIGRATED_REVID=122337003
* Global cleanup change.Gravatar Googler2016-05-16
| | | | | -- MOS_MIGRATED_REVID=122312325
* Adds configuration fragment requirements for AndroidNeverlinkAspect.Gravatar Michael Staib2016-05-16
| | | | | | | | | | | | | In the near future, aspect RuleContexts will enforce that they only access the configuration fragments they have declared as required, in order to prepare for the eventual migration to dynamic configurations (where only configuration fragments which are actually necessary for a particular build are loaded for that build). This change adds those declarations to AndroidNeverlinkAspect. -- MOS_MIGRATED_REVID=122296909
* Adds configuration fragment requirements for J2ObjcAspect.Gravatar Michael Staib2016-05-16
| | | | | | | | | | | | | In the near future, aspect RuleContexts will enforce that they only access the configuration fragments they have declared as required, in order to prepare for the eventual migration to dynamic configurations (where only configuration fragments which are actually necessary for a particular build are loaded for that build). This change adds those declarations to J2ObjcAspect. -- MOS_MIGRATED_REVID=122296270