aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Remove unused "extraPrecomputedValues" from WorkspaceBuilder, and therefore ↵Gravatar janakr2017-09-25
| | | | | | | | remove all "precomputed values for analysis" from SkyframeExecutor. We use SkyframeExecutor#injectExtraPrecomputedValues these days. This simplifies logic around when to inject precomputed values, and makes the graph more consistent. PiperOrigin-RevId: 169733304
* Remove BuildInfoFactory precomputed value.Gravatar janakr2017-09-25
| | | | PiperOrigin-RevId: 169728184
* Stop the transitive duplication of FilesetTraversalParams when Filesets are ↵Gravatar kush2017-09-25
| | | | | | | nested. RELNOTES: None PiperOrigin-RevId: 169723791
* Remove product name precomputed value.Gravatar janakr2017-09-25
| | | | PiperOrigin-RevId: 169723724
* Fix error-prone warning on AndroidBinaryTest.Gravatar ajmichael2017-09-25
| | | | | | | | | The test was not incorrect before, however it was unfortunate that we were both expecting an AssertionError and also throwing an AssertionError to signal that no AssertionError was thrown. RELNOTES: None PiperOrigin-RevId: 169721076
* Remove dependence on compilation attributes (e.g. 'srcs') for apple_binary ↵Gravatar cparsons2017-09-25
| | | | | | | | | and apple_static_library in objc unit tests. These attributes are deprecated and being removed. RELNOTES: None. PiperOrigin-RevId: 169720318
* Remove PrecomputedValue for BlazeDirectories. All consumers have the value ↵Gravatar janakr2017-09-25
| | | | | | | | injected directly, which makes sense, because it's immutable over the lifetime of the server. Step 3. PiperOrigin-RevId: 169717587
* Allow alternate GroupedList constructor to be public, but add warnings ↵Gravatar shreyax2017-09-25
| | | | | | regarding the integrity of the structure to various operations. PiperOrigin-RevId: 169715233
* Inject BlazeDirectories into RepositoryDelegatorFunction directly, instead ↵Gravatar janakr2017-09-25
| | | | | | | | of depending on a precomputed value. BlazeDirectories don't change over the lifetime of the Blaze server, and certainly not over the lifetime of a SkyframeExecutor instance, which already had a reference to them. Step 2. PiperOrigin-RevId: 169711443
* Update doc: there is no default value for --jobs.Gravatar Googler2017-09-25
| | | | PiperOrigin-RevId: 169710801
* Inject BlazeDirectories into FdoSupportFunction directly, instead of ↵Gravatar janakr2017-09-25
| | | | | | | | depending on a precomputed value. BlazeDirectories don't change over the lifetime of the Blaze server, and certainly not over the lifetime of a SkyframeExecutor instance, which already had a reference to them. The goal is getting rid of the precomputed value entirely, but since this change necessitated a fair number of testing changes, I'm mailing this out as a first step. PiperOrigin-RevId: 169705474
* Update the Bazel iOS tutorial to pull the latest Apple build rules.Gravatar Googler2017-09-25
| | | | PiperOrigin-RevId: 169698060
* Update travis setup instructionsGravatar Siddhartha Bagaria2017-09-25
| | | | | | | | | | Travis now (since Aug 2017) has trusty as the default image for both VM and container, on which the bazel apt repo can be used and so compiling from source is not needed. See working example at https://github.com/grailbio/rules_r/blob/master/.travis.yml Closes #3781. PiperOrigin-RevId: 169695984
* Create AndroidManifest.xml symlink if user provides a manifest not namedGravatar jingwen2017-09-25
| | | | | | | | | | "AndroidManifest.xml". aapt requires the manifest to be named "AndroidManifest.xml" (unknown commit) This allows users to provide manifests with custom names. RELNOTES: Android rules no longer restrict the manifest file to be named "AndroidManifest.xml". PiperOrigin-RevId: 169695062
* Contingent on a flag --experimental_objc_provider_from_linked, apple_binary ↵Gravatar cparsons2017-09-25
| | | | | | | and apple_static_library no longer propagate ObjcProvider. RELNOTES: None. PiperOrigin-RevId: 169690934
* Don't emit an undeclared outputs MANIFEST if there are no files.Gravatar Googler2017-09-25
| | | | | | | Tested manually (with a test that doesn't emit undeclared outputs), and added a test that failed before and passes after the test-setup.sh change. RELNOTES: N/A PiperOrigin-RevId: 169687782
* Use FeatureConfiguration to compute linkstamping compile command lineGravatar hlopko2017-09-25
| | | | | | | | | Before, linkstamping compile actions were hardcoded in bazel and assumed gcc/clang and bash. This cl removes gcc/clang assumptions by using feature configuration. RELNOTES: None. PiperOrigin-RevId: 169685949
* Improve style in SkylarkMutableTestGravatar brandjon2017-09-25
| | | | | RELNOTES: None PiperOrigin-RevId: 169676866
* Automated rollback of commit 17214ac78ffaec369d5d5bafe62a39730473cfaa.Gravatar dslomov2017-09-22
| | | | | | | | | | | | | | | | | | *** Reason for rollback *** Rolled back commit enforces stricter parameter checks. Will fix and roll forward This creates several failures on the nightly build of Bazel: ERROR: /home/ci/workspace/Global/rules_closure-node=linux-x86_64/closure/protobuf/test/BUILD:23:1: no such package '@com_google_protobuf_protoc//': Cannot convert parameter 'url' to type string or sequence of strings, in method download_and_extract(List, string, string, string, string) of 'repository_ctx' and referenced by '//closure/protobuf/test:example_proto_gen'. ERROR: Analysis of target '//closure/protobuf/test:example_lib' failed; build aborted: no such package '@com_google_protobuf_protoc//': Cannot convert parameter 'url' to type string or sequence of strings, in method download_and_extract(List, string, string, string, string) of 'repository_ctx'. *** Original change description *** Check parameter types for methods when multiple types are allowed. Fixes #3714 RELNOTES: None. PiperOrigin-RevId: 169669802
* Add a global failure when a test is interrupted/cancelled.Gravatar elenairina2017-09-22
| | | | | | | | | | | When a timeout occurred, the current test case is interrupted and the others are cancelled. This was not reflected in any way and all tests were reported as success, even if there was a timeout and the tests were cancelled/interrupted. Also add a status xml attribute to mark if the test was completed, cancelled or interrupted. Fixes #3763 RELNOTES: None. PiperOrigin-RevId: 169665622
* docker_pull: rely on the main repository docker_buildGravatar Damien Martin-Guillerez2017-09-22
| | | | | | | | | | | | | The legacy docker_build was removed from bazel_tools but we need to use it for our integration test so refer to the one in the main repository. Also restore the visibility, just excluding it from bazel_tools is enough and docker_pull needs to call it from other repository. Change-Id: I8a8a5781859960030ae996db95fbaf9c54ec596a PiperOrigin-RevId: 169664916
* Move SpawnResult from build.lib.exec into build.lib.actions so that e.g. ↵Gravatar ruperts2017-09-22
| | | | | | | build.lib.actions.SpawnActionContext can import SpawnResult without creating a cyclic dependency. RELNOTES: None. PiperOrigin-RevId: 169642267
* Internal changeGravatar tomlu2017-09-22
| | | | PiperOrigin-RevId: 169631693
* Use fail() in tests to catch missing expected exceptions.Gravatar ruperts2017-09-22
| | | | | RELNOTES: None. PiperOrigin-RevId: 169624979
* Action for resource shrinking with aapt2Gravatar corysmith2017-09-22
| | | | | | | Introduces the ResourcesZip class to more easily handle processing merged resources. RELNOTES: None PiperOrigin-RevId: 169622715
* Add toString() methods for Advertised and Required Providers.Gravatar Googler2017-09-22
| | | | | RELNOTES: None. PiperOrigin-RevId: 169582778
* Add more thorough error reporting behavior for when config_setting has ↵Gravatar juliexxia2017-09-22
| | | | | | multiple constraint_values from the same constraint_setting (re: #350) PiperOrigin-RevId: 169577576
* PiperOrigin-RevId: 169563607Gravatar kmb2017-09-22
|
* Remove unncessary duplication of zipper target.Gravatar xingao2017-09-22
| | | | PiperOrigin-RevId: 169563077
* Include all test output files (e.g. undeclared outputs) for non-cached test ↵Gravatar Googler2017-09-22
| | | | | | | | | | | | | | executions and tests with multiple attempts. Previously, non-cached test execution would incorrectly only include test.log and test.xml. Implement this by unifying test output list building in a static TestResult method. For additional output files in multi-attempt tests, we follow the existing convention: Existing example: test.xml => test_attempts/attempt_N.xml New example (all new outputs done similarly): test.outputs/outputs.zip => test_attempts/attempt_N.outputs/outputs.zip RELNOTES: All test output files included for cached, uncached, and multiple attempt tests. PiperOrigin-RevId: 169556608
* CI,Windows: run //third_party/def_parser testsGravatar László Csomor2017-09-22
| | | | | | | Fixes https://github.com/bazelbuild/bazel/issues/3742 Change-Id: Ibfa1909e387e9734040b00523cc9388a386e0bf4 PiperOrigin-RevId: 169538023
* Increase the timeout for Bazel SkylarkTests to "long"Gravatar vladmos2017-09-21
| | | | | | | | | | The tests have become large so that the default 5 minutes timeout is no longer enough for them. At the same point it doesn't look that the test requires more resources, just a longer timeout. Fixes #3774 PiperOrigin-RevId: 169532333
* Skylint: add flag to disable certain checkers.Gravatar fzaiser2017-09-21
| | | | | RELNOTES: none PiperOrigin-RevId: 169518230
* Track the origin of an option in the option instance, not its final value.Gravatar ccalvarin2017-09-21
| | | | | | | | | A single instance of an option has a single origin, but the final value only has a single origin if it has a single value. For multi-valued options, it is wrong to expect that the final value of an option will have a single parent. Track the option parents (which option expanded to the current instance, if any) in the right place, with the ParsedOptionDescription. Also fix some inconsistent spelling of 'dependent,' in favor of the American English standard. RELNOTES: None. PiperOrigin-RevId: 169487515
* Deprecate wrapperOptions.Gravatar ccalvarin2017-09-21
| | | | | | | In order to discourage new uses (there shouldn't be any, but just in case), make it illegal to set wrapperOption=true for non deprecated options. RELNOTES: None. PiperOrigin-RevId: 169477990
* Track all option instances.Gravatar ccalvarin2017-09-21
| | | | | | | Regardless of option type, have the OptionValueDescription track information about the parsed option. This does not yet change the values that we output as part of the GotOptionsEvent, as the expansion, implicit req, and wrapper options still don't actually track anything in their option value. RELNOTES: None. PiperOrigin-RevId: 169469793
* Cleanup of expansion option namingGravatar ccalvarin2017-09-21
| | | | | | | | | Options that expand to other options are expansion options and the options they expand to have values that were expansions. This can be a bit confusing. Removes the isExpansion() call that is somewhat ambiguous, and forces option users to explicitly check the option definition for this information. Also provide a parallel boolean function for implicit requirements, so that we stop querying for the length of the implicit requirement all over the place. RELNOTES: None. PiperOrigin-RevId: 169461566
* Allow config_settings to match on constraint_values to a target_platform. ↵Gravatar juliexxia2017-09-21
| | | | | | This is on the way to making select() work with constraint_values re: #305. PiperOrigin-RevId: 169454982
* Move aspect resolution out of ConfiguredTargetFunction.Gravatar gregce2017-09-21
| | | | | | Part of the effort to simplify ConfiguredTargetFunction. PiperOrigin-RevId: 169453435
* Create multiple ParamsFilePreProcessors to allow parsing files using the ↵Gravatar apell2017-09-21
| | | | | | | formats specified in ParameterFile.ParameterFileType. Also maintain the currently used parsing style of whitespace split arguments that allows single and double quoting and whitespace and quote escaping. This style of parsing is for a format not currently generated and will be removed once all consuming actions have been converted to using a supported format explicitly. RELNOTES: None. PiperOrigin-RevId: 169437362
* This time for sure: stop using --undefined dynamic_lookup in osx linking.Gravatar Googler2017-09-21
| | | | | | | | | | For the time being, all C++ links will provide ObjC core libraries on the command line, via having the link actions imply 'contains_objc_sources', which is a built-in feature that is in the process of being enabled automatically when objective-C/C++ sources are involved in the build. Once that happens, the 'imply' directives will be removed. RELNOTES: Stop using --undefined dynamic_lookup in Apple links. Enables unresolved symbol errors. PiperOrigin-RevId: 169437020
* Add a constraint_values attribute and a target platforms attribute to the ↵Gravatar juliexxia2017-09-21
| | | | | | | | configsetting rule class. This is a step in the process of integrating platforms with selects and works towards fixing #350. Also allow the host platform to be empty/nullable to support clients without access to its default settings. PiperOrigin-RevId: 169436155
* Move --build_python_zip into PythonConfiguration.Gravatar mstaib2017-09-21
| | | | | | | | There's no need for it in the core configuration options, as it's used exclusively by Python rules. RELNOTES: None. PiperOrigin-RevId: 169435643
* remove long-deprecated incremental dexing flag that has no effectGravatar kmb2017-09-21
| | | | | | RELNOTES: remove unused --host_incremental_dexing flag PiperOrigin-RevId: 169433775
* Removing deprecated field total_input_file_count.Gravatar olaola2017-09-21
| | | | | | | | | See API Revisions design doc: https://docs.google.com/document/d/12c3oAPgedckLpue2yj0xGgJTEOyUm4mXWWBJ157J-8I/edit#heading=h.llz6ymkp07b1 The BuildInfo is now sent via RequestMetadata. TESTED=we never used this field PiperOrigin-RevId: 169432884
* Skylint: be less strict about indentation in docstringsGravatar fzaiser2017-09-21
| | | | | | | | | | | | Instead of enforcing two spaces of indentation, we now only enforce a positive number of spaces in indented lines. Reason: Apparently, a lot of docstrings in Skylark files are badly indented, so we should only warn about the worst offenders until a formatting tool is available. RELNOTES: none PiperOrigin-RevId: 169429429
* Delete ios_application, ios_extension(_binary), objc_binary.Gravatar allevato2017-09-21
| | | | PiperOrigin-RevId: 169428146
* PiperOrigin-RevId: 169422401Gravatar Googler2017-09-21
|
* Add ability to write param files to disk.Gravatar tomlu2017-09-21
| | | | PiperOrigin-RevId: 169418286
* Fix unittest.bash to get the correct TEST_script path.Gravatar John Cater2017-09-21
| | | | | Change-Id: Ia250c322353638928747d99fbfdb62808a2fd838 PiperOrigin-RevId: 169417597
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 11:47:18 +0000