| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
| |
AbstractSpawnRunner now uses a SpawnCache if one is registered, this allows
adding caching to any spawn runner without having to be aware of the
implementations.
I will delete the old CachedLocalSpawnRunner in a follow-up CL.
PiperOrigin-RevId: 165024382
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 165015884
|
|
|
|
|
| |
RELNOTES:
PiperOrigin-RevId: 165012363
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 165012084
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 165010750
|
|
|
|
|
|
| |
RELNOTES[NEW]: There is now a 'siblings' query function. See the query documentation for more details.
PiperOrigin-RevId: 165010653
|
|
|
|
|
|
|
|
|
| |
https://github.com/bazelbuild/bazel/commit/21436e062a12b64c8bee665b0cf79dfe48cff114.
That change broke module maps that depended on the transitive headers from ObjC protos.
RELNOTES: None
PiperOrigin-RevId: 165010275
|
|
|
|
| |
PiperOrigin-RevId: 165003777
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tags associated with a rule is information that
is useful as information about the target, independent
of the configuration. At the moment, tags cannot be
configuration-dependent anyway, but even if the extend
bazel it that way, the union of all possible tags is
still useful information.
Change-Id: Iabca0c28b0da4b13b8a62b2638a881c53cc70ccc
PiperOrigin-RevId: 164996472
|
|
|
|
|
|
|
|
| |
This takes advantage of CustomCommandLine's ability to defer argument expansion. I can't think of any situation where this would be inferior, at it also cleans up the code a little.
After the execution phase when Artifact strings will have been prodded and interned, I expect the memory difference to be less pronounced.
PiperOrigin-RevId: 164996323
|
|
|
|
|
|
|
| |
By using generics we can help the user ensure that they pass a map function of the right type.
RELNOTES: None
PiperOrigin-RevId: 164984415
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All resource types should be supported by PlaceholderIdFieldInitializerBuilder.
Will keeping the ordering from the previous scheme, ensure that all of the
contents of ResourceType.values() are considered. This means that, when adding
new resource types, only updating the ResourceType enum is needed.
A previous attempt at this change tried eliminating the special ordering of
resource types entirely, on the grounds that it shouldn't be needed. However,
strange build failures mean we're keeping it there for now.
RELNOTES: none
PiperOrigin-RevId: 164983075
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 164981071
|
|
|
|
|
|
| |
These only had usages in test code. The tests could be altered to use other methods.
PiperOrigin-RevId: 164977900
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
state.
A remote cache must never serve a failed action. However, if it did
Bazel would not detect this and simply fail and display an error message
that's hard to distinquish from a local execution failure.
Bazel now displays a clear error message stating what went wrong.
RELNOTES: None.
PiperOrigin-RevId: 164975631
|
|
|
|
|
|
|
|
|
|
| |
Some information about a target is configuration independent and therefore can
already be provided at a target level (i.e., in the TargetConfigured event). Do
so, to have that information available earlier and, once the deprecation period
is over, avoid redundant information in the stream.
Change-Id: I8021ce3dd2a8168d409ea513190c4e3a349dbc2f
PiperOrigin-RevId: 164967059
|
|
|
|
|
|
|
|
|
|
|
| |
executor, remote cache and local executor errors.
This is a no-op refactoring and clears the way to integrate a change
that no longer uploads to the remote cache if a previous remote cache
interaction failed.
RELNOTES: None.
PiperOrigin-RevId: 164966432
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the persistent worker spawn strategy to extend
AbstractSpawnStrategy and put the actual logic into
WorkerSpawnRunner. WorkerTestStrategy is unaffected.
I had to extend SpawnPolicy with a speculating() method. Persistent
workers need to know if speculation is happening in order to require
sandboxing.
Additionally, I added java_test rules for the local runner tests and
worker tests. See https://github.com/bazelbuild/bazel/issues/3481.
NOTE: ulfjack@ made some changes to this change before merging:
- changed Reporter to EventHandler; added TODO about its usage
- reverted non-semantic indentation change in AbstractSpawnStrategy
- reverted a non-semantic indentation change in WorkerSpawnRunner
- updated some internal classes to match
- removed catch IOException in WorkerSpawnRunner in some cases,
removed verboseFailures flag from WorkerSpawnRunner, updated callers
- disable some tests on Windows; we were previously not running them,
now that we do, they fail :-(
Change-Id: I207b3938f0dc84d374ab052d5030020886451d47
PiperOrigin-RevId: 164965398
|
|
|
|
| |
PiperOrigin-RevId: 164963238
|
|
|
|
| |
PiperOrigin-RevId: 164961564
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux-sandbox has a useful option -R, that runs the spawn as fake
root. However, it's not exposed to Bazel rules. Here, we do that via
the "requires-fakeroot" tag.
One possible usecase: In combination with "block-network",
"requires-fakeroot" makes it possible to integration test services
that insist on listening on privileged ports.
Unsurprisingly, this is incompatible with --sandbox_fake_username.
Change-Id: I9e8ab4d4abf0e45626e005ff21f73e6c17de0788
PiperOrigin-RevId: 164961019
|
|
|
|
|
|
|
| |
...instead of injecting it through the constructor. Simplify all the callers
accordingly.
PiperOrigin-RevId: 164955391
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It can only pack to zip for now (packing to tar is
not trivial and I haven't figured it out yet).
This allows building //:bazel-distfile on Windows.
Previously it was either timing out or taking so
long that it was unbearable (over 10 minutes).
I never waited long enough to see it build.
The new Python version runs under just a few
seconds.
Change-Id: I3264eb7132dd58c581c4216e5bbab035a79d716d
PiperOrigin-RevId: 164954162
|
|
|
|
|
|
|
|
|
| |
We'll use the extracted functions in the upcoming
Python-based reincarnation of the
//:bazel-distfile rule.
Change-Id: I5140938ae4af50f62fb695b5b96cd41f3cd939ef
PiperOrigin-RevId: 164950515
|
|
|
|
|
|
| |
RELNOTES: speedup of incremental dexing tools
PiperOrigin-RevId: 164926895
|
|
|
|
|
|
| |
action actually executed.
PiperOrigin-RevId: 164917959
|
|
|
|
|
|
|
| |
Fixes #3072
RELNOTES: None
PiperOrigin-RevId: 164906305
|
|
|
|
|
| |
RELNOTES:None
PiperOrigin-RevId: 164903310
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 164899416
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 164893252
|
|
|
|
|
|
|
| |
libraries.
RELNOTES: None
PiperOrigin-RevId: 164893197
|
|
|
|
| |
PiperOrigin-RevId: 164892826
|
|
|
|
|
|
|
|
|
|
| |
ConfigurationFactory.
This is a prerequisite to removing ConfigurationFactory (which is only used for static configurations). We still need List<ConfigurationFragmentFactory> to supply ConfigurationFragmentFunction.
Eventually even that will go away (for fully trimmed builds). But we're not there yet.
PiperOrigin-RevId: 164890139
|
|
|
|
|
|
| |
thinning is enabled.
PiperOrigin-RevId: 164884344
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 164884056
|
|
|
|
|
|
|
|
|
|
| |
Refactorings:
* Change data binding to have configurable archive generation
* Extract a ZipBuilder class from the ZipBuilderVisitor to provide a general purpose archiving class.
* Small changes to visibility AaptCommandLineBuilder for reuse in the aapt2 code.
RELNOTES: None
PiperOrigin-RevId: 164880571
|
|
|
|
|
| |
RELNOTES: The `print` function now prints debug messages instead of warnings.
PiperOrigin-RevId: 164880003
|
|
|
|
|
|
|
|
|
| |
Apart from updating CustomCommandLineTest this CL is entirely automated.
We also sneak in a rename of addFormat -> addFormatted.
RELNOTES: None
PiperOrigin-RevId: 164870140
|
|
|
|
|
|
|
|
|
|
|
| |
This isn't ideal, but is the fastest way to split analysis, execution, and
rules into separate java libraries, with lib.skyframe still being in the
analysis library. Ideally, we'd split up the lib.skyframe package, move the
analysis stuff to the analysis library, the execution stuff to the execution
library, and so on. That wouldn't require us moving OutputService out of
lib.exec.
PiperOrigin-RevId: 164856998
|
|
|
|
| |
PiperOrigin-RevId: 164850909
|
|
|
|
|
|
|
|
| |
Fixes #3055.
RELNOTES: `bazel info output_path` no longer relies on the root directory
filename being equal to the workspace name.
PiperOrigin-RevId: 164847833
|
|
|
|
|
|
|
|
| |
These are depended upon by analysis code, so need to live in the same library
as lib.analysis. Moving them here makes it possible to split the build-base
library into separate libraries for analysis, execution, and rules.
PiperOrigin-RevId: 164847161
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use $(location) to get the unittest.bash script, which allows this test to also
run with a different label prefix. This involves removing the intermediate
testenv.sh script, which doesn't seem to add much value.
We might want to consider a sh_unit_test rule or macro that has an implicit
dependency on the unittest.bash script and doesn't require every test to do
this manually.
PiperOrigin-RevId: 164846477
|
|
|
|
| |
PiperOrigin-RevId: 164844520
|
|
|
|
|
|
|
| |
This reverts commit 1fb46ce05bb6423d9064b8d274e7be601f16a49f.
Trying again.
Closes https://github.com/bazelbuild/bazel/pull/3363
|
|
|
|
|
|
|
| |
Fixes #3522.
Change-Id: I41e0498ccf351f6ce57da4cfe1ef84d5567e6315
PiperOrigin-RevId: 164839897
|
|
|
|
|
|
|
| |
All prefetching now goes through AbstractSpawnStrategy's implementation of
SpawnExecutionPolicy. Make sure the sandbox runners also do this consistently.
PiperOrigin-RevId: 164836877
|
|
|
|
|
|
|
| |
This is part of splitting up the build-base library into separate libraries for
analysis, exec, and rules.
PiperOrigin-RevId: 164835678
|
|
|
|
|
|
|
|
| |
Zip files are always opened in binary mode and the
ctor doesn't accept "b" in the mode string.
RELNOTES: none
PiperOrigin-RevId: 164832193
|
|
|
|
|
|
|
| |
crosstool
RELNOTES: None.
PiperOrigin-RevId: 164830825
|