aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Automated g4 rollback of commit c4134802dd15d6ef5cca6521f6bf6aac395ee2ad.Gravatar kchodorow2017-05-23
| | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Roll forward of directory name change *** Original change description *** Automated g4 rollback of commit 1d9e1ac90197b1d3d7b137ba3c1ada67bb9ba31b. *** Reason for rollback *** Breaks //src/test/shell/integration:force_delete_output_test *** Original change description *** Symlink output directories to the correct directory name If the workspace directory is /path/to/my/proj and the name in the WORKSPACE file is "floop", this will symlink the output directories to output_base/execroot/floop instead of output_base/execroot/proj. More prep for #1262, fixes #1681. PiperOrigin-RevId: 156892980
* cpp: change PrintError() to print "ERROR:"Gravatar Thiago Farina2017-05-23
| | | | | | | | | | | As it was suggested in https://bazel-review.googlesource.com/#/c/10875/3/src/main/cpp/util/errors.cc@58 This is because that way it's consistent with the warnings/errors that the Bazel server displays. Change-Id: I65ee961ac4db5b21461fa7f7864e7f3c94a6e4f3 PiperOrigin-RevId: 156884812
* Automated g4 rollback of commit 7f520a8286c39c5145b6d816cd0be5a6b7b18250.Gravatar elenairina2017-05-23
| | | | | | | | | | | | | | | | | | *** Reason for rollback *** This broke Bazel CI on freebsd: http://ci.bazel.io/view/Dashboard/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=freebsd-11/1516/console# *** Original change description *** Refactor process-wrapper code so the spawn/wait code is pluggable. In an upcoming change I'll reintroduce the new platform-specific implementations that can kill and wait for all descendant processes spawned by the wrapped process. This has no functional changes. PiperOrigin-RevId: 156884488
* Make PackageOrException.get() public + make loadPackages() variant.Gravatar carmi2017-05-23
| | | | | RELNOTES: None PiperOrigin-RevId: 156876531
* Add functionality from the old shell-based coverage runner script to the new ↵Gravatar lberki2017-05-23
| | | | | | | | | | | | | one. This isn't a principled solution, but since it depends on /usr/bin/lcov, it should never be relied on at all. It's mostly a courtesy to people who came to use C++ coverage in Bazel before we removed it. Fixes #2685. Progress on #1118. RELNOTES: None. PiperOrigin-RevId: 156866370
* Add a new action for generating reconciled R classes for Robolectric.Gravatar corysmith2017-05-23
| | | | | | | | | This includes some refactoring: * Move the symbol deserialization our of the merger and into the ParsedAndroidData (probably move again.) * Change the FailedFutureAggregator generics to work more callables RELNOTES: None PiperOrigin-RevId: 156863698
* Update remote caching / execution docsGravatar ulfjack2017-05-23
| | | | | | Progress on #904. PiperOrigin-RevId: 156862823
* Make sure Copyright year is always up to date.Gravatar steren2017-05-23
| | | | | | | | | | In a document comment, xam@ said it was OK to have the copyright year showing the current date. Instead of using a fixed date, I used the technique described at http://www.adamwadeharris.com/get-current-year-in-jekyll/ I tested the change locally. RELNOTES: None PiperOrigin-RevId: 156861876
* Remove unused .css file.Gravatar steren2017-05-23
| | | | | | | The website's style is coming from css/main.scss, which itself uses _sass/style.css. The file at styles/main.css is never used. Tested: locally. PiperOrigin-RevId: 156856307
* Add an integration test that verifies that the source file of a C++ compile ↵Gravatar lberki2017-05-23
| | | | | | | | | | | action is present in extra actions attached to it. Also rename cc_inc_library test to something that reflects better what it does (there was already a test case that did not have anything to do with cc_inc_library) Fixes #2790 . RELNOTES: None. PiperOrigin-RevId: 156854584
* Make Desugar work for relative dumpDirectory paths.Gravatar Googler2017-05-23
| | | | | | | | | | | | | Before CL 155913466, Desugar was not working when dumpDirectory was a relative path because of an extra/incorrect resolve() that ended up duplicating such a relative path. CL 155913466 fixed this by converting Desugar's dumpDirectory to an absolute path. However, CL 156257767 introduced a check that Desugar's dumpDirectory must match the one in Java's InnerClassLambdaMetafactory, which broke the case of a relative path again. Therefore, this CL undoes the conversion to absolute path again (so that Desugar's path matches that in InnerClassLambdaMetafactory). Instead, to make relative paths work, it drops the unnecessary/incorrect call to resolve(). A regression test is left for a future CL (I don't have a dev environment set up that would allow me to easily write one). RELNOTES: None. PiperOrigin-RevId: 156852882
* Refactor process-wrapper code so the spawn/wait code is pluggable.Gravatar philwo2017-05-23
| | | | | | | | In an upcoming change I'll reintroduce the new platform-specific implementations that can kill and wait for all descendant processes spawned by the wrapped process. This has no functional changes. PiperOrigin-RevId: 156849610
* experimental UI: Support limiting consoleGravatar Klaus Aehlig2017-05-23
| | | | | | | | | | | | Add an option allowing to set a hard limit on the number of characters bazel will write to stdout/stderr (combined). In this way, it can be avoided to overwhelm the user with information (especially, if the invocation of bazel is wrapped in some way). Once the limit is approaching, bazel will try hard to meaningfully reduce the output, but will ultimately resort to just dropping output completely. Change-Id: I49cce96cc6a025c9753632dd489021766df81077 PiperOrigin-RevId: 156849105
* BEP: explicitly mark the important outputs as deprecatedGravatar aehlig2017-05-23
| | | | | | | | While the fact that they are only added temporarily is obvious from the comment, a machine-readable deprecation annotation is more likely to be honored. So add it. PiperOrigin-RevId: 156846712
* Don't de-duplicate linkopts from two different configured targets that have ↵Gravatar lberki2017-05-23
| | | | | | | the same value. RELNOTES: None. PiperOrigin-RevId: 156837699
* Add a #hashCode() method to WorkspaceStatusAction implementations as is ↵Gravatar lberki2017-05-23
| | | | | | | | | | | advisable when overriding #equals(). Intricacies within Skyframe prevented us from adding this method before, but whatever those were are not a problem anymore. This was empirically proven by making the change, looking at the set of tests that failed when I last tried this, then finding that they don't fail. The reason for the original failures will stay obscured by the mists of time forever. RELNOTES: None. PiperOrigin-RevId: 156835875
* Fix typos in android_device.system_image attribute documentationGravatar Googler2017-05-23
| | | | | RELNOTES: None PiperOrigin-RevId: 156827893
* Store the features enabled for each targetGravatar Googler2017-05-23
| | | | | | | ctx.features has already merged the package-level and rule-level feature sets. RELNOTES: None. PiperOrigin-RevId: 156811464
* Make checking of lambda dump directory accept relative path.Gravatar cnsun2017-05-23
| | | | | | | | | | | | | | Before, we use Path.equals(Object), which will fail if we use relative path in the system property. Now I use Files.isSameFile which will check two paths point to the same file system resource. In https://github.com/bazelbuild/bazel/commit/69e855c7b0f0f7899a69a882cba0abd304233c97, I introduce the check to test whether setting the system property for lambda meta factory succeeds. However, the check does not consider relative path, which will always fail. RELNOTES: n/a PiperOrigin-RevId: 156796457
* Add CC_FLAGS to the macros that pull in the CcToolchainProvider for genrulesGravatar Googler2017-05-23
| | | | | RELNOTES: Using $(CC_FLAGS) in a GenRule adds a dependency to the c++ toolchain PiperOrigin-RevId: 156770639
* Remove outdated comment.Gravatar ajmichael2017-05-23
| | | | | RELNOTES: None PiperOrigin-RevId: 156770067
* Add deprecation warning if the "legacy" manifest merger is used, now that ↵Gravatar apell2017-05-23
| | | | | | | the default has been switched to "android". RELNOTES: The 'legacy' Android manifest merger is deprecated. Please upgrade to the 'android' manifest merger, which is the same merger used by Gradle. https://developer.android.com/studio/build/manifest-merge.html PiperOrigin-RevId: 156765307
* Wrap ar invocations for osx bazel crosstool.Gravatar cparsons2017-05-23
| | | | | | | | | This: 1. Forces ar invocations to go through xcrunwrapper (thus having the environment variables set correctly so that the appropriate xcode is used) 2. Institutes a fix for non-hermeticism around object file timestamps. RELNOTES: None. PiperOrigin-RevId: 156759530
* If the target apple_binary is a loadable_bundle, always pass the ↵Gravatar kaipi2017-05-23
| | | | | | @loader_path/Frameworks rpath flag to the linker. PiperOrigin-RevId: 156759162
* Move the field name out of the FieldInitializerGravatar corysmith2017-05-23
| | | | | RELNOTES: None PiperOrigin-RevId: 156747534
* Fix ordering of -fPIC for PIC compiles in the LTOBackendActionGravatar Googler2017-05-23
| | | | | | | | | | For compiles that the CppConfiguration flags as needing PIC, the -fPIC option needs to be added after the other compile options so that it cannot be overridden (e.g. with a --copt). This is consistent with the way the CppCompileAction compile options are ordered. RELNOTES: None. PiperOrigin-RevId: 156746218
* Automated g4 rollback of commit c78c947e6a8cbb323304f872a3dcabb989a3d76b.Gravatar cpeyser2017-05-23
| | | | | | | | | | | | | | *** Reason for rollback *** Breaks android targets in the nightly - see [] *** Original change description *** Do not retain transitive data in AndroidLocalTestBase. The argument strings and artifacts were both transitive and flattened, causing O(N^2) memory consumption. PiperOrigin-RevId: 156745610
* Loosen java_library.exports and java_import.*Gravatar Stephen Twigg2017-05-22
| | | | | | | | | | | | | | | | | | | | | | | | | java_library.exports and java_import.runtime_deps|exports|deps will now accept any label from a rule that has a JavaProvider declared provider. Note that java_library.deps|runtime_deps already had this feature and this simply extends that privilege. This relies on the fact that both those targets (via JavaCommon) are simply searching for jars via JavaProvider anyway. Added test for passing a custom Skylark rule (that provides a JavaProvider) can successfully be added to the deps, runtime_deps, and exports of java_library, java_import, and java_binary (where appropriate). Added integration tests for java_library.exports|runtime_deps (the basic sandwich already tests deps) and java_import.exports|runtime_deps. Note that custom Skylark rules are still unable to provide or propagate a JavaNativeLibraryProvider, which results from a cc dependency. Also, the deps argument for java_import is somewhat odd. Change-Id: I7b2c19c6b99516ce524e8c82193d0c73e2d66530 PiperOrigin-RevId: 156740729
* Extract determining which manifest merger to use (legacy v android) to a ↵Gravatar Googler2017-05-22
| | | | | | | separate method. This is so that android_local_test won't need access to the AndroidConfiguration fragment. RELNOTES: None PiperOrigin-RevId: 156740056
* Fix aspect processing when same dep appears in 2 attributes.Gravatar kaipi2017-05-22
| | | | | | If a target appeared in 2 different attributes, it is not processed twice, even if different aspects were applied to the different attributes. In that case, only one of the aspects is applied. This commit fixes this by checking which aspects have been applied to the target, instead of checking if the target was already processed. PiperOrigin-RevId: 156738275
* Clarify difference between sources and distribution archiveGravatar Klaus Aehlig2017-05-22
| | | | | | | | | | In the install instructions, explain that the distribution archive contains more files than a checkout of the source tree. It is a common mistake to believe that using a checkout of the source tree is equivalent to downloading a distribution archive. Change-Id: I13cc48f5efe93bd2593d7b74d1f7c6db19de74dc PiperOrigin-RevId: 156732571
* Fix URL in compile.sh error messageGravatar Klaus Aehlig2017-05-22
| | | | | | | | | Our web page has been reorganized. The instructions to compile from source are now on a page of its own. Update the link in the error message accordingly. Change-Id: Ica1187a893b911eca638c5535a3f9686a661fe6f PiperOrigin-RevId: 156731324
* Extract :cc_toolchain as constantGravatar hlopko2017-05-22
| | | | | | | | And while at it cleanup all the calls of CppHelper.getToolchain and CppHelper.getFdoSupport. RELNOTES: None. PiperOrigin-RevId: 156716291
* Fix Edit button style.Gravatar steren2017-05-22
| | | | | | | Fix #3028 tested: locally with ./scripts/serve-docs.sh PiperOrigin-RevId: 156674683
* Create a loadPackages() method that loads multiple packages simultaneously, ↵Gravatar carmi2017-05-22
| | | | | | | | | using multiple threads. The immediate upside is that if multiple packages load the same bzl file, that file will only be read once when using loadPackages(). RELNOTES: None PiperOrigin-RevId: 156621988
* Include input header files in CIdeInfoGravatar Googler2017-05-22
| | | | | | A precursor to prefetching source files outside the project. PiperOrigin-RevId: 156598992
* Expose javac jar in java_toolchain's skylark providerGravatar Googler2017-05-22
| | | | PiperOrigin-RevId: 156589908
* Keep annotations of default methods in interfaces during desugaring.Gravatar cnsun2017-05-22
| | | | | RELNOTES: n/a PiperOrigin-RevId: 156582965
* Add operator // for division.Gravatar laurentlb2017-05-22
| | | | | | | | In both Python 2 and Python 3, the operator // is used for int division. With Python 3, operator / is for float division. RELNOTES: None. PiperOrigin-RevId: 156582262
* Move Bazel Android WORKSPACE rule docs to Android family.Gravatar ajmichael2017-05-22
| | | | | RELNOTES: None PiperOrigin-RevId: 156578239
* Update the platform rule documentation to match the actual attribute names.Gravatar jcater2017-05-22
| | | | PiperOrigin-RevId: 156571671
* Turn the --explicit_jre_deps flag into a noop.Gravatar Googler2017-05-22
| | | | | | RELNOTES: Flag --explicit_jre_deps is now a noop. PiperOrigin-RevId: 156570342
* Fix attribute name so docs are generated properly.Gravatar jcater2017-05-22
| | | | PiperOrigin-RevId: 156558693
* Remote+BES: Stabilize command line flags.Gravatar buchgr2017-05-22
| | | | | | | | | | | | | | | | | | | | Update the command line flags used by remote execution/caching as well as the build event service (BES). Major changes: - Remote execution/caching and BES share flags for authentication and TLS. - Removed API Key authentication from BES, as it's not being used. - Add TLS support to BES upload. - Add --bes_project_id flag. If set, the value is propagated as part of BES lifecycle events. For reviewers: Start your review at CommonRemoteAndBesOptions, BuildEventServiceOptions and RemoteOptions. The other changes are mostly automatic IDE renames of fields and flag updates in shell script tests. RELNOTES: None. PiperOrigin-RevId: 156553857
* Avoid waste in registerNewlyDiscovered... when there aren't anyGravatar mschaller2017-05-22
| | | | | RELNOTES: None. PiperOrigin-RevId: 156553687
* Create new android_host_service_fixture rule.Gravatar ajmichael2017-05-22
| | | | | | | | | | | This rule specifies a host binary that is run as part of an android_instrumentation_test. It merely collects options, support APKs and the runfiles for the host binary and passes them along to the upcoming android_instrumentation_test rule. Note that this CL does _not_ install the rule, so this CL does not make it usable by anyone. Once the other android testing rules are ready, we will install them all. One small step towards https://github.com/bazelbuild/bazel/issues/903. RELNOTES: None PiperOrigin-RevId: 156553198
* gRPC is locking down access to internal classes, so remove refs to it.Gravatar Googler2017-05-22
| | | | | | | This value is unlikely to change in the near future, and we don't feel comfortable exposing it. You can force the size to be whatever you want, so the default value isn't really relevant. RELNOTES: n/a PiperOrigin-RevId: 156543600
* Fixes incorrectly-ordered arguments to calls to assertEqualsGravatar Googler2017-05-19
| | | | | | | | | | | | | | | [] This change has been automatically generated by an Error Prone check that detects incorrect argument ordering on calls to assertEquals-style methods. See [] Cleanup change automatically generated by javacflume/refactory Refactoring: third_party/java_src/error_prone/project/core/src/main/java/com/google/errorprone/bugpatterns/argumentselectiondefects:AssertEqualsArgumentOrderChecker_refactoring Tested: TAP --sample for global presubmit queue [] PiperOrigin-RevId: 156539781
* Don't join javabuilder classpath flagsGravatar cushon2017-05-19
| | | | | | | This avoids some string unnecessary string operations, and keeps command lines below the per-arg limit. PiperOrigin-RevId: 156514047
* Remove resourcejar handling from buildjarGravatar cushon2017-05-19
| | | | | | | singlejar is now used to add resources to library jars, so this code is unnecessary. PiperOrigin-RevId: 156473371