aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Mark ASTFileLookupValue as a NotComparableSkyValue. See the added comments ↵Gravatar nharmata2018-03-28
| | | | | | | for motivation. RELNOTES: None PiperOrigin-RevId: 190794479
* Removed the statement of "What does Bazel support?" as it's ↵Gravatar Googler2018-03-28
| | | | | | | limiting/misleading. Added supported host OSes to "multi-platform" paragraph. RELNOTES: Removed the statement of "What does Bazel support?" as it's limiting/misleading. Added supported host OSes to "multi-platform" paragraph. PiperOrigin-RevId: 190793121
* Put configuration checksum into BuildOptions$OptionsDiffForReconstruction ↵Gravatar janakr2018-03-28
| | | | | | | | and make it available to ConfiguredTarget. Also give BuildConfigurationValue.Key the same toString() that BuildConfiguration had, so we recover how we used to print out ConfiguredTarget labels in debugging. This may have a tiny bit of overhead in serialization, but we'll cross that bridge when we come to it. Could just make the string a constant. PiperOrigin-RevId: 190787145
* Migrate string tests to Skylark test suite.Gravatar laurentlb2018-03-28
| | | | | RELNOTES: None. PiperOrigin-RevId: 190785580
* Update version references of rules_apple in Bazel.Gravatar kaipi2018-03-28
| | | | | | minus some minor specific features. PiperOrigin-RevId: 190784717
* Removes superfluous generic parameter from DynamicCodec, allowing it to be usedGravatar shahan2018-03-28
| | | | | | with CodecRegisterer. PiperOrigin-RevId: 190780559
* ArtifactRoot correctly switches output base when serializing.Gravatar shahan2018-03-28
| | | | PiperOrigin-RevId: 190779535
* Make deprecated ObjcProvider fields return empty sets when ↵Gravatar cparsons2018-03-28
| | | | | | | | | --incompatible_disable_objc_provider_resources is true. This involves propagating SkylarkSemantics to all ObjcProvider constructors. RELNOTES: Introduce --incompatible_disable_objc_provider_resources to turn off all resource-related fields of the Objc provider. PiperOrigin-RevId: 190778491
* Get rid of call to deprecated ConfiguredTarget.getConfiguration()Gravatar juliexxia2018-03-28
| | | | PiperOrigin-RevId: 190777533
* Use the provided javac for host_javabase=9Gravatar cushon2018-03-28
| | | | | | Follow-up to 7ee0c670412d508cad0518a45961b9244921d649 PiperOrigin-RevId: 190776857
* Add a skylark-compatible alternative to MessageBundleProviderGravatar cushon2018-03-28
| | | | PiperOrigin-RevId: 190775527
* Remove categories from Bazel options.Gravatar ccalvarin2018-03-28
| | | | | | | | | These have all had a chance to be categorized with the OptionDocumentationCategory enum, and the help output already uses the enum-grouped format. The "incompatible changes" category has meaning for --all_incompatible_changes and will be removed separately. RELNOTES: None. PiperOrigin-RevId: 190773778
* Delete the ios_device rule from bazel.Gravatar kaipi2018-03-28
| | | | PiperOrigin-RevId: 190771926
* Move strip and compile build variables into separate classesGravatar hlopko2018-03-28
| | | | | | | | Working on link build variables I see they cannot stay in a single file, they're too big and complicated. This will make the followup cl smaller. RELNOTES: None. PiperOrigin-RevId: 190771072
* Add tests verifying the embedded skylark codeGravatar Klaus Aehlig2018-03-28
| | | | | | | | | | | | | | We suggest our users to regularly test their code base with --all_incompatible_chages to have time to adapt their code base to upcoming incompatible changes. When doing so, it is annoying if that breaks due to the Skylark code embedded in bazel not being ready for the upcoming incompatible changes. Therefore, add tests exercising the embedded code enabling all incompatible changes. This way, hopefully, changes like f1ad0e6df1528894b will come before the deprecation is added. Change-Id: Iea60ff6a4019db310d1f1a1ad6a7b2bb53101c6d PiperOrigin-RevId: 190766449
* Make error messages about illegal dependencies involving aliases clearer.Gravatar lberki2018-03-28
| | | | | RELNOTES: None. PiperOrigin-RevId: 190759949
* Inline ObjectFilePathHelperGravatar pcloudy2018-03-28
| | | | | | | Since it's not used anywhere else outside of CcCompilationHelper.java RELNOTES: PiperOrigin-RevId: 190755588
* Use the provided javac for host_javabase=9Gravatar Liam Miller-Cushon2018-03-28
| | | | | | See #3410, #4812 Change-Id: Idd4adad7d48899c3b6de635d417446b71ba44afa
* ObjcLibrary.java: Use objectFilesCollector to get object filesGravatar pcloudy2018-03-28
| | | | | | | This can avoid passing targetBuilder to CompilationSupport.java RELNOTES: None PiperOrigin-RevId: 190743994
* Remove stale cc_library nonconfigurablesGravatar George Gensure2018-03-28
| | | | | | | | | | | | Specifications of cc_library attribute nonconfigurability for linkstatic and alwayslink were introduced in d08b27f and have been stale since the ImplicitOutputsFunction specification was removed in 8a995b4. These attributes should have no problem interpreting configured specifications for their values. Closes #4917. PiperOrigin-RevId: 190743836
* Remove last few test uses of ConfiguredTarget#getConfiguration. Only uses ↵Gravatar janakr2018-03-27
| | | | | | are now internal, and the one that https://github.com/bazelbuild/bazel/commit/d350a897f6182d637ea819c41cd292a50c2db53d just snuck in... PiperOrigin-RevId: 190705224
* Replace nearly all test uses of ConfiguredTarget#getConfiguration with ↵Gravatar janakr2018-03-27
| | | | | | | | | | utility method getConfiguration(ConfiguredTarget). Done using IntelliJ structural replace, with $val$.getConfiguration() -> getConfiguration($val$) and Expression type: TransitiveInfoCollection, applying constraint within type hierarchy. Had to clean up a few compile errors. PiperOrigin-RevId: 190692493
* Get rid of all remaining non-test non-internal uses of ↵Gravatar janakr2018-03-27
| | | | | | ConfiguredTarget#getConfiguration(). Add convenience methods in four Java test classes for use by refactoring tools to do this#getConfiguration(ConfiguredTarget) instead of ConfiguredTarget#getConfiguration. PiperOrigin-RevId: 190684008
* PiperOrigin-RevId: 190680743Gravatar mjhalupka2018-03-27
|
* Introduce a simple data structure for incrementing keyed atomic long ↵Gravatar nharmata2018-03-27
| | | | | | | | | counters, optimized for the use-case of hot keys. RELNOTES: None PiperOrigin-RevId: 190678987
* Remove ConfiguredTargetKey#of(ConfiguredTarget), since it calls ↵Gravatar janakr2018-03-27
| | | | | | ConfiguredTarget#getConfiguration. PiperOrigin-RevId: 190676253
* documentation for cquery --output=transitionsGravatar juliexxia2018-03-27
| | | | PiperOrigin-RevId: 190673642
* Expose j2objc.dead_code_report as a configuration field instead of a basic ↵Gravatar cparsons2018-03-27
| | | | | | | struct field on the j2objc fragment. RELNOTES: None. PiperOrigin-RevId: 190672475
* In singlejar runs with --check_desugar_deps, error out when encountering ↵Gravatar kmb2018-03-27
| | | | | | | | j$.** files. RELNOTES: None. PiperOrigin-RevId: 190667956
* Move the default cquery output format to its own callback and standardize ↵Gravatar juliexxia2018-03-27
| | | | | | cquery output callback logic PiperOrigin-RevId: 190667120
* DynamicCodec class.Gravatar shahan2018-03-27
| | | | PiperOrigin-RevId: 190667019
* Remove old option categorization from the help output.Gravatar ccalvarin2018-03-27
| | | | | | | In preparation for removing all uses of the category field in Bazel options. RELNOTES: None. PiperOrigin-RevId: 190665669
* Remove some more #getConfiguration calls (and some transitive ones through ↵Gravatar janakr2018-03-27
| | | | | | ConfiguredTargetKey#of(ConfiguredTarget)). PiperOrigin-RevId: 190663565
* Remove unused execRoot parameter from buildActionGravatar George Gensure2018-03-27
| | | | | | Closes #4916. PiperOrigin-RevId: 190662077
* New incompatible flag to disable PACKAGE_NAME and REPOSITORY_NAME.Gravatar laurentlb2018-03-27
| | | | | | | | | RELNOTES[INC]: Variables PACKAGE_NAME and REPOSITORY_NAME are deprecated in favor of functions `package_name()` and `repository_name()`. https://docs.bazel.build/versions/master/skylark/lib/native.html#package_name PiperOrigin-RevId: 190657188
* Fix accidental eager expansion of grouped list in in-memory nodes.Gravatar felly2018-03-27
| | | | PiperOrigin-RevId: 190656902
* Thread configuration map through TestFilteringCompleteEvent. This isn't the ↵Gravatar janakr2018-03-27
| | | | | | most elegant solution, but I don't have a better idea. PiperOrigin-RevId: 190656869
* Remove EventHandler from SkylarkCustomCommandLine.Gravatar tomlu2018-03-27
| | | | | | | | | EventHandler is scoped to a commond, but SkylarkCustomCommandLine can outlive a single command. This constitutes a memory leak. Any error messages caused by command line evaluation are still propagated to the user via a CommandLineExpansionException. RELNOTES: None PiperOrigin-RevId: 190650016
* Compute the list of test output files in TestRunnerActionGravatar ulfjack2018-03-27
| | | | | | This allows us to slightly simplify the renaming logic in StandaloneTestStrategy. PiperOrigin-RevId: 190645674
* Get rid of ConfiguredTarget#getConfiguration() call in ↵Gravatar janakr2018-03-27
| | | | | | ConfiguredTargetFunction. The dep always has the right configuration, even in the case of an AliasConfiguredTarget. PiperOrigin-RevId: 190642982
* Remove the --allow_configurable_attributes startup option.Gravatar ccalvarin2018-03-27
| | | | | | | It was removed from the java code 4 years ago, mentioning it causes the server to crash at startup. RELNOTES: None. PiperOrigin-RevId: 190636455
* Get rid of a few more #getConfiguration() calls. We're now passing a ↵Gravatar janakr2018-03-27
| | | | | | ConfiguredTargetAndData into TargetCompleteEvent, which seems reasonable. PiperOrigin-RevId: 190634162
* Fix and rollforward of "Convert SkylarkRuleImplementationFunctions functions ↵Gravatar cparsons2018-03-27
| | | | | | | | | to use @SkylarkCallable instead." expand_location.targets needed to be a named parameter. RELNOTES: None. PiperOrigin-RevId: 190624472
* Ensure Runner name is always set.Gravatar Googler2018-03-27
| | | | | RELNOTES: None. PiperOrigin-RevId: 190617155
* Use JUnit assertions instead of Truth assertions.Gravatar cpovirk2018-03-27
| | | | | | | | | | The format of Truth's failure messages is about to change, which would break these tests. Alternatively, I could modify these tests to accept both the old and new Truth message formats, but ideally most tests wouldn't rely on the exact message format at all. (That suggests that an even better approach might be to just throw an exception whose message is a fixed string. That would avoid relying even on JUnit's message format, unlikely as I think that is to change.) RELNOTES: None. PiperOrigin-RevId: 190617095
* C++: Fixes Blaze crashing on CLIF in toolchains that don't need PICGravatar plf2018-03-27
| | | | | | | | | | | | | | | | | | | | For CLIF it doesn't matter whether we use PIC or no-PIC, the important thing is we get an output protobuf. Before https://github.com/bazelbuild/bazel/commit/35773928532c132e3229b490ad98f4ebfd3e5770, using no-PIC was hardcoded. In this CL it was decided to generate PIC instead because the toolchains used by CLIF targets appeared to all have needsPic. In b/73955395 it has been shown not to be the case. In this CL I'm changing the logic again to use no-PIC for CLIF and to circumvent the logic that checks what the configuration and the toolchain say. At the same time, SWIG also used the method setGenerateNoPic() after the variable onlySingleOutput was removed in https://github.com/bazelbuild/bazel/commit/4e9c9f93b15dd2594097644c6b9ca5a579c712fb. In this CL I use the enum to apply PIC and no-PIC in the same cases as before for SWIG. This CL also refactors the methods and boolean variables used to determine whether to use PIC or not, hopefully making it clearer. RELNOTES:none PiperOrigin-RevId: 190615548
* Add toolchain definitions for autoconfigured cc_toolchain entries.Gravatar jcater2018-03-27
| | | | PiperOrigin-RevId: 190611069
* Support for empty_files and empty_dirs in pkg.Gravatar Pawe? Zuzelski2018-03-27
| | | | | | | | | | | | Backport recent changes to build_tar tool in bazelbuild/rules_docker: https://github.com/bazelbuild/rules_docker/pull/310 - add --empty_file and --empty_dir flags to build_tar.py, allowing creation of empty files and dirs with specified mode. - expose those flags as empty_files and empty_dirs parameters to pkg_tar rule. Closes #4837. PiperOrigin-RevId: 190610460
* Only allow regular files and directories spawn outputs to be uploaded to a ↵Gravatar Benjamin Peterson2018-03-27
| | | | | | | | | | | | | | | | | | | | remote cache. The remote cache protocol only knows about regular files and directories. Currently, during action output upload, symlinks are resolved into regular files. This means cached "executions" of an action may have different output file types than the original execution, which can be a footgun. This CL bans symlinks from cachable spawn outputs and fixes https://github.com/bazelbuild/bazel/issues/4840. The interface of SpawnCache.CacheHandle.store is refactored: 1. The outputs parameter is removed, since that can be retrieved from the underlying Spawn. 2. It can now throw ExecException in order to fail actions. Closes #4902. Change-Id: I0d1d94d48779b970bb5d0840c66a14c189ab0091 PiperOrigin-RevId: 190608852
* Remove third_party/gtest, we now have the remote dependency @googletest instead.Gravatar Chloe Calvarin2018-03-27
| | | | Change-Id: I65379afbee65d321c31a48a9e1c8afae0cb99c34
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-18 15:41:15 +0000