aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* "bazel clean": prevent creation of command.logGravatar Laszlo Csomor2016-10-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Open files cannot be deleted on Windows, thus `bazel clean --expunge` fails when it attemps to delete the `command.log` that stdout/stderr is tee'd into, and so does BlazeCommandDispatcher when it attemps to delete the `command.log` just before dispatching to the command implementation (not just `clean` but any command). This change: - closes `command.log` before we attempt to delete it - marks CleanCommand (through the Command annotation) as one that should not write to the command.log, thus we don't create a new instance of the file This change allows `bazel clean --expunge` to delete everything in the output base, with the exception of `jvm.log`. Unfortunately that file is opened by the C++ bazel client process, so we have to close it there prior to sending the clean to the bazel server. See https://github.com/bazelbuild/bazel/issues/1586 -- MOS_MIGRATED_REVID=137278553
* stop passing BuildConfiguration to CppCompileActionGravatar Thiago Farina2016-10-27
| | | | | | | | | | | This fixes Ulf's TODO by adding fields for the local shell environment and code coverage and as stated on it accessing anything other than these fields can impact correctness. -- Change-Id: I9ccebaa0bc8ed920e2941b3d156692cb1e0fe117 Reviewed-on: https://bazel-review.googlesource.com/c/6870/ MOS_MIGRATED_REVID=137275206
* Report completion of a target together with failed actionsGravatar Klaus Aehlig2016-10-27
| | | | | | | | | | | | | | | | Report the completion of all targets together with the root causes on the build event stream. To do so, have TargetCompleteEvent and ActionExecutedEvent be instances of BuildEvent; however, ignore an ActionExecutedEvent in the BuildEventStreamer if the execution was successful. By this change we get, for the first time, a build event stream that is naturally closed, i.e., without Aborted events closing up lose ends. Add a test asserting this property. -- Change-Id: Ie90dd52ee80deb0fdabdce1da551935522880a1a Reviewed-on: https://bazel-review.googlesource.com/#/c/6279 MOS_MIGRATED_REVID=137273002
* Cleanup: remove isSkylark in Environment ContinuationGravatar Laurent Le Brun2016-10-27
| | | | | -- MOS_MIGRATED_REVID=137272887
* Fix a few issues that prevented Bazel from building with Java 7.Gravatar Lukacs Berki2016-10-27
| | | | | -- MOS_MIGRATED_REVID=137269807
* Clarify how startup options are conveyed between the client and the server.Gravatar Lukacs Berki2016-10-27
| | | | | -- MOS_MIGRATED_REVID=137266505
* Cleanup in Environment, remove unused lookup functionGravatar Laurent Le Brun2016-10-27
| | | | | -- MOS_MIGRATED_REVID=137266170
* Skip gpg signing if .sig file is already thereGravatar Yun Peng2016-10-27
| | | | | | | Fix https://github.com/bazelbuild/bazel/issues/1990 -- MOS_MIGRATED_REVID=137262738
* Create a separate module for .proto.h files. Together with modules pruning,Gravatar Googler2016-10-27
| | | | | | | | this allows reaping some of the benefits of .proto.h files even without completely disabling .pb.h files. -- MOS_MIGRATED_REVID=137261686
* Cleanup in the parserGravatar Laurent Le Brun2016-10-26
| | | | | | | | | | - Move break/continue check from ValidationEnvironment to the Parser - Remove some differences between BUILD / Skylark parsing mode - Fix location off-by-one error in the break/continue tokens - Remove duplicated error message ('for loops are not allowed on top-level') -- MOS_MIGRATED_REVID=137259929
* Fix uses of LocalRepositoryLookupFunction to work with JDK7.Gravatar John Cater2016-10-26
| | | | | -- MOS_MIGRATED_REVID=137257525
* Refactor: extract anonymous classesGravatar Laszlo Csomor2016-10-26
| | | | | | | | | | | | | | | | | | | AbstractFileSystem.getFile{Input,Output}Stream created anonymous File{Input,Output}Stream objects. These hold a reference to the outer class instance (AbstractFileSystem). This may prevent memory release in case the returned objects are kept around even if the AbstractFileSystem instance could otherwise be released. This particular refactoring is unlikely to have caught any memory leaks like this, so it's not really necessary, but I came across it and thought it won't hurt and will future-prove the class against such leaks. -- MOS_MIGRATED_REVID=137254192
* Remove .sig file before gpg signingGravatar Yun Peng2016-10-26
| | | | | | | | | gpg need tty because it's requesting confirmation for overriding that file Fix https://github.com/bazelbuild/bazel/issues/1990 -- MOS_MIGRATED_REVID=137251576
* Use TEST_TMPDIR for zip_manifest_extractor_test.sh.Gravatar Adam Michael2016-10-26
| | | | | -- MOS_MIGRATED_REVID=137209855
* Fix zip_manifest_creator dep in bazel_tools repo with an alias.Gravatar Adam Michael2016-10-26
| | | | | | | | | | | In commit 78c19807d2cbb308b830022dcdcc8b03f19f90a9 I accidentally broke aar_import when I moved zip_manifest_creator from tools/android to tools/zip because tools/android does not have separate BUILD and BUILD.tools files. The test did not catch this, because the dependency in tools/android/BUILD is correct in the context of the bazel tree but not in the context of the bazel_tools embedded workspace. -- MOS_MIGRATED_REVID=137209500
* Merge all jars in AAR in aar_import, not just classes.jarGravatar Adam Michael2016-10-26
| | | | | | | See https://github.com/bazelbuild/bazel/issues/1935 -- MOS_MIGRATED_REVID=137202533
* bazel query --output=xml: avoid iterating over all possible values forGravatar Greg Estren2016-10-26
| | | | | | | | attr = select({"a": LABEL_LIST, "b": LABEL_LIST, ...}). This can be exponential (w.r.t. the # of select conditions) and produce OOMs. -- MOS_MIGRATED_REVID=137200979
* Uncomment lines inside blaze_util_tests since the tests are nowGravatar Luis Fernando Pino Duque2016-10-26
| | | | | | | passing. -- MOS_MIGRATED_REVID=137196103
* Update some FAQ questions.Gravatar Han-Wen Nienhuys2016-10-26
| | | | | | | -- Change-Id: I218ae41da9a139ac1a613e0fcef0adf062845ef5 Reviewed-on: https://bazel-review.googlesource.com/6891 MOS_MIGRATED_REVID=137193672
* Adds a check that the new local repository path exists and is aGravatar John Cater2016-10-25
| | | | | | | | | | | directory. Fixes #1981. -- Change-Id: I16a96be3f4f9de66e608b1914a2554613ddc096a Reviewed-on: https://bazel-review.googlesource.com/c/6910/ MOS_MIGRATED_REVID=137192543
* Add generic parameter to make ParallelSkyQueryUtil Java7 compliantGravatar Googler2016-10-25
| | | | | -- MOS_MIGRATED_REVID=137192333
* Adds support to aar_import for native libs in /jni.Gravatar Adam Michael2016-10-25
| | | | | | | The libs that are extracted are dependent on the CPU from the Android split transition. This is set either from --fat_apk_cpu or --android_cpu if fat_apk_cpu is empty. -- MOS_MIGRATED_REVID=137188695
* Rollback of commit abb0b633339ef76bf19a1e5af8477d42d13151d8.Gravatar Peter Schmitt2016-10-25
| | | | | | | | | | | | | | | | | | *** Reason for rollback *** breaks bazel linux sandbox *** Original change description *** Move -l/-L link opts to FeatureConfiguration This cl moves -l/-L link opts generation from Java to FeatureConfiguration making it possible to alter the flags in CROSSTOOL. Change-Id: I1ea7501435ab7e62992e1e9b0cb7f5e22d52c521 -- MOS_MIGRATED_REVID=137184226
* Remove deprecated kind in IDE aspect.Gravatar Googler2016-10-25
| | | | | -- MOS_MIGRATED_REVID=137178015
* Update Skylark documentationGravatar Laurent Le Brun2016-10-25
| | | | | | | | | | - Add debugging tips - Give more visibility to tools/build_defs/g3doc/ - Mention Standalone Skylark - Remove some mentions of build extensions -- MOS_MIGRATED_REVID=137175010
* Move from simulator version 8.4 to 9.3 which is going to be far more common ↵Gravatar Dave MacLachlan2016-10-25
| | | | | | | now given that most devs are on Xcode 7.3. -- MOS_MIGRATED_REVID=137169017
* Remove iossim from Bazel. Gravatar Dave MacLachlan2016-10-25
| | | | | | | | | We have stopped using iossim in Bazel and replaced it with direct access to xcode's APIs. As a result we can clean up our code base by removing any references to iossim. RELNOTES:none -- MOS_MIGRATED_REVID=137165435
* Add new skyframe function to lookup the repository given a path, and use thatGravatar John Cater2016-10-25
| | | | | | | to report invalid package references. Fixes #1592. -- MOS_MIGRATED_REVID=137164164
* Wrap the source Path in a DataSource object.Gravatar Googler2016-10-25
| | | | | | | | The DataSource object will then be used to track which values have been overwritten and avoid incorrect merge warnings. -- MOS_MIGRATED_REVID=137159260
* Add a new concept of failure causesGravatar Klaus Aehlig2016-10-25
| | | | | | | | | | | | | | | | | | | | Not all possible reasons for failure are uniquely identified by a label. Therefore, add a new data type describing possible root causes of failures and use it. The new type is added in causes/*.java and coresponds to Haskell's one-line definition data Cause = LabelCause Label | ActionCause Path Label deriving Show With future clean up of other failure causes inadequately described by a label, we expect that type to be extended by new constructors (i.e., new classes implementing Cause). -- Change-Id: I6fec74c78cec6abb9c10e32743b05a792888fead Reviewed-on: https://bazel-review.googlesource.com/#/c/6617 MOS_MIGRATED_REVID=137156390
* Trim labels in location expressions before expansion.Gravatar Tobias Werth2016-10-25
| | | | | | | -- Change-Id: If626fd448ddbfbdf65b71569fda7a9b206e5f8b2 Reviewed-on: https://bazel-review.googlesource.com/c/6890/ MOS_MIGRATED_REVID=137155361
* Multidex uses singlejar instead of zip.Gravatar Adam Michael2016-10-25
| | | | | | | | | To roll this out safely, this is hidden behind a flag: --experimental_android_use_singlejar_for_multidex See https://github.com/bazelbuild/bazel/issues/1936 -- MOS_MIGRATED_REVID=137155214
* Reimplement whole archive on WindowsGravatar Yun Peng2016-10-25
| | | | | | | | | | | | Use wrapper script to get object files if /WHOLEARCHIVE is not supported. fix https://github.com/bazelbuild/bazel/issues/1978 work towards https://github.com/bazelbuild/bazel/issues/1918 -- Change-Id: I675311478e65a1e1f3fa963187a5a8da531150d3 Reviewed-on: https://bazel-review.googlesource.com/#/c/6833 MOS_MIGRATED_REVID=137151817
* VFS: implement a Windows-specific Path subclassGravatar Laszlo Csomor2016-10-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change rolls forward commit e0d7a540e3c615c628f63fcaaaba0c47fca2cb25 and commit 8bb4299b28de14eed9d3b57bcaeb9350c81c7db3, and adds a bugfix: - FileSystem.PathFactory got a new translatePath method that WindowsFileSystem.PathFactory overrides to translate absolute Unix paths to MSYS-relative paths - Path.getCachedChildPath calls this translatePath method so the child path is registered with the correct (translated) parent and under the correct name (e.g. "C:" instead of say "c") Below is the rest of the original change description: The new subclass WindowsFileSystem.WindowsPath is aware of Windows drives. This change: - introduces a new factory for Path objects so FileSystems can return a custom implementation that instantiates filesystem-specific Paths - implements the WindowsPath subclass of Path that is aware of Windows drives - introduces the bazel.windows_unix_root JVM argument that defines the MSYS root, which defines the absolute Windows path that is the root of all Unix paths that Bazel creates (e.g. "/usr/lib" -> "C:/tools/msys64/usr/lib") except if the path is of the form "/c/foo" which is treated as "C:/foo" - removes all Windows-specific logic from Path PathFragment is still aware of drive letters and it has to remain so because it is unaware of file systems. WindowsPath restricts the allowed path strings to absolute Unix paths where the first segment, if any, is a volume specifier. From now on if Bazel attempts to create a WindowsPath from an absolute Unix path, Bazel will make it relative to WindowsPath.UNIX_ROOT, unless the first component is a single-letter name (e.g. "/c/foo" which is "C:/foo"). Subclassing Path is necessary because a Unix-style absolute path doesn't sufficiently define a full Windows path, as it may be relative to any drive. Fixes https://github.com/bazelbuild/bazel/issues/1463 -- MOS_MIGRATED_REVID=137149483
* Ignore the environment variable "http_proxy" so that it doesn't interfere ↵Gravatar Lukacs Berki2016-10-25
| | | | | | | with the gRPC-based communication between the Bazel client and server. -- MOS_MIGRATED_REVID=137138408
* Fix help text for --command_port so that it does not refer to the ↵Gravatar Lukacs Berki2016-10-25
| | | | | | | nonexistent AF_UNIX mode. -- MOS_MIGRATED_REVID=137135400
* Fix the windows blogpost date.Gravatar Dmitry Lomov2016-10-25
| | | | | -- MOS_MIGRATED_REVID=137128701
* Add a flag to lock down isystem include checks.Gravatar Ulf Adams2016-10-25
| | | | | | | | | | | | | | | | | If this flag is disabled, Bazel continues to behave as previously - includes reached through isystem paths are completely ignored, i.e., they don't have to be declared in any rule. This applies primarily to cc_library.includes. When the flag is enabled, Bazel gives an error for any such header file that isn't declared in srcs or hdrs of a dependent rule. Goes towards fixing #1162. RELNOTES[NEW]: Use --strict_system_includes to apply hdrs_check=strict also to cc_library.includes, even if sandboxing is disabled. -- MOS_MIGRATED_REVID=137125638
* Enables AllowValues and DisallowValues invocation policy operations to takeGravatar Alex Humesky2016-10-25
| | | | | | | | | a value to use instead of the given flag value if it is disallowed by the policy. This is a generalization of the existing new_default_value behavior to cover any value of the flag, not just the default value if the flag is unset. -- MOS_MIGRATED_REVID=137104944
* If a group of deps has only one unique element, store it bare.Gravatar Janak Ramakrishnan2016-10-25
| | | | | | | | | | Not storing it bare both breaks equality comparison for GroupedList and uses more space. -- Change-Id: Iaf4f88908ecf4293cfc31dbd896f46e1da3b4184 Reviewed-on: https://bazel-review.googlesource.com/#/c/6850/ MOS_MIGRATED_REVID=137099785
* Accept valid relative symlinks in TreeArtifacts.Gravatar Rumou Duan2016-10-25
| | | | | -- MOS_MIGRATED_REVID=137072310
* Defer targetification of SkyKeys during unbounded allrdeps evaluationGravatar Googler2016-10-24
| | | | | -- MOS_MIGRATED_REVID=137064426
* Add support for exported_plugins to android_libraryGravatar Googler2016-10-24
| | | | | | | | | AndroidLibrary already has the support for exported_plugins thanks to its use of JavaCommon.getTransitivePlugins() RELNOTES[NEW]: android_library now has a "exported_plugins" attribute just like java_library -- MOS_MIGRATED_REVID=137053056
* Remove hack from bazel_apple_test to select an xcode that is 7-series or ↵Gravatar Chris Parsons2016-10-24
| | | | | | | | | | 8-series. The test now relies on the auto-detection skylark repository rule (querying the result for an appropriate 7-series or 8-series alternative) -- MOS_MIGRATED_REVID=137050518
* Add --no-tty for gpg signingGravatar Yun Peng2016-10-24
| | | | | | | RELNOTES:None -- MOS_MIGRATED_REVID=137043040
* Prepare to remove ↵Gravatar Liam Miller-Cushon2016-10-24
| | | | | | | --experimental_optimize_header_compilation_annotation_processing -- MOS_MIGRATED_REVID=137035372
* Stamp Windows release.Gravatar Dmitry Lomov2016-10-24
| | | | | | | -- Change-Id: I6f782f5dbeba03962381d32183e2afd2f0175709 Reviewed-on: https://bazel-review.googlesource.com/#/c/6832/ MOS_MIGRATED_REVID=137029264
* Syncing up the latest protos with the internal version. Adding UNSUPPORTEDGravatar Ola Rozenfeld2016-10-24
| | | | | | | option to setting remote execution cache. -- MOS_MIGRATED_REVID=137027196
* Fix chocolatey package build scripts - minor fixes.Gravatar Peter Mounce2016-10-24
| | | | | | | | Closes #1949. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/1949 MOS_MIGRATED_REVID=137022912
* Gives warning instead of error when fail to delete sandbox directory.Gravatar Yue Gan2016-10-24
| | | | | -- MOS_MIGRATED_REVID=137012950
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-04 13:47:33 +0000