| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
| |
RELNOTES:
Add worker support to single jar.
--
MOS_MIGRATED_REVID=131043398
|
|
|
|
|
|
|
|
|
| |
If the user had an alias grep='grep --color=always' it would break the
bash completion, outputting the formatting character. Bypass the user
alias to avoid the effect.
--
MOS_MIGRATED_REVID=131040601
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130986194
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130976776
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is invoked via the new --dataBindingInfoOut flag.
If specified and the rule has resources, data binding declarations
in layout .xmls are stripped and fed into an aggregated .zip file
under that name. The original (stripped) .xml is then fed into
aapt for normal processing.
If specified and the rule has no resources, an empty file is created.
If not specified, everything works as before.
--
MOS_MIGRATED_REVID=130973265
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130971534
|
|
|
|
|
|
|
|
|
| |
for rules to inherit from which require it.
This fixes a apple_watch2_extension bug in which this swift tool is unavailable (because it is undefined).
--
MOS_MIGRATED_REVID=130961298
|
|
|
|
|
|
|
| |
(AppleConfiguration) to skylark.
--
MOS_MIGRATED_REVID=130960948
|
|
|
|
|
|
|
| |
only works when using the new version of objc_proto_library by adding the portable_proto_filters attribute.
--
MOS_MIGRATED_REVID=130952647
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130950815
|
|
|
|
|
|
|
|
|
|
|
| |
Bazel users that are using a different Guava version than the one in the
junitrunner jar are getting an IncompatibleClassChangeError. Rewriting
parts of junitrunner code so it won't depend on Guava anymore.
Continuing progress on issue #1150.
--
MOS_MIGRATED_REVID=130946174
|
|
|
|
|
|
|
|
|
| |
shows that they aren't actually used anymore. If they were, they wouldn't work
as expected as the nested sets that are used in the comparison don't implement
hashCode or equals.
--
MOS_MIGRATED_REVID=130945911
|
|
|
|
|
|
|
| |
will be used to perform tests of the changeover.
--
MOS_MIGRATED_REVID=130943982
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130941264
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130938527
|
|
|
|
| |
Change-Id: I5382b70f7ebc8450aa475c61eacc524e5263b0ce
|
|
|
|
|
|
|
| |
This allow us to skip the import validation in non-build usages.
--
MOS_MIGRATED_REVID=130936612
|
|
|
|
|
|
|
| |
are always within BUILD files.
--
MOS_MIGRATED_REVID=130936412
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130936320
|
|
|
|
|
|
|
| |
rolling our own in Consumers.
--
MOS_MIGRATED_REVID=130936036
|
|
|
|
|
|
|
| |
rolling our own in ExperimentalEventHandler.
--
MOS_MIGRATED_REVID=130935928
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130916210
|
|
|
|
|
|
|
|
|
| |
assert that solib symlinks always point to dynamic libraries.
Note that this makes it possible to crash Bazel with a malicious CROSSTOOL file, but since we are migrating to cc_toolchain_suite which raises a user-friendly error earlier, this is okay.
--
MOS_MIGRATED_REVID=130915262
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130914217
|
|
|
|
|
|
|
| |
actions, use instead the intersection of all the groups in which each proto appears. This further minimizes the average number of inputs per generation/compilation action.
--
MOS_MIGRATED_REVID=130867114
|
|
|
|
|
|
|
| |
paths so that ios_test targets can access them without the need to use non_propagate_deps for protos.
--
MOS_MIGRATED_REVID=130796608
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid writing the non-values IdXmlResourceValues
to the merged values.xml file. It's redundant
since the merged resources will include the src
layout / menu, etc. file. E.g., adds 25KB out
of 250KB to some merged values.xml.
It can also change the way R.fields are initialized
(ids from values.xml are numbered before other
sources), that would have changed the numbering in
AndroidIntegratinoTest#testAndroidBinaryResourceShrinking
and in AndroidResourceClassWriterAaptTest.
--
MOS_MIGRATED_REVID=130789333
|
|
|
|
|
|
|
| |
rule is now handled as a native application, unless its path ends with '.jar' (in which case it is a Java application as before).
--
MOS_MIGRATED_REVID=130783627
|
|
|
|
|
|
|
| |
to Artifacts. Also avoid overhead of creating a set when we only need an iterable, and avoid an unnecessary iteration over the iterable as a contains check. In future, we may not want to pay the cost of constructing a true map in SkyFunction.Environment implementations. Part of this is a preliminary refactor to allow that.
--
MOS_MIGRATED_REVID=130765995
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130765742
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130761732
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130755375
|
|
|
|
|
|
|
| |
Makes #1664 much less acute.
--
MOS_MIGRATED_REVID=130750731
|
|
|
|
| |
MOS_MIGRATED_REVID=130747105
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130745524
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130742362
|
|
|
|
|
|
|
|
|
|
|
| |
bfaff29b1bafd7892a2197b7cf826e1be0ff3927.
Without the newline, our bazel/scripts/ci/build.sh will append an android_sdk_repository() rule into the file in such a way, that it produces a syntax error.
Also fix the build.sh script to be more resilient and not actually require the newline.
--
MOS_MIGRATED_REVID=130737331
|
|
|
|
|
|
|
| |
don't litter test directories in the output base.
--
MOS_MIGRATED_REVID=130730383
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130725849
|
|
|
|
|
|
|
|
| |
A valid argument has been made for opening it up, and it's
not clear it's helping anyone by locking it down.
--
MOS_MIGRATED_REVID=130686109
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130665520
|
|
|
|
|
|
|
| |
test what it's supposed to test, as pointed out by gregce.
--
MOS_MIGRATED_REVID=130661645
|
|
|
|
|
|
|
| |
InterruptedException instead of wrapping as a TargetParsingException.
--
MOS_MIGRATED_REVID=130660310
|
|
|
|
|
|
|
| |
SkyFunction.Environment#getValues call. In future, we may not want to pay the cost of constructing a true map in SkyFunction.Environment implementations. This is a preliminary refactor to allow that.
--
MOS_MIGRATED_REVID=130649663
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has the following improvements upon the older one:
- Uses PID namespaces, PR_SET_PDEATHSIG and a number of other tricks for
further process isolation and 100% reliable killing of child processes.
- Uses clone() instead of unshare() to work around a Linux kernel bug that
made creating a sandbox unreliable.
- Instead of mounting a hardcoded list of paths + whatever you add with
--sandbox_add_path, this sandbox instead mounts all of /, except for what
you make inaccessible via --sandbox_block_path. This should solve the
majority of "Sandboxing breaks my build, because my compiler is installed
in /opt or /usr/local" issues that users have seen.
- Instead of doing magic with bind mounts, we create a separate execroot for
each process containing symlinks to the input files. This is simpler and
gives more predictable performance.
- Actually makes everything except the working directory read-only
(fixes #1364). This means that a running process can no longer accidentally
modify your source code (yay!).
- Prevents a number of additional "attacks" or leaks, like accidentally
inheriting file handles from the parent.
- Simpler command-line interface.
- We can provide the same semantics in a Mac OS X sandbox, which will come in
a separate code review from yueg@.
It has the following caveats / known issues:
- The "fallback to /bin/bash on error" feature is gone, but now that the
sandbox mounts everything by default, the main use-case for this is no
longer needed.
The following improvements are planned:
- Use a FUSE filesystem if possible for the new execroot, instead of creating
symlinks.
- Mount a base image instead of "/".
FAQ:
Q: Why is mounting all of "/" okay, doesn't this make the whole sandbox
useless?
A: This is still a reasonable behavior, because the sandbox never tried to
isolate your build from the operating system it runs in. Instead it is
supposed to protect your data from a test running "rm -rf $HOME" and to
make it difficult / impossible for actions to use input files that are not
declared dependencies. For even more isolation the sandbox will support
mounting a base image as its root in a future version (similar to Docker
images).
Q: Let's say my process-specific execroot contains a symlink to an input file
"good.h", can't the process just resolve the symlink, strip off the file
name and then look around in the workspace?
A: Yes. Unfortunately we could not find any way on Linux to make a file appear
in a different directory with *all* of the semantics we would like. The
options investigated were:
1) Copying input files, which is much too slow.
2) Hard linking input files, which is fast, but doesn't work cross-
filesystems and it's also not possible to make them read-only.
3) Bind mounts, which don't scale once you're up in the thousands of input
files (across all actions) - it seems like the kernel has some
non-linear performance behavior when the mount table grows too much,
resulting in the mount syscall taking more time the more mounts you
have.
4) FUSE filesystem, good in theory, but wasn't ready for the first
iteration.
RELNOTES: New sandboxing implementation for Linux in which all actions run in a separate execroot that contains input files as symlinks back to the originals in the workspace. The running action now has read-write access to its execroot and /tmp only and can no longer write in arbitrary other places in the file system.
--
Change-Id: Ic91386fc92f8eef727ed6d22e6bd0f357d145063
Reviewed-on: https://bazel-review.googlesource.com/#/c/4053
MOS_MIGRATED_REVID=130638204
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the tmpdir wasn't below the execroot, Bazel would crash and print a stack
trace.
Also, the test was incorrect because the EOF wasn't quoted, so it was actually
just executing "echo TEST_TMPDIR=/path/to/tmpdir" which (surprise surprise)
matched TEST_TMPDIR=/path/to/tmpdir.
Finally, the test was _also_ incorrect because it was using the cached test
result for the second case, since changing the tmpdir doesn't invalidate the
test result. So it not only was comparing a constant string to a constant
string, but it wasn't even re-evaluating the constant string.
--
MOS_MIGRATED_REVID=130637221
|
|
|
|
|
|
|
|
|
| |
method cannot be found when called from Skylark.
PAIR=laurentlb
--
MOS_MIGRATED_REVID=130636387
|
|
|
|
|
|
|
|
|
|
| |
This makes the same change to cc_configure.bzl made to the hard-coded
CROSSTOOL in 763f1397155fc7c12e1f1071a1bc942f91b867c4 to fix #1642
--
Change-Id: Ia05788243d0128ea4921f12c437ef6cebd83a4ff
Reviewed-on: https://bazel-review.git.corp.google.com/#/c/5450/
MOS_MIGRATED_REVID=130636065
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Please don't merge before I8b8c3596fd2a4c125071406eefd407ca402099dd. The
test will fail then.
I've seen two issues with this functionality breaking: #481 and #1637.
Seems like it's time to add a test which catches the issue on the
Debian/Ubuntu machines people commonly test on. The test fails on my
Debian system before I8b8c3596fd2a4c125071406eefd407ca402099dd, and
passes with that change applied.
--
Change-Id: Ib785c874cdb9192920f9935b696bfd6c9c0e5f4f
Reviewed-on: https://bazel-review.git.corp.google.com/#/c/5451/
MOS_MIGRATED_REVID=130635565
|
|
|
|
|
|
|
|
|
| |
fixes #1637 (https://github.com/bazelbuild/bazel/issues/1637)
--
Change-Id: I8b8c3596fd2a4c125071406eefd407ca402099dd
Reviewed-on: https://bazel-review.git.corp.google.com/#/c/5410/2
MOS_MIGRATED_REVID=130633667
|