aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Make explicit the contract of ConfiguredTarget builders returning null when ↵Gravatar cparsons2018-07-30
| | | | | | | there are rule errors. RELNOTES: None. PiperOrigin-RevId: 206652580
* Internal changeGravatar ruperts2018-07-30
| | | | PiperOrigin-RevId: 206642715
* [Skylark] Size argument list builder to avoid allocations.Gravatar Taras Tsugrii2018-07-30
| | | | | | | | | | | This change is focused on 2 things: - avoid creating builders in case they don't end up being used - create builders using the maximum expected size to avoid intermediate allocations to accommodate more elements Closes #5694. PiperOrigin-RevId: 206636046
* Automated rollback of commit be88b8539b30d1c36c68b0f6acfe1e9ae010db3b.Gravatar cparsons2018-07-30
| | | | | | | | | | | | | *** Reason for rollback *** Concerns were raised about this breaking change, so rolling back to be safe. *** Original change description *** Throw a rule error when a skylark rule implementation returns multiple providers of the same type. RELNOTES: A rule error is now thrown if a Skylark rule implementation function returns multiple providers of the same type. PiperOrigin-RevId: 206629186
* Improve artifact->owner label accounting in two ways. First, don't do the ↵Gravatar janakr2018-07-30
| | | | | | full mapping unless requested. This gets rid of any performance issue for the vast majority of builds. Second, if requested, use a custom data structure so that we don't have to create a full HashSet for artifacts whose only owning labels are their own owner labels. PiperOrigin-RevId: 206610370
* [Skylark] Use POJOs instead of dynamic proxies.Gravatar Taras Tsugrii2018-07-30
| | | | | | | | | | | | | | Java uses dynamically generated proxy classes to access annotation properties and their methods are ~7X slower than plain getters. According to async-profiler 50%+ of `convertArgumentList` method time is spent in dynamic proxy methods, so optimizing their performance makes sense. This also makes the model less anemic, since POJOs can actually provide business methods. Closes #5666. PiperOrigin-RevId: 206608812
* Some code cleanups and improvements around the various DTC visitor ↵Gravatar nharmata2018-07-30
| | | | | | | | | | | implementations in SkyQuery: (1) Get rid of the 'errorReporter' param used in the two unbounded 'deps' implementations. In practice, this callback is always used right alongside the normal query callback. So we can re-implement it as a single, composite callback. (2) Revert the recent change to processResultsAndReturnTargets (and restore the old method name). It general, it's a bad idea to return Targets outside that method, because it means we aren't respecting the MultisetSemaphore<PackageIdentifier>. Along with (1), this fixes a real issue where DepsUnboundedVisitor#processPartialResults was using Targets (and thus keeping their Packages live in memory) outside of the package semaphore. RELNOTES: None PiperOrigin-RevId: 206606747
* Expanding execution log parser to filter by runner type.Gravatar Googler2018-07-30
| | | | | RELNOTES: Execution Log Parser can now, when printing it out, filter the log by runner type PiperOrigin-RevId: 206602183
* Remove source index from SourceFileArtifactValue.Gravatar felly2018-07-30
| | | | PiperOrigin-RevId: 206586252
* Return Java providers only onceGravatar elenairina2018-07-30
| | | | | | | through JavaInfo, instead of returning them also through ConfiguredTarget. Since these providers can not be found in ConfiguredTarget anymore they have to be retrieved from JavaInfo instead. RELNOTES: None. PiperOrigin-RevId: 206585413
* Add manifestProtoOutput produced during Java compilation to the OutputJar so ↵Gravatar Googler2018-07-30
| | | | | | | that it can be accessed in Skylark. One example where this is used is in Android IDL processing where the manifestProtoOutput is used to split out the Android IDL generated Java classes from the overarching outputJar produced by the android_library rule. RELNOTES: none PiperOrigin-RevId: 206580880
* Add a todo to ProcessUtils to use the new Java 9 APIsGravatar ulfjack2018-07-30
| | | | PiperOrigin-RevId: 206573961
* Allows subclasses of SkyframeExecutor to enable analysis during execution.Gravatar shahan2018-07-30
| | | | PiperOrigin-RevId: 206568465
* Automatic code cleanup.Gravatar Googler2018-07-30
| | | | PiperOrigin-RevId: 206567309
* Make the fallback strategy for Bazel's remote execution configurable.Gravatar philwo2018-07-30
| | | | | | | | | RELNOTES: When using Bazel's remote execution feature and Bazel has to fallback to local execution for an action, Bazel used non-sandboxed local execution until now. From this release on, you can use the new flag --remote_local_fallback_strategy=<strategy> to tell Bazel which strategy to use in that case. PiperOrigin-RevId: 206566380
* Automatic code cleanup.Gravatar Googler2018-07-30
| | | | PiperOrigin-RevId: 206564363
* Windows,tests: port execution_phase_testsGravatar Laszlo Csomor2018-07-30
| | | | | | | | | | | | | | //src/test/shell/integration:execution_phase_tests now runs on Windows. See https://github.com/bazelbuild/bazel/issues/4292 Change-Id: Ia46f26d7fa428cc17cd6988859d427165174fe29 Closes #5688. Change-Id: I5d001825431e8a0ee7d2ce6be911544b72c3bdd2 PiperOrigin-RevId: 206560081
* Windows,tests: port startup_options_testsGravatar Laszlo Csomor2018-07-30
| | | | | | | | | | | | | | //src/test/shell/integration:startup_options_tests now runs on Windows. See https://github.com/bazelbuild/bazel/issues/4292 Change-Id: I255b227f7b6b788f21b45b743e7065a646252a36 Closes #5706. Change-Id: Ibee4997783a820858fc2d2bdda02082a91385d0e PiperOrigin-RevId: 206551029
* Add the ParallelEvaluator.eval call to the ProfilerGravatar ulfjack2018-07-30
| | | | | | | We want to make sure that the profile captures all Skyframe invocations, so that we can catch cases where we accidentally introduce new ones. PiperOrigin-RevId: 206543307
* Windows,tests: port experimental_ui_testGravatar Laszlo Csomor2018-07-30
| | | | | | | | | | | | | | //src/test/shell/integration:experimental_ui_test now runs on Windows. See https://github.com/bazelbuild/bazel/issues/4292 Change-Id: I7997e8a2e8dce9377c0326b9ed3f6c55a09b2708 Closes #5690. Change-Id: I7997e8a2e8dce9377c0326b9ed3f6c55a09b2708 PiperOrigin-RevId: 206535860
* Windows,tests: port loading_phase_testsGravatar Laszlo Csomor2018-07-29
| | | | | | | | | | | | | | | | | | //src/test/shell/integration:loading_phase_tests now runs on Windows. The inherently incompatible parts of the test are now in //src/test/shell/integration:loading_phase_posix_tests See https://github.com/bazelbuild/bazel/issues/4292 Change-Id: I90db31449e72aed2138916eed6289bcc20af5cae Closes #5685. Change-Id: I38727aed1b548ec8b566f99551e63cceac78180b PiperOrigin-RevId: 206533515
* Document AndroidLibrary.java for readability.Gravatar jingwen2018-07-27
| | | | | RELNOTES: None. PiperOrigin-RevId: 206393574
* Blacklist PackageFactory$BuiltInRuleFunction from serialization.Gravatar janakr2018-07-27
| | | | PiperOrigin-RevId: 206389059
* Make sure the --host_platform_remote_properties_override flags isGravatar John Cater2018-07-27
| | | | | | | | | | | | | honored when creating the host platform. Fixes #5695. Change-Id: Iaa99c8189421893440e5e5140450c70de69d7b86 Closes #5696. Change-Id: Iaa99c8189421893440e5e5140450c70de69d7b86 PiperOrigin-RevId: 206371468
* Throw a rule error when a skylark rule implementation returns multiple ↵Gravatar cparsons2018-07-27
| | | | | | | providers of the same type. RELNOTES: A rule error is now thrown if a Skylark rule implementation function returns multiple providers of the same type. PiperOrigin-RevId: 206371385
* Fix crash bug in SkyQuery rdeps when there's a dependency edge filter.Gravatar nharmata2018-07-27
| | | | | RELNOTES: None PiperOrigin-RevId: 206368137
* Automated rollback of commit 71479d3ef1627a30b9ec75ca50e6a90cf7db6377.Gravatar ruperts2018-07-27
| | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** http://https://github.com/bazelbuild/bazel/commit/71479d3ef1627a30b9ec75ca50e6a90cf7db6377 broke thousands of targets in the nightly, notably: //abuse/ares/rulesystem/generator/python/rule_set:main (x1754) //net/encapdecap/common/templates:gen_dr_scopes (x903) //testing/cloud/vex/public:vex_main_internal (x782) //wireless/android/play/playlog/server:playlog_server (x401) *** Original change description *** C++: Removes calls to setCcLinkparamsStore of CcLinkingInfo.Builder This is in preparation for deleting CcLinkParamsStore. All remaining calls to the setCcLinkparamsStore method of the CcLinkingInfo builder have been removed. RELNOTES:none PiperOrigin-RevId: 206361808
* Automated rollback of commit 7e87730de985b7099b9b683571d58efdaab70890.Gravatar ccalvarin2018-07-27
| | | | | | | | | | | | | | | | | *** Reason for rollback *** Go back to the default constructor - instead of requiring everywhere to know the correct hash function, we'll have the default rely on global state. It will make transition easier, even if it makes the origin of the hash less obvious. *** Original change description *** Remove default MD5 in most of Bazel's virtual filesystems. This forces the ex-default to be explicit in a lot of tests, but I'd rather that than have the risk of implicit md5-use in production code. To keep this CL smaller, do not remove the default from UnixFS quite yet. RELNOTES: None. PiperOrigin-RevId: 206358838
* Remove global owners from Bazel CODEOWNERS.Gravatar jingwen2018-07-27
| | | | | | | GitHub assigns *everyone* in a team to a PR, if it matches. Let's not assign everyone to a PR. RELNOTES: None. PiperOrigin-RevId: 206350165
* Skip strict deps suggested fix commands with strict deps disabledGravatar cushon2018-07-27
| | | | | | | instead of just skipping the add dep errors. RELNOTES: follow-up to https://github.com/bazelbuild/bazel/commit/1ac359743176e659e9c7472645e3142f3c44b9e8 PiperOrigin-RevId: 206350053
* Automated rollback of commit db01c6f926bcb4774d901797c59f51dd54c05624.Gravatar janakr2018-07-27
| | | | | | | | | | *** Reason for rollback *** Rolling forward with fixes. *** Original change description *** PiperOrigin-RevId: 206339696
* Update Android owners in Bazel GitHub CODEOWNERSGravatar jingwen2018-07-27
| | | | | RELNOTES: None PiperOrigin-RevId: 206338340
* Simplify tree artifact directory check, and avoid an extra system call.Gravatar felly2018-07-27
| | | | | | RELNOTES: None PiperOrigin-RevId: 206328416
* Repository Options: fix meta dataGravatar Klaus Aehlig2018-07-27
| | | | | | | | | | The "distdir" option is no longer experimental and therefore should not be marked as such. Also, the "experimental_repository_hash_file" and "experimental_verify_repository_rules" are not really about loggig; but they actually are still experimental. Change-Id: I5c30c7c0871822c077a713819ae47b250a7d8a71 PiperOrigin-RevId: 206326885
* Adding option to change the root directory name in build_tar.py and archive.py.Gravatar Googler2018-07-27
| | | | | | | This is required to support Windows Docker image creation. RELNOTES: None PiperOrigin-RevId: 206326316
* Windows,tests: port python_testGravatar Laszlo Csomor2018-07-27
| | | | | | | | | | | | | | //src/test/shell/integration:python_test now runs on Windows. See https://github.com/bazelbuild/bazel/issues/4292 Change-Id: Ie408ea55973a32fc5ee6e74f9bed5e3fa9f818b1 Closes #5684. Change-Id: Ie408ea55973a32fc5ee6e74f9bed5e3fa9f818b1 PiperOrigin-RevId: 206321651
* [singlejar] cleanup port libraryGravatar Loo Rong Jie2018-07-27
| | | | | | | | /cc @laszlocsomor Closes #5655. PiperOrigin-RevId: 206319221
* Add GitHub CODEOWNERS file.Gravatar jingwen2018-07-27
| | | | | | | | | | | | | | With this file, GitHub can automatically assign reviewers for pull requests containing files in component subdirectories. This is a step towards enabling external contributors to be maintainers of components in Bazel. For more information: https://help.github.com/articles/about-codeowners/ GitHub blog post: https://blog.github.com/2017-07-06-introducing-code-owners/ RELNOTES: None. PiperOrigin-RevId: 206318552
* Windows,tests: port progress_reporting_testGravatar Laszlo Csomor2018-07-27
| | | | | | | | | | | | | | //src/test/shell/integration:progress_reporting_test now runs on Windows. See https://github.com/bazelbuild/bazel/issues/4292 Change-Id: Ic6a4c466156e26717beacb3bbbb270a8c2ccccd0 Closes #5675. Change-Id: I4152dbe38a9880cbdad5d897b3d8b082b200552b PiperOrigin-RevId: 206315309
* shell tests: use Bazel-embedded Bash runfiles libGravatar laszlocsomor2018-07-27
| | | | | | | | Use the Bash runfiles library under @bazel_tools, do not depend on it from source. RELNOTES: none PiperOrigin-RevId: 206312278
* Update ProjectFileSupport to take an OptionsParser.Gravatar Googler2018-07-27
| | | | | RELNOTES: None. PiperOrigin-RevId: 206310700
* Add an option to compress the JSON trace profile.Gravatar twerth2018-07-27
| | | | | | | chrome://tracing is able to load gzipped profiles out of the box. RELNOTES: None PiperOrigin-RevId: 206308018
* Add a flag to split test.xml generation into a separate SpawnGravatar ulfjack2018-07-27
| | | | | | | | | | At this time, this is only implemented for the StandaloneTestStrategy. This solves a race condition on Posix-like systems, where we cannot guarantee that the pipes are actually fully flushed to disk when the test process exits, and this can cause the test.xml to be empty, which makes it hard to debug issues. (The test.log files do not show up in normal CI systems, only the test.xml files.) Progress on #4608. PiperOrigin-RevId: 206292179
* Experimental UI: on limited output, reserve capacity for post-build statusGravatar Klaus Aehlig2018-07-27
| | | | | | | | | | | | | When the experimental UI is asked to limit its overall output, reserve a certain fraction for output to be generated after the build is complete. In this way, at least a final status, or a bit of the test summary, is shown. Also, to help staying within the limit also for small limits, from a certain threshold onwards, more severely restrict the output we allow for each individual action. Change-Id: I912aec0dd17639d9864133a10359f93537b473ad PiperOrigin-RevId: 206288651
* C++: Fixes the way errors are checked in tests.Gravatar plf2018-07-27
| | | | | RELNOTES:none PiperOrigin-RevId: 206287557
* Remove load() from contents.Gravatar Googler2018-07-26
| | | | | | | This was missed in earlier patch. RELNOTES: None. PiperOrigin-RevId: 206276771
* Perform strict deps enforcement on compilations with attribution errorsGravatar cushon2018-07-26
| | | | | | | | | | | | | Reporting strict deps errors in addition to attribution errors is helpful particularly with code-generating annotation processors that may fail due to missing transitive deps. Currently those failures prevent add_dep suggestions from being emitted, making the problem harder to diagnose. The presence of other errors may prevent some SJD issues from being detected, but in theory should never lead to spurious SJD errors from being reported, so the additional errors should generally be helpful. PiperOrigin-RevId: 206261677
* Unconditionally run the SJD machinery, which is necessary for jdeps outputGravatar cushon2018-07-26
| | | | | | | | | | | | and just skip the diagnostics at the end if strict deps errors are disabled. This is necessary to javac-turbine, where we don't report strict deps errors (we rely on JavaBuilder for enforcement) but where we still want to emit jdeps. See also bazelbuild/rules_scala#559 PiperOrigin-RevId: 206257304
* Generalize fix to not emit a -gensrc.jar if the annotation processor ↵Gravatar cushon2018-07-26
| | | | | | | | classpath is non-empty but there are no annotation processors to run. PiperOrigin-RevId: 206244327
* Fix skydoc following of nontrivial relative labels.Gravatar cparsons2018-07-26
| | | | | | | Previously, only trivial relative paths (within the same package) were handled correctly. Now paths such as ":foo/bar.bzl" are handled appropriately. RELNOTES: None. PiperOrigin-RevId: 206237161
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-30 04:43:25 +0000