aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Cleanup Skylark types some moreGravatar Francois-Rene Rideau2015-09-17
| | | | | | | | | | | Clarify the criterion for being a valid Skylark value; stop claiming immutability is "the" criterion when Skylark now has mutable values; stop relying on a reflection with a magic list (this also fixes the SkylarkShell build). Clarify the criterion for determining immutable types when making a SkylarkNestedSet. Clarify and use the criterion for being a valid Skylark dict key. -- MOS_MIGRATED_REVID=103313934
* Remove obsolete and deprecated xcode_options flag.Gravatar Googler2015-09-17
| | | | | | | RELNOTES: Remove deprecated xcode_options flag. -- MOS_MIGRATED_REVID=103311963
* Move all J2ObjC Bazel dependencies to third_party/java/j2objc.Gravatar Michael Thvedt2015-09-17
| | | | | -- MOS_MIGRATED_REVID=103303357
* Propogate J2ObjC files from runtime_deps in Java rules.Gravatar Michael Thvedt2015-09-17
| | | | | -- MOS_MIGRATED_REVID=103294328
* Fix Build Encyclopedia links for java_import.Gravatar Googler2015-09-17
| | | | | -- MOS_MIGRATED_REVID=103291087
* Make exception in case a test tries to remote-log more informative.Gravatar Janak Ramakrishnan2015-09-17
| | | | | -- MOS_MIGRATED_REVID=103290841
* Rollback of commit 4e5037520e3067f9d8784e1c59f9545b96111cd4.Gravatar Lukacs Berki2015-09-17
| | | | | | | | | | | | | | | | | *** Reason for rollback *** Broke tests, I mistakenly assumed it was flakiness. *** Original change description *** Remove support for the deprecated include() statement. This is part of the crusade to eliminate as every dependency in Skylark on the rest of the code so that it can be moved deeper in the dependency graph. RELNOTES: The include() statement in BUILD files is not supported anymore. -- MOS_MIGRATED_REVID=103284257
* Create an abstraction for user defined data types in Skylark.Gravatar Lukacs Berki2015-09-17
| | | | | | | This will be used to remove Blaze-specific data types, FilesetEntry, Label and GlobList from the .syntax package. -- MOS_MIGRATED_REVID=103281375
* Remove support for the deprecated include() statement.Gravatar Lukacs Berki2015-09-17
| | | | | | | | | This is part of the crusade to eliminate as every dependency in Skylark on the rest of the code so that it can be moved deeper in the dependency graph. RELNOTES: The include() statement in BUILD files is not supported anymore. -- MOS_MIGRATED_REVID=103279943
* Simplify BuildView construction and store configurations in the build result.Gravatar Ulf Adams2015-09-17
| | | | | | | | | | | | | | | I was persuing the idea that BuildView could become stateless. While that should be possible, we're currently still relying on minimal state in BuildView (from tests at least) in a way that makes it tricky to remove. Instead, I'm now trying to move the BuildView into CommandEnvironment, and create a new one as needed (only for build commands); that makes it safe in the presence of concurrently running commands, as long as they don't use the same BuildView instace. (Of course, allowing commands to run concurrently will need more changes outside of BuildView.) -- MOS_MIGRATED_REVID=103279370
* Make the module environment invoked exit code path thread-safe.Gravatar Ulf Adams2015-09-17
| | | | | | | | | | The module environment can be called from any number of threads, not necessarily from the main thread. I don't know if it's a problem right now - we don't have any problem reports that could be caused by this - but better be safe than sorry. -- MOS_MIGRATED_REVID=103277567
* Remove the now-unused BlazeModule.beforeCommand variant.Gravatar Ulf Adams2015-09-17
| | | | | -- MOS_MIGRATED_REVID=103276489
* Move the clientEnv to the CommandEnvironment.Gravatar Ulf Adams2015-09-17
| | | | | -- MOS_MIGRATED_REVID=103269584
* Refactor Type.getLabels() so that instead of collecting labels, it flattens ↵Gravatar Lukacs Berki2015-09-17
| | | | | | | | | composite types and remove the mention of the type "Label" from the context argument of Type.convert(). This is in preparation of separating build-specific types and types inherent to Skylark. -- MOS_MIGRATED_REVID=103266869
* Stop throwing an exception if a Package was successfully created but ↵Gravatar Janak Ramakrishnan2015-09-17
| | | | | | | | | | | contains errors. Instead, require callers to process the package and throw if they need to. This allows us to avoid embedding a Package in an exception, which is icky. This also allows us to remove Package#containsTemporaryErrors. Most callers' changes are fairly straightforward. The exception is EnvironmentBackedRecursivePackageProvider, which cannot throw an exception of its own in case of a package with errors (because it doesn't do that in keep_going mode), but whose request for a package with errors *should* shut down the build in case of nokeep_going mode. To do this in Skyframe, we have a new PackageErrorFunction which is to be called only in this situation, and will unconditionally throw. EnvironmentBackedRecursivePackageProvider can then catch this exception and continue on as usual, except that the exception will shut down the thread pool in a nokeep_going build. -- MOS_MIGRATED_REVID=103247761
* Fix an issue in which dependent files of translated package-info.java files ↵Gravatar Rumou Duan2015-09-17
| | | | | | | are incorrectly stripped. -- MOS_MIGRATED_REVID=103235923
* Introduce Path#readSymbolicLinkUnchecked, intended to only be used when the ↵Gravatar Nathan Harmata2015-09-17
| | | | | | | caller already knows the path is a symlink, and use this new method throughout the codebase. -- MOS_MIGRATED_REVID=103229983
* Added support for scalac and jvm_flags in scala_[library|binary]. Fixes #457.Gravatar John Sullivan2015-09-16
| | | | | | -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/459 MOS_MIGRATED_REVID=103229152
* Remove unused 'followSymlinks' parameter to FileSystem#getxattr. It is ↵Gravatar Nathan Harmata2015-09-16
| | | | | | | always true in practice. -- MOS_MIGRATED_REVID=103221081
* Deflake maven_testGravatar Kristina Chodorow2015-09-16
| | | | | | | | Change the test to only starts up the fileserver when needed, not before each test case, to prevent timeouts. -- MOS_MIGRATED_REVID=103216306
* Remove commentGravatar Miguel Alcon Pinto2015-09-16
| | | | | | | | | | | | Also includes the following changes: Fix a bug in which the dead code pruner throws if users specify J2ObjC proto classes as entry classes. -- Make skyquery more optimal. -- MOS_MIGRATED_REVID=103213483
* Teach Bazel to accept assembler-without-preprocessor source files.Gravatar Googler2015-09-16
| | | | | | | | | | | Adding the accepted file extensions was a minor issue. The bulk of this change was to weaken the assertion that all cxx compiler actions produce a '.d' file. RELNOTES[NEW]: a cc_binary rule may list '.s' and '.asm' files in the srcs -- MOS_MIGRATED_REVID=103196242
* Add a maven_server ruleGravatar Kristina Chodorow2015-09-16
| | | | | | | | This will also be used for authentication, but that has not been implemented yet. -- MOS_MIGRATED_REVID=103194964
* Makes the generation of the Info.plist environment variables fail-safe.Gravatar Anastasios Kakalis2015-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | | This prevents the invocation from failing, when one of the variables could not be discovered (and mimics the behavior of Xcode 7.1 and SDK 9.1). An example generated with SDK 9.1 { ... BuildMachineOSBuild = 14F27; DTCompiler = "com.apple.compilers.llvm.clang.1_0"; DTPlatformBuild = ""; DTPlatformVersion = "9.1"; DTSDKBuild = 13B5110e; DTXCodeBuild = 7B60; DTXcode = 0710; ... } RELNOTES: -- MOS_MIGRATED_REVID=103191602
* Move several parts of BlazeRuntime to CommandEnvironment.Gravatar Ulf Adams2015-09-16
| | | | | | | | The main piece is the blaze module environment, which is only valid during command execution. Also configuration creation and precompleteCommand. -- MOS_MIGRATED_REVID=103186467
* Defer Label parsing from BuildFileAST to PackageFunction so that ↵Gravatar Lukacs Berki2015-09-16
| | | | | | | BuildFileAST doesn't have to know about the existence of Labels. -- MOS_MIGRATED_REVID=103181342
* Change checkRuntime to take a CommandEnvironment instead.Gravatar Ulf Adams2015-09-16
| | | | | | | | | I wanted to merge it into beforeCommand, but the reporter isn't set up yet when we call beforeCommand. Hopefully we can refactor the code to merge it in the future. -- MOS_MIGRATED_REVID=103179268
* Add maven settings librariesGravatar Kristina Chodorow2015-09-16
| | | | Change-Id: I4eb8d305274121733ff7e146d8bcac6874de6158
* Remove a few minor lib.syntax -> lib.packages dependencies.Gravatar Lukacs Berki2015-09-16
| | | | | | | We want to move Skylark as down on the dependency graph as possible. The immediate motivation is to move Label to the lib.cmdline package, but this is a good idea nevertheless. -- MOS_MIGRATED_REVID=103178549
* Add experimental flag, that partially disables loading phase (pattern ↵Gravatar Marian Lobur2015-09-16
| | | | | | | evaluation, test_suite expansion and configuration creation is still there). Also remove some unused code. -- MOS_MIGRATED_REVID=103177839
* Change most calls to BlazeRuntime.getReporter() to use CommandEnvironment.Gravatar Ulf Adams2015-09-16
| | | | | -- MOS_MIGRATED_REVID=103175472
* Minor visibility tweaksGravatar Michajlo Matijkiw2015-09-16
| | | | | -- MOS_MIGRATED_REVID=103140718
* Don't allow subclasses of AQV to treat Errors as non-critical. Also update ↵Gravatar Nathan Harmata2015-09-16
| | | | | | | the documentation for AQV#work to reflect the semantics of critical errors. -- MOS_MIGRATED_REVID=103140100
* Increase the size of ijar_testGravatar Damien Martin-Guillerez2015-09-16
| | | | | | | It is timingout on our Darwin CI machine, see http://ci.bazel.io/job/Bazel/PLATFORM_NAME=darwin-x86_64/110/console -- MOS_MIGRATED_REVID=103130707
* Fix very minor concurrency issue in AQV. 'unhandled' doesn't have memory ↵Gravatar Nathan Harmata2015-09-16
| | | | | | | visibility from other threads, so we may end up storing the non-first unhandled exception and/or decline to not run new tasks because we don't realize there already is an unhandled exception. -- MOS_MIGRATED_REVID=103127733
* Get rid of transient errors during preprocessing and throw IOExceptions ↵Gravatar Janak Ramakrishnan2015-09-16
| | | | | | | instead. Transient errors were only detected on IOExceptions, but preprocessing doesn't actually throw IOExceptions except if it fails before it even opens the main file, so there's no sense in trying to construct a package in that case. -- MOS_MIGRATED_REVID=103119445
* Clean up J2ObjC support in Bazel, removing an unused dependency and linting ↵Gravatar Michael Thvedt2015-09-15
| | | | | | | the relevant files. -- MOS_MIGRATED_REVID=103100493
* Removed attribute 'generator_location' from rules created by Skylark macros.Gravatar Florian Weikert2015-09-15
| | | | | -- MOS_MIGRATED_REVID=103090380
* Add a test for FileSystem#resolveSymbolicLinks for dangling symlinks.Gravatar Nathan Harmata2015-09-15
| | | | | -- MOS_MIGRATED_REVID=103090211
* Only collect source files from attributes that don't have instrumentation data.Gravatar Ulf Adams2015-09-15
| | | | | | | | This fixes a recent regression in coverage; it's currently collecting too many files for instrumentation for non-compiled languages. -- MOS_MIGRATED_REVID=103089788
* Support java_test and java_binary in AndroidStudioInfoAspect.Gravatar Dmitry Lomov2015-09-15
| | | | | -- MOS_MIGRATED_REVID=103089400
* Parse the label syntax "@//a:b" so that eventually we can make that the ↵Gravatar Lukacs Berki2015-09-15
| | | | | | | | | syntax that means "refer to the main repository". There isn't an overarching plan for what we are going to do with the cmdline package, which seems to be separated from the .syntax one in all sorts of awkward ways. -- MOS_MIGRATED_REVID=103088960
* Some minor updates to the BUILD files.Gravatar Ulf Adams2015-09-15
| | | | | -- MOS_MIGRATED_REVID=103087492
* Add self-time relative to total time in HTML profiling output, enables ↵Gravatar Klaas Boesche2015-09-15
| | | | | | | finding optimizable functions faster. -- MOS_MIGRATED_REVID=103081207
* Add a paragraph to the Build Encyclopedia that tells how to use the ↵Gravatar Lukacs Berki2015-09-15
| | | | | | | appcompat library. -- MOS_MIGRATED_REVID=103080967
* Introduce CommandEnvironment and pass it instead of BlazeRuntime.Gravatar Ulf Adams2015-09-15
| | | | | | | | The very long term plan is to make BlazeRuntime immutable, so that we can run multiple commands in the same server. -- MOS_MIGRATED_REVID=103080946
* Support java_import in AndroidStudioIdeInfoAspectGravatar Dmitry Lomov2015-09-15
| | | | | -- MOS_MIGRATED_REVID=103079877
* refactor usage of ProfilePhaseStatistics, no need to hand it around via ChartGravatar Klaas Boesche2015-09-15
| | | | | -- MOS_MIGRATED_REVID=103079475
* Parses the correct values of SDK, Platform and XCode version numbers when ↵Gravatar Anastasios Kakalis2015-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | generating the environment's plist. The script no longer parses the values from the Platform's Info.plist, which contained the values used to compile the Platform's library *itself*, rather than the values of the actual running environment. Also the BuildMachineOSBuild is being read from the sw_version, rather than the Xcode's plist, and the DTSDKBuild is determined by the plist under sdk-path. An example environment.plist: { BuildMachineOSBuild = 14F27; DTCompiler = "com.apple.compilers.llvm.clang.1_0"; DTPlatformBuild = 12H141; DTPlatformVersion = "8.4"; DTSDKBuild = 12H141; DTXCodeBuild = 6E35b; DTXcode = 0640; } -- MOS_MIGRATED_REVID=103079006
* Fixes ijar tests on OSXGravatar Damien Martin-Guillerez2015-09-15
| | | | | | | | | Two things were broken: - Paths to zip/unzip when in the PATH by latest change - md5sum was broken by FreeBSD change -- MOS_MIGRATED_REVID=103077733