aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Replace calls to <class>.newInstance with <class>.getConstructor().newInstance.Gravatar Ulf Adams2016-08-12
| | | | | | | This is safer; newInstance on class objects bypasses exception checking. -- MOS_MIGRATED_REVID=129976805
* cpp: remove unused WaitForServerDeath() functionGravatar Thiago Farina2016-08-12
| | | | | | | | | | It is unused since commit f107debac45ddf5859b1eb963379769b5815b18f: (" Remove the AF_UNIX client/server communication"). -- Change-Id: Ia4051eb518ab7e97fb0523b0b3cdb4c0f19e704c Reviewed-on: https://bazel-review.googlesource.com/#/c/4290 MOS_MIGRATED_REVID=129971957
* Continuing removing GUAVA dependencies from junitrunner (junit.runner.model).Gravatar Elena-Irina Iancu2016-08-11
| | | | | | | | | | | | | | | | | | Bazel users that are using a different Guava version than the one in the junitrunner jar are getting an IncompatibleClassChangeError. This CL rewrites parts of junitrunner code so it won't depend on Guava anymore. Continuing progress on issue #1150. Removing most of Guava dependencies from junit.runner.model, more significant changes include converting ImmutableMap/List to Map/List and converting Optional<> objects to nullable objects, removing all nullable checks regarding them. CL also removes previous trailing spaces and replaces LinkedList<> with ArrayList<>. -- MOS_MIGRATED_REVID=129960401
* Add ide-compile output group to IDE aspect.Gravatar Googler2016-08-11
| | | | | | | | | | | | This output group will contain all artifacts that are needed to compile the project (and get compilation errors), but aren't needed during the resolve step. Initially ide-compile is the object file output from any cc_* rule, so we can get compile errors. -- MOS_MIGRATED_REVID=129937436
* The Android transition requires a valid CPU value. If we don't have one, ↵Gravatar Googler2016-08-11
| | | | | | | | | don't do the split. RELNOTES: Disable the Android split transition if --android_cpu and fat_apk_cpu are both empty. -- MOS_MIGRATED_REVID=129931354
* Rollback of commit fbaa700337bf0cf9083f083e6cd0d2f82faf1506.Gravatar Googler2016-08-11
| | | | | | | | | | | | | | | | *** Reason for rollback *** I want to do this in a way that exposes the data attribute only for android_test and android_binary, so I'll add it to the deploy manifest instead. *** Original change description *** Expose test "data" attribute to IDE. This is needed to deploy android_tests to the device for testing. For symmetry we expose it for all tests rules. -- MOS_MIGRATED_REVID=129926351
* Sets SONAME on shared objects in Android binaries.Gravatar Adam Michael2016-08-11
| | | | | | | | | | | | | | | Adds a linker flag to set the internal DT_SONAME. This fixes #1578 for SDK 24 and removes the warnings for previous SDKs. There is no need to set the linker flag for android_librarys that depend on native code, because the linker flag will be set by the android_binarys that depend on that android_library. Testing is done via `readelf` executable that is shipped with the NDK. -- Change-Id: I16fdfe6522c8694ce51554289122bf035a61d9ec Reviewed-on: https://bazel-review.googlesource.com/#/c/4302/ MOS_MIGRATED_REVID=129920256
* Fix bug in ParallelEvaluator when an error dep was not newly requested in a ↵Gravatar Janak Ramakrishnan2016-08-11
| | | | | | | | | nokeep_going build because it finished building in between the time it was first requested and when we checked it for done-ness after the SkyFunction evaluation. This results in an IllegalStateException that gets ignored (and, importantly, not propagated) by AbstractQueueVisitor because AbstractQueueVisitor only records and propagates the first Throwable encountered. For nokeep_going evaluations, this will be the SchedulerException that we use for control flow. The IllegalStateException in question is benign in this case because it's merely from a Preconditions failure and doesn't leave anything in a bad state. It's possible, though, that we have other bugs that are being masked in this way. -- MOS_MIGRATED_REVID=129919336
* Minimize ArrayList resizing in MutableList constructionGravatar Michajlo Matijkiw2016-08-11
| | | | | | | | | Specialize the creation of internal contents if we have a collection and can properly presize the ArrayList (this is almost always the case), and provide a special case constructor for concat. -- MOS_MIGRATED_REVID=129919134
* Fix typo in X86CrosstoolsGravatar sergey2016-08-11
| | | | | | | | | | Because of this the combination of `--fat_apk_cpu=x86 --android_compiler=clang3.8 --compilation_mode=dbg` was broken. Closes #1588. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/1588 MOS_MIGRATED_REVID=129918785
* Expose test "data" attribute to IDE.Gravatar Googler2016-08-11
| | | | | | | | This is needed to deploy android_tests to the device for testing. For symmetry we expose it for all tests rules. -- MOS_MIGRATED_REVID=129918247
* Properly size compact hash map in order to mitigate GC churn.Gravatar Eric Fellheimer2016-08-11
| | | | | -- MOS_MIGRATED_REVID=129912633
* Rollback of commit 6aa2f64045d390f4da77d396cd3fcbe1c44a98c1.Gravatar Chris Parsons2016-08-11
| | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks release. *** *** Original change description *** Fix Environment.Continuation's tracking of global variables RELNOTES[INC]: Skylark: It is an error to shadow a global variable with a local variable after the global has already been accessed in the function. -- MOS_MIGRATED_REVID=129910501
* Delete unused classesGravatar Michajlo Matijkiw2016-08-11
| | | | | -- MOS_MIGRATED_REVID=129910435
* Dynamic config test improvements:Gravatar Greg Estren2016-08-11
| | | | | | | | - Adds a helper routine to get all configured targets with a given label - Enhances latebound split test to check that deps actually take expected configurations -- MOS_MIGRATED_REVID=129906477
* Refactors out ProtocolBuffers2 related code into it's own class. This is the ↵Gravatar Sergio Campama2016-08-11
| | | | | | | | | first step into integrating the grouping behavior for proto targets using the new library. There's no change in functionality, only restructuring of code. -- MOS_MIGRATED_REVID=129903574
* Roll forward commit 94c86135d05a1844263c59f3ce6b1c1917e0f4c8Gravatar Liam Miller-Cushon2016-08-11
| | | | | | | And don't provide a default value for :java_launcher -- MOS_MIGRATED_REVID=129900898
* Get rid of InvalidatableGraph. This explicit concept is no longer needed.Gravatar Nathan Harmata2016-08-11
| | | | | -- MOS_MIGRATED_REVID=129895423
* Add 'provider()' function.Gravatar Dmitry Lomov2016-08-11
| | | | | -- MOS_MIGRATED_REVID=129889793
* Turn on output tree tracking.Gravatar Eric Fellheimer2016-08-11
| | | | | -- MOS_MIGRATED_REVID=129887102
* Put runfiles tree under 'runfiles' directory to avoid conflictGravatar Yun Peng2016-08-11
| | | | | | | | | | | | | Currently, in python executable zip file, the default workspace name "__main__" conflicts with __main__.py file. This change fixes it. Also refactored the bazel_windows_example_test -- Change-Id: I8b9d64d72335148dba41032ce93643d34670a771 Reviewed-on: https://bazel-review.googlesource.com/#/c/5351 MOS_MIGRATED_REVID=129879570
* Store non-code inputs to link actions separately.Gravatar Lukacs Berki2016-08-11
| | | | | | | | | | | | This is a re-submission of commit 99de0d07574f808fee36826289cb1f5c83e3b3e0 (rolled back in commit eff8b365c172b7e904ac6f7bba0c893fed7c91a8) and a few tweaks: - The fix for the bug that caused the rollback (see line 888 in CppModel.java -- we now use addNonCodeInputs() instead of addObjectFiles() to pass in the processed header tokens) - A few extra assertions - A test case - The re-submission of the parts of commit 603b540bbcd7414cd3e2c0b92c1c8985b035e41b that were also rolled back as collateral damage. The bug report didn't contain a precise reproduction, but the bug is trivial enough that I'm comfortable with things this way. -- MOS_MIGRATED_REVID=129872117
* Provide ExtraCombiner method.Gravatar Sasha Smundak2016-08-11
| | | | | -- MOS_MIGRATED_REVID=129870872
* Get rid of python exectuable zip file headerGravatar Yun Peng2016-08-11
| | | | | | | | | | | | | We don't have to add the stub_template.txt as the python zip file header except a simple '#!/usr/bin/env python' shebang, because it's equivalent to 'python <file>'. Apparently, python checks the file type firstly, if it's a zip file, it will find and run __main__.py instead of running the header script. -- Change-Id: Icbd3bacacc3857dc3b857d3a7cb770fd94362b9d Reviewed-on: https://bazel-review.googlesource.com/#/c/5350 MOS_MIGRATED_REVID=129870674
* Substituted NoSuchVariableException with manual checks for performance purposesGravatar Vladimir Moskva2016-08-11
| | | | | -- MOS_MIGRATED_REVID=129869968
* Remove all temporary detrius upon exiting objc action scripts.Gravatar Peter Schmitt2016-08-11
| | | | | -- MOS_MIGRATED_REVID=129867284
* Update the proto library version in BUILD filesGravatar Kristina Chodorow2016-08-11
| | | | | -- MOS_MIGRATED_REVID=129865689
* Add brandjon@ to CONTRIBUTORSGravatar Jon Brandvein2016-08-11
| | | | | -- MOS_MIGRATED_REVID=129864137
* Remove the experimental hardlink / junction code from UnixFileSystem.Gravatar Ulf Adams2016-08-11
| | | | | -- MOS_MIGRATED_REVID=129863453
* Add 3.0.0 beta 4 version of protobuf to third_partyGravatar Kristina Chodorow2016-08-10
| | | | Change-Id: I1505726ca66ab578cf29d2dc6018a2ff1e2ccaaf
* Don't follow symlink when looking for python module space, since it breaks ↵Gravatar Yue Gan2016-08-10
| | | | | | | | | sandbox on Mac and is also not necessary. Fixes #1625. -- MOS_MIGRATED_REVID=129860300
* Remove the outputPath parameter from BlazeModule.getFileSystem.Gravatar Ulf Adams2016-08-10
| | | | | | | | It's never used, and it's tricky to run with multiple different file systems in the same process -> remove it to simplify. -- MOS_MIGRATED_REVID=129858142
* Dedupe code: parse startup options in newRuntime, instead of calling it twice.Gravatar Ulf Adams2016-08-10
| | | | | -- MOS_MIGRATED_REVID=129856323
* Pass in the command options to BlazeModule.getCoverageReportFactory.Gravatar Ulf Adams2016-08-10
| | | | | | | This allows us to make the coverage module stateless if it depends on options. -- MOS_MIGRATED_REVID=129852270
* Added support for null terminated queries.Gravatar Andreas Bergmeier2016-08-10
| | | | | | | | Closes #1496. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/1496 MOS_MIGRATED_REVID=129846158
* Cleanup BlazeRuntime and ServerBuilder slightly.Gravatar Ulf Adams2016-08-10
| | | | | -- MOS_MIGRATED_REVID=129843837
* Move workspace initialization out of BlazeRuntime.Builder.Gravatar Ulf Adams2016-08-10
| | | | | | | Require all callers to call initWorkspace after BlazeRuntime construction. -- MOS_MIGRATED_REVID=129842292
* Implements dynamic split transitions on latebound attributes.Gravatar Greg Estren2016-08-10
| | | | | | | | | With this change, dynamic configs are at full feature parity for split transitions (minus some small differences in composed transitions from BuildConfigurationCollection.configurationHook). -- MOS_MIGRATED_REVID=129802414
* Rollback of commit 99de0d07574f808fee36826289cb1f5c83e3b3e0.Gravatar Googler2016-08-10
| | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Makes blaze unable to build //third_party/stl IllegalArgumentException: complex.h.processed at com.google.common.base.Preconditions.checkArgument(Preconditions.java:127) at com.google.devtools.build.lib.util.Preconditions.checkArgument(Preconditions.java:38) at com.google.devtools.build.lib.rules.cpp.CppLinkActionBuilder.addObjectFile(CppLinkActionBuilder.java:831) NOT a clean rollback; conflict in one file (CppCompilationContext.java). So this also partially rolls back commit 603b540bbcd7414cd3e2c0b92c1c8985b035e41b (just the change in that file). *** Original change description *** Cleanup: store non-code inputs to link actions separately. -- MOS_MIGRATED_REVID=129798636
* Refactor JavaCompileAction in preparation for adding minimum classpath ↵Gravatar Googler2016-08-10
| | | | | | | optimization, second attempt. -- MOS_MIGRATED_REVID=129797456
* Allow ImplicitOutputsFunctions to be overriden on Rule creation.Gravatar Michajlo Matijkiw2016-08-10
| | | | | -- MOS_MIGRATED_REVID=129787305
* Using stub_template.txt as __main__.py and zip header in python executable zipGravatar Yun Peng2016-08-10
| | | | | | | | | | | | | | | | | | In stub_template.txt, we now unzip the python zip file to a temp directory if needed. This will get rid of bash in python executable file completely. Users can run the binary directly or using python <zip>, like: ./bazel-bin/examples/py_native/bin or python ./bazel-bin/examples/py_native/bin On Windows, we can use the second way to run python binary from native Windows command line (cmd.exe). -- Change-Id: I73fdd88f05f8f343dd19b2f3686ae031dfb476ba Reviewed-on: https://bazel-review.googlesource.com/#/c/5310 MOS_MIGRATED_REVID=129767890
* Combiners overhaul: introduce Combiner interface common to all combiners, ↵Gravatar Sasha Smundak2016-08-10
| | | | | | | use it instead of switch statement in output_jar. Move implementations to combiners.cc -- MOS_MIGRATED_REVID=129763019
* Update DensitySpecificManifestProcessor to omit a <compatible-screens> ↵Gravatar Googler2016-08-10
| | | | | | | | | | | declaration from the generated manifest if the list of requested densities contains an unsupported density. Typically, the DensitySpecificManifestProcessor will add a <compatible-screens> declaration with a <screen> element for every density specified in the "densities=" argument of the android_binary build rule. If the "densities=" argument includes a density not officially supported by the Play Store, it will throw an exception and the build will fail. After this change, an build rule that explicitly specifies a density not officially supported by the Play Store will instead result in the <compatible-screens> declaration being omitted from the generated manifest, indicating that the APK can support all densities. -- MOS_MIGRATED_REVID=129761968
* Apply extra actions to top-level aspects.Gravatar Dmitry Lomov2016-08-10
| | | | | -- MOS_MIGRATED_REVID=129759632
* Continuing removing GUAVA dependencies from junitrunner.Gravatar Elena-Irina Iancu2016-08-10
| | | | | | | | | | | Bazel users that are using a different Guava version than the one in the junitrunner jar are getting an IncompatibleClassChangeError. This CL rewrites parts of junitrunner code so it won't depend on Guava anymore. Continuing progress on issue #1150. Removed Guava dependencies, except for Supplier and Ticker, from junit.runner.junit4. -- MOS_MIGRATED_REVID=129757029
* Allow extra action inputs and variables extensions to boe propagated to theGravatar Cal Peyser2016-08-10
| | | | | | | CppLinkAction. -- MOS_MIGRATED_REVID=129753508
* Drive-by cleanup to remove unnecessary function from the ActionCache interface.Gravatar Shreya Bhattarai2016-08-10
| | | | | -- MOS_MIGRATED_REVID=129753109
* Rephrase tests so that they can be shared between objc_library andGravatar Cal Peyser2016-08-10
| | | | | | | | | | | experimental_objc_library. Do this by introducing CommandAction, which contains the common interface of SpawnAction and CppCompileAction needed for testing. This change will allow compilation, linking, and archiving tests to be copied over into the experimental tests. -- MOS_MIGRATED_REVID=129749930
* Do not add useless library files to the inputs of the linker action.Gravatar Lukacs Berki2016-08-10
| | | | | | | These are not mentioned on the linker command line, and as such, are useless. -- MOS_MIGRATED_REVID=129746593