| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Technically, this code is incorrect, because we're calling into spawn strategy,
which might do any amount of additional waiting (e.g., to acquire local
resources). We should change spawn strategy to return structured information
about the subprocess execution, including the wall time, and use that to set
the test information. But for now, this seems good enough.
Fixes #1748.
--
PiperOrigin-RevId: 144082073
MOS_MIGRATED_REVID=144082073
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add backquotes around the changelog
- Add empty line at the end of the changelog
- Enforce the use of the master changelog prior to release
Fixes #2281.
--
Change-Id: I449f5209a6b05e65411a64ce82ea1d89d60ee4d3
Reviewed-on: https://cr.bazel.build/8044
PiperOrigin-RevId: 144080940
MOS_MIGRATED_REVID=144080940
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
*still* does not work with Windows:
http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=windows-x86_64/lastBuild/console
*** Original change description ***
Jarjar the third-party dependencies of the Jacoco test runner.
This is an encore of commit 823091f7516abf7d854021edc765daf1467f1647, which failed because Java temp directory handling in actions is broken at the moment.
Fixes #2343.
--
PiperOrigin-RevId: 144076235
MOS_MIGRATED_REVID=144076235
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the patch-id differ because of merge conflict or subtle adjacent
change, the cherrypick origin was missing, resulting in non existent
cherrypick lines in the changelog.
If the cherrypicks are done by the script, adds the cherrypick origin
to a git note and use that origin when generating the release note. Also
fallback to the commit hash of the resulting commit if the cherrypick
origin cannot be found.
Fixes #2272.
--
Change-Id: I311bbe777ea82be05f9fba0a658bab075ed1bd97
Reviewed-on: https://cr.bazel.build/8042
PiperOrigin-RevId: 144075867
MOS_MIGRATED_REVID=144075867
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144074221
MOS_MIGRATED_REVID=144074221
|
|
|
|
|
|
|
|
| |
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 144073888
MOS_MIGRATED_REVID=144073888
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144072456
MOS_MIGRATED_REVID=144072456
|
|
|
|
|
|
|
|
| |
08426525c517599a76b4f69814baf28731e840c7 .
--
PiperOrigin-RevId: 144071698
MOS_MIGRATED_REVID=144071698
|
|
|
|
|
|
|
|
|
| |
This cl exposes param files that were hard-coded before. This enables more
precise placement on the link command line.
--
PiperOrigin-RevId: 144069927
MOS_MIGRATED_REVID=144069927
|
|
|
|
|
|
|
|
| |
RELNOTES[INC]: Deprecated globals HOST_CFG and DATA_CFG are removed. Use strings "host" and "data" instead.
--
PiperOrigin-RevId: 144069794
MOS_MIGRATED_REVID=144069794
|
|
|
|
|
|
|
|
| |
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 144068695
MOS_MIGRATED_REVID=144068695
|
|
|
|
|
|
|
|
|
|
| |
This is part of a sequence of changes to update the test strategies; most of
the actual code changes in this specific change is Google-internal, but I'm
planning to update the external test strategies as well.
--
PiperOrigin-RevId: 144064802
MOS_MIGRATED_REVID=144064802
|
|
|
|
|
|
|
|
| |
package.
--
PiperOrigin-RevId: 144064682
MOS_MIGRATED_REVID=144064682
|
|
|
|
|
|
|
|
|
| |
For now, only for aspects, but eventually expand to Attribute's
mandatory providers as well.
--
PiperOrigin-RevId: 144063369
MOS_MIGRATED_REVID=144063369
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because CreateProcessW doesn't support long paths,
not even with the "\\?\" prefix [1], we need to
convert long paths to short ones to spawn
processes. This change implements the
corresponding function and uses it in
blaze_util_windows.
[1] https://github.com/bazelbuild/bazel/issues/2181#issuecomment-270696173
See https://github.com/bazelbuild/bazel/issues/2107
See https://github.com/bazelbuild/bazel/issues/2181
--
PiperOrigin-RevId: 144062404
MOS_MIGRATED_REVID=144062404
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This method was only used by the Windows-specific
code so move it there and adapt it to Windows
paths.
Update AsWindowsPath to normalize its output: this
is necessary because AsWindowsPath's output is a
widechar path string which we often prefix with
the UNC prefix, but such paths must be normalized
(the kernel won't do it if the path has an UNC
prefix).
Finally, add an AsWindowsPathWithUncPrefix method
which does what the name suggests: converts the
path to Windows path, makes it absolute, and adds
the UNC prefix if necessary. (This is a very common
operation when calling WinAPI functions and we'll
use it a lot in subsequent changes.)
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 144060297
MOS_MIGRATED_REVID=144060297
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. no flag: only the direct reason is given (command execution termination status), and also the instruction to use "--verbose_failures"
2. flag "--verbose_failures": gives failed execution command and the instruction to use "--sandbox_debug --strategy"
3. flag "--verbose_failures --sandbox_debug": gives failed execution command, debugging message from sandboxing, and the instruction to use "--strategy"
Also removes "cd <sandbox_path>" in given failed command, since debugging is only necessary with flag "--verbose_failures --sandbox_debug" and the path is already given in sandboxing debugging message.
Addresses #2174.
Fixes bazel_sandboxing_test.sh and bazel_test_test.sh for the new error message.
--
PiperOrigin-RevId: 144058351
MOS_MIGRATED_REVID=144058351
|
|
|
|
|
|
|
|
| |
No production code should depend on inmemoryfs.
--
PiperOrigin-RevId: 144054981
MOS_MIGRATED_REVID=144054981
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144054816
MOS_MIGRATED_REVID=144054816
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144053696
MOS_MIGRATED_REVID=144053696
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144039394
MOS_MIGRATED_REVID=144039394
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144010091
MOS_MIGRATED_REVID=144010091
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Set status to implementing
2. Reorder the list of tasks because we need to invalidate correctly
Skylark repositories before enabling environ parameter.
3. Fix the step 2 (was step 3) in order to pass a map instead of
creating a new function.
--
Change-Id: I9387ccedf75d63fef7e2e9546dc1f0421cb12679
Reviewed-on: https://cr.bazel.build/7972
PiperOrigin-RevId: 143999391
MOS_MIGRATED_REVID=143999391
|
|
|
|
|
|
|
|
|
|
| |
source jars.
In the j2objc dead code removal script, quote the object file names when invoking ar. They may contain special shell characeters.
--
PiperOrigin-RevId: 143993977
MOS_MIGRATED_REVID=143993977
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143991903
MOS_MIGRATED_REVID=143991903
|
|
|
|
|
|
|
|
| |
* Also make constants private since they both have getters now.
--
PiperOrigin-RevId: 143973536
MOS_MIGRATED_REVID=143973536
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143972504
MOS_MIGRATED_REVID=143972504
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
== Before this change ==
Previously, if a and b are sets, then a + b created a new set c whose direct and transitive elements were all those of a, and with b appended as an additional transitive element. If on the other hand b is a list instead of a set, then its contents were appended as additional direct elements of c. In both cases, you can think of c as a copy of a that also knows about b.
This copying of a's elements into c can lead to accumulation when you do it repeatedly, e.g. x += y in a loop. Each union can take O(n) time so you get O(n^2) time overall. Nested set union is supposed to be O(1) time per operation and O(n) time overall.
It also leads to surprising iteration orders. If you do a + b + c + d (left-associative), where each one is a set, then when you do a post-order traversal you get the elements of b, c, d, and a, in that order. This is because b, c, and d each get appended as transitive children of the copies of a.
== After this change ==
If a and b are sets, then a + b returns a new set c with a and b as its two transitive children. If b is a list, then c has a as its only transitive child and b's elements as its only direct elements. This is straightforward, O(1), and avoids the problem with the confusing order.
It is implemented by removing the items/transitiveItems fields and just relying on NestedSetBuilder.
RELNOTES[INC]: (Skylark) Set union is now O(1). As a side-effect, the iteration order of sets produced by union has changed. "print(set([1]) + set([2]) + set([3]))" will now give back the order 1, 2, 3 instead of 2, 3, 1.
--
PiperOrigin-RevId: 143972165
MOS_MIGRATED_REVID=143972165
|
|
|
|
|
|
|
|
|
|
|
| |
We may not assume that those are pulled in by other
header files; in fact, they are not on FreeBSD stable/11.
--
Change-Id: Ic976cc71968aab0a1c3d6652fe8d8f1c4afa480b
Reviewed-on: https://cr.bazel.build/8145
PiperOrigin-RevId: 143970238
MOS_MIGRATED_REVID=143970238
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes #2311
Closes #2312.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/2312
PiperOrigin-RevId: 143967880
MOS_MIGRATED_REVID=143967880
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test was still using the old path syntax that is deprecated,
use the label syntax instead.
Note that there is still several instance of that old syntax
in our tests:
```
grep -E -r 'load\(['"'"'"]/[^/]' src/test | wc -l
109
```
--
Change-Id: Id2d1a9a525f1584136501026de01cf53e2263c3f
Reviewed-on: https://cr.bazel.build/8135
PiperOrigin-RevId: 143967775
MOS_MIGRATED_REVID=143967775
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143966520
MOS_MIGRATED_REVID=143966520
|
|
|
|
|
|
|
|
|
|
| |
This is an encore of commit 823091f7516abf7d854021edc765daf1467f1647, which failed because Java temp directory handling in actions is broken at the moment.
Fixes #2343.
--
PiperOrigin-RevId: 143961605
MOS_MIGRATED_REVID=143961605
|
|
|
|
|
|
|
|
| |
The skylark provider is bound as "proto_java" to avoid collisions with the base, which is called "java".
--
PiperOrigin-RevId: 143960605
MOS_MIGRATED_REVID=143960605
|
|
|
|
|
|
|
|
|
|
| |
This feature allows us to expand a flag_group when a build variable is not
available. This is helpful when migrating crosstools in a backward compatible
way (that works with released bazel as well as with bazel at HEAD).
--
PiperOrigin-RevId: 143955333
MOS_MIGRATED_REVID=143955333
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks //src/test/shell/bazel:bazel_sandboxing_test:
http://ci.bazel.io/job/bazel-tests/lastCompletedBuild/BAZEL_VERSION=latest-jdk7,PLATFORM_NAME=linux-x86_64/testReport/(root)/(empty)/test_failing_action_with_ioexception_while_copying_outputs_throws_correct_exception/
*** Original change description ***
Gives 3 levels of sandbox error message under different flags.
1. no flag: only the direct reason is given (command execution termination status), and also the instruction to use "--verbose_failures"
2. flag "--verbose_failures": gives failed execution command and the instruction to use "--sandbox_debug --strategy"
3. flag "--verbose_failures --sandbox_debug": gives failed execution command, debugging message from sandboxing, and the instruction to use "--strategy"
Also removes "cd <sandbox_...
***
ROLLBACK_OF=143937589
--
PiperOrigin-RevId: 143951901
MOS_MIGRATED_REVID=143951901
|
|
|
|
|
|
|
|
| |
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 143950681
MOS_MIGRATED_REVID=143950681
|
|
|
|
|
|
|
|
|
| |
We were previously jumping through hoops to avoid cyclic dependencies. It's
unclear why the class was here in the first place rather than in lib.actions.
--
PiperOrigin-RevId: 143948959
MOS_MIGRATED_REVID=143948959
|
|
|
|
|
|
|
|
|
|
|
| |
Use std::ostringstream instead of string concats
when building a command line, for more efficiency.
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 143947880
MOS_MIGRATED_REVID=143947880
|
|
|
|
|
|
|
|
|
| |
See https://github.com/bazelbuild/bazel/issues/2107
See https://github.com/bazelbuild/bazel/issues/2181
--
PiperOrigin-RevId: 143947877
MOS_MIGRATED_REVID=143947877
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143939410
MOS_MIGRATED_REVID=143939410
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. no flag: only the direct reason is given (command execution termination status), and also the instruction to use "--verbose_failures"
2. flag "--verbose_failures": gives failed execution command and the instruction to use "--sandbox_debug --strategy"
3. flag "--verbose_failures --sandbox_debug": gives failed execution command, debugging message from sandboxing, and the instruction to use "--strategy"
Also removes "cd <sandbox_path>" in given failed command, since debugging is only necessary with flag "--verbose_failures --sandbox_debug" and the path is already given in sandboxing debugging message.
Addresses #2174.
--
PiperOrigin-RevId: 143937589
MOS_MIGRATED_REVID=143937589
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143936734
MOS_MIGRATED_REVID=143936734
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143933349
MOS_MIGRATED_REVID=143933349
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143905310
MOS_MIGRATED_REVID=143905310
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143864069
MOS_MIGRATED_REVID=143864069
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143825037
MOS_MIGRATED_REVID=143825037
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143823562
MOS_MIGRATED_REVID=143823562
|
|
|
|
|
|
|
|
| |
extension registry for the enclosing binary.
--
PiperOrigin-RevId: 143807030
MOS_MIGRATED_REVID=143807030
|
|
|
|
|
|
|
|
| |
The main effect is to cause cc_test rules to build into a self-contained executable rather than relying on external shared libraries. (cc_binary rules do this by default already.)
--
PiperOrigin-RevId: 143806513
MOS_MIGRATED_REVID=143806513
|