aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Remove ConfiguredTarget from TargetCompletionValue, since it is no longer ↵Gravatar janakr2018-06-04
| | | | | | needed: we can get the ConfiguredTargetKey directly from the TargetCompletionKey. Since that was the only use of the actual value in EvaluationProgressReceiver#evaluated, remove it, instead just provide a boolean enum that gives whether or not evaluation succeeded. PiperOrigin-RevId: 199178047
* Print the target names of the problematic classes, for better description of ↵Gravatar cnsun2018-06-04
| | | | | | | the dependency problems. RELNOTES: None. PiperOrigin-RevId: 199170334
* Remove --glibc optionGravatar rosica2018-06-04
| | | | | | | Crosstool selection will be based solely on --cpu and --compiler options. RELNOTES: Option --glibc is removed, toolchain selection relies solely on --cpu and --compiler options. PiperOrigin-RevId: 199156131
* Set no_proxy=localhost when an http_proxy is detected, instead of deleting ↵Gravatar ruperts2018-06-04
| | | | | | | | | the http_proxy value. Also change the environment for the client and the server in this case, instead of only changing the server's environment. RELNOTES: None. PiperOrigin-RevId: 199152406
* Add documentation for building JavaScript outputs.Gravatar spomorski2018-06-04
| | | | | RELNOTES: None. PiperOrigin-RevId: 199151698
* Small tagging change in HTML doc.Gravatar Googler2018-06-04
| | | | PiperOrigin-RevId: 199143339
* Failing targets are identified by comparing ConfiguredTarget.Key instead of ↵Gravatar cpeyser2018-06-04
| | | | | | ConfiguredTarget. Since ConfiguredTarget does not implement equals(), reference equality has been used until now, and this is not valid for the case where the ConfiguredTarget has been deserialized. PiperOrigin-RevId: 199133926
* Let Skylark rules take part in MakeVariableExpandingRule expansions using theGravatar jcater2018-06-04
| | | | | | toolchains attribute. PiperOrigin-RevId: 199133235
* ActionFS is now aware of inserted files.Gravatar felly2018-06-04
| | | | PiperOrigin-RevId: 199131390
* Allow injection of custom SkyFunctions into GraphTester.Gravatar janakr2018-06-04
| | | | PiperOrigin-RevId: 199126212
* Get rid of the tokens queue in the lexerGravatar laurentlb2018-06-04
| | | | | | | Next step will be to skip token allocation. RELNOTES: None. PiperOrigin-RevId: 199121625
* Improve error message slightlyGravatar ulfjack2018-06-04
| | | | PiperOrigin-RevId: 199118944
* Remove an unused method variable.Gravatar lberki2018-06-04
| | | | | RELNOTES: None. PiperOrigin-RevId: 199115199
* C++: Makes JavaWrapCc use CcLinkingHelperGravatar plf2018-06-04
| | | | | | | It doesn't use CcLinkParamsStore and CppLinkAction directly anymore. RELNOTES:none PiperOrigin-RevId: 199107747
* Carry tree artifacts' self data through aggregating middlemen.Gravatar Benjamin Peterson2018-06-03
| | | | | | | | | | | | | | | | | | | | | | | | This CL is a followup to c868c47. It is intended to fix #5296. The immediate problem in that issue is that remote caching finds a tree artifact in an input runfiles tree without metadata in the cache. The metadata isn't there because the runfiles artifacts are now all behind a middleman action, and ArtifactFunction didn't propagate tree artifact values through middlemen. This change fixes the problem by adding a tree artifact's self data value to the values carried through to dependent actions. Remote caching with tree artifact inputs seems to have been working mostly by accident. (Evidence: it wasn't tested, and remote execution of actions with tree artifact inputs results a Java traceback before and after c868c47.) This CL is only really a bandaid to return to the old "working" state. If remote execution wants to start supporting tree artifacts properly in the future, we'll likely need to carry the tree artifact child data through middleman actions, too. Closes #5299. Change-Id: I2e07d4fca0f6d2d34d97b7edb27f9d0063776225 PiperOrigin-RevId: 199079382
* Fast-path Label#equals by first comparing the interned PackageIdentifier.Gravatar shreyax2018-06-02
| | | | PiperOrigin-RevId: 199007753
* remote: concurrent blob downloads. Fixes #5215Gravatar buchgr2018-06-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change introduces concurrent downloads of action outputs for remote caching/execution. So far, for an action we would download one output after the other which isn't as bad as it sounds as we would typically run dozens or hundreds of actions in parallel. However, for actions with a lot of outputs or graphs that allow limited parallelism we expect this change to positively impact performance. Note, that with this change the AbstractRemoteActionCache will attempt to always download all outputs concurrently. The actual parallelism is controlled by the underlying network transport. The gRPC transport currently enforces no limits on the concurrent calls, which should be fine given that all calls are multiplexed on a single network connection. The HTTP/1.1 transport also enforces no parallelism by default, but I have added the --remote_max_connections=INT flag which allows to specify an upper bound on the number of network connections to be open concurrently. I have introduced this flag as a defensive mechanism for users who's environment might enforce an upper bound on the number of open connections, as with this change its possible for the number of concurrently open connections to dramatically increase (from NumParallelActions to NumParallelActions * SumParallelActionOutputs). A side effect of this change is that it puts the infrastructure for retries and circuit breaking for the HttpBlobStore in place. RELNOTES: None PiperOrigin-RevId: 199005510
* Make tools in action inputs an error.Gravatar tomlu2018-06-02
| | | | | | | | | | Supporting tools in inputs introduces a slow linear scan. Such tools should be moved to the 'tools' attribute. If --incompatible_no_support_tools_in_action_inputs is set the inputs are scanned, but a helpful error message is issued to the user. Eventually we will remove the slow scanning. Errors will surface in the execution phase instead of during analysis, and the resulting error messages will be less obvious. RELNOTES: None RELNOTES[INC]: With --incompatible_no_support_tools_in_action_inputs enabled, Skylark action inputs are no longer scanned for tools. Move any such inputs to the newly introduced 'tools' attribute. PiperOrigin-RevId: 198996093
* Automated rollback of commit c4e128e2c6d8cacaeba034d6a3195796d50f1745.Gravatar tomlu2018-06-02
| | | | | | | Always generating source jars can lead to action conflicts. RELNOTES: None PiperOrigin-RevId: 198994272
* Removes most ActionInputFileCache functionality.Gravatar shahan2018-06-01
| | | | | | Actual class to be removed in a later change. PiperOrigin-RevId: 198937695
* Allow multiple trimming transition factories to be added.Gravatar mstaib2018-06-01
| | | | | | | | If multiple trimming transition factories are added, they are composed in the order they were added. RELNOTES: None. PiperOrigin-RevId: 198934666
* Amend a skylark test to attempt access of FilesToRunProvider.executableGravatar cparsons2018-06-01
| | | | | | | This serves a regression test of a previous breakage which broke SkylarkCallable method of FilesToRunProvider. RELNOTES: None. PiperOrigin-RevId: 198915920
* Migrate remaining java skylark types to skylarkbuildapiGravatar cparsons2018-06-01
| | | | | RELNOTES: None. PiperOrigin-RevId: 198911668
* Create a Bootstrap for config-related libraries of skylarkbuildapi.Gravatar cparsons2018-06-01
| | | | | RELNOTES: None. PiperOrigin-RevId: 198906931
* Migrate repository_rule to skylarkbuildapiGravatar cparsons2018-06-01
| | | | | RELNOTES: None. PiperOrigin-RevId: 198906068
* Fix string.title and string.upper documentation.Gravatar Googler2018-06-01
| | | | | | | Cut and paste errors left references to lower in descriptions. RELNOTES: None. PiperOrigin-RevId: 198903374
* Android font resource supportGravatar Jingwen Chen2018-06-01
| | | | | | | | | | | | | | | | | | | | | Fixes #4381 Without layoutlib 26+, this test is expected to fail with: ``` ERROR: /private/var/tmp/_bazel_jin/ed227ac31d5e65f9c3effb1d1fe2605e/sandbox/4960637019899260266/execroot/io_bazel/_tmp/845372d54b28cdaedc66e35385e5009a/workspace.u0NdZr9w/java/bazel/BUILD:14:22: in resource_files attribute of android_binary rule //java/bazel:bin: 'java/bazel/res/font/Roboto.ttf' is not in the expected resource directory structure of <resource directory>/{anim,animator,color,drawable,interpolator,layout,menu,mipmap,raw,transition,values,xml}/<file> ERROR: Analysis of target '//java/bazel:bin' failed; build aborted: Analysis of target '//java/bazel:bin' failed; build aborted INFO: Elapsed time: 26.248s INFO: 0 processes. FAILED: Build did NOT complete successfully (36 packages loaded) ``` We will first need to upgrade the layoutlib jar in `//third_party/android_common` to 26+, rebase, then merge this set of tests. Closes #5287. Change-Id: Icad80e7e40df4ff6d2fc3373d37cfd9972e8d400 PiperOrigin-RevId: 198893525
* Mention string comparison in the documentationGravatar laurentlb2018-06-01
| | | | | RELNOTES: None. PiperOrigin-RevId: 198882702
* Migrate remaining apple-related skylark types to skylarkbuildapiGravatar cparsons2018-06-01
| | | | | RELNOTES: None. PiperOrigin-RevId: 198880301
* Use a new RecursivePackageProvider to ask skyframe for the correct package ↵Gravatar juliexxia2018-06-01
| | | | | | nodes in ConfiguredTargetQueryEnvironemnt. This lets us support recursive target patterns with cquery. PiperOrigin-RevId: 198879650
* Move TARGET_CPU from the CcToolchainProvider to BuildConfiguration.Gravatar jcater2018-06-01
| | | | PiperOrigin-RevId: 198877280
* [java_common.compile] Always generate a source jar.Gravatar elenairina2018-06-01
| | | | | | | | | | | java_common.compile doesn't generate the output source jar when a source jar is the only input for the compilation. This is wrong because the source jar can include APT generated sources. It is also inconsistent with java_library and leads to inconsistent Skylark rules where a declared output will not always have a generating action. RELNOTES: None. PiperOrigin-RevId: 198872718
* repository_resolved_file: pretty printGravatar Klaus Aehlig2018-06-01
| | | | | | | | As the list of external repositories with their resolved information can grow quite large, pretty print it, to make it easier for humans to inspect. Change-Id: I34b2d6df84e52c07471a0bfaf97994cabd45feff PiperOrigin-RevId: 198871353
* Fix broken flag existence check for linking flags in unix_cc_configure.Gravatar hlopko2018-06-01
| | | | | | | Fixes #5090 RELNOTES: NONE. PiperOrigin-RevId: 198870918
* Release 0.14.0 (2018-06-01)Gravatar Bazel Release System2018-06-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Baseline: 5c3f5c9be7fa40d4fb3c35756891fab8483ca406 Cherry picks: + f96f037f8f77335dc444844abcc31a372a3e1849: Windows, Java launcher: Support jar files under different drives + ff8162d01409db34893de98bd840a51c5f13e257: sh_configure.bzl: FreeBSD is also a known platform + 7092ed324137f03fcd34856bdb0595a1bdec3069: Remove unneeded exec_compatible_with from local_sh_toolchain + 57bc201346e61c62a921c1cbf32ad24f185c10c9: Do not autodetect C++ toolchain when BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 is present + 35a78c09cf2fbfc3de9c124d2142e3d72aac4348: remote: recursively delete incomplete downloaded output directory. + 3c9cd82b847f3ece8ec04b2029bd5e8ad0eb7502: distfile: pack the archives needed later in the build + 27487c77387e457df18be3b6833697096d074eab: Slightly refactor SpawnAction to improve env handling + 1b333a2c37add9d04fe5bc5258ee4f73c93115e2: Fix Cpp{Compile,Link}Action environment and cache key computation + 3da8929963e9c70dff5d8859d6e988e6e7f4f9d7: Make SymlinkTreeAction properly use the configuration's environment + eca7b81cf8cc51e1fe56e5ed7d4ad5cd1668a17a: Add a missing dependency from checker framework dataflow to javacutils Incompatible changes: - Add --incompatible_disallow_legacy_javainfo flag. - Added flag --incompatible_disallow_old_style_args_add to help migrate from args.add() to args.add_all() / args.add_joined() where appropriate. New features: - Bash,runfiles: use the new platform-independent library in `@bazel_tools//tools/bash/runfiles` to access runfiles (data-dependencies). See https://github.com/bazelbuild/bazel/blob/master/tools/bash/runfile s/runfiles.bash for usage information. - TemplateVariableInfo can now be constructed from Skylark. - The java_host_runtime_alias rule is now implemented in Java. Important changes: - Flip default value of --experimental_shortened_obj_file_path to true, Bazel now generates short object file path by default. - Introduce fdo_profile rule that allows architecture-sensitive specification of fdo profiles. - canonicalize-flags no longer reorders the flags - CppRules: optional_compiler_flag was removed from CROSSTOOL, use features instead. - Labels of the form ////foo are disallowed. - The `/` operator is deprecated in favor of `//` (floor integer division). Try the `--incompatible_disallow_slash_operator` flag to ensure your code is forward-compatible. - Flip default value of --experimental_shortened_obj_file_path to true, Bazel now generates short object file path by default. - Exposed "mnemonic" and "env" fields on skylark "Action" objects. - Removed flag `--incompatible_disallow_toplevel_if_statement`. - Remove vestigial 'deps' and 'data' attributes from proto_lang_toolchain - Args objects (ctx.actions.args()) have new methods add_all() and add_joined() for building command lines using depsets. - `FileType` is deprecated and will be removed soon. Try the `--incompatible_disallow_filetype` flag to ensure your code is forward-compatible. - Introduce absolute_path_profile attribute that allows fdo_profile to accept absolute paths. - Support two-arg overloads for ctx.actions.args (eg. args.add("--foo", val)) - Introduce 'tools' attribute to ctx.actions.run. - Fixed error message for proguard_apply_dictionary. - "bazel run" now lets one run interactive binaries. The BUILD_WORKSPACE_DIRECTORY and BUILD_WORKING_DIRECTORY environment variables indicate the working directory and the workspace root of the Bazel invocation. Tests are provided with an approximation of the official test environment. - repository rules are no longer restricted to return None. - Add --high_priority_workers flag. - CppRules: Feature configuration can be created from Skylark - Adds new-style JavaInfo provider constructor. - Make java_common.compile now uses java_toolchain javacopts by default; explicitly retrieving them using java_common.default_javac_opts is unnecessary. - CppRules: C++ command lines and env variables for C++ actions can be retrieved from feature configuration. - Skylark rule definitions may advertise providers that targets of the rule must propagate. - Bazel now supports running actions inside Docker containers. To use this feature, run "bazel build --spawn_strategy=docker --experimental_docker_image=myimage:latest". - Remote execution works for Windows binaries with launchers. - Fixing start/end lib expansion for linking. There were many cases where archive files were still being used with toolchains that support start/end lib. This change consolidates the places that make that decision so they can be more consistent. - Add support for reporting an error if android_test.binary_under_test contains incompatible versions of deps - We replaced the --experimental_local_disk_cache and --experimental_local_disk_cache_path flags into a single --disk_cache flag. Additionally, Bazel now tries to create the disk cache directory if it doesn't exist. - Save Blaze memory by not storing LinkerInput objects in LinkCommandLine - In the JavaInfo created by java_common.create_provider now includes both direct and transitive arguments in transitive_compile_time_jars and transitive_runtime_jars - Allow --worker_max_instances to take MnemonicName=value to specify max for each worker. - Allow java_toolchain.header_compiler to be an arbitrary executable
* Revert "Release 0.14.0 (2018-06-01)"Gravatar Luis Pino2018-06-01
| | | | This reverts commit 2269ee2af91b7df13820381d61e8e4e26a257b3a.
* C++: Remove CcSpecificLinkParamsProvider.Gravatar plf2018-06-01
| | | | | | No longer needed since proto_library cannot be used for Java. PiperOrigin-RevId: 198859993
* Format all bzl files with buildifierGravatar vladmos2018-06-01
| | | | | | This CL aslo enables a presubmit check for correct formatting of all bzl files in //third_party/bazel. PiperOrigin-RevId: 198857055
* Release 0.14.0 (2018-06-01)Gravatar Bazel Release System2018-06-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Baseline: 5c3f5c9be7fa40d4fb3c35756891fab8483ca406 Cherry picks: + f96f037f8f77335dc444844abcc31a372a3e1849: Windows, Java launcher: Support jar files under different drives + ff8162d01409db34893de98bd840a51c5f13e257: sh_configure.bzl: FreeBSD is also a known platform + 7092ed324137f03fcd34856bdb0595a1bdec3069: Remove unneeded exec_compatible_with from local_sh_toolchain + 57bc201346e61c62a921c1cbf32ad24f185c10c9: Do not autodetect C++ toolchain when BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 is present + 35a78c09cf2fbfc3de9c124d2142e3d72aac4348: remote: recursively delete incomplete downloaded output directory. + 3c9cd82b847f3ece8ec04b2029bd5e8ad0eb7502: distfile: pack the archives needed later in the build + 27487c77387e457df18be3b6833697096d074eab: Slightly refactor SpawnAction to improve env handling + 1b333a2c37add9d04fe5bc5258ee4f73c93115e2: Fix Cpp{Compile,Link}Action environment and cache key computation + 3da8929963e9c70dff5d8859d6e988e6e7f4f9d7: Make SymlinkTreeAction properly use the configuration's environment + eca7b81cf8cc51e1fe56e5ed7d4ad5cd1668a17a: Add a missing dependency from checker framework dataflow to javacutils Incompatible changes: - Add --incompatible_disallow_legacy_javainfo flag. - Added flag --incompatible_disallow_old_style_args_add to help migrate from args.add() to args.add_all() / args.add_joined() where appropriate. New features: - Bash,runfiles: use the new platform-independent library in `@bazel_tools//tools/bash/runfiles` to access runfiles (data-dependencies). See https://github.com/bazelbuild/bazel/blob/master/tools/bash/runfile s/runfiles.bash for usage information. - TemplateVariableInfo can now be constructed from Skylark. - The java_host_runtime_alias rule is now implemented in Java. Important changes: - Flip default value of --experimental_shortened_obj_file_path to true, Bazel now generates short object file path by default. - Introduce fdo_profile rule that allows architecture-sensitive specification of fdo profiles. - canonicalize-flags no longer reorders the flags - CppRules: optional_compiler_flag was removed from CROSSTOOL, use features instead. - Labels of the form ////foo are disallowed. - The `/` operator is deprecated in favor of `//` (floor integer division). Try the `--incompatible_disallow_slash_operator` flag to ensure your code is forward-compatible. - Flip default value of --experimental_shortened_obj_file_path to true, Bazel now generates short object file path by default. - Exposed "mnemonic" and "env" fields on skylark "Action" objects. - Removed flag `--incompatible_disallow_toplevel_if_statement`. - Remove vestigial 'deps' and 'data' attributes from proto_lang_toolchain - Args objects (ctx.actions.args()) have new methods add_all() and add_joined() for building command lines using depsets. - `FileType` is deprecated and will be removed soon. Try the `--incompatible_disallow_filetype` flag to ensure your code is forward-compatible. - Introduce absolute_path_profile attribute that allows fdo_profile to accept absolute paths. - Support two-arg overloads for ctx.actions.args (eg. args.add("--foo", val)) - Introduce 'tools' attribute to ctx.actions.run. - Fixed error message for proguard_apply_dictionary. - "bazel run" now lets one run interactive binaries. The BUILD_WORKSPACE_DIRECTORY and BUILD_WORKING_DIRECTORY environment variables indicate the working directory and the workspace root of the Bazel invocation. Tests are provided with an approximation of the official test environment. - repository rules are no longer restricted to return None. - Add --high_priority_workers flag. - CppRules: Feature configuration can be created from Skylark - Adds new-style JavaInfo provider constructor. - Make java_common.compile now uses java_toolchain javacopts by default; explicitly retrieving them using java_common.default_javac_opts is unnecessary. - CppRules: C++ command lines and env variables for C++ actions can be retrieved from feature configuration. - Skylark rule definitions may advertise providers that targets of the rule must propagate. - Bazel now supports running actions inside Docker containers. To use this feature, run "bazel build --spawn_strategy=docker --experimental_docker_image=myimage:latest". - Remote execution works for Windows binaries with launchers. - Fixing start/end lib expansion for linking. There were many cases where archive files were still being used with toolchains that support start/end lib. This change consolidates the places that make that decision so they can be more consistent. - Add support for reporting an error if android_test.binary_under_test contains incompatible versions of deps - We replaced the --experimental_local_disk_cache and --experimental_local_disk_cache_path flags into a single --disk_cache flag. Additionally, Bazel now tries to create the disk cache directory if it doesn't exist. - Save Blaze memory by not storing LinkerInput objects in LinkCommandLine - In the JavaInfo created by java_common.create_provider now includes both direct and transitive arguments in transitive_compile_time_jars and transitive_runtime_jars - Allow --worker_max_instances to take MnemonicName=value to specify max for each worker. - Allow java_toolchain.header_compiler to be an arbitrary executable
* Windows,testing: add query regression testGravatar Laszlo Csomor2018-06-01
| | | | | | | | | | | This test could have prevented https://github.com/bazelbuild/bazel/issues/5300 Change-Id: I02e3b723958c81e0de80f2c2130b583ea4e7f40b Closes #5310. Change-Id: I02e3b723958c81e0de80f2c2130b583ea4e7f40b PiperOrigin-RevId: 198849437
* Converts PLACEHOLDER FileValues into RegularFileValue when queried viaGravatar shahan2018-05-31
| | | | | | ActionExecutionValue.getAllFileValues. PiperOrigin-RevId: 198807229
* Remove the Blaze strict java deps exemption for Android databinding. As ofGravatar Googler2018-05-31
| | | | | | | | | | | | | unknown commit, we are using the JavaBuilder processor exemption list instead of disabling strict deps for the affected rules outright. This narrows the degree to which the exemption is applied, and prevents other strict deps violations from accruing on targets that enable databinding. Step 2 of 2; we needed the change to roll out in JavaBuilder first to be able to fix up issues in the depot first before removing the exemption in Blaze. See https://github.com/bazelbuild/bazel/commit/7edc5d49c8e764ab2bdf19e3a9fb58ea30fa708f for the original attempt. PiperOrigin-RevId: 198793976
* Migrate remaining Android Skylark API to skylarkbuildapiGravatar asteinb2018-05-31
| | | | | | | | I don't know much about most of this code, but there should be no functional changes. RELNOTES: none PiperOrigin-RevId: 198773657
* Explicitly validate local resources are passed to Java compilation firstGravatar asteinb2018-05-31
| | | | | | | We thought we had a test for this, but it turns out we didn't. Add one now. RELNOTES: none PiperOrigin-RevId: 198772854
* Make test more explicit about what it is testing.Gravatar dannark2018-05-31
| | | | | RELNOTES: None PiperOrigin-RevId: 198765991
* Log warning cleanupGravatar neerajen2018-05-31
| | | | | | | Setting --config in .blazerc that overrode previous options in .blazerc was triggering unnecessary warnings. Fixed by only logging warnings when a user attempts to override an option specified on the command line. RELNOTES: None. PiperOrigin-RevId: 198756160
* Remove redundant @SkylarkModule annotation on JavaInfo.Provider, as its ↵Gravatar cparsons2018-05-31
| | | | | | | skylarkbuildapi interface is annotated. RELNOTES: None. PiperOrigin-RevId: 198743504
* Update android_common's layoutlib to 26.1.2 to support fonts in BazelGravatar Jingwen Chen2018-05-31
| | | | | | | | | RELNOTES: For Android projects, Bazel now supports building fonts as resources. See https://developer.android.com/guide/topics/ui/look-and-feel/fonts-in-xml for more information on the feature. Change-Id: I1cb25828b04e98cacc19d3c7a2e23ea764b48e92
* Migrate config-related skylark objects to skylarkbuildapiGravatar cparsons2018-05-31
| | | | | RELNOTES: None. PiperOrigin-RevId: 198735582
* Remove unused codepaths now that non_propagated_deps has been removed as an ↵Gravatar kaipi2018-05-31
| | | | | | attribute. PiperOrigin-RevId: 198735448