aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Have BazelPackageLoader use the newly added BazelSkyframeExecutorConstants.Gravatar nharmata2017-06-07
| | | | PiperOrigin-RevId: 158159054
* Section about Bazel concepts should be titled as such (rather than "BUILD ↵Gravatar Googler2017-06-06
| | | | | | file" and "Bazel: Build Files and Terminology"). PiperOrigin-RevId: 158149353
* protobuf: Use bazel's native java_proto_library rules.Gravatar Jakob Buchgraber2017-06-06
| | | | | | | | | Additional changes: - Introduce a Skylark macro java_library_srcs that provides the source jars of a java_*_library rule. - Remove bazel's own java_proto_library implementation. Change-Id: I18f2259bc75ca0fb32dcd8a6a857c609bd2c7773 PiperOrigin-RevId: 158146210
* Fix automatic host platform detection to check the --host_cpu flag.Gravatar John Cater2017-06-06
| | | | | | | | | Also adds a new target_platform attribute that checks the --cpu flag. Part of #2219. Change-Id: Icc732917db127ac8377a7722adc70b1a722d538a PiperOrigin-RevId: 158143095
* java_stub_template: remove cygpath callGravatar Laszlo Csomor2017-06-06
| | | | | | | | | | | | | | | | | | Remove the cygpath call on non-Windows platforms, that was recently added by 102ce6ddc04063d26165c6a2167059f2348026bf Also add a test for Bazel's Java launcher. Also update the testenv.sh:cleanup method to wait for Bazel to shut down, don't give up immediately if it could not clean up the inner Bazel's temp dir. Fixes https://github.com/bazelbuild/bazel/issues/3092 See https://github.com/bazelbuild/bazel/issues/3069 Change-Id: I82b1026a60056f340caa53a59b6f2ec8a1397ef3 PiperOrigin-RevId: 158139846
* Factor out Bazel-specific ctor constants in SequencedSkyframeExecutor into a ↵Gravatar nharmata2017-06-06
| | | | | | | separate class. They're currently passed in around various callsites in the codebase and tests. RELNOTES: None PiperOrigin-RevId: 158139074
* third_party/grpc: Introduce filegroup of jars for bootstrappingGravatar Jakob Buchgraber2017-06-06
| | | | Change-Id: I580f519c1b274b497b3b37427a96e105bbe241dd
* Add java_grpc_library rule that uses bazel's native proto_library.Gravatar Jakob Buchgraber2017-06-06
| | | | | | | | Code taken from PR: https://github.com/grpc/grpc-java/pull/2975 Once this is merged into gRPC we can directly depend on gRPC. Change-Id: Ide77414276b4125e85dfa6f93725143e3149d8ec
* Remove the CommandEnvironment from BlazeCommand.editOptionsGravatar ulfjack2017-06-06
| | | | | | | | | | | BlazeCommand.editOptions is currently called fairly late in the startup process, so it must be restrictive in what it does, as any change to the options can potentially introduce inconsistencies between different parts of Bazel. Removing the CommandEnvironment reduces the amount of damage it can do, and may allow us to move the call earlier in the startup process (maybe even to a point where the CommandEnvironment does not exist yet). PiperOrigin-RevId: 158133862
* Automated g4 rollback of commit 5608765ab737ebb8a98a04a6068143d53ae7065c.Gravatar philwo2017-06-06
| | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Rollforward with fix for FreeBSD. I added the missing headers and verified that it now builds fine on FreeBSD 11, too. *** Original change description *** Automated g4 rollback of commit 7f520a8286c39c5145b6d816cd0be5a6b7b18250. *** Reason for rollback *** This broke Bazel CI on freebsd: http://ci.bazel.io/view/Dashboard/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=freebsd-11/1516/console# *** Original change description *** Refactor process-wrapper code so the spawn/wait code is pluggable. In an upcoming change I'll reintroduce the new platform-specific implementations that can kill and wait for all descendant processes spawned by the wrapped process. This has no functional changes. PiperOrigin-RevId: 158133159
* Fix a typo.Gravatar Googler2017-06-06
| | | | | RELNOTES: None. PiperOrigin-RevId: 158131549
* Fix a bunch of issues related to server startup/shutdown:Gravatar lberki2017-06-06
| | | | | | | | | - Only try to communicate with the server if it passes verification (i.e. the indicated PID exists and its start time is correct) - Use only one thread to delete files on exit - Don't set restart reason to NEW_VERSION unless there is an existing server RELNOTES: None. PiperOrigin-RevId: 158131470
* Move the instrumentation filter computation to BuildToolGravatar ulfjack2017-06-06
| | | | | | | | | | | | | | | | | | Previously, it was in CoverageCommand, which led to all sorts of special casing and workarounds, because it required options editing, error handling during options editing, as well as early package path setup. It also caused us to duplicate target pattern evaluation for the coverage command. A semantic change is that the TestCommand can now also trigger the heuristic instrumentation filter computation, if collect_code_coverage is enabled; we might consider also enabling this for the BuildCommand, which can also have collect_code_coverage enabled (e.g., when a user wants to build a non-test binary with coverage instrumentation). Also remove a bunch of unnecessary AbruptExitException declarations. RELNOTES: bazel test now also computes a default instrumentation filter if --collect_code_coverage is enabled PiperOrigin-RevId: 158129953
* Add exit codes for remote errors to ExitCodeGravatar ulfjack2017-06-06
| | | | | | | These values are already used inside Google with specific semantics, so we have to use these exact values (for now). PiperOrigin-RevId: 158127273
* Fix: remote execution was ignoring the exit codeGravatar Ulf Adams2017-06-06
| | | | | | | | | | | | | | | | | | | | I likely broke that in 7f6e27f, although it was a pre-existing condition: previously, the remote worker was reporting non-zero exit as a failure. Now it reports the run as successful with a non-zero exit code. Update RemoteSpawnStrategy to handle the exit code and generate an appropriate error. In the future, we won't throw exceptions for non-zero exit at this level, but instead report the non-zero exit in the SpawnResult, and have the caller inspect that (and generate the error if applicable). Fixes #3121. Change-Id: Ia39f5c2ef5622544285c1957bb9ebae89e58edf2 Closes #3130. Change-Id: Ia39f5c2ef5622544285c1957bb9ebae89e58edf2 PiperOrigin-RevId: 158120222
* Add a tag to ExecutionRequirements that allows disabling local prefetchGravatar ulfjack2017-06-06
| | | | | | | Remove SpawnExecutionPolicy.shouldPrefetchInputsForLocalExecution in favor of a static helper method in Spawns. PiperOrigin-RevId: 158119993
* Use a wrapper-free MSVC toolchain when NO_MSVC_WRAPPER=1Gravatar Yun Peng2017-06-06
| | | | | | | | | | | | | | | | | | | To enable a wrapper free MSVC CROSSTOOL, set NO_MSVC_WRAPPER=1 or add --action_env=NO_MSVC_WRAPPER=1 flag. Note that we still use windows_cc_wrapper.bat to invoke cl.exe and link.exe for different actions. Result for bazel build src/main/cpp:client : NO_WRAPPER: INFO: Elapsed time: 76.833s, Critical Path: 16.70s WRAPPER: INFO: Elapsed time: 138.517s, Critical Path: 27.78s Change-Id: Iaf6b67fc791ae1f8b62d332e47f96f719510bda1 PiperOrigin-RevId: 158118110
* Chocolatey install: fix script. problem onGravatar Peter Mounce2017-06-06
| | | | | | | | reading. Closes #2794. PiperOrigin-RevId: 158117701
* Add an example that shows how to use the cpu:<num> tag for tests.Gravatar philwo2017-06-06
| | | | | | Also serves as an example for bug #3106. PiperOrigin-RevId: 158116940
* Move ExecutionRequirements to the lib.actions packageGravatar ulfjack2017-06-06
| | | | | | | | | It was previously the odd-one out in lib.analysis.actions, due to other code that wanted to depend on it without pulling in all of analysis. However, it's needed to interpret Spawn instances, and Spawn lives in lib.actions, so it makes more sense to move it there, and remove the special-casing. PiperOrigin-RevId: 158116684
* Change help message for --batchGravatar Mike Morearty2017-06-06
| | | | | | | | | | The help message previously said that `--batch` is strongly discouraged, but in fact it's only discouraged when using bazel interactively. Since the tradeoffs of `--batch` are fully explained in the online docs, this commit changes the help message to explain what the option does without getting into the tradeoffs. Fixes #3051 Closes #3118. PiperOrigin-RevId: 158112611
* apple_binary provides information about its dylibs' symbols in its nested ↵Gravatar cparsons2017-06-06
| | | | | | | | | | | | | ObjcProvider This facilitates app->dylib->dylib dependencies, as the app needs to avoid linking in symbols contained in any *transitive* dylibs, not just in any direct dylibs. This also removes a test which verified the previous, incorrect functionality (not propagating information about dylibs up the tree). RELNOTES: None. PiperOrigin-RevId: 158070381
* Specify isTestRule as an input to CompilationSupport instead of from the ↵Gravatar cparsons2017-06-06
| | | | | | | current rule name RELNOTES: None. PiperOrigin-RevId: 158068921
* Suggest signing xcode license if that likely inhibits xcode-locator-bin ↵Gravatar cparsons2017-06-06
| | | | | | | generation RELNOTES: None. PiperOrigin-RevId: 158066648
* Make compatible_with = ["all", "foo"] the same as compatible_with = ["all"].Gravatar gregce2017-06-06
| | | | | | | | | | | | | Assuming "all" fulfills "foo", these should be exactly the same (and maybe we should trigger a redundant listing error). In practice, it's possible to make the first case succeed while the second fails because of environment refining and lack of static constraint checking for selects. See changes for details. Also refactor ConstraintSemantics.checkConstraints to divide and conquer more clearly. PiperOrigin-RevId: 158047217
* Remote host_platform pending upcoming changes inGravatar jcater2017-06-06
| | | | | | https://bazel-review.googlesource.com/c/11690/. PiperOrigin-RevId: 158046253
* Internal changeGravatar cpeyser2017-06-06
| | | | PiperOrigin-RevId: 158041525
* Release 0.5.1 (2017-06-06)Gravatar Bazel Release System2017-06-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Baseline: f3ae88ee043846e7acdffd645137075a4e72c573 Cherry picks: + c58ba098526b748f9c73e6229cafd74748205aa1: Release to GCS: put the final release in its own directory + 0acead4ea3631240659836ce6ecd6d7f67fd352b: Update protobuf to latest master at a64497c and apply @laszlocsomor's latest changes from https://github.com/google/protobuf/pull/2969 on top of it. + d0242ce4a87929f2528f4602d0fb09d1ccfcea94: Make symlinks consistent + d953ca8b87a46decbce385cebb446ae0dd390881: Clean VanillaJavaBuilder output directories + 755669fb5de1f4e762f27c19776cac9f410fcb94: Pass all the environment variable to Bazel during bootstrapping + 6f041661ca159903691fcb443d86dc7b6454253d: Do not mark the JDK7 installer -without-jdk-installer + 720561113bfa702acfc2ca24ce3cc3fd7ee9c115: Fix #2958: Installer should not overwrite bazelrc + 511c35b46cead500d4e76706e0a709e50995ceba: Bootstrap: move the fail function to the top + 8470be1122825aae8ad0903dd1e1e2a90cce47d2: Clean up javac and Error Prone targets + 4a404de2c6c38735167e17ab41be45ef6fc4713a: Update javac version to 9-dev-r4023-2 + 36ce4b433e19498a78c34540d5a166d4e0006b22: Update javac version to 9-dev-r4023-2 + 38949b8526bdb3e6db22f3846aac87162c28c33f: Migrate off versioned javac and Error Prone targets + 1a57d298f8aa6ea8136d93223902104f2479cd2a: Re-enabling passing -sourcepath via javacopts. + eb565f408e03125e92d42b00756e519795be6593: Make make sure that msys build actually builds msys version + 39f328cf392056618d1a3ead4835a138b189a06d: Fix typo. Also do not override host_cpu for msvc. + 624802893f4fe72118f00a78452605d41a2e1c6f: Select correct JDK for windows_msys + c4f271d1a68366b6fa5ff38ea7d951b6a22af044: Automated g4 rollback of commit 3e5edafa2a04a71cd3596e929e83222da725f3f9. + 926180997a0f296a5a009326aead887279ce0a90: Remove process-tools.cc which I forgot to delete during the last rollback. + baca6e4cb023649920871b74810927d304729e59: Fix #2982: Bazel installer should not check for installed JDK if using a bundled JDK. + 866ecc8c3d5e0b899e3f0c9c6b2265f16daae842: Disable msys path conversion on Windows. + cc21998c299b4d1f97df37b961552ff8168da17f: Rollforward #2 of: Basic open-source crosstool to support targeting apple platform types. + 0f0ccc4fc8229c1860a9c9b58089d6cfb2ee971f: Escape % in strings that will appear in Crosstool + 3b08f774e7938928e3a240a47a0a7554cdc8d50b: Adding feature for linking C Run-Time library on Windows + 3566474202d1978acfdcb7e5ff73ee03ea6f3df9: Do not use sed -E in bootstrap/compile.sh + c3cf7d917afd02d71de3800cd46ad8d14f1ddf55: Reverts non-xcode-available darwin crosstool generation. Important changes: - Fixes regression in 0.5.0 requiring Xcode to build C++ on OSX.
* Cleanup the interface of ApkActionsBuilder.Gravatar ajmichael2017-06-05
| | | | | | | | | | | | | | | A few changes: 1. Remove the ApkSigningMethod input. We always read this from AndroidConfiguration, callers shouldn't need to pass it in. 2. Add a signingKey attribute. This will be needed for dex2oat to pass in whatever key was used to sign the input APKs. 3. Unify the resourceApk and nativeLibsZips into a "addInputZip(s)" methods. This can also be used for inputting an existing APK, such as the one from dex2oat. RELNOTES: None PiperOrigin-RevId: 157973679
* Fix sandbox to recursively bind mount the writable directories.Gravatar Googler2017-06-05
| | | | | | | | | | | If a directory that is being bind mounted has a subdirectory that is a mount point (e.g.: tmpfs on /tmp/tmp), then the MS_BIND mount() call will fail with invalid argument. Fixes #3064. RELNOTES: None. PiperOrigin-RevId: 157973469
* Add a new flag --sandbox_writable_path, which asks the sandbox to make anGravatar Googler2017-06-05
| | | | | | | | existing directory writable when running actions. RELNOTES: Added a new flag --sandbox_writable_path, which asks the sandbox to make an existing directory writable when running actions. PiperOrigin-RevId: 157971858
* Improve the error message when Desugar fails to load a class from theGravatar cnsun2017-06-05
| | | | | | | classpath. Now it prints the name of the class that is under desugaring. RELNOTES: n/a PiperOrigin-RevId: 157889131
* Internal changeGravatar Googler2017-06-05
| | | | PiperOrigin-RevId: 157878648
* Automated g4 rollforward of commit b71e99b1f3746103e5d6802eebc24096b3494959.Gravatar gregce2017-06-05
| | | | | | | | | | | | | | | | | | | | | | | | (Automated g4 rollback of commit de92f9d8ea093416fae999073bbfcf3cf501ab55). *** Reason for rollback *** The problems that forced commit de92f9d8ea093416fae999073bbfcf3cf501ab55 were fixed in commit e6392cd380fce14d719890c78d5eb2657e8a6cfc . *** Original change description being rolled forward *** Implement dynamically configured LIPO builds. Quick overview: - provide a dynamic interface for getting the artifact owner configuration - provide a (dynamic) RuleTransitionFactory LIPO_ON_DEMAND to replace the (static) RuleClass.Configurator LIPO_ON_DEMAND. Eventually we'll remove the rule class configurator interface entirely.... *** ROLLBACK_OF=156180015 PiperOrigin-RevId: 157865224
* Fixing documentation for platforms and toolchains.Gravatar John Cater2017-06-05
| | | | | Change-Id: I98fd671af858c402b10bb5ef59735d83d4003593 PiperOrigin-RevId: 157863146
* Remove Xcodege integration from Blaze.Gravatar schmitt2017-06-05
| | | | | RELNOTES: None. PiperOrigin-RevId: 157857216
* Include the root cause IOException in the BuildFileContainsErrorsException ↵Gravatar nharmata2017-06-05
| | | | | | | thrown when PackageFunction encounters such an IOException when reading the contents of a BUILD file. RELNOTES: None PiperOrigin-RevId: 157853283
* Make the non propagated values available in the Skylark representation of ↵Gravatar kaipi2017-06-05
| | | | | | ObjcProvider. PiperOrigin-RevId: 157850516
* Rename xcode_version's default_macosx_sdk_version to use 'macos'.Gravatar cparsons2017-06-05
| | | | | | | This is consistent with other usage. RELNOTES: NONE. PiperOrigin-RevId: 157849696
* Set host apple platform type to MACOSGravatar cparsons2017-06-05
| | | | | RELNOTES: None. PiperOrigin-RevId: 157847930
* Expose .ap_ artifact as a skylark providerGravatar Googler2017-06-05
| | | | | RELNOTES: none PiperOrigin-RevId: 157837746
* Document --nouse_action_cacheGravatar Googler2017-06-05
| | | | | RELNOTES: None. PiperOrigin-RevId: 157833033
* Remove "supports-workers" tag from ApkBuilder execution info.Gravatar philwo2017-06-05
| | | | | | The C++ implementation of SingleJar, which is available in Bazel, but not yet the default, doesn't support persistent worker mode, so this causes issues when you try to use it. PiperOrigin-RevId: 157831362
* Windows, jvm.out: create with deletion sharingGravatar Laszlo Csomor2017-06-02
| | | | | | | | | | | | This allows `bazel clean` to delete this file. See https://github.com/bazelbuild/bazel/issues/1586 See https://github.com/bazelbuild/bazel/issues/1906 See https://github.com/bazelbuild/bazel/issues/2480 See https://github.com/bazelbuild/bazel/issues/3043 Change-Id: I245f368c2f2564511bbe6f06193a3ead49724d7b PiperOrigin-RevId: 157818284
* Update documentation for --output_filter and --auto_output_filterGravatar ulfjack2017-06-02
| | | | PiperOrigin-RevId: 157809651
* Move helper methods for accessing platform providers to a utility class.Gravatar John Cater2017-06-02
| | | | | Change-Id: I45d0cf8e5096ad4ab516af5ddaa98eea8d516c04 PiperOrigin-RevId: 157788771
* Generate pre-reconciled ids R classes for dependency libraries with resourcesGravatar corysmith2017-06-02
| | | | | | | in the transitive closure of robolectric tests. RELNOTES: None PiperOrigin-RevId: 157762190
* Fix a bug in ParallelVisitor which prevents visitation task from being ↵Gravatar Googler2017-06-02
| | | | | | | | | | | | | | interrupted eagerly The original code swallows the InterruptedException, sets the interrupt bit and stops new tasks from being submitted. However it does not actively send an interrupt signal to all running and pending tasks already in the pool. It is partly due to the misleading syntax of awaitTermination, which actually quitely waits for all tasks to exit even if interruptWorkers is set to true. Both errors are fixed in this change. RELNOTES: None PiperOrigin-RevId: 157762029
* Remove javacopts and java_plugins attributes of aar_import.Gravatar ajmichael2017-06-02
| | | | | | | These do not make sense since aar_import does not compile any java but are inherited from JavaBaseRule. RELNOTES: None PiperOrigin-RevId: 157751090
* Add .equals(), .hashCode() to EnableLipoTransition.Gravatar gregce2017-06-02
| | | | | | | | | | | | This fixes a subtle integration bug between PatchTransition, ConfiguredTargetFunction, and DependencyResolver. Short story: ConfiguredTargetFunction.getDynamicConfigurations assumes at most one <Attribute, Label, Transition> entry per configured target dep. DependencyResolver.dependentNodeMap faithfully supplies this by returning an OrderedSetMultimap<Attribute, Dependency>, where each Dependency is a <Label, Transition>. OrderedSetMultimap guarantees no <key, value> repeats, but if you have two semantically equal EnableLipoTransition instances that don't satisfy .equals(), deduping fails. Most PatchTransitions don't have this problem because they're singletons. But each EnableLipoTransition is instantiated with a Rule, so singletons don't work here. This problem can only happen when a rule has multiple instances of the same C++ dep under the same attribute. But this isn't actually possible for normal attributes like "deps" because they don't allow duplicates (see RuleClass#checkForDuplicateLabels). Only non-LABEL_LIST attributes can trigger this. PiperOrigin-RevId: 157733284