aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Close some streams that we didn'tGravatar Miguel Alcon Pinto2015-11-05
| | | | | -- MOS_MIGRATED_REVID=107048547
* Skylark: Updated the locations of more error messages.Gravatar Florian Weikert2015-11-05
| | | | | | | | | | | | | | In the presence of a Skylark macro some error messages used to show the location of a bzl file for errors that actually happened in a BUILD file. For the "crosses boundary of subpackage" case, we decided to always show the location of the BUILD file. This solution is not perfect since it misses some scenarios where the illegal label was actually specified in a bzl file, such as def macro_skylark_rule(name, srcs=[]): skylark_rule(name = name, srcs = srcs + ['sub/package/illegal.h']) However, the current design in regards to attribute errors does not allow us to provide two locations (BUILD and bzl), nor can we make a case-by-case choice whether we return the location in the BUILD file or in the bzl file. Consequently, we still get a wrong location in some cases. However, these cases should be rare. -- MOS_MIGRATED_REVID=107044681
* Hook up the network sandboxing codeGravatar Brian Silverman2015-11-05
| | | | | | | | | | RELNOTES: Tests, genrules, and Skylark actions without the "requires-network" tag will no longer be able to access the network. -- Change-Id: I6f7ad209142c6cfa2ad0318adf3dcfbc9af3d724 Reviewed-on: https://bazel-review.git.corp.google.com/#/c/2221/ MOS_MIGRATED_REVID=107043709
* Add Byte Buddy jar and up-to-date ASM jars.Gravatar Klaas Boesche2015-11-05
| | | | | | The old ASM jar contains all parts of ASM while the existing dependents only require the core of it. Byte Buddy also requires asm-commons and asm-util.
* Disallow jars in srcs of java-based rulesGravatar Liam Miller-Cushon2015-11-04
| | | | | -- MOS_MIGRATED_REVID=107000128
* Avoid copying file contents when reading the expected number of bytes ↵Gravatar Eric Fellheimer2015-11-04
| | | | | | | in#readContentWithLimit(). -- MOS_MIGRATED_REVID=106995917
* Change "contact us" link in Bazel's mobile-install docs, to point at the ↵Gravatar Carmi Grushko2015-11-04
| | | | | | | | | bazel-discuss group, not the contribution instructions. RELNOTES: -- MOS_MIGRATED_REVID=106995833
* In SkyKey#equals, check for 'functionName' equality before checking for ↵Gravatar Nathan Harmata2015-11-04
| | | | | | | 'argument' equality. When the two keys are equal we have to check both fields anyways, so we should only consider the case where they are unequal: 'functionName' equality is almost certainly cheaper, so we'd prefer short circuiting on inequality from that cheap check. -- MOS_MIGRATED_REVID=106989244
* [groovy] Add missing </table> tag.Gravatar David Chen2015-11-04
| | | | | -- MOS_MIGRATED_REVID=106971971
* Open source SkyframeLabelVisitorTest.Gravatar Han-Wen Nienhuys2015-11-04
| | | | | -- MOS_MIGRATED_REVID=106961863
* Pass AspectWithParameters instead of separately passing AspectParameters and ↵Gravatar Carmi Grushko2015-11-04
| | | | | | | | | aspect-attributes. The former contains both. -- MOS_MIGRATED_REVID=106961145
* Permit use of ForkJoinQuiescingExecutor for invalidationGravatar Mark Schaller2015-11-04
| | | | | | | | | | Changes InvalidatingNodeVisitor's use of AbstractQueueVisitor from inheritance to composition. This allows it to vary its executor implementation. A ForkJoinPool-specialized implementation option is provided. -- MOS_MIGRATED_REVID=106960011
* Post preliminary events so it doesn't crash outright.Gravatar Ulf Adams2015-11-04
| | | | | | | | This makes the new loading phase runner work for basic builds, but there are still a lot of broken tests if enabled by default. -- MOS_MIGRATED_REVID=106952054
* Fix broken resolution of STL sources through @bazel_tools.Gravatar Peter Schmitt2015-11-03
| | | | | | | | | Includes an integration test for bazel + stl and objc -> cc deps. Based on patched work by cparsons@. -- MOS_MIGRATED_REVID=106946039
* Add support for proguard's -applymapping option to android_binary.Gravatar Googler2015-11-03
| | | | | | | | RELNOTES[NEW]: android_binary now supports proguard_apply_mapping to re-use a previously generated proguard mapping. -- MOS_MIGRATED_REVID=106945104
* Add a skyframe-based loading phase runner hidden behind a compile-time const.Gravatar Ulf Adams2015-11-03
| | | | | | | More testing required before we even add a command-line option. -- MOS_MIGRATED_REVID=106922350
* Split the LoadingPhaseRunner into interface and implementation.Gravatar Ulf Adams2015-11-03
| | | | | | | | This is in preparation for adding a Skyframe-based implementation that uses the recently added TargetPatternPhaseFunction. -- MOS_MIGRATED_REVID=106920157
* [go] Add attribute documentation.Gravatar David Chen2015-11-03
| | | | | -- MOS_MIGRATED_REVID=106918682
* Don't remove a reverse dep after it was added in GraphConcurrencyTest. That ↵Gravatar Janak Ramakrishnan2015-11-03
| | | | | | | never happens during evaluation. Also make sure node entries exist when we add them as reverse deps. -- MOS_MIGRATED_REVID=106908097
* Cache and canonicalize references to PathFragments in ↵Gravatar Eric Fellheimer2015-11-03
| | | | | | | | | LineNumberTable$HashLine. This avoids creating largely the same set of PathFragment again and again. Also remove unnecessary boxing/unboxing. -- MOS_MIGRATED_REVID=106892926
* Make it more obvious where to look for build_tools_versions and api_level.Gravatar Carmi Grushko2015-11-03
| | | | | -- MOS_MIGRATED_REVID=106887522
* Update links in Bazel docs to point to new BE pages.Gravatar David Chen2015-11-02
| | | | | | | Fixes #529 -- MOS_MIGRATED_REVID=106883457
* When creating RuleContext, explicitly pass the set of attributes an attached ↵Gravatar Carmi Grushko2015-11-02
| | | | | | | Aspect provides. -- MOS_MIGRATED_REVID=106882046
* Make subcommand completion in zsh work on Mac OS XGravatar Yuki Yugui Sonoda2015-11-02
| | | | | | | | | Avoid depending on extended regexp of gawk -- Change-Id: I28a57c249c5b8078b410c365f51f400bcdc27997 Reviewed-on: https://bazel-review.googlesource.com/#/c/2240 MOS_MIGRATED_REVID=106877966
* Introduce ForkJoinQuiescingExecutor, permit its use in evaluationGravatar Mark Schaller2015-11-02
| | | | | | | | | | | | | | | | | | This CL introduces a QuiescingExecutor implementation specialized for ForkJoinPools with the same interrupt handling, error propagation, and task completion semantics as AbstractQueueVisitor. Currently it does this by largely sharing its implementation with AQV. Future refactoring could let it rely more on ForkJoinPool's own awaitQuiescence implementation to avoid the overhead of AQV's remainingTasks counter maintenance. Subtasks spawned by tasks executing in ForkJoinQuiescingExecutor will rely on ForkJoinPool's thread-local task deques for low contention and (mostly) LIFO ordering. -- MOS_MIGRATED_REVID=106864395
* Changes from [] that were left out of theGravatar Brian Silverman2015-11-02
| | | | | | | | | | | | | | previous commit Document and test how rules can run without the sandbox. The only documentation about usable tags values was in a weird place, along with duplicated information about flaky tests. -- Change-Id: Ib98a0a5c582890512161ecf9f5d89c8e78d9ad68 Reviewed-on: https://bazel-review.googlesource.com/#/c/2220 MOS_MIGRATED_REVID=106858070
* Fix AbstractQueueVisitor synchronization, comments, and field namesGravatar Mark Schaller2015-11-02
| | | | | | | | | | | | | | | | This fixes the following synchronization issue with AbstractQueueVisitor's jobsMustBeStoppedField: it was read in awaitTermination in a block synchronized on zeroRemainingTasks, but in markToStopAllJobsIfNeeded it was read and written in a block synchronized on the AQV instance. Now, it is always read or written in a block synchronized on zeroRemainingTasks, because it is used in the condition represented by that object. This also thoroughly cleans up obsolete and irregular documentation in the class. -- MOS_MIGRATED_REVID=106849236
* Parametrize aspect definition with AspectParameters.Gravatar Dmitry Lomov2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106848269
* Cleanup ValueVisitor (and dirty QuiescingExecutor)Gravatar Mark Schaller2015-11-02
| | | | | | | | | | | | | Raises the level of abstraction of ValueVisitor's dependence on AbstractQueueVisitor. Except for the "ForTestingOnly" methods now available on the QuiescingExecutor interface, ValueVisitor is agnostic to the implementation of its executor. This also cleans up the full spectrum of visibility modifiers on ValueVisitor methods, all of which ought to be private. -- MOS_MIGRATED_REVID=106847453
* Change ValueVisitor to use delegationGravatar Mark Schaller2015-11-02
| | | | | | | | This simplifies a future change that introduces new variance to ValueVisitor's use of AbstractQueueVisitor. -- MOS_MIGRATED_REVID=106846210
* Add runfiles for HOST executables for actions without commands tooGravatar Brian Silverman2015-11-02
| | | | | | | | | | | | 6c51059e0a04d4170d10bfedbd9553b498cf28e7 adds the runfiles for HOST executables listed as inputs to SpawnActions with a command, but it seems reasonable to be able to execute those with non-command SpawnActions (ie shell scripts) too. -- Change-Id: I33b0fe3936afa87c69046350a53ee1485f2beab3 Reviewed-on: https://bazel-review.googlesource.com/#/c/2260/ MOS_MIGRATED_REVID=106845702
* Move LoadingPhaseRunner.Callback to the top-level class LoadingCallback.Gravatar Ulf Adams2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106839024
* Move LoadingPhaseRunner.loadForConfigurations to CommandEnvironment.Gravatar Ulf Adams2015-11-02
| | | | | | | | It's unclear if the method is still necessary with Skyframe, but I don't want to investigate in detail right now. -- MOS_MIGRATED_REVID=106838896
* Move LoadingPhaseRunner.LoadingResult to a top-level class.Gravatar Ulf Adams2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106838787
* Move LoadingPhaseRunner.Options to top-level class LoadingOptions.Gravatar Ulf Adams2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106836859
* Document and test how rules can run without the sandbox.Gravatar Brian Silverman2015-11-02
| | | | | | | | | | The only documentation about usable tags values was in a weird place, along with duplicated information about flaky tests. -- Change-Id: Ib98a0a5c582890512161ecf9f5d89c8e78d9ad68 Reviewed-on: https://bazel-review.googlesource.com/#/c/2220 MOS_MIGRATED_REVID=106832660
* Interface methods are public anyway, remove superfluous modifiers.Gravatar Philipp Wollermann2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106826084
* Remove BlazeRuntime.reporter; use a BlazeModule to attach event handlers.Gravatar Ulf Adams2015-11-02
| | | | | | | | This only affects tests that previously set a Reporter on the BlazeRuntime; the production code is already using the per-command Reporter in all cases. -- MOS_MIGRATED_REVID=106820846
* Introduce ErrorClassifierGravatar Mark Schaller2015-11-02
| | | | | | | | | | Changes the AbstractQueueVisitor strategy for varying its response to unhandled exceptions from inheritance to composition. This will help with a forthcoming switch from inheritance to delegation for ValueVisitor's use of AbstractQueueVisitor. -- MOS_MIGRATED_REVID=106730708
* Introduce QuiescingExecutorGravatar Mark Schaller2015-11-02
| | | | | | | | | | | | This interface (mostly) encapsulates what the ValueVisitor expects from the AbstractQueueVisitor class it currently inherits from. This makes it easier for a future CL to change ValueVisitor's strategy of code reuse from inheritance to composition. RELNOTES: -- MOS_MIGRATED_REVID=106728863
* Pass StdRedirect.dylib to ios_runner.sh.mac_template. So that we could use ↵Gravatar Googler2015-11-02
| | | | | | | | | "xcrun simctl" instead of iossim to launch the app when we invoke "blaze run". The next CL is to use it in ios_runner.sh.mac_template after new bazle is released. -- MOS_MIGRATED_REVID=106725049
* Strict matching of architecture name to ios platform. Also refactor Platform ↵Gravatar Chris Parsons2015-11-02
| | | | | | | into a new .apple package, as it is not relevant for solely objc rules. -- MOS_MIGRATED_REVID=106709486
* Adds a bazel-rules-tests java_test rule for the tests under ↵Gravatar Alex Humesky2015-11-02
| | | | | | | src/test/java/com/google/devtools/build/lib/bazel/rules -- MOS_MIGRATED_REVID=106695490
* Implement propagation along dependencies for Skylark aspects.Gravatar Dmitry Lomov2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106694515
* xcrun was adding a newline on the output that was being set in the SDKROOT ↵Gravatar Dave MacLachlan2015-11-02
| | | | | | | | | environment variable. RELNOTES:none -- MOS_MIGRATED_REVID=106694003
* Create directories for all the files in tarballs.Gravatar Brian Silverman2015-11-02
| | | | | | | | | | dpkg fails to install packages without the directories listed before the files in the data tarball. -- Change-Id: I839ce82de5414d3bf6ed98ec81f576eddcc66bee Reviewed-on: https://bazel-review.googlesource.com/#/c/2212 MOS_MIGRATED_REVID=106693757
* Deflake --runs_per_test_detects_flakes.Gravatar Brian Silverman2015-11-02
| | | | | | | | | | | Previously, if the first run failed (in iteration order, which I don't think is necessarily execution order) then --runs_per_test_detects_flakes would report FAILED instead of FLAKY. -- Change-Id: Ice7889d46203e1598d94a4e3c0bcbe13a45b0fe1 Reviewed-on: https://bazel-review.googlesource.com/#/c/2210/ MOS_MIGRATED_REVID=106693725
* Error out if no src files are provided to GroovyGravatar Erik Kuefler2015-11-02
| | | | | | | | | Otherwise you get groovyc's usage message spammed to stdout -- Change-Id: I04bcfd9166adb6c9287839035f025f93d805e738 Reviewed-on: https://bazel-review.googlesource.com/#/c/2251/ MOS_MIGRATED_REVID=106693428
* Drop src/test/java/BUILDGravatar Han-Wen Nienhuys2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106693383
* Don't overwrite existing __init__.py files in py_binary zipsGravatar Benjamin Staffin2015-10-30
| | | | | | | | | | | | This switches zip from "add" to "update" mode, and only adds __init__.py where it's not already present. Fixes: #542 -- Change-Id: Id65632d1448b403ad328e4a1619c0d4e8ebfdcb4 Reviewed-on: https://bazel-review.googlesource.com/#/c/2250 MOS_MIGRATED_REVID=106690985
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-22 03:27:33 +0000