aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Allow cc_toolchain to have inline proto toolchain data, instead of using ↵Gravatar John Cater2018-03-02
| | | | | | | crosstool top. Change-Id: I531034b0c991d18b05818db4b40cbd739535b565 PiperOrigin-RevId: 187617580
* ci,windows: fix "bazel-rules-tests"Gravatar Laszlo Csomor2018-03-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the failing test in //src/test/java/com/google/devtools/build/lib:bazel-rules-tests on Windows. The problem was that the test setup read a resource file and assumed line endings to be "\n", but on Windows this resource file was generated with "\r\n" endings. The test setup code then put those strings into a set. Finally, the test tried to match a string in this set, but because the entries had an invisible "\r" at the end, the matching failed. This commit trims the entries before putting them in the set. Fixes https://github.com/bazelbuild/bazel/issues/4752 Closes #4754. PiperOrigin-RevId: 187608803
* Add option to filter for targets in the action graph dump.Gravatar twerth2018-03-02
| | | | | RELNOTES: Use bazel dump --action_graph=/path/to/action.proto --action_graph:targets://foo:bar,//foo:foo to filter for certain targets in the action graph dump. PiperOrigin-RevId: 187608321
* CROSSTOOLS: Fix comment for /EHsc compiler flagGravatar Samer Masterson2018-03-02
| | | | | | | | The previous comment referred to the option `/EHa`, but `/EHsc` is the option to only catch C++ standards (which seems to be what we want, according to this doc: https://msdn.microsoft.com/en-us/library/1deeycx5.aspx) Closes #4739. PiperOrigin-RevId: 187593737
* C++: Exposes to Skylark basic API functionalityGravatar plf2018-03-02
| | | | | RELNOTES:none PiperOrigin-RevId: 187591225
* Greeter.java: Trimming content read from greeting.txtGravatar pcloudy2018-03-02
| | | | | | | Fixed https://github.com/bazelbuild/bazel/issues/4723 RELNOTES: PiperOrigin-RevId: 187589378
* Improve error message of import_deps_checker.Gravatar cnsun2018-03-01
| | | | | RELNOTES: None. PiperOrigin-RevId: 187571707
* Make JavaCompileAction and friends emit new-style arguments.Gravatar tomlu2018-03-01
| | | | | | | | | Instead of --direct_dependency, --indirect_dependency args we now emit --direct_dependencies. We no longer need to emit any jar owner information since that is baked into the jar by JavaBuilder. This CL also contains the deletion of CustomMultiArgv and the injecting_rule_kind aspect parameter, as the deleted code was the last remaining usage. RELNOTES: None PiperOrigin-RevId: 187558628
* Android desugar config options to exclude methods from interface emulationGravatar kmb2018-03-01
| | | | | | RELNOTES: None. PiperOrigin-RevId: 187551970
* Create --incompatible_disable_objc_provider_resources to disable deprecated ↵Gravatar cparsons2018-03-01
| | | | | | | | | objc provider skylark fields. This flag is not fully implemented -- there should also be a way to disable the provider getters using this flag, but, since @SkylarkCallable does not allow for evaluation of SkylarkSemantics, this is not yet possible. RELNOTES: None. PiperOrigin-RevId: 187542004
* Add target name to android_device boot step action.Gravatar ajmichael2018-03-01
| | | | | RELNOTES: None PiperOrigin-RevId: 187539005
* Migrate a few trivial uses of @SkylarkSignature to use @SkylarkCallable insteadGravatar cparsons2018-03-01
| | | | | RELNOTES: None. PiperOrigin-RevId: 187531006
* Add AndroidDex2OatInfo to Skylark.Gravatar Googler2018-03-01
| | | | | RELNOTES: None PiperOrigin-RevId: 187530224
* Migrate some users of useAst to useLocationGravatar cparsons2018-03-01
| | | | | | | (It's good to avoid passing around more information than one needs, and FuncallExpression is pretty heavy when only a Location is necessary) RELNOTES: None. PiperOrigin-RevId: 187529568
* Remove hacky cast now that Copybara is updated to use GlobalFrameGravatar nharmata2018-03-01
| | | | | | | (https://github.com/google/copybara/commit/77a0e68eb0b044449b412e939ad25d500d2c12d3). RELNOTES: None PiperOrigin-RevId: 187525928
* Introduce a specific action_config for linking nodeps dynamic librariesGravatar hlopko2018-03-01
| | | | | | | | | | | | | With this cl toolchain author can specify different flags for linking shared library produced by cc_library and a shared library produced by cc_binary. This is what is needed to remove linking_mode_flags - MOSTLY_STATIC_LIBRARIES from the crosstool. What this linking mode was used for was to separate when we link transitive shared library from cc_binary and when we link this little-and-not-really-useful-outside-of-bazel nodeps shared library in cc_library. RELNOTES: CcToolchain: Introduced action_config for "c++-link-transitive-dynamic-library" PiperOrigin-RevId: 187523334
* send invocations to emulated interfaces through dispatch helper.Gravatar kmb2018-03-01
| | | | | | | fix logic for implementing emulated interfaces. RELNOTES: None. PiperOrigin-RevId: 187520298
* Remove unnecessary copy of source SPEC file to temporary destinationGravatar mmikitka2018-03-01
| | | | | | | | | | | | Previous behaviour: * The CopyAndRewrite function would raise a write permission denied error on the output file, which had permissions 0555, when the input SPEC file was auto-generated. Current behaviour: * Do not copy the input SPEC file (auto-generated or otherwise) to the destination in the temporary working directory since the CopyAndRewrite function will generate the output file regardless. This allows the package to support static or auto-generated SPEC files. Closes #4716. PiperOrigin-RevId: 187511568
* Make the distinction between "global frame" and "lexical frame" explicit. As ↵Gravatar nharmata2018-03-01
| | | | | | | a nice consequence, this lets us reduce GC churn since we no longer need to create a frame instance for the lexical frame at a callsite of either a function when the environment is frozen or a builtin function (since builtins cannot modify bindings in their lexical frame). RELNOTES: None PiperOrigin-RevId: 187495787
* Change pkg_rpm changelog to optionalGravatar mmikitka2018-03-01
| | | | | | | | The changelog is not used by make_rpm.py, and I don't have a need for it since I auto-generate the SPEC file, which includes a "%changelog" section, prior to invoking the pkg_rpm rule. Closes #4717. PiperOrigin-RevId: 187494400
* Fixes nit by removing accidently-repeated words.Gravatar Googler2018-03-01
| | | | | RELNOTES: None. PiperOrigin-RevId: 187489449
* Fix broken linksGravatar Googler2018-03-01
| | | | | | | The links were to different sections in the page, but were not prefixed with hashtags. RELNOTES: Fix broken links in query docs. PiperOrigin-RevId: 187486286
* Update iOS tutorial to reference latest releaseGravatar Sergio Campama2018-03-01
| | | | | | Closes #4712. PiperOrigin-RevId: 187486082
* Fixing issue with external j2objc protosGravatar Mike Lewis2018-03-01
| | | | | | | | | | | | | | | | | | | | | | | The output files are created without a repository, but the expected filenames have them This resolves issues when having a proto_library from an external build file. This seems to be a regression, so maybe should go into the 0.8.0 branch? Note: Work at Square and we have a signed CLA with google Note, without this fix we get errors like ``` ERROR: /private/var/tmp/_bazel_lewis/4a25cfc2b9b758043413ac58525ef6b4/external/AllProtos/BUILD.bazel:27:1: output 'external/AllProtos/squareup/objc/objc.j2objc.pb.m' was not created ERROR: /private/var/tmp/_bazel_lewis/4a25cfc2b9b758043413ac58525ef6b4/external/AllProtos/BUILD.bazel:27:1: output 'external/AllProtos/squareup/objc/objc.j2objc.pb.h' was not created ``` Closes #4058. PiperOrigin-RevId: 187480864
* Remove --incompatible_load_argument_is_label flagGravatar laurentlb2018-03-01
| | | | | | RELNOTES: Removed flag `--incompatible_load_argument_is_label`. PiperOrigin-RevId: 187479614
* Fix invocation policy's handling of the null default when filtering values.Gravatar ccalvarin2018-03-01
| | | | | | | For a filter on option values (either by whitelist, allow_values, or blacklist, disallow_values), one of the options for what to do when encountering a disallowed value is to replace it with the default. This default must be itself an allowed value for this to make sense, so this is checked. This check, however, shouldn't apply to flags that are null by default, since these flags' default value is not parsed by the converter, so there is no guarantee that there exists an accepted user-input value that would also set the value to NULL. In these cases, we assume that "unset" is a distinct value that is always allowed. RELNOTES: None. PiperOrigin-RevId: 187475696
* bazel_workspace_status_test: don't assume orderGravatar Justin Santa Barbara2018-03-01
| | | | | | | | | | | The test_errmsg test tested the behaviour when workspace_status_command was set to a file that did not exist, but other tests created a file with that name. If test_errmsg did not run first, the workspace_status_command would be valid and the test would fail. Closes #4704. PiperOrigin-RevId: 187470549
* Add aehlig@ to list of Bazel contributorsGravatar aehlig2018-03-01
| | | | PiperOrigin-RevId: 187467154
* Deprecate native git_repositoryGravatar Klaus Aehlig2018-03-01
| | | | | | | | | | | | | | The skylark implementation of git_repository is a drop-in replacement for the native workspace rule. So deprecate the latter to avoid having two implementations of the same. Also, the native rule pulls in quite some dependencies. RELNOTES: The native git_repository rule is deprecated. Use the Skylark version available via load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository") instead. Change-Id: Id75d8e7b7377acd1092c4ba993f488be86c03fa0 PiperOrigin-RevId: 187466931
* Sync Debian package deps, and add a comment to prevent future desync.Gravatar John Millikin2018-03-01
| | | | | | | | | | | | | Commit c8be465869fbcfaa00b75d241c67279324976e0b added the headless JDK to `debian/control`, but this isn't propagating to published packages because those use the deps list in `debian/BUILD`. This commit adds the headless JDK to `debian/BUILD`, with comments so future changes won't hit the same problem. Closes #4686. PiperOrigin-RevId: 187461399
* Correct docstring for skylark string.split().Gravatar Googler2018-03-01
| | | | | RELNOTES: None. PiperOrigin-RevId: 187453379
* Convert static std::set to constexpr arrayGravatar Loo Rong Jie2018-03-01
| | | | | | | | | | | | | Google C++ Style Guide disallows static variable with non-trivial destructor. Use constexpr for static variable whenever possible. std::array would make the code cleaner, but MSVC's implementation of constexpr std::array is buggy. Side-benefit: linear search is faster when array is small (<20). Change-Id: Ic8244dcb868e27d02ceb5298ccec482e7d4254b7 PiperOrigin-RevId: 187451495
* Support patching of git repositories as wellGravatar Klaus Aehlig2018-03-01
| | | | | | | | | | By simply sharing the utility function. In this way, we get feature parity between git_repository and http_archive. Fixes #4676. Change-Id: I99b300e42b2f267d8d04fd965f09c24f3ae54f10 PiperOrigin-RevId: 187450644
* Respect JAVA_HOME before searching JDK under "C:/Program Files/Java"Gravatar pcloudy2018-03-01
| | | | | | | Fixed https://github.com/bazelbuild/bazel/issues/4722 RELNOTES: None PiperOrigin-RevId: 187443457
* Remove a misleading comment.Gravatar carmi2018-02-28
| | | | | | | installBase is also used to access the embedded binaries. RELNOTES: None PiperOrigin-RevId: 187422136
* Change the strict deps plugin to read jar owner from manifest.Gravatar tomlu2018-02-28
| | | | | | | | | | | | | | | | | The plugin tries to read the following attributes: Target-Label: <label> Injecting-Rule-Kind: <rule kind> These are used instead of the jar owners passed to JavaBuilder from blaze. Any owners currently passed from blaze are now ignored. This CL also half-reverts the command line syntax for JavaBuilder and Turbine. It is now: --classpath <jar1> <jar2> ... --direct_dependencies <jar1> ... RELNOTES: None PiperOrigin-RevId: 187419469
* PiperOrigin-RevId: 187409545Gravatar dannark2018-02-28
|
* Automated rollback of commit c0e52bce8278243e8fd43f8307b413114d3ebbba.Gravatar dannark2018-02-28
| | | | PiperOrigin-RevId: 187409187
* Verifying result read with retries in the remote execute unit test.Gravatar olaola2018-02-28
| | | | | | | | The current behavior is already correct, just adding a test to make sure we retry reads as we should. TESTED=the unit test RELNOTES: None PiperOrigin-RevId: 187398578
* Deletes CODEC fields now that they are no longer needed.Gravatar shahan2018-02-28
| | | | PiperOrigin-RevId: 187397314
* Add @AutoCodec to FileType and FileTypeSet.Gravatar mjhalupka2018-02-28
| | | | | | More strictly type the arguments for creating FileTypes. PiperOrigin-RevId: 187391336
* Prevent aspects with the same attributes but different names from outputting ↵Gravatar juliexxia2018-02-28
| | | | | | duplicates of those attributes in query's proto output format. PiperOrigin-RevId: 187387578
* Add logging message when a PublishBuildToolEventStream() RPCs start.Gravatar Googler2018-02-28
| | | | | | | Logs whenever BuildEvenServiceTransport starts a PublishBuildToolEventStream streaming RPC. PiperOrigin-RevId: 187374228
* Introduce an Extrema aggregator.Gravatar nharmata2018-02-28
| | | | | RELNOTES: None PiperOrigin-RevId: 187370833
* Refactor the AbstractAction computeKey method to be easier to add invariantsGravatar jcater2018-02-28
| | | | | | for every type of action. PiperOrigin-RevId: 187368369
* Add --proto:output_rule_attrs flag to blaze query to enable filtering of ↵Gravatar Googler2018-02-28
| | | | | | | | output to given attributes. RELNOTES[NEW]: blaze query: use --proto:output_rule_attrs to filter for given attributes PiperOrigin-RevId: 187364996
* Deprecate and remove several uses of the 'values' map in NativeInfo subclasses.Gravatar cparsons2018-02-28
| | | | | | | | | | These subclasses should be using @SkylarkCallable(structField = true) instead This is a bit of a memory win, as there is now no need to store field information twice. There are still a couple of stragglers that are more difficult, namely ToolchainInfo and DefaultInfo. Their APIs will likely need some more extensive revamping before proceeding. RELNOTES: None. PiperOrigin-RevId: 187364392
* Remove unused fields from a few Cc* rule implementations.Gravatar cparsons2018-02-28
| | | | | RELNOTES: None. PiperOrigin-RevId: 187356329
* Tag RuleClassNamePredicate with @AutoCodec by switching to lazyGravatar mjhalupka2018-02-28
| | | | | | | initialization of the Predicates, and storing the set of strings the predicates are based on. PiperOrigin-RevId: 187351700
* Create a runtime codec for HashCode.Gravatar mjhalupka2018-02-28
| | | | | | Remove the HashCode marshaller. PiperOrigin-RevId: 187350917