| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default values for
flags whose allowMultiple is true.
The behavior is the following:
- If allowMultiple is false then behave as previously.
- Otherwise for retrieving the default we now look at defaultMultipleValue instead of defaultValue and
in the process it will apply the converter to each element. If no defaultMultipleValue is specified
then the default value will be an empty list.
--
MOS_MIGRATED_REVID=117558645
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117552815
|
|
|
|
|
|
|
| |
references that escape its package.
--
MOS_MIGRATED_REVID=117550535
|
|
|
|
|
|
|
| |
optionally expose a custom factory implementation.
--
MOS_MIGRATED_REVID=117546934
|
|
|
|
|
|
|
| |
I didn't verify that this is the right thing, but it sure compiles. That's not a very high bar for Python rules, though.
--
MOS_MIGRATED_REVID=117543822
|
|
|
|
|
|
|
|
|
| |
because we halted.
RELNOTES: Tests that failed to build because execution was halted no longer print their status.
--
MOS_MIGRATED_REVID=117542221
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117534962
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117512506
|
|
|
|
|
|
|
|
|
| |
Note:
- If build rules do not change this action should be identical
- This relies on a very experiment set of changes to proguard and should be used with caution until they have soaked for a while
--
MOS_MIGRATED_REVID=117508271
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117494528
|
|
|
|
|
|
|
|
|
| |
Introduces the AndroidDataMerger, MergeConflict, and UnwrittenMergedAndroidData which is the entry point in the AndroidResourceProcessing *AndroidData lifecycle.
Also, refactors the AndroidDataSet parsing of resources, making it functionally immutable.
--
MOS_MIGRATED_REVID=117492690
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The //tools/defaults package exports the values of blaze flags, including
--java_langtools. That flag is being deprecated and the configuration moved
into the java_toolchain rule.
This change migrates from the //tools/defaults targets for Java tools to the
canonical versions of those tools.
Unlike the previous solution, the tools in the package are no longer affected
by the current build configuration (e.g. the value of --java_toolchain). If
that configurability becomes necessary again, we can achieve it using Skylark
(via the java.compilation_info.boot_classpath provider), or by expanding the
blaze query output for java_toolchain (as used in java_toolchain_content).
--
MOS_MIGRATED_REVID=117485737
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117485208
|
|
|
|
|
|
|
| |
This was actually not breaking the build, just outputing an error
--
MOS_MIGRATED_REVID=117481375
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117478721
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117477418
|
|
|
|
|
|
|
| |
copying it. The copying showed up as a source of memory spikiness in an OOM.
--
MOS_MIGRATED_REVID=117477133
|
|
|
|
|
|
|
|
|
| |
Cycle when looking for a repository name will now shows a user-understable error.
Fixes #877.
--
MOS_MIGRATED_REVID=117453646
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117452774
|
|
|
|
|
|
|
|
|
| |
conflicting actions.
Currently Blaze outputs all mandatory inputs diffs between two actions if they result in conflictions. It is useful debugging information however could be quite large. This change sets the maximum number of records in the diff list to 5.
--
MOS_MIGRATED_REVID=117449664
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117446080
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117438482
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--java_langtools=@bazel_tools//tools/jdk:langtools
--javabuilder_top=@bazel_tools//tools/jdk:JavaBuilder_deploy.jar
--singlejar_top=@bazel_tools//tools/jdk:SingleJar_deploy.jar
--genclass_top=@bazel_tools//tools/jdk:GenClass_deploy.jar
--ijar_top=@bazel_tools//tools/jdk:ijar
--javac_bootclasspath=@bazel_tools//tools/jdk:bootclasspath
--javac_extdir=@bazel_tools//tools/jdk:extdir
--java_toolchain=@bazel_tools//tools/jdk:toolchain
--
MOS_MIGRATED_REVID=117437051
|
|
|
|
|
|
|
|
| |
AspectClass (also SkylarkApsectClass as its implementation) is a part of AspectKey.
DependencyResolver gets the definition of aspect (including
--
MOS_MIGRATED_REVID=117433907
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, this would get thrown when referring to the same package
from both the main and default repositories:
java.lang.IllegalArgumentException: Multiple entries with same key: tools/cpp=/home/brian/971-Robot-Code and tools/cpp=/home/brian/971-Robot-Code
at com.google.common.collect.ImmutableMap.checkNoConflict(ImmutableMap.java:136)
at com.google.common.collect.RegularImmutableMap.checkNoConflictInKeyBucket(RegularImmutableMap.java:98)
at com.google.common.collect.RegularImmutableMap.fromEntryArray(RegularImmutableMap.java:84)
at com.google.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:295)
at com.google.devtools.build.lib.buildtool.BuildTool.transformPackageRoots(BuildTool.java:301)
at com.google.devtools.build.lib.buildtool.BuildTool.buildTargets(BuildTool.java:209)
at com.google.devtools.build.lib.buildtool.BuildTool.processRequest(BuildTool.java:334)
at com.google.devtools.build.lib.runtime.commands.TestCommand.doTest(TestCommand.java:119)
at com.google.devtools.build.lib.runtime.commands.TestCommand.exec(TestCommand.java:104)
at com.google.devtools.build.lib.runtime.BlazeCommandDispatcher.exec(BlazeCommandDispatcher.java:371)
at com.google.devtools.build.lib.runtime.BlazeRuntime$3.exec(BlazeRuntime.java:1016)
at com.google.devtools.build.lib.server.RPCService.executeRequest(RPCService.java:65)
at com.google.devtools.build.lib.server.RPCServer.executeRequest(RPCServer.java:434)
at com.google.devtools.build.lib.server.RPCServer.serve(RPCServer.java:229)
at com.google.devtools.build.lib.runtime.BlazeRuntime.serverMain(BlazeRuntime.java:975)
at com.google.devtools.build.lib.runtime.BlazeRuntime.main(BlazeRuntime.java:772)
at com.google.devtools.build.lib.bazel.BazelMain.main(BazelMain.java:55)
And this would get thrown for any packages in the main repository loaded
from other repositories:
java.lang.RuntimeException: Unrecoverable error while evaluating node 'PACKAGE:@//tools/build_rules/go/toolchain' (requested by nodes )
at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:982)
at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:499)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalArgumentException: Invalid BUILD file name for package '@//tools/build_rules/go/toolchain': /home/brian/bazel/tools/build_rules/go/toolchain/BUILD
at com.google.devtools.build.lib.packages.Package.finishInit(Package.java:299)
at com.google.devtools.build.lib.packages.Package$Builder.finishBuild(Package.java:1308)
at com.google.devtools.build.lib.skyframe.PackageFunction.compute(PackageFunction.java:501)
at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:933)
... 4 more
Sponsor's comment: note the abundance of new Label.resolveRepositoryRelative() calls. They are ugly, but it's only making existing ugliness explicit. Yes, we should fix it, especially in the implementation of configurable attributes.
Refs #940
--
Change-Id: I8bd7f7b00bec58a7157507595421bc50c81b404c
Reviewed-on: https://bazel-review.googlesource.com/#/c/2591
MOS_MIGRATED_REVID=117429733
|
|
|
|
|
|
|
| |
superfluous .toString() calls from Constants.java .
--
MOS_MIGRATED_REVID=117429096
|
|
|
|
|
|
|
| |
RELNOTES[INC]: Any project that depended on the objc_options rule will be broken. Can be fixed by adding attrs (infoplists,copts) directly to rules depending on the options.
--
MOS_MIGRATED_REVID=117393853
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also enables Jack support to compile with the Java bootclasspath
when running over non-Android rules. This is akin to how normal javac
support works - android_ rules are compiled with android.jar, while
java_libraries are compiled with special flags but the normal compile
time bootclasspath.
As of this change, the android_jack attribute on android_sdk is now
deprecated, and has no further effect. Because it was always optional,
this isn't really much of a change, it just means that now it does
nothing even if you DO specify it.
Because Jack support is still experimental, this should have no effect
on most users.
RELNOTES[INC]: android_sdk now compiles android_jack on the fly from
android_jar, which means android_jar must be a jar and android_jack is
now deprecated. The Jack tools (jack, jill, resource_extractor) must
be specified.
--
MOS_MIGRATED_REVID=117386373
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117383853
|
|
|
|
|
|
|
| |
This will set the default value for the iOS SDK version configuration value. Users can override this by specifying ios_sdk_version themselves.
--
MOS_MIGRATED_REVID=117377043
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117375231
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
3a95f353704dc2f7061e2c0786c2459ac1db0fd1.
AbstractSet#removeAll has unexpected, yet oddly intentional (and documented), performance characteristics. Suppose we are evaluating 'set.removeAll(collection)' and 'collection.contains(x)' is 'O(e)'. Then 'set.removeAll(collection)' is 'O(set.size())' when 'set.size() <= collection.size()' and 'O(set.size()) * e' otherwise. When 'collection' is e.g. an ArrayList, 'e' is 'collection.size()' and so 'set.removeAll(collection)' is 'O(set.size() * collection.size())', which is bad.
This meant we had poor performance when the excludes patterns of a glob matched more files than the includes patterns.
Note that, while GlobCache#glob() *did* also use removeAll (potentially inefficiently), it was doing so for each list of exclude glob matches individually. So legacy globbing would have suboptimal performance for 'glob(includes=[i_1, i_2, ...i_k], excludes = [e_1, e_2, ..., e_j])' whenever the result of any e_i was larger than the union of all the includes matches. (But skyframe hybrid globbing has the performance issue when the union of the excludes matches is larger than the union of the includes matches, which is more likely to happen in practice.) I fixed this hypothetical problem too.
--
MOS_MIGRATED_REVID=117367755
|
|
|
|
|
|
|
|
|
|
|
|
| |
- add flag --sandbox_add_path, which takes a list of additional paths as argument and mount these paths to sandbox. Fixes #884.
- mount target of /etc/resolv.conf if it is a symlink. Fixes #738.
RELNOTES:
- add flag --sandbox_add_path, which takes a list of additional paths as argument and mount these paths to sandbox.
- mount target of /etc/resolv.conf if it is a symlink.
--
MOS_MIGRATED_REVID=117364211
|
|
|
|
|
|
|
|
| |
This prevents processors from seeing turbine's version of e.g. guava. javac is
still available becuase Blaze puts it on the bootstrap classpath.
--
MOS_MIGRATED_REVID=117363448
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117361388
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bazel expects to be told the width of the terminal; during
bootstrap, we do not have a good mechanism of determining it,
so we have to resort to a hard-coded value. However, 97 is a
not very well motivated value (and actually not a very useful
value either) which is hard to guess that this is a default value.
Resorting to Bazel's built-in default of 80 is only slightly
more useful, but, at least, it is easily recognizable as a default
value, as 80 is the width of the famous VT100, the standard punch
card, etc.
--
Change-Id: I62403ca37ee74a090067a5a4248028e3d624b7c6
Reviewed-on: https://bazel-review.googlesource.com/#/c/3082
MOS_MIGRATED_REVID=117346018
|
|
|
|
|
|
|
| |
collectProguardSpecsFromAttribute work with attributes added by Aspects.
--
MOS_MIGRATED_REVID=117343880
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117340875
|
|
|
|
|
|
|
| |
--
Change-Id: Ib7d2e97a62fab06e47d3c1504f47c5e30933524e
Reviewed-on: https://bazel-review.googlesource.com/#/c/3073/
MOS_MIGRATED_REVID=117340155
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the process wrapper the value '-' has a special meaning
as file name to which stdout/stderr are to be redirected: do
not redirect. However, the simple shell script that serves
as process wrapper during the bootstrap phase was not aware
of this special meaning, resulting in loss of useful process
output, which is especially annoying during bootstrap. Fix this.
--
Change-Id: Ifcf84e9000d74dafc69b675f192c1fc1cce484e8
Reviewed-on: https://bazel-review.googlesource.com/#/c/3081
MOS_MIGRATED_REVID=117338558
|
|
|
|
|
|
|
| |
//third_party/protobuf.
--
MOS_MIGRATED_REVID=117336377
|
|
|
|
|
|
|
| |
getGeneratingSpawnAction.
--
MOS_MIGRATED_REVID=117290280
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117277091
|
|
|
|
|
|
|
|
|
| |
This makes it possible to isolate coverage runs for Apple platforms and perform a different set of operations.
RELNOTES:
--
MOS_MIGRATED_REVID=117269972
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117268295
|
|
|
|
|
|
|
| |
RELNOTES: Enable overriding jsonnet binaries and stdlib for Jsonnet rules.
--
MOS_MIGRATED_REVID=117267276
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117262661
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117260412
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117258091
|
|
|
|
|
|
|
| |
--
Change-Id: I1831a657552a661a555c7f8bef54e8f46ddd482d
Reviewed-on: https://bazel-review.googlesource.com/#/c/3050/
MOS_MIGRATED_REVID=117238730
|