| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks bazel-docker-tests
http://ci.bazel.io/view/Dashboard/job/bazel-docker-tests/lastCompletedBuild/BAZEL_VERSION=HEAD,PLATFORM_NAME=docker/console
*** Original change description ***
Enable header compilation by default
--
PiperOrigin-RevId: 144176396
MOS_MIGRATED_REVID=144176396
|
|
|
|
|
|
|
|
|
| |
being bundled instead of copying them into the directory structure
first.
--
PiperOrigin-RevId: 144133387
MOS_MIGRATED_REVID=144133387
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144127414
MOS_MIGRATED_REVID=144127414
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Bad rollback, was only partial.
*** Original change description ***
Automated [] rollback of commit 9a13899b1492738f8d1a9118cebc9ef9d90c6b34.
*** Reason for rollback ***
Fixed the problem with the CL.
*** Original change description ***
Bazel client, Windows: implement UnlinkPath
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 144115263
MOS_MIGRATED_REVID=144115263
|
|
|
|
|
|
|
|
| |
this test has been rolled back.
--
PiperOrigin-RevId: 144112095
MOS_MIGRATED_REVID=144112095
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This unifies the test and production javac invocations. Location arguments
(e.g. classpath, sources) are now set programatically from Paths, instead
of going through string args.
The classloader masking plugin is now just a custom filemanager, since javac
uses the same context for the entire compilation and we don't need a plugin
to carry it across annotation processing rounds.
--
PiperOrigin-RevId: 144110025
MOS_MIGRATED_REVID=144110025
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144108788
MOS_MIGRATED_REVID=144108788
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144107395
MOS_MIGRATED_REVID=144107395
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Still breaks //src/test/shell/bazel:bazel_test_test
http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/lastCompletedBuild/testReport/(root)/(empty)/test_test_timeout/
--
PiperOrigin-RevId: 144107285
MOS_MIGRATED_REVID=144107285
|
|
|
|
|
|
|
|
| |
it conflicts with IntelliJ dependencies, till we find a better way to separate the dependencies of the Test Runner from the dependencies of the Test Target.
--
PiperOrigin-RevId: 144100298
MOS_MIGRATED_REVID=144100298
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks //src/test/shell/bazel:persistent_test_runner_test
http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/lastBuild/testReport/junit/(root)/(empty)/test_simple_scenario/
*** Original change description ***
Also add the duration as the test process time.
Technically, this code is incorrect, because we're calling into spawn strategy,
which might do any amount of additional waiting (e.g., to acquire local
resources). We should change spawn strategy to return structured information
about the subprocess execution, including the wall time, and use that to set
the test information. But for now, this seems good enough.
Fixes #1748.
--
PiperOrigin-RevId: 144096164
MOS_MIGRATED_REVID=144096164
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The environment is now computed with a mixture of the client environment and
the values specified by the --action_env flag. If a user want to overwrite its
environment for skylark repository, they can do `--action_env FOO=BAR` and
the repository will see FOO as having the value BAR, whichever value is
set in the client environment.
Also propagate it to all repository functions, and deduplicate the way
the client environment is passed to repository functions.
Design doc: https://bazel.build/designs/2016/10/18/repository-invalidation.html [step 1]
RELNOTES[INC]: repository_ctx environment is now affected by --action_env flag (value from the
client environment will be replaced by value given on the command line through --action_env).
--
Change-Id: I131a9695439aa9949d5001f820e2ae450e41332f
Reviewed-on: https://cr.bazel.build/7971
PiperOrigin-RevId: 144091492
MOS_MIGRATED_REVID=144091492
|
|
|
|
|
|
|
|
|
|
|
| |
Since it's already a no-op after the latest release
this should be harmless...
R=ahumesky
--
PiperOrigin-RevId: 144088752
MOS_MIGRATED_REVID=144088752
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Fixed the problem with the CL.
*** Original change description ***
Bazel client, Windows: implement UnlinkPath
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 144087552
MOS_MIGRATED_REVID=144087552
|
|
|
|
|
|
|
|
|
|
| |
Create the test spawn upfront instead of lazily. In the common case, this
doesn't cost anything, but the worker test strategy doesn't use the spawn
right now.
--
PiperOrigin-RevId: 144086321
MOS_MIGRATED_REVID=144086321
|
|
|
|
|
|
|
|
| |
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 144084379
MOS_MIGRATED_REVID=144084379
|
|
|
|
|
|
|
|
|
|
| |
licenses.
Also flipped :jvm attribute from HOST to TARGET and set the new flag on it.
--
PiperOrigin-RevId: 144084000
MOS_MIGRATED_REVID=144084000
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks windows:
bazel-out/local-fastbuild/bin/src/main/cpp/util/libfile.a(file_windows.o):file_windows.cc:(.text+0x11e2): multiple definition of `blaze_util::UnlinkPath(std::string const&)'
bazel-out/local-fastbuild/bin/src/main/cpp/util/libfile.a(file_posix.o):file_posix.cc:(.text+0x3ff): first defined here
*** Original change description ***
Bazel client, Windows: implement UnlinkPath
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 144082937
MOS_MIGRATED_REVID=144082937
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Technically, this code is incorrect, because we're calling into spawn strategy,
which might do any amount of additional waiting (e.g., to acquire local
resources). We should change spawn strategy to return structured information
about the subprocess execution, including the wall time, and use that to set
the test information. But for now, this seems good enough.
Fixes #1748.
--
PiperOrigin-RevId: 144082073
MOS_MIGRATED_REVID=144082073
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add backquotes around the changelog
- Add empty line at the end of the changelog
- Enforce the use of the master changelog prior to release
Fixes #2281.
--
Change-Id: I449f5209a6b05e65411a64ce82ea1d89d60ee4d3
Reviewed-on: https://cr.bazel.build/8044
PiperOrigin-RevId: 144080940
MOS_MIGRATED_REVID=144080940
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
*still* does not work with Windows:
http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=windows-x86_64/lastBuild/console
*** Original change description ***
Jarjar the third-party dependencies of the Jacoco test runner.
This is an encore of commit 823091f7516abf7d854021edc765daf1467f1647, which failed because Java temp directory handling in actions is broken at the moment.
Fixes #2343.
--
PiperOrigin-RevId: 144076235
MOS_MIGRATED_REVID=144076235
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the patch-id differ because of merge conflict or subtle adjacent
change, the cherrypick origin was missing, resulting in non existent
cherrypick lines in the changelog.
If the cherrypicks are done by the script, adds the cherrypick origin
to a git note and use that origin when generating the release note. Also
fallback to the commit hash of the resulting commit if the cherrypick
origin cannot be found.
Fixes #2272.
--
Change-Id: I311bbe777ea82be05f9fba0a658bab075ed1bd97
Reviewed-on: https://cr.bazel.build/8042
PiperOrigin-RevId: 144075867
MOS_MIGRATED_REVID=144075867
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144074221
MOS_MIGRATED_REVID=144074221
|
|
|
|
|
|
|
|
| |
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 144073888
MOS_MIGRATED_REVID=144073888
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144072456
MOS_MIGRATED_REVID=144072456
|
|
|
|
|
|
|
|
| |
08426525c517599a76b4f69814baf28731e840c7 .
--
PiperOrigin-RevId: 144071698
MOS_MIGRATED_REVID=144071698
|
|
|
|
|
|
|
|
|
| |
This cl exposes param files that were hard-coded before. This enables more
precise placement on the link command line.
--
PiperOrigin-RevId: 144069927
MOS_MIGRATED_REVID=144069927
|
|
|
|
|
|
|
|
| |
RELNOTES[INC]: Deprecated globals HOST_CFG and DATA_CFG are removed. Use strings "host" and "data" instead.
--
PiperOrigin-RevId: 144069794
MOS_MIGRATED_REVID=144069794
|
|
|
|
|
|
|
|
| |
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 144068695
MOS_MIGRATED_REVID=144068695
|
|
|
|
|
|
|
|
|
|
| |
This is part of a sequence of changes to update the test strategies; most of
the actual code changes in this specific change is Google-internal, but I'm
planning to update the external test strategies as well.
--
PiperOrigin-RevId: 144064802
MOS_MIGRATED_REVID=144064802
|
|
|
|
|
|
|
|
| |
package.
--
PiperOrigin-RevId: 144064682
MOS_MIGRATED_REVID=144064682
|
|
|
|
|
|
|
|
|
| |
For now, only for aspects, but eventually expand to Attribute's
mandatory providers as well.
--
PiperOrigin-RevId: 144063369
MOS_MIGRATED_REVID=144063369
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because CreateProcessW doesn't support long paths,
not even with the "\\?\" prefix [1], we need to
convert long paths to short ones to spawn
processes. This change implements the
corresponding function and uses it in
blaze_util_windows.
[1] https://github.com/bazelbuild/bazel/issues/2181#issuecomment-270696173
See https://github.com/bazelbuild/bazel/issues/2107
See https://github.com/bazelbuild/bazel/issues/2181
--
PiperOrigin-RevId: 144062404
MOS_MIGRATED_REVID=144062404
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This method was only used by the Windows-specific
code so move it there and adapt it to Windows
paths.
Update AsWindowsPath to normalize its output: this
is necessary because AsWindowsPath's output is a
widechar path string which we often prefix with
the UNC prefix, but such paths must be normalized
(the kernel won't do it if the path has an UNC
prefix).
Finally, add an AsWindowsPathWithUncPrefix method
which does what the name suggests: converts the
path to Windows path, makes it absolute, and adds
the UNC prefix if necessary. (This is a very common
operation when calling WinAPI functions and we'll
use it a lot in subsequent changes.)
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 144060297
MOS_MIGRATED_REVID=144060297
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. no flag: only the direct reason is given (command execution termination status), and also the instruction to use "--verbose_failures"
2. flag "--verbose_failures": gives failed execution command and the instruction to use "--sandbox_debug --strategy"
3. flag "--verbose_failures --sandbox_debug": gives failed execution command, debugging message from sandboxing, and the instruction to use "--strategy"
Also removes "cd <sandbox_path>" in given failed command, since debugging is only necessary with flag "--verbose_failures --sandbox_debug" and the path is already given in sandboxing debugging message.
Addresses #2174.
Fixes bazel_sandboxing_test.sh and bazel_test_test.sh for the new error message.
--
PiperOrigin-RevId: 144058351
MOS_MIGRATED_REVID=144058351
|
|
|
|
|
|
|
|
| |
No production code should depend on inmemoryfs.
--
PiperOrigin-RevId: 144054981
MOS_MIGRATED_REVID=144054981
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144054816
MOS_MIGRATED_REVID=144054816
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144053696
MOS_MIGRATED_REVID=144053696
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144039394
MOS_MIGRATED_REVID=144039394
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144010091
MOS_MIGRATED_REVID=144010091
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Set status to implementing
2. Reorder the list of tasks because we need to invalidate correctly
Skylark repositories before enabling environ parameter.
3. Fix the step 2 (was step 3) in order to pass a map instead of
creating a new function.
--
Change-Id: I9387ccedf75d63fef7e2e9546dc1f0421cb12679
Reviewed-on: https://cr.bazel.build/7972
PiperOrigin-RevId: 143999391
MOS_MIGRATED_REVID=143999391
|
|
|
|
|
|
|
|
|
|
| |
source jars.
In the j2objc dead code removal script, quote the object file names when invoking ar. They may contain special shell characeters.
--
PiperOrigin-RevId: 143993977
MOS_MIGRATED_REVID=143993977
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143991903
MOS_MIGRATED_REVID=143991903
|
|
|
|
|
|
|
|
| |
* Also make constants private since they both have getters now.
--
PiperOrigin-RevId: 143973536
MOS_MIGRATED_REVID=143973536
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143972504
MOS_MIGRATED_REVID=143972504
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
== Before this change ==
Previously, if a and b are sets, then a + b created a new set c whose direct and transitive elements were all those of a, and with b appended as an additional transitive element. If on the other hand b is a list instead of a set, then its contents were appended as additional direct elements of c. In both cases, you can think of c as a copy of a that also knows about b.
This copying of a's elements into c can lead to accumulation when you do it repeatedly, e.g. x += y in a loop. Each union can take O(n) time so you get O(n^2) time overall. Nested set union is supposed to be O(1) time per operation and O(n) time overall.
It also leads to surprising iteration orders. If you do a + b + c + d (left-associative), where each one is a set, then when you do a post-order traversal you get the elements of b, c, d, and a, in that order. This is because b, c, and d each get appended as transitive children of the copies of a.
== After this change ==
If a and b are sets, then a + b returns a new set c with a and b as its two transitive children. If b is a list, then c has a as its only transitive child and b's elements as its only direct elements. This is straightforward, O(1), and avoids the problem with the confusing order.
It is implemented by removing the items/transitiveItems fields and just relying on NestedSetBuilder.
RELNOTES[INC]: (Skylark) Set union is now O(1). As a side-effect, the iteration order of sets produced by union has changed. "print(set([1]) + set([2]) + set([3]))" will now give back the order 1, 2, 3 instead of 2, 3, 1.
--
PiperOrigin-RevId: 143972165
MOS_MIGRATED_REVID=143972165
|
|
|
|
|
|
|
|
|
|
|
| |
We may not assume that those are pulled in by other
header files; in fact, they are not on FreeBSD stable/11.
--
Change-Id: Ic976cc71968aab0a1c3d6652fe8d8f1c4afa480b
Reviewed-on: https://cr.bazel.build/8145
PiperOrigin-RevId: 143970238
MOS_MIGRATED_REVID=143970238
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes #2311
Closes #2312.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/2312
PiperOrigin-RevId: 143967880
MOS_MIGRATED_REVID=143967880
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test was still using the old path syntax that is deprecated,
use the label syntax instead.
Note that there is still several instance of that old syntax
in our tests:
```
grep -E -r 'load\(['"'"'"]/[^/]' src/test | wc -l
109
```
--
Change-Id: Id2d1a9a525f1584136501026de01cf53e2263c3f
Reviewed-on: https://cr.bazel.build/8135
PiperOrigin-RevId: 143967775
MOS_MIGRATED_REVID=143967775
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143966520
MOS_MIGRATED_REVID=143966520
|