aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Introduce language to clearly warn against usage of $(CC) and $(JAVA).Gravatar Ulf Adams2016-09-23
| | | | | -- MOS_MIGRATED_REVID=134062471
* Split the workspace status keys into stable and volatile parts based on if ↵Gravatar Lukacs Berki2016-09-23
| | | | | | | | | they are prefixed with STABLE_. Fixes #1758 . -- MOS_MIGRATED_REVID=134058125
* Add a SandboxedSpawnActionContext interface and implementations for our ↵Gravatar Philipp Wollermann2016-09-23
| | | | | | | sandboxed execution strategies. -- MOS_MIGRATED_REVID=134054610
* Open sourcing ↵Gravatar Irina Iancu2016-09-23
| | | | | | | junitrunner/java/com/google/testing/junit/runner/sharding/weighted. -- MOS_MIGRATED_REVID=134046554
* Clean up ijar tests that use Java 8 featuresGravatar Liam Miller-Cushon2016-09-23
| | | | | -- MOS_MIGRATED_REVID=134040102
* Change the filegroup for the android sdk to an alias to unbreak android in ↵Gravatar Alex Humesky2016-09-23
| | | | | | | bazel after commit 1092e9d68773adb7444cc85a47af650aeeaf65fc -- MOS_MIGRATED_REVID=134036851
* Expose AppleBitcodeMode to SkylarkGravatar Dmitry Shevchenko2016-09-23
| | | | | -- MOS_MIGRATED_REVID=134011406
* Fixed symbolic link and hard link path not stripped when "strip_prefix" is set.Gravatar Xin Gao2016-09-23
| | | | | -- MOS_MIGRATED_REVID=134005484
* Removes the output_cpp attribute from the objc_proto_library rule.Gravatar Sergio Campama2016-09-23
| | | | | -- MOS_MIGRATED_REVID=133989926
* Adds exports attribute to aar_import allowing aar_import and java_import.Gravatar Adam Michael2016-09-23
| | | | | | | Manually propagates class jars in AarImport. Resource propagation is handled by magic in AndroidCommon. -- MOS_MIGRATED_REVID=133988946
* Rollback of commit 5c548f11e20c0b75203e9fe4ab682ed0418064cf.Gravatar Carmi Grushko2016-09-23
| | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Fixed depot issues. *** Original change description *** Automated [] rollback of commit 2e5ec0fd99ac4bfd930da99f6089dc5faf778464. *** Reason for rollback *** Breaks some targets in the nightly: see [] *** Original change description *** Make java_proto_library's strict_deps default to true. Remove package-level attribute to set the default of strict_deps. Change the semantics to --strict_deps_java_protos to mean force strict deps of all Java protos to be true regardless of their strict_deps attribute. -- MOS_MIGRATED_REVID=133981754
* BuildConfiguration: Remove outdated references to getShortName.Gravatar Greg Estren2016-09-23
| | | | | -- MOS_MIGRATED_REVID=133971955
* Implementation of maven_jar rule in Skylark.Gravatar Jingwen Chen2016-09-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | **Experimental** This is an initial implementation of the maven_jar rule in Skylark, targeted at the FRs in issue #1410. Implemented a wrapper around the maven binary to pull dependencies from remote repositories into a directory under {output_base}/external. Attributes `name`, `artifact`, `repository`, `sha1` have been implemented, but not `server`. Caveat: this rule assumes that the Maven dependency is installed in the system. Hence, the maven_skylark_test integration tests are tagged with "manual" and commented out because the Bazel CI isn't configured with the Maven binary yet. Added a serve_not_found helper for 404 response tests. Usage: ``` load("@bazel_tools//tools/build_defs/repo:maven_rules.bzl", "maven_jar") maven_jar( name = "com_google_guava_guava", artifact = "com.google.guava:guava:18.0", sha1 = "cce0823396aa693798f8882e64213b1772032b09", repository = "http://uk.maven.org/maven2", ) ``` With regards to server, there are some limitations with retrieving a maven_server's attribute at Loading Phase without the use of hacky macros (issue #1704), and even if macros are used, the maven_server is not treated as an actual dependency by maven_jar. There is a test (`test_unimplemented_server_attr`) to ensure that the error message to shown to users if they use the server attribute with this rule. -- Change-Id: I167f9d13835c30be971928b4cc60167a8e396893 Reviewed-on: https://bazel-review.googlesource.com/c/5770 MOS_MIGRATED_REVID=133971809
* Rollback of commit 4e2f75d8e60020f13a7df452488ec4cc7a719f03.Gravatar Kristina Chodorow2016-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** This is causing external_integration_test to fail See, for example, http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/236/console: ** test_http_archive_tar_xz **************************************************** GET /fox.tar.xz HTTP/1.1 User-Agent: Java/1.8.0_101 Host: localhost:36541 Accept: text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2 Connection: keep-alive cat: bazel-out/../external/endangered/fox/male_absolute: No such file or directory -- Test log: ----------------------------------------------------------- INFO: Reading 'startup' options from /home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/_tmp/external_integration_test_2/bazelrc: --output_user_root=/home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/_tmp/external_integration_test_2/root --host_javabase=/home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/bazel-out/local-fastbuild/bin/src/test/shell/bazel/external_integration_test.runfiles/local_jdk INFO: $TEST_TMPDIR defined: output root default is '/home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/_tmp/external_integration_test_2'. .............................................. ____Loading package: zoo ____Loading... ____Loading package: @bazel_tools//tools/cpp ____Loading package: @bazel_tools//tools/jdk ____Loading package: @local_config_xcode// ____Loading package: @local_jdk// ____Loading package: @local_config_cc// ____Loading complete. Analyzing... ____Downloading from [] 0B ____Downloading from [] 1KB ____Loading package: @endangered//fox ____Found 1 target... ____Building... ____[0 / 1] BazelWorkspaceStatusAction stable-status.txt ____[0 / 4] Creating source manifest for //zoo:breeding-program ____[0 / 4] Symlinking //zoo:breeding-program ____[3 / 4] Creating runfiles tree bazel-out/local-fastbuild/bin/zoo/breeding-program.runfiles ____Building complete. Target //zoo:breeding-program up-to-date: bazel-bin/zoo/breeding-program ____Elapsed time: 6.903s, Critical Path: 0.04s ____Running command line: bazel-bin/zoo/breeding-program Fraka-kaka-kaka-kaka-kow ------------------------------------------------------------------------ test_http_archive_tar_xz FAILED: Expected regexp #!/bin/bash echo Fraka-kaka-kaka-kaka-kow not found in bazel-out/../external/endangered/fox/male_absolute . /home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/bazel-out/local-fastbuild/bin/src/test/shell/bazel/external_integration_test.runfiles/io_bazel/src/test/shell/bazel/external_integration_test:154: in call to assert_files_same /home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/bazel-out/local-fastbuild/bin/src/test/shell/bazel/external_integration_test.runfiles/io_bazel/src/test/shell/bazel/external_integration_test:150: in call to http_archive_helper /home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/bazel-out/local-fastbuild/bin/src/test/shell/bazel/external_integration_test.runfiles/io_bazel/src/test/shell/bazel/external_integration_test:190: in call to test_http_archive_tar_xz FAILED: test_http_archive_tar_xz *** Original change description *** Fixed symbolic link and hard link path not stripped when "strip_prefix" is set. -- MOS_MIGRATED_REVID=133970692
* Fix Windows JDK7 testsGravatar Kristina Chodorow2016-09-22
| | | | | | | | | | | | | | They're accessing non-final variables in inner classes, e.g.,: src\test\java\com\google\devtools\build\lib\packages\BuildTypeTest.java:425: error: local variable result is accessed from within inner class; needs to be declared final result.add(label); (From http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/JAVA_VERSION=1.7,PLATFORM_NAME=windows-x86_64/845/consoleFull). Not sure how this is working on Linux/OS X JDK7. -- MOS_MIGRATED_REVID=133967835
* Cleanup swift_library after Blaze release.Gravatar Dmitry Shevchenko2016-09-22
| | | | | | | * Removes iOS specific platform/cpu calls in favor of platform-agnostic counterparts. -- MOS_MIGRATED_REVID=133966024
* Update concepts.md to warn users of upcoming changes to SkylarkGravatar Jon Brandvein2016-09-22
| | | | | -- MOS_MIGRATED_REVID=133959741
* Enable split transitions for tvOS.Gravatar Googler2016-09-22
| | | | | -- MOS_MIGRATED_REVID=133954052
* Push missing testdata directory to Github.Gravatar Xin Gao2016-09-22
| | | | | -- MOS_MIGRATED_REVID=133949075
* Implement input pruning using .d files in objc.Gravatar Cal Peyser2016-09-22
| | | | | -- MOS_MIGRATED_REVID=133944059
* Rollback of commit 2e5ec0fd99ac4bfd930da99f6089dc5faf778464.Gravatar Tobias Werth2016-09-22
| | | | | | | | | | | | | | | *** Reason for rollback *** Breaks some targets in the nightly: see [] *** Original change description *** Make java_proto_library's strict_deps default to true. Remove package-level attribute to set the default of strict_deps. Change the semantics to --strict_deps_java_protos to mean force strict deps of all Java protos to be true regardless of their strict_deps attribute. -- MOS_MIGRATED_REVID=133938648
* Bazel to support external links integration. This is so that the tests can ↵Gravatar Googler2016-09-22
| | | | | | | inject custom extra data (link, icons, etc) so that a test method can be associated with an external tool. -- MOS_MIGRATED_REVID=133912980
* Drop bridge methods in turbineGravatar Liam Miller-Cushon2016-09-22
| | | | | -- MOS_MIGRATED_REVID=133899664
* Use -source 8 -target 8 in turbine integration testsGravatar Liam Miller-Cushon2016-09-22
| | | | | -- MOS_MIGRATED_REVID=133894022
* Make aar_import use the java package from the manifest for all aapt resource ↵Gravatar Adam Michael2016-09-22
| | | | | | | | | rules. The AndroidResourcesProcessorBuilder, AndroidResourceValidatorActionBuilder and AndroidResourceMergingActionBuilder that use the java package specified by the AndroidResourceProvider check if it is not null or empty before using it and default to using the package from the manifest. This CL just allows us to pass null java package from AndroidSdkProvider and does so with aar_import. -- MOS_MIGRATED_REVID=133883286
* Move zlib-interfacing code from third_party/ijar/zip.cc into a separate ↵Gravatar Rumou Duan2016-09-22
| | | | | | | class. And add a dummy zlib client. -- MOS_MIGRATED_REVID=133879880
* Adds apksigner attribute to android_sdk. This supports the new APK v2 ↵Gravatar Adam Michael2016-09-22
| | | | | | | | | signing scheme added behind a flag in commit 602f3ae70f49bd8bae6205a93f3df5918d3bacac. RELNOTES: -- MOS_MIGRATED_REVID=133877396
* Split dynamic configurations mode into:Gravatar Greg Estren2016-09-22
| | | | | | | | | | | | | | | --experimental_dynamic_configs=off - don't use dynamic configs --experimental_dynamic_configs=on - use dynamic configs with trimmed fragments --experimental_dynamic_configs=notrim - use dynamic configs with all fragments This lets us decouple two independent dimensions of dynamic configurations: 1) being able to trigger new configurations and transitions anywhere and 2) only including the fragments needed by a target's transitive closure. 2) is likely to take much more time and effort to properly finesse (three notable challenges: late-bound attributes, aspects, and dynamic shedding of output path names). But 1) by itself already yields significant benefits. So in the name of starting to shift the config work from backend theory to stuff real builds actually use, this change lets us focus on productionizing 1) without blocking on getting all of 2) working first. tl;dr: iterable deployment and all that. -- MOS_MIGRATED_REVID=133874661
* Some updates to C++ to support Clif, an automatic interface generator for ↵Gravatar Googler2016-09-22
| | | | | | | C++/Python. -- MOS_MIGRATED_REVID=133863929
* Moves multidex attribute up the rule inheritance hierarchy.Gravatar Alex Humesky2016-09-22
| | | | | -- MOS_MIGRATED_REVID=133852628
* Use WriteBytes instead of AppendFile to write entries.Gravatar Sasha Smundak2016-09-22
| | | | | | | | | This improves wallclock times for building deploy jars by ~5%. Also, calculate the length of the Data Descriptor Record more accurately. -- MOS_MIGRATED_REVID=133849413
* Add test for //tools/zip/zip_manifest_creatorGravatar Adam Michael2016-09-22
| | | | | -- MOS_MIGRATED_REVID=133847278
* Use ForkJoinPool, rather than ListeningExecutorService, for parallel query ↵Gravatar Nathan Harmata2016-09-22
| | | | | | | evaluation in SkyQueryEnvironment. FJP is nicer to program against, imo. -- MOS_MIGRATED_REVID=133844508
* Update instructions on how to build protoc-mingw.exe.Gravatar Dmitry Lomov2016-09-22
| | | | | -- MOS_MIGRATED_REVID=133842785
* Be honest about type in Type#visitLabelsGravatar Michajlo Matijkiw2016-09-22
| | | | | | | | | | We avoided referencing Label directly, but as the code evolved it became inevitable. Also fix a typo I introduced earlier. -- MOS_MIGRATED_REVID=133831955
* Disables sandbox for one more action.Gravatar Yue Gan2016-09-22
| | | | | -- MOS_MIGRATED_REVID=133831200
* Remove the --show_cached_analysis_results command line option, which was a ↵Gravatar Lukacs Berki2016-09-22
| | | | | | | no-op. -- MOS_MIGRATED_REVID=133830375
* Replace BuildConfiguration.Fragment#collectExecutables() with a ↵Gravatar Lukacs Berki2016-09-22
| | | | | | | | | #getShellExecutable() method. That's all it was used for anyway. -- MOS_MIGRATED_REVID=133824769
* Allow passing None to SkylarkCallables with 'noneable = true'Gravatar Googler2016-09-22
| | | | | | | | | | Currently, you will get an error for nearly all types since None is not contained in any type but NoneType and Object. Instead, use the same approach as SkylarkSignatureProcessor does currently. -- MOS_MIGRATED_REVID=133821662
* Added 3.0.0 protocGravatar Dmitry Lomov2016-09-21
| | | | Change-Id: Ia0d5aebdf5d24da8aadecc51fd8ffdefa063d993
* Remove a comment that says we can remove some obsolete code.Gravatar Lukacs Berki2016-09-21
| | | | | | | | | Spurred by Thiago's change in the area, I figured I'll try removing the PID symlink, but then I realized that this won't work, because the code currently gives precedence to the symlink, which means that if a server that writes both is replaced with a server that only writes the text file, the contents of the text file will not be read. Also note that in Bazel, long jumps between server versions are much more possible than internally, so the cleanup is just not worth the risk, which is sad. -- MOS_MIGRATED_REVID=133820484
* Use nanosleep(2) instead of poll(2) to sleep.Gravatar Chongyu Zhu2016-09-21
| | | | | | | | | | | | | Starting with macOS Sierra developer beta 4, the behavior of poll(2) was changed, such that poll(2) will return immediately regardless the timeout if there is no file descriptor. This fixes #1767. And, this should be a better solution for Homebrew/homebrew-core#5041. Closes #1803. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/1803 MOS_MIGRATED_REVID=133816294
* Remove redirect chasing from java_toolchain and --android_sdk rules.Gravatar Lukacs Berki2016-09-21
| | | | | | | | | They are all aliases everywhere, so this is not needed. Sadly, we can't remove it from --crosstool_top and --javabase and from AppleConfiguration because then the actual rules are dissected during configuration creation and not just used as an implicit dependency. -- MOS_MIGRATED_REVID=133812052
* Disables sandbox for more actions.Gravatar Yue Gan2016-09-21
| | | | | -- MOS_MIGRATED_REVID=133811000
* cpp: convert ServerPidFile() and ServerPidSymlink() into constantsGravatar Thiago Farina2016-09-21
| | | | | | | | | | | These two functions have no logic inside it, they just return a string, and a string that does not change, so they might be better expressed as real C/C++ constants. This might as well generate some better (and less) code anyway. -- Change-Id: I78673c537c17c2665a74c5778e45a4d41a5f7b50 Reviewed-on: https://bazel-review.googlesource.com/#/c/6114 MOS_MIGRATED_REVID=133805201
* Mark unresolved classes in jdeps as Kind.INCOMPLETE.Gravatar Googler2016-09-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, all classes from the symbol table are added to jdeps, even if some of them haven't been resolved and as such aren't actually used. This causes siblings from other jars (such as R.java) to be added to jdeps, even though they are not actually referenced. Mark these with Kind.UNRESOLVED to allow code to discard these. All non-test code that references Kind.IMPLICIT has been modified to also check for Kind.INCOMPLETE to keep the current behavior unchanged. Eg: jar liba.jar: package a; class A { void test() { // Use R.id } } jar liba_resources.jar: package a; class R { } package b; import a; class MyClass { A a = new A(); } ---> jdeps will contain both liba.jar, liba_resources.jar the latter will now have Kind.INCOMPLETE. -- MOS_MIGRATED_REVID=133791687
* Make java_proto_library's strict_deps default to true.Gravatar Carmi Grushko2016-09-21
| | | | | | | | Remove package-level attribute to set the default of strict_deps. Change the semantics to --strict_deps_java_protos to mean force strict deps of all Java protos to be true regardless of their strict_deps attribute. -- MOS_MIGRATED_REVID=133789725
* Remove absolute paths from protoGravatar Googler2016-09-21
| | | | | | | RELNOTES: Remove deprecated absolute paths in blaze IDE artifacts -- MOS_MIGRATED_REVID=133758389
* Drop class initializers in turbineGravatar Liam Miller-Cushon2016-09-21
| | | | | -- MOS_MIGRATED_REVID=133756960
* Implement label visitation using visitorGravatar Michajlo Matijkiw2016-09-21
| | | | | | | | | As opposed to building up a collection. These collections, and all their iterators, add up creating a lot of garbage. This saves us at least an ImmutableList + Iterator per label. -- MOS_MIGRATED_REVID=133754998