aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* experimental_ui: show number of packages loaded during analysisGravatar Klaus Aehlig2016-05-19
| | | | | | | | | | | After the initial loading phase, further packages are loaded during analysis. Show in the experimental UI the total number of packages loaded during analysis phase to indicate at least some progress. -- Change-Id: I345c6f806591e70e4397fc3e3365718dde95d7d2 Reviewed-on: https://bazel-review.googlesource.com/#/c/3645 MOS_MIGRATED_REVID=122728719
* Allow imports of dylib frameworks.Gravatar Peter Schmitt2016-05-19
| | | | | | | RELNOTES: objc_framework now supports dynamic frameworks. -- MOS_MIGRATED_REVID=122728042
* Remove the unused field CppConfiguration.execRoot.Gravatar Lukacs Berki2016-05-19
| | | | | -- MOS_MIGRATED_REVID=122727524
* Make "blaze run" work with aliases.Gravatar Lukacs Berki2016-05-19
| | | | | | | Fixes #1290. -- MOS_MIGRATED_REVID=122726071
* Move the command line arguments for C++ preprocessor defines to a feature.Gravatar Lukacs Berki2016-05-19
| | | | | | | | | | | This required a few assorted changes: - The LIPO compilation context is not merged anymore. Include paths for auxiliary files are apparently taken from the profile files, so it is not necessary. - The FDO build stamp is not special-cased anymore, it is treated as a preprocessor define like any other. - When compiling a .pcm file, use interfaceContext instead of the regular context when setting up the build variables. This is a bit more consistent and would be a good cause for a future bug. -- MOS_MIGRATED_REVID=122725179
* LoadingPhaseStartedEvent: also provide the counter of packages loadedGravatar Klaus Aehlig2016-05-19
| | | | | | | | | | | Even during analysis, more packages will be loaded. However, those are not tracked by the LoadingProgressReceiver. Therefore, provide a reference to the AtomicInteger counting the total number of packages loaded already. -- Change-Id: Ia546a2fec4afe6fd1bd69448b14ba889c68ae12c Reviewed-on: https://bazel-review.googlesource.com/#/c/3644 MOS_MIGRATED_REVID=122722688
* Remove the "licenses" and "distribs" attribute from the alias rule.Gravatar Lukacs Berki2016-05-19
| | | | | -- MOS_MIGRATED_REVID=122721164
* Simplify DependencySet.Gravatar Ulf Adams2016-05-19
| | | | | | | | | | - mark the addDependencies method as @VisibleForTesting, and don't round-trip through PathFragment - use Path.getRelative(String) instead of Path.getRelative(PathFragment), which may do additional optimizations -- MOS_MIGRATED_REVID=122720947
* Add an overview comment about how the analysis phase works and some pointers ↵Gravatar Lukacs Berki2016-05-19
| | | | | | | to it. -- MOS_MIGRATED_REVID=122718503
* * Adds handling for anydpi and watch, two unsupported qualifiers in ↵Gravatar Googler2016-05-19
| | | | | | | | | | FolderConfiguration. * Handles resources nested in directories. * Makes the resource processing resilient to invalid qualifiers. -- MOS_MIGRATED_REVID=122688529
* Write a -gensrc.jar even if the compilation failedGravatar Liam Miller-Cushon2016-05-19
| | | | | | | The generated sources are useful for debugging annotation processors. -- MOS_MIGRATED_REVID=122683781
* Use BufferedOutputStream for zipping / jar.Gravatar Googler2016-05-19
| | | | | | | | | | | | | | | | | | | | | | | | | This is for the resources.zip and the srcjar and aar. For the srcjar this is only slightly faster (100ms), but we might as well? Perhaps this is because the files are quite large anyway. Not sure if there would be smaller writes with compression. For the resources.zip it seems to make a bigger difference: > 1s when run locally. Perhaps this is because there are more small files. Didn't benchmark aar at all, just noticed it. Kevin mentioned the Buffering on one of the issues, so I happened to notice this when using similar code for prototype of R.class jar creation (seemed to be > 1s faster in that case, but that was also compressing). -- MOS_MIGRATED_REVID=122663374
* For tests that check against output paths, provide the ability to strip out ↵Gravatar Greg Estren2016-05-19
| | | | | | | | | | | | | | | | | the C++-contributed fragment. e.g. provide the ability to translate: bazel-out/gcc-X-glibc-Y-x86-fastbuild/ to: bazel-out/fastbuild/ This applies to artifacts built with dynamic configurations for targets with no C++ fragments in their configuration. -- MOS_MIGRATED_REVID=122643518
* Fix #837: worker_verbose flag has no effect.Gravatar Philipp Wollermann2016-05-19
| | | | | | | Due to reusing an old Reporter instead of grabbing the current one for each build, verbose messages were lost and not printed to the console. Also adds a test for this feature. -- MOS_MIGRATED_REVID=122639383
* Always restrict aspects to only access requested configuration fragments.Gravatar Michael Staib2016-05-19
| | | | | | | | | | | This completes the introduction of aspect configuration fragment enforcement for static configuration builds; as of this change, it is no longer possible to fall back to the base rule's set of requested configuration fragments. This sort of fallback may become possible later, likely in a more controlled way. -- MOS_MIGRATED_REVID=122638152
* Remove testing-only constructor for RuleClass from non-testing code.Gravatar Janak Ramakrishnan2016-05-19
| | | | | -- MOS_MIGRATED_REVID=122635220
* LoadingProgressReceiver: provide pending packagesGravatar Klaus Aehlig2016-05-19
| | | | | | | | | | When reporting on the progress state while loading packages, also report the number of packages currently being loaded simultaneously. -- Change-Id: I5e46c6f392e1e583b752560878f4c42c160f12d2 Reviewed-on: https://bazel-review.googlesource.com/#/c/3643 MOS_MIGRATED_REVID=122632188
* Fix Windows issue in Path.getRelative, which wasn't handling backslashes.Gravatar Ulf Adams2016-05-19
| | | | | -- MOS_MIGRATED_REVID=122627792
* Precompute Label#hashCode and use it to implement a fast-path for #equals. ↵Gravatar Nathan Harmata2016-05-19
| | | | | | | | | Label#equals was a cpu hotspot revealed during profiling. The additional field for the precomputed hash code has no memory cost since each Label instance was already wasting 4 bytes due to object alignment requirements. -- MOS_MIGRATED_REVID=122626707
* Rollback of commit e37c55eccbd4516b2db7aaf58ef95209dfad3ed4.Gravatar Ulf Adams2016-05-19
| | | | | -- MOS_MIGRATED_REVID=122626656
* Turn the addition of -fPIC to the command line of PIC actions into a feature.Gravatar Lukacs Berki2016-05-19
| | | | | | | This is a resubmission of commit 45d48bf1fe7503acbbb0c095822b7f8f558881e8. It turns out that we also need -fPIC for *assembler* command line options, because some assembler sources are preprocessed and they can say "#ifdef __PIC__". -- MOS_MIGRATED_REVID=122626234
* Rollback of commit b8946eabd60a199a66a1892701d52d9801c7fb1a.Gravatar Ulf Adams2016-05-18
| | | | | -- MOS_MIGRATED_REVID=122620007
* Handle b+.{2}+{3,4} qualifiers, as well as mobile country code and mobile ↵Gravatar Googler2016-05-18
| | | | | | | network code qualifiers. -- MOS_MIGRATED_REVID=122591469
* Fix bug in lazy removal of reverse deps -- there was one remaining case ↵Gravatar Janak Ramakrishnan2016-05-18
| | | | | | | where we weren't checking to see if a reverse dep already existed when we declared a reverse dep. -- MOS_MIGRATED_REVID=122581019
* Add || true to increment so test doesn't exit earlyGravatar Kristina Chodorow2016-05-17
| | | | | | | | | The test is run with -e, so when ((wait_seconds++)) returns 1, it exits. This fixes #1271. -- MOS_MIGRATED_REVID=122567259
* Add a way to set USES_SWIFT flag from Skylark.Gravatar Dmitry Shevchenko2016-05-17
| | | | | | | RELNOTES: new_objc_provider can now set the USES_SWIFT flag. -- MOS_MIGRATED_REVID=122566589
* Remove reverse deps lazily, only when the node has finished building and we ↵Gravatar Janak Ramakrishnan2016-05-17
| | | | | | | | | | | discover that it no longer has certain deps. In the common case, where a node's deps do not change in the end, this reduces lock contention and CPU. The downside of this is that we now create a set of the previous reverse deps during each evaluation of a node. We don't store this set in order to conserve memory, so we pay for it in CPU. We will probably only construct it two or three times (most SkyFunctions don't have so many groups), so the cost shouldn't be so high, but we can try to mitigate if it shows up in profiling. -- MOS_MIGRATED_REVID=122566267
* Thread through a map of the attributes which we have serialized into ↵Gravatar Shreya Bhattarai2016-05-17
| | | | | | | postProcess(). -- MOS_MIGRATED_REVID=122542545
* Remove extraneous space added by commit 5e34a3d4ea30525971e320ce283ba8cd67c74e3cGravatar Nathan Harmata2016-05-17
| | | | | -- MOS_MIGRATED_REVID=122542339
* Batch package retrieval for rbuildfiles so that even if a single file has a ↵Gravatar Janak Ramakrishnan2016-05-17
| | | | | | | large number of rbuildfile dependencies, we retrieve them in batches of at most BATCH_CALLBACK_SIZE. -- MOS_MIGRATED_REVID=122540401
* Remove unnecessary aspect CC bloat.Gravatar Googler2016-05-17
| | | | | | | | | | | * Do not include cc info for non-C rules * Omit exported headers (unused on the IDE side) This CL reduces aspect output size (and memory footprint) by ~50MB for an example real-life project. -- MOS_MIGRATED_REVID=122537339
* Switch the qualifier parsing to use FolderConfiguration. There is some extra ↵Gravatar Googler2016-05-17
| | | | | | | processing due to the missing support for ll-{3,4}, which should be removed with the android-ide-common update. -- MOS_MIGRATED_REVID=122536342
* Cleanup swift.bzl.Gravatar Dmitry Shevchenko2016-05-17
| | | | | | | | | Removes an old code path that is not relevant anymore. RELNOTES: -- MOS_MIGRATED_REVID=122534499
* Fix compilation with JDK7Gravatar Alpha Lam2016-05-17
| | | | | | | | | Add a final keyword to make java compiler happy. -- Change-Id: If44881164d4e3e2485d0e7dc8074ca7171a6ceb6 Reviewed-on: https://bazel-review.googlesource.com/c/3630/ MOS_MIGRATED_REVID=122529756
* Support top-level packages in pkg_tarGravatar Kristina Chodorow2016-05-17
| | | | | | | | | | | | | Previously, _short_path_dirname would take a short path like "libfoo.jar", rfind would return -1, sp[:-1] would return "libfoo.ja", and then _dest_path would strip that prefix off of "libfoo.jar", leaving just "r". Also added some unit tests for these functions. Fixes #1253. -- MOS_MIGRATED_REVID=122527723
* Rollback of commit 45d48bf1fe7503acbbb0c095822b7f8f558881e8.Gravatar Lukacs Berki2016-05-17
| | | | | | | | | | | | | *** Reason for rollback *** Breaks //[]/go:all . *** Original change description *** Turn the addition of -fPIC to the command line of PIC actions into a feature. -- MOS_MIGRATED_REVID=122526799
* Add Skylark tests for intellij_info.bzlGravatar Dmitry Lomov2016-05-17
| | | | | | | This add a "testing framework" and reimplements first two tests from AndroidStudioInfoAspectTest. -- MOS_MIGRATED_REVID=122523803
* Improve progress message of the actions triggered by --precompile_python.Gravatar Googler2016-05-17
| | | | | | | | Typical output looks like: Compiling Python my/package/module.py -- MOS_MIGRATED_REVID=122522202
* Make the rule in the workspace package reference the correct Package object.Gravatar Lukacs Berki2016-05-17
| | | | | | | Fixes #1228. -- MOS_MIGRATED_REVID=122511655
* Add rule_or_page#heading syntax to RuleLinkExpander and support for expandingGravatar David Chen2016-05-17
| | | | | | | | | | rule_name_implicit_outputs. This change adds support for new syntax for referencing a heading for a rule or static BE page. -- MOS_MIGRATED_REVID=122509323
* Add -headerpad_max_install_names to darwin CROSSTOOL linker flags.Gravatar David Chen2016-05-17
| | | | | | | Fixes #1269 -- MOS_MIGRATED_REVID=122502116
* Turn the addition of -fPIC to the command line of PIC actions into a feature.Gravatar Lukacs Berki2016-05-17
| | | | | -- MOS_MIGRATED_REVID=122498464
* Add attribute to android binaries to explicitly control incremental dexing.Gravatar Googler2016-05-17
| | | | | -- MOS_MIGRATED_REVID=122473346
* Fix for combining resources so that the transitive, direct, and primary ↵Gravatar Googler2016-05-17
| | | | | | | | | | | | | | | | resources are combined for the primary writing. Example: transitive resource: styleable/RubADubDub has an attr of butcher direct resource: styleable/RubADubDub has an attr of baker primary resource: styleable/RubADubDub has an attr of candlestickmaker The merged resources should have: transitive resource: <no matching key> primary resource: styleable/RubADubDub has attrs of butcher, baker, candlestickmaker -- MOS_MIGRATED_REVID=122453026
* Export Objective-C header from swift_library.Gravatar Dmitry Shevchenko2016-05-17
| | | | | | | | | * Switches the rule to output to genfiles/, this makes C-headers it produces importable by depending targets. RELNOTES: swift_library now generates an Objective-C header for its @objc interfaces. -- MOS_MIGRATED_REVID=122448949
* Fix maven_jar documentation to use to the correct repository nameGravatar Kristina Chodorow2016-05-17
| | | | | | | Fixes #1230. -- MOS_MIGRATED_REVID=122439376
* Make AarGeneratorAction deterministic by zeroing zip entry timestamps.Gravatar Nicholas Lativy2016-05-17
| | | | | | | | ZipOutputStream#putNextEntry(ZipEntry) sets the modification time to the current time if no time is set on the ZipEntry passed to it. -- MOS_MIGRATED_REVID=122436300
* Add deprecation warning for --objc_generate_debug_symbols.Gravatar Dmitry Shevchenko2016-05-17
| | | | | | | RELNOTES: --objc_generate_debug_symbols is now deprecated. -- MOS_MIGRATED_REVID=122432600
* Adds information about resources referenced from AndroidManifest.xml toGravatar Alex Humesky2016-05-17
| | | | | | | the apk manifest. -- MOS_MIGRATED_REVID=122431761
* Always unzip paths ending in / as directoriesGravatar Kristina Chodorow2016-05-17
| | | | | | | | | | | | | Does file type mean nothing to people? Fixes #1263, also made some code hygiene improvements: * Added some tests. * Broke a java_test out of lib/BUILD. * Renamed ZipFunction so it doesn't look like a child of SkyFunction. -- MOS_MIGRATED_REVID=122431322