aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Clean up whitespace in add_dep messagesGravatar cushon2018-03-15
| | | | PiperOrigin-RevId: 189225279
* Allow optimization related features to be ignored when unsupported as ↵Gravatar Googler2018-03-15
| | | | | | opposed to reporting errors PiperOrigin-RevId: 189201637
* Add cquery to Blaze manual's list of commandsGravatar juliexxia2018-03-15
| | | | PiperOrigin-RevId: 189201051
* Suppress ThinLTO indexing for linkstatic library in testsGravatar Googler2018-03-15
| | | | | | | | | | This extends the scalability fix in https://github.com/bazelbuild/bazel/commit/8c5e290dfab3cab378a9ca107ecdd6267403cd4b to apply to statically linked libraries linked into dynamically linked tests. Otherwise we are still getting the O(N*M) LTO backend job behavior for those libraries when invoking ThinLTO on many targets. RELNOTES: None PiperOrigin-RevId: 189200150
* Adds 'timeout' to the table describing test size and a table for the timeoutGravatar ahumesky2018-03-15
| | | | | | | names to time. RELNOTES: None. PiperOrigin-RevId: 189198230
* Optimize GC churn due to PackageFunction#getContainingDirectory. While I'm ↵Gravatar nharmata2018-03-15
| | | | | | | | | here, also slightly restructure the code in #handleLabelsCrossingSubpackagesAndPropagateInconsistentFilesystemExceptions to make it more readable (and defer PackageIdentifier allocations). Alternatives considered: Add a PathFragment#getParentDirectoryOfRelative(String other) instance method, and use it in PackageFunction#getContainingDirectory. I thought the approach in this CL would be preferable to adding a specialized method like that to PathFragment. RELNOTES: None PiperOrigin-RevId: 189197855
* Modify CTQEnvironment and associated files to handle AliasConfiguredTargets. ↵Gravatar juliexxia2018-03-15
| | | | | | Always handle AliasConfiguredTargets as separate nodes from their "actual" value. This is helpful in understanding certain query results e.g. somepath. PiperOrigin-RevId: 189196863
* Add documentation about cquery to bazel!Gravatar juliexxia2018-03-15
| | | | PiperOrigin-RevId: 189196060
* Conditionally set the default crosstool based on the major revision by ↵Gravatar jingwen2018-03-15
| | | | | | | | | | | binding //external:android/crosstool to an alias in the NDK BUILD file. This does not change existing behavior until r17 support is released. https://github.com/bazelbuild/bazel/issues/4742 RELNOTES: None. PiperOrigin-RevId: 189195669
* Include object exec path in LTO Backend progress messageGravatar Googler2018-03-15
| | | | | | | | | | With only the filename the LTO Backend objects are hard to distinguish (i.e. many files will share the same base filename, but have different paths. Additionally, this change causes the target specific ".lto" or "shared.nonlto" subdirectory to be included, which is useful for analysis. RELNOTES: None PiperOrigin-RevId: 189194070
* Android tools: remove mtime-modificationsGravatar Laszlo Csomor2018-03-15
| | | | | | | | | | | | | | | | | | | | | | | | The Android tools no longer modify output file mtimes in hopes of achievening better action cache hits. Modifying the mtimes was confusing Bazel and causing correctness bugs. Modifying the mtimes is unnecessary because Bazel is smart about picking up filesystem changes and observes more signals than just the mtime, though as the corresponding bug shows it's sadly not bullet-proof. Fixes https://github.com/bazelbuild/bazel/issues/4734 Change-Id: I4aa8abf29486841ba8133f927e2816d7f85881fe Closes #4848. Change-Id: I0615fae1f20d786771d742705ab4a6ddf7f2306e PiperOrigin-RevId: 189183742
* Ensure that only ObjC tests initialize the MockObjcSupport.Gravatar jcater2018-03-15
| | | | PiperOrigin-RevId: 189181919
* Simplify ClientEnvironmentValue invalidation.Gravatar Benjamin Peterson2018-03-15
| | | | | | | Unconditionally inject the new values, and let skyframe change pruning avoid over-invalidation. Change-Id: I3f478ea756121bde1078e9e79ddcfbeb54951cbb PiperOrigin-RevId: 189156698
* Emit SJD errors even if we don't know the label of a dependencyGravatar cushon2018-03-14
| | | | | | Fixes bazelbuild/bazel#4846 PiperOrigin-RevId: 189123353
* Splits the iterableMarshaller into runtime codecs.Gravatar shahan2018-03-14
| | | | | | Makes NestedSetCodec into a runtime codec instead of a Marshaller. PiperOrigin-RevId: 189110883
* Dedupes aspects in BuildViewGravatar Googler2018-03-14
| | | | | | | This change ensures that there is no duplicate aspect in AnalysisResult. RELNOTES: None PiperOrigin-RevId: 189086095
* Clean up tests of temp dirs in CcCommonTest to properly set the host CPU.Gravatar jcater2018-03-14
| | | | | | Also have each method only test one CPU value, for easier debugging. PiperOrigin-RevId: 189081488
* Delete unused method.Gravatar carmi2018-03-14
| | | | | RELNOTES: None PiperOrigin-RevId: 189065642
* Bazel: add ar_files/as_files to cc_toolchain targetsGravatar Googler2018-03-14
| | | | | | | | These are mostly tests. This is a step toward making the ar_files/as_files attributes mandatory. RELNOTES: None. PiperOrigin-RevId: 189052327
* Remove the table of contents from the Android and Bazel page. I clicked on ↵Gravatar jingwen2018-03-14
| | | | | | | the link, expecting to be redirected to a new page, but it's just an anchor link on the same page. The page is short enough to not need a ToC. RELNOTES: None. PiperOrigin-RevId: 189042068
* Automated rollback of commit c2b332b45e6ea41a14ecbd3c5f30782bcdeec301.Gravatar laszlocsomor2018-03-14
| | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Causes https://github.com/bazelbuild/bazel/issues/4847 *** Original change description *** windows: replace custom JunctionResolver There's a realpath(3)-like Windows API function called GetFinalPathNameByHandle{A,W}. This commit removes JunctionResolver, implements RealPath using GetFinalPathNameByHandleW, and replaces JunctionResolver usages with RealPath. PiperOrigin-RevId: 189031288
* Remove unused files.Gravatar kaipi2018-03-14
| | | | PiperOrigin-RevId: 189023695
* Modify the Java rules to take in JavaInfoGravatar elenairina2018-03-14
| | | | | | instead of JavaCompilationArgsProvider and JavaPluginInfoProvider. This change facilitates the interaction of Java native and Java Skylark code, avoiding code duplication in the future. PiperOrigin-RevId: 189011873
* Windows: Allow users to build non-C++ rules when VC++ detect failsGravatar Yun Peng2018-03-14
| | | | | | | | | | | Bazel now only reports VC detection error when users actually try to build C++ targets. Fixed https://github.com/bazelbuild/bazel/issues/4813 Closes #4818. Change-Id: I224f54eae9fc9ff87bc13059609dccac17804210 PiperOrigin-RevId: 189009905
* Allow BazelPackageLoader to load external repositories.Gravatar carmi2018-03-13
| | | | | | | | | Also, disallow BazelPackageLoader from fetching missing external repos. Integration tests for BazelPackageLoader wrt external repos will be left for a follow-up CL. RELNOTES: None. PiperOrigin-RevId: 188967694
* Deleted implementation of internal_bootstrap_hack from Blaze.Gravatar Googler2018-03-13
| | | | | | | | | | | | | | As of unknown commit, internal_bootstrap_hack no longer appears in any BUILD files, so once that CL is clearly landed (without rollback) we should be able to submit this CL. There are still some users who set --experimental_js_proto_generate_js_even_for_bootstrap (including tools/blaze.blazerc), so we can't remove that flag until all references are removed. RELNOTES: internal_bootstrap_hack has been deprecated and removed. PiperOrigin-RevId: 188952693
* Delete some unused code.Gravatar ajmichael2018-03-13
| | | | | RELNOTES: None PiperOrigin-RevId: 188937449
* Tags some more non-serializable classes (for serialization).Gravatar shahan2018-03-13
| | | | PiperOrigin-RevId: 188930446
* Integrate memoization into standard serialization. This involves a number of ↵Gravatar janakr2018-03-13
| | | | | | | | | | | | | | | | large changes: 1. SerializationContext and DeserializationContext become the owners of the Memoizer if requested. They produce new versions of themselves on demand that are memoization-aware. Because of intricacies of Skylark that I do not fully understand, we inject a Mutability object when starting memoization, and so to be conservative, that injection starts up a new memoization frame, nested if we were already memoizing, just like before. It would be nice to decouple this injection from memoization in the future. 2. MemoizingCodec is deleted, but really ObjectCodec becomes MemoizingCodec, so it lives on. BaseCodec is deleted since it now has only one implementation. 3. The simplified model of registering MemoizingCodecs is adopted for ObjectCodecs: all codecs are registered based on their #getEncodedClass and #additionalEncodedSubclasses. This also allows us to register codecs that are defined using tricky parameter types, since we're no longer trying to reflectively examine them. This required a clean-up of such codecs, and the addition of ArrayListCodec to stop NullableListCodec from making lists unmodifiable when they shouldn't be. 4. @AutoCodec is extended to allow users to specify that memoization should start with this codec. To ensure bit-equivalence, SkyKeySerializer disables memoization. PiperOrigin-RevId: 188918251
* Integrate import_deps_checker into aar_import.Gravatar cnsun2018-03-13
| | | | | RELNOTES: Enable dependency checking for aar_import targets. PiperOrigin-RevId: 188912126
* Remove documentation regarding keystore name and password.Gravatar ajmichael2018-03-13
| | | | | RELNOTES: None PiperOrigin-RevId: 188895880
* Add a helper method for checking whether toolchain resolution is enabled for ↵Gravatar John Cater2018-03-13
| | | | | | | | | a toolchain type. Closes #4832. Change-Id: Ia4fce6dd7003dc441f81ea7ca65ce865ca222142 PiperOrigin-RevId: 188882041
* Clean up testing of constraint-based selects to not rely on anything that ↵Gravatar John Cater2018-03-13
| | | | | | | | | uses toolchains. Closes #4833. Change-Id: I9f58dc98cc00d0b2246d479d33a5086114d95073 PiperOrigin-RevId: 188882007
* Remove assumption from test that /a and /b don't exist.Gravatar buchgr2018-03-13
| | | | | | | | | | The updated test cases in the InMemoryFileSystemTest make the assumption that /a and /b are not prefixes of the InMemoryFilesystemTest.workingDir field. This is not safe and thus use a randomly generated directory name instead of a hardcoded one. PiperOrigin-RevId: 188872604
* WORKSPACE file: fix sha256 of j2objc-2.0.3.zipGravatar Laszlo Csomor2018-03-13
| | | | | | | | | | | Fixes https://github.com/bazelbuild/bazel/issues/4801 Change-Id: I6a66a4d0cb3651484af48a10f5f9eabbf569a8dc Closes #4826. Change-Id: I6a66a4d0cb3651484af48a10f5f9eabbf569a8dc PiperOrigin-RevId: 188866578
* PiperOrigin-RevId: 188862123Gravatar lpino2018-03-13
|
* Make DeployArchiveBuilder fetch the C++ toolchain identifier throughGravatar lberki2018-03-13
| | | | | | | | | CcToolchainProvider instead of BuildConfiguration. This is a step towards removing BuildConfiguration#getPlatformName(). RELNOTES: None. PiperOrigin-RevId: 188862029
* Allow @Ignore on junit test classesGravatar Stephen Amar2018-03-13
| | | | | | | | | | | | | | | | | | | | | | | | Currently a test class annotated with `@Ignore` will cause the test runner to fail with ``` Exception in thread "main" java.lang.IllegalArgumentException: Top test must be a suite at com.google.testing.junit.runner.junit4.JUnit4TestModelBuilder.get(JUnit4TestModelBuilder.java:53) ``` This change treats classes with no tests (either no @Test annotations or @Ignore at class level) as an empty test suite. The main motivation behind this is allowing an entire test class to be ignored (e.g. to quickly deal with a flaky test) without having to modify the BUILD file. This is desirable in order to reduce the likelihood that a developer forgets to update the BUILD file when removing the `@Ignore` annotation. This pull request overrides the previous pull request https://github.com/bazelbuild/bazel/pull/4073 Closes #4293. PiperOrigin-RevId: 188850828
* tests: add TimestampGranularityUtilsGravatar laszlocsomor2018-03-13
| | | | | | | | | | | | | | Add a new test utility class TimestampGranularityUtils which offers methods to wait for the filesystem timestamp granularity to pass. Such waiting is necessary if a test asserts changes in a file's mtime or ctime. This is a follow-up to comments on https://github.com/bazelbuild/bazel/commit/a31e035fb42aa8db9fd248ef2ebd665a411053b8. PiperOrigin-RevId: 188847729
* Make KeepScanner tool search classpath for nearest definition of each member ↵Gravatar kmb2018-03-12
| | | | | | | | | reference, instead of potentially referring to a subtype. Refactor desugar's class loading machinery and related code into a separate package for easier reuse in this tool. RELNOTES: None. PiperOrigin-RevId: 188825305
* Fix toolchain and execution platform registration to use patterns.Gravatar John Cater2018-03-12
| | | | | | | | This allows more flexibility in registering toolchains and execution platforms, both in the WORKSPACE and from the command-line. Change-Id: I6fe75507d1a74de74085b7c927fdf093c152b894 PiperOrigin-RevId: 188813688
* Add mostly-ide-generated hashCode for RootedPathGravatar michajlo2018-03-12
| | | | | | | Removed null-checks since not expecting null. RootedPath's hashCode is called enough that it's worth optimizing. PiperOrigin-RevId: 188801280
* Fix javac-turbine diagnostic formatting to include source positionGravatar cushon2018-03-12
| | | | PiperOrigin-RevId: 188799934
* Minor fixes to KeepScanner tool:Gravatar kmb2018-03-12
| | | | | | | | - use Guava to read zip entries - Fix keep rules emitted for constructors RELNOTES: None. PiperOrigin-RevId: 188781547
* Tag Attribute, SkylarkDefinedAspect and some other Skylark classes withGravatar mjhalupka2018-03-12
| | | | | | | | | @AutoCodec. Remove Environment from SkylarkDefinedAspect. Add a note to BuiltInFunction that we shouldn't need to serialize it because all instances should be constant. PiperOrigin-RevId: 188763259
* Support custom implementations of emulated core interface methodsGravatar kmb2018-03-12
| | | | | | RELNOTES: None. PiperOrigin-RevId: 188760099
* Added release and release_file parameters to pkg_rpmGravatar mmikitka2018-03-12
| | | | | | | | | | | | 1. Added the "rpm_nvra" output which follows the recommended package naming convention of *Name-Version-Release.Arch.rpm* (NVRA). See http://ftp.rpm.org/max-rpm/ch-rpm-file-format.html 2. Expose "release" and "release_file" parameters to support the NVRA naming convention 3. Remove the mandatory constraint on version parameters (version or version_file): I want to auto-generate my SPEC file outside of the pkg_rpm rule, and I don't want pkg_rpm altering the file. Closes #4732. PiperOrigin-RevId: 188744806
* Prefix startup dots with "Connecting to local Bazel server..." message.Gravatar ruperts2018-03-12
| | | | | RELNOTES: None. PiperOrigin-RevId: 188744724
* Remove comment that is false as of a recent commit.Gravatar nharmata2018-03-12
| | | | | RELNOTES: None PiperOrigin-RevId: 188739970
* Remove support for blaze dump --vfs.Gravatar tomlu2018-03-12
| | | | | | | It is no longer meaningful since the vfs doesn't have an internal path tree to dump. RELNOTES: Remove support for blaze dump --vfs. It is no longer meaningful. PiperOrigin-RevId: 188739379