aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Update ActionMetadata -> ActionExecutionMetadata references.Gravatar Greg Estren2016-09-28
| | | | | -- MOS_MIGRATED_REVID=134537085
* Allow new_ rules to overwrited BUILD files in downloaded reposGravatar Kristina Chodorow2016-09-28
| | | | | | | | | | | My previous change carefully checked that the file was a symlink before removing it and added a test with local repositories... and it of course isn't a symlink with downloaded repositories and crashes. Fixes #1697. -- MOS_MIGRATED_REVID=134536130
* Windows, native: add windows_msvc config_settingGravatar Laszlo Csomor2016-09-28
| | | | | | | | | | | | | | | Update `select` statements in BUILD files with the new config_setting. This is a first step on a long path that leads to us being able to compile bazel on Windows with --cpu=x64_windows_msvc. Needless to say, we're not there yet. Tested: on Linux, Darwin, Windows/MSYS -- MOS_MIGRATED_REVID=134534613
* Eliminates performance overhead of --experimental_dynamic_configs=notrim.Gravatar Greg Estren2016-09-28
| | | | | | | | | | | | | | Before this change, a non-trivial real-world build was measured to have about 20% analysis time overhead. After, that's theoretically down to 2.4%. But that's only the analysis phase, so the impact on full builds is smaller. And the impact on analysis-cached builds is zero. And practical tests show no obvious difference (JProfiler is probably overstating the impact since it excludes known heavyweight methods). The improvements, in short: - Optimize a sanity check that expects each <Attribute, Label> pair to only have one transition. This alone was over half the original performance penalty. - Simplify logic for null configuration deps (of which there are many, e.g.: all source files) - Skip a check for required fragments not available in the configuration. This is irrelevant for notrim mode. There are still some places we could optimize. Dependency.withNullConfiguration in particular takes measurable time (I think from being constructed all the time and in its hashCode calls). But this doesn't seem pressing given the new numbers. -- MOS_MIGRATED_REVID=134533452
* Make cc_configure on Windows more robustGravatar Yun Peng2016-09-28
| | | | | | | | | | | | | 1. Throw an error if Bash-on-Windows is found instead of MSYS bash 2. Introduce BAZEL_VS environment variable 3. Output more information Fix https://github.com/bazelbuild/bazel/issues/1847 -- Change-Id: Ic4571c6c792d9b81df4cd800b8f19d121cc44c33 Reviewed-on: https://bazel-review.googlesource.com/#/c/6330 MOS_MIGRATED_REVID=134531295
* Add a new flag --sandbox_tmpfs_path, which asks the sandbox to mount an ↵Gravatar Philipp Wollermann2016-09-28
| | | | | | | | | empty, writable directory at a specified path when running actions. (Supported on Linux only for now.) RELNOTES: Added a new flag --sandbox_tmpfs_path, which asks the sandbox to mount an empty, writable directory at a specified path when running actions. (Supported on Linux only for now.) -- MOS_MIGRATED_REVID=134526345
* Add support for sandboxing persistent workers.Gravatar Philipp Wollermann2016-09-28
| | | | | -- MOS_MIGRATED_REVID=134523222
* Add interfaces for the build event protocolGravatar Klaus Aehlig2016-09-28
| | | | | | | | | | | Bazel in the will provide a machine-readable stream of important build events. These interfaces set up the framework and expectations about the produced events and the entities distributing those events. -- Change-Id: If2c3b2e11c31b0136b57eadeef2d2f8f8fe5e2e7 Reviewed-on: https://bazel-review.googlesource.com/#/c/6272 MOS_MIGRATED_REVID=134522369
* Remove the "labels in the configuration must be in the transitive closure of ↵Gravatar Lukacs Berki2016-09-28
| | | | | | | | | command line labels" sanity check. It's only used for --libc_top and makes configuration creation much more heavyweight that it would otherwise be. -- MOS_MIGRATED_REVID=134513058
* Rollback of commit a12aae73ee292fdcb170f4eaeb8939283d05383c.Gravatar Yun Peng2016-09-28
| | | | | | | | | | | | | | *** Reason for rollback *** Breaks Bazel Windows Bootstrap Fix https://github.com/bazelbuild/bazel/issues/1851 *** Original change description *** Updates protobuf in bazel to version 3.0.0. -- MOS_MIGRATED_REVID=134510744
* cpp: reuse InWorkspace() function in GetWorkspace()Gravatar Thiago Farina2016-09-28
| | | | | | | | | | | | The access() check in the do-while loop is basically doing the same thing that the InWorkspace() function provides. So lets just call that function instead. It also has the effect of making the code easier to read and understand. -- Change-Id: I02495775a9c9aa262396261824359538ca650e36 Reviewed-on: https://bazel-review.googlesource.com/#/c/6230 MOS_MIGRATED_REVID=134509465
* Windows, bootstrapping: do not build JNI library.Gravatar Laszlo Csomor2016-09-28
| | | | | | | | | | Since commit 94d905836c167a21d2321d26c646fde07f5fc522 we no longer need JNI for WindowsFileSystem.isJunction. This is a partial rollback of commit 4a249b6962d32ed4cfd4165dfdae4a555b00bb69. Affects https://github.com/bazelbuild/bazel/issues/1680 -- MOS_MIGRATED_REVID=134506403
* Skylark: Give more detailed errors when parsing the argumentsGravatar Pedro Liberal Fernandez2016-09-28
| | | | | | | | | | | | | | | | | | | | | of a SkylarkCallable. CL already reviewed in commit 5972bee6ebfa53cf165befab9fa7962e19d5f620. Rolled back due to casting error in Java 1.7. This is fixed now: https://github.com/bazelbuild/bazel/issues/1832 Old: matchingMethod = new Pair<>( method, argumentListConversionResult.getArguments()); New: matchingMethod = new Pair<MethodDescriptor, List<Object>>( method, argumentListConversionResult.getArguments()); -- MOS_MIGRATED_REVID=134503884
* Remove bazel references to PB2 CPP runtime lib.Gravatar Sergio Campama2016-09-28
| | | | | -- MOS_MIGRATED_REVID=134499729
* Fix import ordering for files under com/google/testing/junit/runner/junit4Gravatar Googler2016-09-28
| | | | | -- MOS_MIGRATED_REVID=134486526
* Prevent interleaved slow interrupt stack tracesGravatar Michajlo Matijkiw2016-09-28
| | | | | | | | It's possible that there are multiple outstanding interrupts. When this happens avoid interleaving their stack traces. -- MOS_MIGRATED_REVID=134477540
* Read android binary attributes that are queried for incremental dexing ↵Gravatar Googler2016-09-28
| | | | | | | artifacts from AndroidSemantics. -- MOS_MIGRATED_REVID=134475699
* Tolerate the rare state where a dependent of a previously cached shared ↵Gravatar Janak Ramakrishnan2016-09-28
| | | | | | | | | action sees a different shared action that is in the midst of being an action cache hit. Concretely, suppose that the user builds A, then requests C and D. C depends on A, D depends on B, which is a shared action with A. If B executes at just the right time, as C is finishing execution, C can think that it must add itself to B's execution path, which is incorrect. -- MOS_MIGRATED_REVID=134475095
* updated a link for P0. Persistent Java compiler is enabledGravatar Helen Altshuler2016-09-28
| | | | | | | -- Change-Id: I699d605b3dc923a60516d70dc5d0144a9be49b0b Reviewed-on: https://bazel-review.googlesource.com/#/c/6310/1 MOS_MIGRATED_REVID=134466041
* Updates protobuf in bazel to version 3.0.0.Gravatar Alex Humesky2016-09-28
| | | | | -- MOS_MIGRATED_REVID=134464786
* patch bootclasspath to allow javac to compile lambdas and method references ↵Gravatar Googler2016-09-28
| | | | | | | in android_* targets (behind existing flag). -- MOS_MIGRATED_REVID=134453743
* Implement input pruning using .d files in objc behind a flag that defaults toGravatar Cal Peyser2016-09-28
| | | | | | | false. -- MOS_MIGRATED_REVID=134452391
* Rollback of commit 96d46280bc5a4803ba2242a4ad16939f85a3b212.Gravatar Damien Martin-Guillerez2016-09-28
| | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Broke installation on latest release. Fixes #1846 *** Original change description *** Reintroduce .bazelrc and set --action_env defaults Shipping a .bazelrc was removed in 009b48bcfaf4ebb17f9ab03bea9036cfa3c12ff0. However, as per our "Specifying environment variables for actions" design document, we want to ship a global rc file specifying the common environment variables to be inherited. So revert that change and add the desired entries to the global bazelrc file we're shipping. -- MOS_MIGRATED_REVID=134450299
* Disallow mutation of values being iterated by a for loop or comprehensionGravatar Jon Brandvein2016-09-28
| | | | | | | | | This entails adding a read-locking mechanism to Mutability contexts. RELNOTES[INC]: Updating list/dicts while they are being looped over is not allowed. Use an explicit copy if needed ("for x in list(mylist):"). -- MOS_MIGRATED_REVID=134442701
* Add the version information to the bazel.exe fileGravatar Damien Martin-Guillerez2016-09-27
| | | | | | | | | | | | | Current change do not include version number. Include the version number in the artifact. Closes #1841. -- Change-Id: I2516527829ec28c7c9abea2424f2e7d9585af9b0 Reviewed-on: https://github.com/bazelbuild/bazel/pull/1841 MOS_MIGRATED_REVID=134422109
* Fix visibility of proto srcsGravatar Klaus Aehlig2016-09-27
| | | | | | | | | | Of course, the sources of the buildevent protos should be visible by the including srcs targets. -- Change-Id: I76f5155990dd767d5eb46ad7150980589050217e Reviewed-on: https://bazel-review.googlesource.com/#/c/6290 MOS_MIGRATED_REVID=134414797
* Fixed EvaluationProgressReceiver object namesGravatar Googler2016-09-27
| | | | | | | | | | EvaluationProgressReceiver objects have two common naming schemes currently, and calling them invalidationReceiver is misleading, so to make the naming convention standard, all object names are based on "progressReceiver." -- MOS_MIGRATED_REVID=134411011
* In J2ObjC proto aspect, add a proto file blacklist to filter out unnecessary ↵Gravatar Rumou Duan2016-09-27
| | | | | | | protos from linking into the final binary. -- MOS_MIGRATED_REVID=134409481
* Refactor SkyframeExecutor#preparePackageLoading to pass all ↵Gravatar Janak Ramakrishnan2016-09-27
| | | | | | | | | PackageCacheOptions as a bundle. This will allow me to thread a new flag through more easily in the future. -- MOS_MIGRATED_REVID=134406676
* Add basic protocol buffer for the build event protocolGravatar Klaus Aehlig2016-09-27
| | | | | | | | | | | | | | Add the basic protocol buffers needed for an event stream. This will eventually become a public interface, but is not complete yet. In particular, users should expect it to be extended over time and handle the following kind of changes should gracefully. - New fields can be added to any protocol buffer, and - new choices of event protocol buffers can be added to the payload. -- Change-Id: Ie4d1fdaa4f1aec6c5002ad94da4ef14112f8303f Reviewed-on: https://bazel-review.googlesource.com/#/c/6271 MOS_MIGRATED_REVID=134405277
* Fixed ISE while looking for cycles in WORKPLACE files #1793Gravatar Vladimir Moskva2016-09-27
| | | | | -- MOS_MIGRATED_REVID=134403060
* Add a regression test for commit 78b9cab45de2a32158cd4306cd40208045cf6f85.Gravatar Googler2016-09-27
| | | | | | | As suggested by klimek in the review (I had already submitted at that point). I confirmed that this test fails if I undo commit 78b9cab45de2a32158cd4306cd40208045cf6f85. -- MOS_MIGRATED_REVID=134400910
* Bootstrapping: don't use convenience symlinksGravatar Laszlo Csomor2016-09-27
| | | | | | | | | | | | | | | | | | | | | | When `compile.sh` builds bazel using bazel, it copies the resulting binary to `output/bazel`. However sometimes the convenience symlink `bazel-bin` is not created, probably because an old one is still around and cannot be deleted. That is clearly a bug, but to work around it, the bootstrap builder shouldn't attempt to rely on the creation of these symlinks in the first place. This change updates compile.sh to use `bazel info` to locate the `bazel-bin` directory's real path, and attempt to copy the bazel binary from there. This works around https://github.com/bazelbuild/bazel/issues/1827 -- MOS_MIGRATED_REVID=134398451
* Allow aspects to propagate to all attributes.Gravatar Dmitry Lomov2016-09-27
| | | | | -- MOS_MIGRATED_REVID=134378592
* Debian package: remove declared dependencies on zip, unzip and pkg-configGravatar Damien Martin-Guillerez2016-09-27
| | | | | | | | | Those dependencies are not needed at runtime. Fixes #1834. -- MOS_MIGRATED_REVID=134373693
* Add a new arg to skylark's new_objc_provider method, direct_dep_providers, ↵Gravatar Chris Parsons2016-09-27
| | | | | | | which allows propagation of keys to only the direct dependers of a provider. -- MOS_MIGRATED_REVID=134337199
* --Gravatar Googler2016-09-27
| | | | MOS_MIGRATED_REVID=134334656
* Update the density filter to account for all passed densities.Gravatar Googler2016-09-27
| | | | | -- MOS_MIGRATED_REVID=134321948
* Fix dependency on libtool's helper script make_hashed_objlist.py.Gravatar Chris Parsons2016-09-27
| | | | | | | This should now get appropriately embedded into @bazel_tools. -- MOS_MIGRATED_REVID=134319465
* Add options to ResourceShrinkerAction to generate an updated R.txt.Gravatar Andrew Pellegrini2016-09-27
| | | | | -- MOS_MIGRATED_REVID=134312343
* Rollback of commit 5972bee6ebfa53cf165befab9fa7962e19d5f620.Gravatar Yun Peng2016-09-26
| | | | | | | | | | | | | | *** Reason for rollback *** Break Bazel bootstrap on JDK7 *** Original change description *** Skylark: Give more detailed errors when parsing the arguments of a SkylarkCallable. -- MOS_MIGRATED_REVID=134309621
* Bazel bootstrapping: build an optimized binaryGravatar Laszlo Csomor2016-09-26
| | | | | | | | | Pass "-c opt" when building bazel. Fixes https://github.com/bazelbuild/bazel/issues/1830 -- MOS_MIGRATED_REVID=134307054
* Implement --nocompress_suffixes option.Gravatar Sasha Smundak2016-09-26
| | | | | | | The planned replacement of the ApkBuilder with singlejar uses it. -- MOS_MIGRATED_REVID=134290339
* Fix an issue where a "build" command might hang after it finished, because ↵Gravatar Philipp Wollermann2016-09-26
| | | | | | | sandbox directories could not be cleaned up. -- MOS_MIGRATED_REVID=134286101
* Create a package for Windows via chocolateyGravatar Peter Mounce2016-09-26
| | | | | | -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/1742 MOS_MIGRATED_REVID=134283632
* Correctly declare direct dependenciesGravatar Klaus Aehlig2016-09-26
| | | | | | | ...instead of pulling in symbols from indirect dependencies. -- MOS_MIGRATED_REVID=134283492
* Fix #1671: Use a better approach to reap child processes, which fixes the ↵Gravatar Philipp Wollermann2016-09-26
| | | | | | | occasional hangs seen during builds and on Bazel CI. -- MOS_MIGRATED_REVID=134279208
* Bazel bootstrapping: consume custom startup flagsGravatar Laszlo Csomor2016-09-26
| | | | | | | | | | | | | | | | | | | | | The bootstrap build is special in that it does not use the Bazel client hence we cannot pass a --bazelrc flag as there'd be nothing to parse it. While Bazel is being bootstrapped it's nice to have colors on a smart terminal, but when the bootstrapping is done by Jenkins as part of a CI test, we need the output to be readable, i.e. be free of control characters, so we should pass --colors=no for example. By exporting BAZEL_BOOTSTRAP_STARTUP_OPTIONS the user can control what startup flags will the bootstrap build use, so we can pass these dumbing-down flags during CI builds. -- MOS_MIGRATED_REVID=134273969
* sandbox: Fix an issue where an IOException happening during ↵Gravatar Philipp Wollermann2016-09-26
| | | | | | | SandboxExecRoot#copyOutputs could hide an earlier ExecException from SandboxRunner#run in the Darwin and Linux sandbox strategies. -- MOS_MIGRATED_REVID=134273806
* Fix external label in Bazel's C++ Tutorial.Gravatar Laszlo Csomor2016-09-26
| | | | | | | Fixes https://github.com/bazelbuild/bazel/issues/1786 -- MOS_MIGRATED_REVID=134271340