aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* maven_jar: Actually add support for sources classifierGravatar David Ostrovsky2018-06-08
| | | | | | | | | | | | | | | | | | | | | | | | Closes: #308, #4798. 7a7c41d7d342cd427e74f091b55690eed13e280d was incomplete addition of sources classifier. API wasn't extended to support source SHA1. This has two implications: 1. Sources sha1 artifact cannot be checked once downloaded. 2. Repository cache integration: when enabled, the source artifact cannot be retrieved from the cache, because its sha1 is not known. Rectify the problem by adding src_sha1 attribute to native maven_jar rule. Test Plan: $ bazel test src/test/shell/bazel:bazel_repository_cache_test PiperOrigin-RevId: 198561462 Change-Id: I9c620cdc3876673195483f9e75bb58108acc87be PiperOrigin-RevId: 199855818
* Replace ambiguous bit of info with pointer to rules pageGravatar brandjon2018-06-08
| | | | | RELNOTES: None PiperOrigin-RevId: 199852932
* Support file renaming in ActionFS.Gravatar felly2018-06-08
| | | | PiperOrigin-RevId: 199850381
* Clean up Profiler a bitGravatar ulfjack2018-06-08
| | | | PiperOrigin-RevId: 199849102
* Skylark debugger: fix thread paused state and location not being properly ↵Gravatar brendandouglas2018-06-08
| | | | | | set in ThreadPausedEvents. PiperOrigin-RevId: 199847385
* Add status details to the protosGravatar ulfjack2018-06-08
| | | | | | | | Both for the build event stream proto, which contains the TestResult event, and to the test status proto which is used for caching. The new field may be populated in the future. PiperOrigin-RevId: 199846232
* Automated rollback of commit 6c87715b8ac6b32e636ba307440e2b7362b10a48.Gravatar cpeyser2018-06-08
| | | | | RELNOTES:none PiperOrigin-RevId: 199840978
* Add support for aar_import_external and aar_maven_import_externalGravatar Jingwen Chen2018-06-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Usage example: ```python # In WORKSPACE load("@bazel_tools//tools/build_defs/repo:android.bzl", "aar_import_external", "aar_maven_import_external") # Specify the URL directly: aar_import_external( name = "com_android_support_preference_v14_25_1_0", # required licenses = ["notice"], # required aar_urls = [ # required "https://dl.google.com/dl/android/maven2/com/android/support/preference-v14/25.1.0/preference-v14-25.1.0.aar" ], aar_sha256 = "442473fe5c395ebef26c14eb01d17ceda33ad207a4cc23a32a2ad95b87edfabb", # optional or empty string deps = [ # optional or empty list "@com_android_support_recyclerview_v7_25_1_0//aar", "@com_android_support_appcompat_v7_25_1_0//aar", "@com_android_support_preference_v7_25_1_0//aar", "@com_android_support_support_v4_25_1_0//aar", ], ) # Or, specify the artifact coordinate: aar_maven_import_external( name = "com_android_support_preference_v14_25_1_0", # required artifact = "com.android.support.test:preference-v14:25.1.0", # required sha256 = "442473fe5c395ebef26c14eb01d17ceda33ad207a4cc23a32a2ad95b87edfabb" # optional or empty string licenses = ["notice"], # required server_urls = ["https://maven.google.com"], # required deps = [ # optional or empty list "@com_android_support_recyclerview_v7_25_1_0//aar", "@com_android_support_appcompat_v7_25_1_0//aar", "@com_android_support_preference_v7_25_1_0//aar", "@com_android_support_support_v4_25_1_0//aar", ], ) # In BUILD.bazel android_library( name = "foo", srcs = [...], deps = [ "@com_android_support_preference_v14_25_1_0//aar", ], ) ``` To test this out with gmaven_rules, change the `load` statement in https://github.com/bazelbuild/gmaven_rules/blob/master/gmaven.bzl to ``` load('@bazel_tools//tools/build_defs/repo:android.bzl', 'aar_import_external') load('@bazel_tools//tools/build_defs/repo:java.bzl', 'java_import_external') ``` Fixes https://github.com/bazelbuild/bazel/issues/4654 RELNOTES: New rules for importing Android dependencies: `aar_import_external` and `aar_maven_import_external`. `aar_import_external` enables specifying external AAR dependencies using a list of HTTP URLs for the artifact. `aar_maven_import_external` enables specifying external AAR dependencies using the artifact coordinate and a list of server URLs. Closes #5319. Change-Id: I9517e68ab78f2e30fb6ceabfe3b35061c585d607 PiperOrigin-RevId: 199839047
* Make Artifact#equals take the owner into account for derived artifacts.Gravatar janakr2018-06-08
| | | | | | | | Derived artifacts' owners are important because they are used to determine the artifact's generating action. Source artifacts' owners are not used in this way, so I left them alone. This allows us to get rid of most uses of ArtifactSkyKey. We may be able to delete it entirely in a follow-up. PiperOrigin-RevId: 199836436
* Publish detailed configurable attributes (select()) documentation.Gravatar gregce2018-06-08
| | | | | | Fixes #2154 PiperOrigin-RevId: 199830177
* ActionFS correctly tracks symlink sources.Gravatar shahan2018-06-08
| | | | PiperOrigin-RevId: 199820207
* Use unsafe String operations when writing parameter files.Gravatar tomlu2018-06-08
| | | | | | | | | When a LATIN-1 parameter file is requested, we can take advantage of the fact that JDK9 strings are (usually) stored as LATIN-1. For UTF-8, we can still optimize for the common case where a LATIN-1 string contains only ASCII characters, as these are bit-identical between UTF-8 and LATIN-1. This would still be expected to be the vast majority of parameter file contents. RELNOTES: None PiperOrigin-RevId: 199816430
* Support basic test functionality in ActionFS.Gravatar felly2018-06-08
| | | | | | | | | ActionFS now allows output files to be created that do not correspond to known Artifacts. Note that tests exercise a greater gamut of filesystem functionality (deleting files, deleting directory trees, moving files, etc.) RELNOTES: None PiperOrigin-RevId: 199809069
* Flip default value of --experimental_shortened_obj_file_path to true (Second ↵Gravatar pcloudy2018-06-08
| | | | | | | | | | try) This is a roll forward of https://github.com/bazelbuild/bazel/commit/3ab52e63079f1e43cb2c973425f615836a334082. The issue caused the objc rule breakage was fixed by https://github.com/bazelbuild/bazel/commit/5176300577b53a15128b3cb6a17d7883c5b7090e. RELNOTES: Flip default value of --experimental_shortened_obj_file_path to true, Bazel now generates short object file path by default. PiperOrigin-RevId: 199806300
* Prepare to remove java_toolchain.encodingGravatar cushon2018-06-08
| | | | | | | | UTF-8 is the only supported encoding for Java sources. See #2926. PiperOrigin-RevId: 199803902
* Deletes default implemetation of MetadataProvider.getInputGravatar shahan2018-06-08
| | | | | | Small misc cleanups. PiperOrigin-RevId: 199797948
* Add link to the auto-generated Node_JS rules documentation.Gravatar spomorski2018-06-08
| | | | | RELNOTES: None. PiperOrigin-RevId: 199796230
* Cleanup BuildEventStreamOptionsGravatar ulfjack2018-06-08
| | | | PiperOrigin-RevId: 199795284
* Expose cc_common.create_link_build_variablesGravatar hlopko2018-06-08
| | | | | | | | | | | This cl enabled skylark rules to create build variables used for C++ link actions (in a limited form, e.g. build variables for thinlto are not exposed etc). Working towards #4571. RELNOTES: None PiperOrigin-RevId: 199792130
* Add a `sync` commandGravatar Klaus Aehlig2018-06-08
| | | | | | | | | | | | | Add a command that ensures that all skylark workspace rules get called. In follow-up changes the semantics of the sync command will be extended to call all those rules unconditionally. This, together with recoding of the return values of the repository rules, as currently provided by --experimental_repository_resolved_file provides the framework for resolving underspecified rules, e.g., rules following head of an external repository. Change-Id: I11061ec138a9ba7a7b61a431eeb1b8667dfabb95 PiperOrigin-RevId: 199792026
* Print an additional link at the end of the build pointing where the Build ↵Gravatar lpino2018-06-08
| | | | | | Event Protocol is being streamed. PiperOrigin-RevId: 199790757
* BlazeOptionHandler: only check in the parent directory, if there is oneGravatar Klaus Aehlig2018-06-08
| | | | | | | | | | | When checking for a file called DO_NOT_BUILD_HERE in the parent direcotry of the workspace path, first verify that there is such a parent directory. This avoids a null pointer exception if the WORKSPACE file is in the top-level directory. Fixes #5349 Change-Id: I81289a27a3f7fb0f4b5a112343de1b454fb5b8c5 PiperOrigin-RevId: 199790735
* Remove include_java_contracts_deps option.Gravatar dbabkin2018-06-08
| | | | | RELNOTES:none PiperOrigin-RevId: 199787025
* Filter middleman artifacts from NamedArtifactGroupGravatar ulfjack2018-06-08
| | | | PiperOrigin-RevId: 199786555
* Update documentation about dict iteration orderGravatar laurentlb2018-06-08
| | | | | | | | | | | The information was redundant. https://github.com/bazelbuild/bazel/commit/d605a62eb9908fe44c89a2ed10f88f633c4dcb3e modified only one place, which created a contradiction. We can just remove the outdated one. #5352 RELNOTES: None. PiperOrigin-RevId: 199780557
* Release 0.14.1 (2018-06-08)Gravatar Bazel Release System2018-06-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Baseline: 5c3f5c9be7fa40d4fb3c35756891fab8483ca406 Cherry picks: + f96f037f8f77335dc444844abcc31a372a3e1849: Windows, Java launcher: Support jar files under different drives + ff8162d01409db34893de98bd840a51c5f13e257: sh_configure.bzl: FreeBSD is also a known platform + 7092ed324137f03fcd34856bdb0595a1bdec3069: Remove unneeded exec_compatible_with from local_sh_toolchain + 57bc201346e61c62a921c1cbf32ad24f185c10c9: Do not autodetect C++ toolchain when BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 is present + 35a78c09cf2fbfc3de9c124d2142e3d72aac4348: remote: recursively delete incomplete downloaded output directory. + 3c9cd82b847f3ece8ec04b2029bd5e8ad0eb7502: distfile: pack the archives needed later in the build + 27487c77387e457df18be3b6833697096d074eab: Slightly refactor SpawnAction to improve env handling + 1b333a2c37add9d04fe5bc5258ee4f73c93115e2: Fix Cpp{Compile,Link}Action environment and cache key computation + 3da8929963e9c70dff5d8859d6e988e6e7f4f9d7: Make SymlinkTreeAction properly use the configuration's environment + eca7b81cf8cc51e1fe56e5ed7d4ad5cd1668a17a: Add a missing dependency from checker framework dataflow to javacutils + 10a4de954c2061258d8222961fc3bd39516db49d: Release 0.14.0 (2018-06-01) + 4b80f2455e7e49a95f3a4c9102a67a57dad52207: Add option to enable Docker sandboxing. + 6b1635279e8b33dc1ac505ac81825e38f8797a14: Allow disabling the simple blob caches via CLI flag overrides. Bug fix for [#5336](https://github.com/bazelbuild/bazel/issues/5336) Bug fix fot [#5308](https://github.com/bazelbuild/bazel/issues/5308)
* C++: Refactors PyWrapCc to make it easier to migrate to SkylarkGravatar plf2018-06-08
| | | | | | | | Rolling forward https://github.com/bazelbuild/bazel/commit/6afc2eb67675e928bc8fa10c5d1745223186b6e0. This CL was only rolled back to make it easier to rollback https://github.com/bazelbuild/bazel/commit/d0982b905d93e219a0caccdcf5d6ae1e219387c2. RELNOTES:none PiperOrigin-RevId: 199779304
* Remove the legacy loading phase runnerGravatar ulfjack2018-06-08
| | | | PiperOrigin-RevId: 199775400
* Automatic ClangTidyReadability code cleanup.Gravatar Googler2018-06-08
| | | | PiperOrigin-RevId: 199769337
* Make JavaBuilder use a unique coverage metadata directoryGravatar elenairina2018-06-08
| | | | | | | | | | | for each test instead of the same directory for all the tests. The previous implementation was using one directory for instrumenting the classes of a jar. For each each jar the metadata directory was deleted if it already existed. This is problematic for local execution when multiple tests are run in parallel because some threads will try to delete the directory and some will try to perform read/write operations on it. This is an important fix for Bazel coverage users. Fixes #4398. RELNOTES: Java coverage works now with multiple jobs. PiperOrigin-RevId: 199764483
* Automated rollback of commit ccaccb2b277a82f7264567563a02ab133a0f6e6f.Gravatar jmmv2018-06-07
| | | | | | | | | | | | | | | *** Reason for rollback *** Suspected root cause behind tons of Blaze nightly failures. One example: [] *** Original change description *** Let blaze obfuscate manual main_dex_list according to proguard map. PiperOrigin-RevId: 199737371
* Deletes ActionInputFileCache.Gravatar shahan2018-06-07
| | | | PiperOrigin-RevId: 199732415
* Automated rollback of commit d0982b905d93e219a0caccdcf5d6ae1e219387c2.Gravatar janakr2018-06-07
| | | | | | | | | | | | | | | *** Reason for rollback *** See linked bug. *** Original change description *** C++: Delete PyCcLinkParamsProvider. No longer needed. RELNOTES:none PiperOrigin-RevId: 199710626
* Automated rollback of commit f137cea0ac74334013e7b064e59d1624cf032ac4.Gravatar janakr2018-06-07
| | | | | | | | | | | | | *** Reason for rollback *** See linked bug. *** Original change description *** C++: Refactors PyWrapCc to make it easier to migrate to Skylark RELNOTES:none PiperOrigin-RevId: 199702630
* Add an initial skylark debug server implementation.Gravatar Googler2018-06-07
| | | | | | | | | | | | Not intending this to be a complete implementation yet. Among the things still to do: - officially add support for debugging aspects, rules, etc., with corresponding tests. - handle breakpoints at return statements (an edge case which bypasses Eval). PiperOrigin-RevId: 199692670
* blaze_util::ConvertPath should not make paths absolute.Gravatar ccalvarin2018-06-07
| | | | | | | | | It does not claim to, and this was already true for posix platforms. Windows platforms, however, always made the path absolute, which was a hard-to-diagnose difference between the two. Similarly, MakeAbsolute was relying on this to be correct for windows, so this change splits the implementation and keeps the behavior consistent. While we're here, also remove the empty-string behavior from MakeAbsolute, and instead make it clear at all sites that this behavior is present and affects accepted flag syntax. We may want to remove this later. RELNOTES: None. PiperOrigin-RevId: 199663395
* Automated rollback of commit 4c72a82ada742bd369185cd07c57f96c497ce440.Gravatar jmmv2018-06-07
| | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks, at least, //ads/aswan/tools:format_mr_results. *** Original change description *** Remove python3/ prefix to generated .pyc files. That makes: (a) merging PY2 and PY3 .runfiles impossible (which is incorrect anyway) and (b) generated .py source files incompatible with 2to3 (src_version=PY2) - that's OK as we deprecate 2to3. RELNOTES: n/a PiperOrigin-RevId: 199661399
* Simplify TestAttempt interfaceGravatar ulfjack2018-06-07
| | | | | | | By always requiring a TestResultData instace, we simplify the callers, which already have to do all the work anyway. PiperOrigin-RevId: 199639965
* Move --distdir out of experimental statusGravatar Klaus Aehlig2018-06-07
| | | | | | | | | | | | | | | | | | | | | | | The option --experimental_distdir has been introduced 4 months ago and was completely unproblematic ever since. Moreover, it is now used productively, both in our own bootstrapping process[1], as well as in external packaging of projects using bazel[2]. So make this option non-experimental. We still keep the old name as an alternative to not break existing uses. Related: #5175. RELNOTES: The --distdir option is no longer experimental. This option allows to specify additional directories to look for files before trying to fetch them from the network. Files from any of the distdirs are only used if a checksum for the file is specified and both, the filename and the checksum, match. [1] Commit 3c9cd82b847f3ece8ec04b2029bd5e8ad0eb7502 [2] https://github.com/gentoo/gentoo/blob/7379cdb578b0c070c846c3fa9f71470e2c5d1320/sci-libs/tensorflow/tensorflow-1.8.0-r1.ebuild#L168 Change-Id: I536238f9bdbad6b4f7222b4f6a1464d70d9f3be3 PiperOrigin-RevId: 199637265
* Fix a few generated docs.Gravatar Sam Rawlins2018-06-07
| | | | | | | | | | | | | | In particular, * fix sentences with no space after the period, like [here]([] * switch backticks to `<code>`, like [here]([] * link `ctx.var` [here]([] * Add periods to the end of paragraphs, like [here]([] * Format a list [here]([] Closes #5337. PiperOrigin-RevId: 199631585
* [launcher] Don't pass std::string to C varargs functionGravatar Loo Rong Jie2018-06-07
| | | | | | | | | | | | | `die` passes parameters to `vfprintf`. Passing `std::string` to this function might crash the program. Found by Clang on Windows. /cc @meteorcloudy Closes #5339. Change-Id: Iff7aa766770771262f91990774ff4d8de1fbeb5c PiperOrigin-RevId: 199630717
* Fix bug in skyframe-based test-suite expansionGravatar ulfjack2018-06-07
| | | | | | | | | | It was tracking filtered tests and then applying the filter at the next higher level. I also added a bunch of comments - we actually have four implementations of test suite expansion, and they are not consistent. Sorry about that. PiperOrigin-RevId: 199629485
* Remove CC_CONFIGURE_DEBUG in test_base.pyGravatar pcloudy2018-06-07
| | | | | | | Since the issue that requires debugging has been fixed. RELNOTES: None PiperOrigin-RevId: 199628410
* Remove genrule's dependency on the cpp toolchain.Gravatar jcater2018-06-07
| | | | PiperOrigin-RevId: 199627983
* Make bes_best_effort a no-opGravatar ulfjack2018-06-07
| | | | | | | | | | | | | | | | The current semantics of the flag is to allow BES upload to continue past the nominal end of the build invocation, and possibly overlapping a subsequent build invocation. This conflicts with file uploads, which must read the file before it is removed or modified by the subsequent build invocation. On Linux, we could just open a file handle, but this isn't possible on Windows. We decided to make the flag a no-op for now. Note that the default is already set to false. We may resurrect this option in the future if there's a strong use case for it, possibly with slightly different semantics. PiperOrigin-RevId: 199620392
* C++: Introduces flag to disable automatic expansion of labels in linkopts.Gravatar plf2018-06-07
| | | | | | | LSC is finished. RELNOTES:none PiperOrigin-RevId: 199619978
* Add LabelLateBoundDefault to :coverage_report_generator attributeGravatar dbabkin2018-06-07
| | | | | RELNOTES:none PiperOrigin-RevId: 199619691
* C++: Refactors PyWrapCc to make it easier to migrate to SkylarkGravatar plf2018-06-07
| | | | | RELNOTES:none PiperOrigin-RevId: 199619637
* Allow disabling the simple blob caches via CLI flag overrides.Gravatar John Millikin2018-06-07
| | | | | | | | | | | | | | This fixes a regression from v0.13. When the local disk cache flags were unified into `--disk_cache`, it became impossible to override a default cache location such that the cache became disabled. This prevents canarying of remote execution in the presence of a default bazelrc that enables the disk cache. Fixes #5308 Closes #5338. PiperOrigin-RevId: 199613922
* Add LabelLateBoundDefault to :coverage_support attributeGravatar dbabkin2018-06-07
| | | | | RELNOTES:none PiperOrigin-RevId: 199604462
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-05 14:58:37 +0000