| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 176643685
|
|
|
|
|
|
|
| |
Fixed https://github.com/bazelbuild/bazel/issues/4144
RELNOTES: None
PiperOrigin-RevId: 176642833
|
|
|
|
|
|
|
| |
--experimental_enable_jvm_configuration_make_variables is not in effect.
RELNOTES: None.
PiperOrigin-RevId: 176641110
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 176635888
|
|
|
|
|
|
|
| |
When system_provide attribute is 1, Bazel assumes the runtime shared library is provided by system.
RELNOTES: None
PiperOrigin-RevId: 176632326
|
|
|
|
|
|
|
|
| |
Working on consolidating all mobile-install artifacts under label.name + "_mi/"
directory.
RELNOTES:None.
PiperOrigin-RevId: 176592620
|
|
|
|
|
|
|
|
|
| |
Currently we don't care about the list order of SpawnResults. However, we may care about the list order later. Also, if the equals() method for SpawnResults is ever changed then it may be problematic to return SpawnResults in a Set.
Aside: ActionResults use SpawnResults to calculate cumulative execution times for Actions, and may provide other metrics in future.
RELNOTES: None.
PiperOrigin-RevId: 176579460
|
|
|
|
|
|
|
|
|
| |
This is only relevant for things like 'bazel build //...' in workspaces that have a top-level //experimental directory. As such, this hardcoded exclusion is unlikely to be desired, especially by bazel users externally.
Fixes #3822.
RELNOTES: None
PiperOrigin-RevId: 176569346
|
|
|
|
|
|
|
|
|
|
| |
Package specifications can now be prefixed with `-` to
indicate negation: the specification `-//foo/bar/...`
excludes all packages under `//foo/bar` that would otherwise
have been matched.
RELNOTES: Package specifications can now be prefixed with `-` to indicate negation
PiperOrigin-RevId: 176551382
|
|
|
|
|
|
|
|
| |
This will instruct AAPT2 to produce conditional keep rules to allow for more aggressive code and resource shrinking.
RELNOTES[NEW]: Add --experimental_android_resource_cycle_shrinking option to allow for more aggressive code and resource shrinking.
PiperOrigin-RevId: 176530749
|
|
|
|
|
|
|
|
|
| |
uses of attribute-name string literals from MultiArchBinarySupport
This cleanup is a step in the right direction for exposing the apple linking API to Skylark -- supports must avoid calling ruleContext.getPrerequisites with attribute-name string literals; providers and TransitiveInfoCollections should come as inputs to the API.
RELNOTES: None.
PiperOrigin-RevId: 176525071
|
|
|
|
| |
PiperOrigin-RevId: 176521744
|
|
|
|
|
|
|
| |
It begins to hit the 300s time limit of medium test.
RELNOTES: None
PiperOrigin-RevId: 176511672
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test case test_failed_actions_with_keep_going was never correct
and only worked by accident: it relied on bazel starting at least
two actions, if for there are at least two where all the dependencies
are already met; however bazel is clever and analyzes the resources
of the system it is running in, and if they are small will only run one
genrule at a time. Fix this by telling it to run 2 actions and lying
about the available resources of the local system.
Also increase the test size and reenable the test for remote execution.
Fixes #3995.
Change-Id: Ic84de17a98a2e74c24901d4efb38d7631de4690a
PiperOrigin-RevId: 176511026
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows a flag_set to emit one flag when a feature is enabled, and a
different flag when that feature is disabled.
And while I was in there, I noticed and fixed a couple other issues:
1. env_set didn't actually implement with_feature, despite having the field in
its proto.
2. action_config implemented with_feature as an optional field, instead of
repeated field.
RELNOTES: None
PiperOrigin-RevId: 176510960
|
|
|
|
| |
PiperOrigin-RevId: 176510846
|
|
|
|
|
|
|
|
| |
See https://github.com/bazelbuild/bazel-website/issues/74 -- these domain redirects are obsolete.
Closes #4130.
PiperOrigin-RevId: 176509860
|
|
|
|
|
|
|
|
|
| |
cycles when loading platforms.
Part of #4128.
Change-Id: Ie55a91aaaec15d8eb537f59131fc2e69a8f9c251
PiperOrigin-RevId: 176509311
|
|
|
|
|
|
| |
Closes #4115.
PiperOrigin-RevId: 176507799
|
|
|
|
|
|
| |
store bare.
PiperOrigin-RevId: 176505963
|
|
|
|
|
|
|
|
|
|
| |
This is needed for the ability to synthesize the correct remote
execution protos from a platform rule.
Part of #4128.
Change-Id: I7fa8acf45642a4df4e2beb1ba9c57c2536670486
PiperOrigin-RevId: 176504885
|
|
|
|
|
|
| |
The serve-docs.sh script uses pygments for formatting code fragments which fails with "no lexer for alias 'shell' found"
PiperOrigin-RevId: 176503221
|
|
|
|
|
| |
Change-Id: I0d77f491422c41831b2840fb7256526f273abbd0
PiperOrigin-RevId: 176502405
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For an action, whenever the status or strategy changes, reset
the timer. In this way, we show the time an action spent in the
current state, rather than the total time the action spent since
started. This might give a better picture of what is currently
going on in the system.
Fixes #4089.
Change-Id: I441337cf2eec58702889ac7a6a9ed150708e8c9d
PiperOrigin-RevId: 176497486
|
|
|
|
|
|
|
|
| |
Fixes #4132
Closes #4134.
PiperOrigin-RevId: 176496829
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 176496770
|
|
|
|
|
|
|
|
| |
came from an AbstractParallelEvaluator evaluation. It's against the standard Java contract to throw but still have the thread's interrupted bit set.
Also get rid of some unnecessary initializeTester() calls in MemoizingEvaluatorTest: we already call it via a @Before annotation.
PiperOrigin-RevId: 176496034
|
|
|
|
|
|
|
|
|
|
|
|
| |
The `set` constructor used to be deprecated, but it was still possible to use
it by providing --incompatible_disallow_set_constructor=false.
It's still allowed to have `set` in parts of the code that are not executed, this will be deprecated later. You can check if your code is compatible with this future change by using the flag --incompatible_disallow_uncalled_set_constructor (currently the default is "false").
RELNOTES[INC]: The flag --incompatible_disallow_set_constructor is no longer
available, the deprecated `set` constructor is not available anymore.
PiperOrigin-RevId: 176491641
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is applying the version 1.1 of the specification (https://reproducible-builds.org/specs/source-date-epoch/)
where the only timestamp that Bazel puts in the final targets is overridden by the value of SOURCE_DATE_EPOCH.
This change also remove the legacy SOURCE_DATE_EPOCH handling which wasn't really following
the spec.
Note that Bazel itself tries hard to remove all timestamps from intermediary binaries and
overridde SOURCE_DATE_EPOCH in most action, which is a not according to the version 1.0 of the spec
but according to the expected change for version 1.1.
RELNOTES: SOURCE_DATE_EPOCH (https://reproducible-builds.org/specs/source-date-epoch/) can
be used to override the timestamp used for stamped target (when using --stamp).
Fixes #2240.
Change-Id: I074e7905fa6745cc706f7391340aeae9188909ca
PiperOrigin-RevId: 176489717
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When showing the current actions, the most interesting are those
that are currently being executed, not those that are waiting for
resources or otherwise in the process of being scheduled. Therefore,
show the executing actions at the top of the list. Also add more
visual hints to distinguish executing from non executing actions.
Screenshot
(14:51:21) [160 / 230] 32 actions, 11 running
Compiling lotsofwork/true986.c; 0s linux-sandbox
Compiling lotsofwork/true982.c; 0s linux-sandbox
Compiling lotsofwork/true983.c; 0s linux-sandbox
Executing genrule //lotsofwork:true975_c; 0s linux-sandbox
Compiling lotsofwork/true981.c; 0s linux-sandbox
Linking lotsofwork/true_999; 0s linux-sandbox
Linking lotsofwork/true_996; 0s linux-sandbox
Linking lotsofwork/true_998; 0s linux-sandbox
Compiling lotsofwork/true980.c; 0s linux-sandbox
Compiling lotsofwork/true98.c; 0s linux-sandbox
Executing genrule //lotsofwork:true974_c; 0s linux-sandbox
[Sched] Creating runfiles tree bazel-out/k8-fastbuild/bin/lotsofwork/true_974.runfiles
[Sched] Linking lotsofwork/true_997
[Sched] Linking lotsofwork/true_995
[Sched] Linking lotsofwork/true_99
[Sched] Linking lotsofwork/true_991 ...
Improves on #4089.
Change-Id: I1bc6636d5e53a16151023bba595e38259eb1ac88
PiperOrigin-RevId: 176483192
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm getting
.../bazel-out/host/bin/external/bazel_tools/tools/build_defs/pkg/make_deb.runfiles/bazel_tools/third_party/py/gflags/gflags/__init__.py:284: UserWarning: Flag architecture has a non-None default value; therefore, mark_flag_as_required will pass even if flag is not specified in the command line!
'command line!' % flag_name)
So, let's not mark it as required if a default is passed in!
Change-Id: Iad9a3886ce0ff21ce26eb7fa17a986be4c4af5cf
PiperOrigin-RevId: 176480367
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 176423487
|
|
|
|
|
|
|
| |
Some flags are relatively immune to repeated mentions, since only the last mention ends up mattering, but in some cases, the values are accumulated. Expanding the same config twice may lead to surprising results, so provide a friendly warning.
RELNOTES: None
PiperOrigin-RevId: 176422758
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 176405273
|
|
|
|
|
|
|
| |
Configs are recursive, but let's be reasonable. If there's an absurdly long list of configs inheritance, warn about it. It is probably unnecessary, and might very well be unintentional and surprising to the user.
RELNOTES: None.
PiperOrigin-RevId: 176405183
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The `set` constructor used to be deprecated, but it was still possible to use
it by providing --incompatible_disallow_set_constructor=false.
It's still allowed to have `set` in parts of the code that are not executed, this will be deprecated later.
RELNOTES[INC]: The deprecated `set` constructor is removed, along with the
migration flag --incompatible_disallow_set_constructor. It is still temporarily
allowed to refer to `set` from within unexecuted code.
PiperOrigin-RevId: 176375859
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--expand_configs_in_place.
--config options were expanded in a fix-point expansion, where in practice, the flags that --config values expanded to ended up between the normal bazelrc options and the command line's explicit options. Since the options parser has an order-based priority scheme and it accepts multiple mentions of a single-valued option, this conflicts with users' expectations of being able to override these config expansions by using the order in which they are mentioned.
This change makes it possible to expand the config values defined in your bazelrc (or blazerc) files to occur in-place: --stuff --config=something --laterstuff will interpret the options that --config=something expands to as if they had been mentioned explicitly between --stuff and --laterstuff.
In order to not break users relying on complex flag combinations to configure their builds, this behavior will not yet be turned on by default. Instead, use --expand_configs_in_place as a startup flag to test this feature. --announce_rc may be helpful for debugging any differences between the fixed point and in-place expansions. Once you've debugged your problems, add "startup --expand_configs_in_place" to your blazerc to stick to the new behavior.
RELNOTES: Use --expand_configs_in_place as a startup argument to change the order in which --config expansions are interpreted.
PiperOrigin-RevId: 176371289
|
|
|
|
|
|
|
| |
https://github.com/bazelbuild/bazel/issues/3985
Change-Id: Ib566103e147219122b3f745a98ad30db5f27553f
PiperOrigin-RevId: 176365079
|
|
|
|
|
|
|
|
|
| |
repository.
Part of #4056.
Change-Id: I4b8e41660b0a135e23aa572bbfeea27a7cda0581
PiperOrigin-RevId: 176362103
|
| |
|
|
|
|
|
|
|
|
|
| |
Since src/tools/launcher is Windows specific, it doesn't actually work
on Linux. Here we select a dummy source file for cc targets non-Windows
platform.
Change-Id: I9a6550ea23a3656ad72cb46b9652f154e2fbf44f
PiperOrigin-RevId: 176350180
|
|
|
|
|
|
|
|
|
|
| |
Fix for #4035
@laszlocsomor
Closes #4110.
PiperOrigin-RevId: 176346381
|
|
|
|
|
|
|
|
| |
Fixes https://github.com/bazelbuild/bazel/issues/3761
Closes #4015.
PiperOrigin-RevId: 176340908
|
|
|
|
|
|
|
|
| |
platform-based toolchain selection to match legacy behavior.
This is a change over previous behavior in the platform case, which was to throw if either of those attributes is not present. The default_toolchain field in CROSSTOOL gives a mapping from cc_toolchain.cpu values to toolchains - this map should be used with compiler and libc are not specified, as is currently the non-platforms, legacy behavior.
PiperOrigin-RevId: 176246316
|
|
|
|
|
|
|
|
| |
Notable implementation details:
- split the flag into --experimental_post_build_query and --experimental_query_options
- allow --nohost_dep filtering to be applied to query targets configured in the host configuration (only returns deps also in the host configuration so allow deps as long as it never sees a transition from a host config to a non-host config)
PiperOrigin-RevId: 176165870
|
|
|
|
|
|
|
|
| |
Add reference to strip-prefix with a real-world example of usage.
Closes #3969.
PiperOrigin-RevId: 176151504
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
performance.
Shaves ~30-40 seconds off the critical path. The critical path is now dominated by the NDK test, but that's out of scope for this change. See below for data.
BEFORE:
$ bazel test //src/test/shell/bazel/android:android_integration_test
INFO: Analysed target //src/test/shell/bazel/android:android_integration_test (0 packages loaded).
INFO: Found 1 test target...
[4 / 5] Testing //src/test/shell/bazel/android:android_integration_test; 23s linux-sandbox
Target //src/test/shell/bazel/android:android_integration_test up-to-date:
/tmp/bazel-bin/src/test/shell/bazel/android/android_integration_test
INFO: Elapsed time: 93.696s, Critical Path: 93.37s
INFO: Build completed successfully, 2 total actions
//src/test/shell/bazel/android:android_integration_test PASSED in 93.4s
AFTER:
$ bazel test :all --nocache_test_results
WARNING: The major revision of the Android NDK referenced by android_ndk_repository rule 'androidndk' is 15. The major revisions supported by Bazel are [10, 11, 12, 13, 14]. Defaulting to revision 14.
WARNING: API level 26 specified by android_ndk_repository 'androidndk' is not available. Using latest known API level 25
INFO: Analysed 9 targets (0 packages loaded).
INFO: Found 2 targets and 7 test targets...
INFO: Elapsed time: 106.452s, Critical Path: 105.66s
INFO: Build completed successfully, 8 total actions
//src/test/shell/bazel/android:aidl_integration_test PASSED in 43.9s
//src/test/shell/bazel/android:android_integration_test PASSED in 55.1s
//src/test/shell/bazel/android:android_ndk_integration_test PASSED in 105.6s
//src/test/shell/bazel/android:android_sdk_integration_test PASSED in 68.4s
//src/test/shell/bazel/android:desugarer_integration_test PASSED in 43.9s
//src/test/shell/bazel/android:proguard_integration_test PASSED in 43.7s
//src/test/shell/bazel/android:resources_integration_test PASSED in 51.4s
Executed 7 out of 7 tests: 7 tests pass.
RELNOTES: None.
PiperOrigin-RevId: 176144822
|
|
|
|
|
|
| |
ToolchainInfo.
PiperOrigin-RevId: 176117866
|
|
|
|
|
|
|
|
| |
Rewrites a significant portion of aspects to give more detailed examples of using aspects. Multiple people on our team found the aspects documentation a little dense and wanted more of a cookbook style explanation of the hows and whys of using aspects.
Closes #3982.
PiperOrigin-RevId: 176115055
|
|
|
|
|
|
|
|
| |
Designed by
https://docs.google.com/document/d/1hK2mWl3TYNL9oJYX_S020TKkXZvBw1aBoYERvTHVyfg/edit#
Change-Id: I025adf555a9827c55a90acc3f254cbd105e224c6
PiperOrigin-RevId: 176114968
|