| Commit message (Collapse) | Author | Age |
... | |
|
|
|
| |
Change-Id: Ifc30d7a2f1cd698f563342e41be9f59989af871b
|
|
|
|
|
|
|
|
| |
three files
--
PiperOrigin-RevId: 151319959
MOS_MIGRATED_REVID=151319959
|
|
|
|
|
|
|
|
| |
http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/lastCompletedBuild/testReport/(root)/(empty)/test_sandbox_mount_customized_path/
--
PiperOrigin-RevId: 151306949
MOS_MIGRATED_REVID=151306949
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151302544
MOS_MIGRATED_REVID=151302544
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151302418
MOS_MIGRATED_REVID=151302418
|
|
|
|
|
|
|
|
|
|
| |
This only add the bootstrap tests. We could add more tests but we should probably rather just update the 15.10 VMs to run Ubuntu 16.04.
Tracking issue #2741.
--
PiperOrigin-RevId: 151299465
MOS_MIGRATED_REVID=151299465
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151297803
MOS_MIGRATED_REVID=151297803
|
|
|
|
|
|
|
|
|
|
| |
- Adjust the date for the milestones
- Move items that we are completing earlier and set P0 for 0.6
- Some other rewriting
--
PiperOrigin-RevId: 151296351
MOS_MIGRATED_REVID=151296351
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additionally to reporting on the originally received command line, also report
it in a parsed form. This, in particular, includes reconstructing the options
originally provided by the user.
--
Change-Id: I5a1c6ed57874f1d37d10bf11d597256d63bc5516
Reviewed-on: https://cr.bazel.build/9459
PiperOrigin-RevId: 151288656
MOS_MIGRATED_REVID=151288656
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151263526
MOS_MIGRATED_REVID=151263526
|
|
|
|
|
|
|
|
| |
RELNOTES: n/a
--
PiperOrigin-RevId: 151203625
MOS_MIGRATED_REVID=151203625
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151201374
MOS_MIGRATED_REVID=151201374
|
|
|
|
|
|
|
|
|
| |
This has no effect unless --incremental_dexing is used.
RELNOTES: turn on --experimental_incremental_dexing_error_on_missed_jars by default.
--
PiperOrigin-RevId: 151198031
MOS_MIGRATED_REVID=151198031
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151193034
MOS_MIGRATED_REVID=151193034
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151183770
MOS_MIGRATED_REVID=151183770
|
|
|
|
|
|
|
|
|
|
|
| |
The linux-sandbox no longer requires extensive configuration via flags,
so the command-line arguments will easily fit into the allowed length.
This simplifies the code and gets rid of some I/O.
--
PiperOrigin-RevId: 151176551
MOS_MIGRATED_REVID=151176551
|
|
|
|
|
|
|
|
|
|
|
| |
Extract the process-wrapper + symlink tree sandbox strategy into its own
class and allow its use in FreeBSD.
RELNOTES: Bazel can now use the process-wrapper + symlink tree based sandbox implementation in FreeBSD.
--
PiperOrigin-RevId: 151171652
MOS_MIGRATED_REVID=151171652
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151170448
MOS_MIGRATED_REVID=151170448
|
|
|
|
|
|
|
|
|
|
| |
This allows us to see for example whether an action ran using the
"process wrapper + symlink tree" sandbox or the real "PID and mount
namespaces" Linux sandbox.
--
PiperOrigin-RevId: 151165170
MOS_MIGRATED_REVID=151165170
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151160662
MOS_MIGRATED_REVID=151160662
|
|
|
|
|
|
|
|
|
|
| |
into a separate method, so that the main becomes shorter. Also move most of the code in main to an instance method.
RELNOTES: n/a
--
PiperOrigin-RevId: 151155142
MOS_MIGRATED_REVID=151155142
|
|
|
|
|
|
|
|
|
|
| |
The header mapping used to be generated by J2ObjcTranspilationAction and consumed by dependent J2ObjcTranspilationActions. This setup led to chained J2ObjcTranspilationActions and long critical path build time. With GenerateJ2objcHeaderMap action, we break that chain and shorten the critical path build time.
This feature is guarded behind a new build flag, --experimental_j2objc_header_map.
--
PiperOrigin-RevId: 151149906
MOS_MIGRATED_REVID=151149906
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151145409
MOS_MIGRATED_REVID=151145409
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151141112
MOS_MIGRATED_REVID=151141112
|
|
|
|
|
|
|
|
|
|
|
| |
Note that this is not quite a no-op. Setting -isystem puts these directories at
the beginning of the search list, whereas not setting them results in them
being near the end. However, this code is unnecessary and confusing and caused
a bug with the clang toolchains so it is best to remove it.
--
PiperOrigin-RevId: 151140445
MOS_MIGRATED_REVID=151140445
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
execution.
If you're feeling like you've already seen this, that's correct, these were the exact contents of commit e860316559eac366d47923a8eb4b5489a661aa35... and then, on Nov 15, something unclear happened and the code disappeared! Perhaps it was the result of a faulty sync. In any case, nobody noticed, and the CL went in. It was later rolloed back and resubmitted, but the crucial code changes were gone.
TESTED=local server with profiling for SHA1 specifically
RELNOTES: n/a
--
PiperOrigin-RevId: 151139685
MOS_MIGRATED_REVID=151139685
|
|
|
|
|
|
|
|
|
|
| |
Previously the mapping is generated directly by J2ObjC through j2objc_wrapper.py.
RELNOTES:None.
--
PiperOrigin-RevId: 151138711
MOS_MIGRATED_REVID=151138711
|
|
|
|
|
|
|
|
|
|
| |
signaledDeps field directly in InMemoryNodeEntry.
Should save ~24 bytes per freshly evaluating node entry (I haven't calculated object alignment for InMemoryNodeEntry now, so could be more or less). Also might save some memory for re-evaluating node entries, since the BuildingState class had to be padded out to a multiple of 8 bytes before the DirtyBuildingState fields could start. Don't actually know if that was happening.
--
PiperOrigin-RevId: 151138224
MOS_MIGRATED_REVID=151138224
|
|
|
|
|
|
|
|
| |
case-insensitive paths.
--
PiperOrigin-RevId: 151137308
MOS_MIGRATED_REVID=151137308
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151130566
MOS_MIGRATED_REVID=151130566
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151129669
MOS_MIGRATED_REVID=151129669
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rollback of commit df366408188f0451bae9b2ed079c795a4beb2e2b.
In addition to undoing the rollback of my previous change, fix the bugs it
introduced and add tests for those bugs.
Always ignore empty filters. Empty filters are always useless or
counterproductive. Before the original change, empty filters as a single item
within the list of filters (e.g., ["en", ""]) were ignored, but empty filters
as a portion of a string in the list (e.g., ["en,"]) were not. I can't imagine
any reason people would actually want the empty filter (if it were handled
correctly, it would effectively tell Bazel to just ignore every other filter
the user passed in).
Since it makes more sense with the new code, represent the stringified filters
as a list of strings, rather than a single string of comma-seperated values.
Manually trim whitespace from each token. Before the original change, the code
trimmed whitespace following commas (e.g., ["en, es"] -> ["en,es"]) but not
otherwise. If we're allowing whitespace in filter strings anyway, there doesn't
seem to be any reason to allow it in some places but not others.
--
PiperOrigin-RevId: 151128685
MOS_MIGRATED_REVID=151128685
|
|
|
|
|
|
|
|
|
|
|
| |
If needed you can restore the old behavior by passing the flag
--sandbox_tmpfs_path=/tmp to bazel.
Fixes #2508.
--
PiperOrigin-RevId: 151127924
MOS_MIGRATED_REVID=151127924
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also refactor the way we compute writable dirs so that they're computed
only once per running action, not twice.
Fixes #2056, fixes #1973, fixes #1460.
RELNOTES: /tmp and /dev/shm are now writable by default inside the
Linux sandbox.
--
PiperOrigin-RevId: 151123543
MOS_MIGRATED_REVID=151123543
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Abusing the checkEnvironment method, register early on the event bus
and catch all events till the time we are supposed to process the options.
This solves the problem that events relevant to the build event stream are
posted (e.g., the GotOptions event) before(!) we know if a BuildEventStreamer
is required.
--
Change-Id: Iac63302351b862772638791932bcaa58b60b22fb
Reviewed-on: https://cr.bazel.build/9457
PiperOrigin-RevId: 151123359
MOS_MIGRATED_REVID=151123359
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151120717
MOS_MIGRATED_REVID=151120717
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of trying to detect overlapping mount points, just ignore any
ENOENT errors during remount. If this error happens, the mount point
wouldn't be accessible anyway, so there's no harm if the remount fails.
Fixes #1948.
--
PiperOrigin-RevId: 151118726
MOS_MIGRATED_REVID=151118726
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Try to run /bin/true as a test of whether the Linux sandbox works,
instead of just trying to create a bunch of namespaces as a proxy.
This helps resolve issues on Linux distros where the earlier check
worked, but then the sandbox ultimately failed due to other operations
being unsupported.
As an example, Debian Jessie and certain Docker versions seem to allow
the creation of PID namespaces, but forbid mounting a new proc on top of
/proc (see #1972). This resulted in Bazel thinking that sandboxing works
fine, when it actually didn't. The improved check correctly catches this
situation and disabled sandboxing.
--
PiperOrigin-RevId: 151116894
MOS_MIGRATED_REVID=151116894
|
|
|
|
|
|
|
|
| |
template
--
PiperOrigin-RevId: 151116658
MOS_MIGRATED_REVID=151116658
|
|
|
|
|
|
|
|
| |
Fix #2730
--
PiperOrigin-RevId: 151116555
MOS_MIGRATED_REVID=151116555
|
|
|
|
|
|
|
| |
Adding third party dependencies required to call OnePlatform
endpoints with proper auth.
Change-Id: Iebafdd846999de2937bfa5f086871b69adae2057
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This can be reactivated by passing the --sandbox_fake_username flag
to Bazel.
Reasoning: 'nobody' has a non-existent home directory on many Linux
distros, leading to issues when tools try to stat / read / write to the
home directory.
Related to #2688.
RELNOTES: The Linux sandbox no longer changes the user to 'nobody' by
default, instead the current user is used as is. The old behavior can be
restored via the --sandbox_fake_username flag.
--
PiperOrigin-RevId: 151115218
MOS_MIGRATED_REVID=151115218
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By removing the --sandbox_block_path feature in an earlier change and
taking advantage of the fact that in a mount namespace we can actually
"remount" mount points to be read-only without bind mounting them to
some other place beforehand, this is no longer necessary. The code
becomes much simpler due to this, for example we no longer need to
chroot.
--
PiperOrigin-RevId: 151111360
MOS_MIGRATED_REVID=151111360
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is in the way of optimizing the performance of the sandbox, because
it requires us to create two helper files (an unreadable file and an
unreadable directory) which are bind-mounted on top of paths specified
via this flag. These two helper files were created on a tmpfs mounted by
the sandbox until now, which ensured that they were automatically
deleted on exit. However, mounting tmpfs on /dev/shm or /tmp causes
issues like #2686 or #1882.
By removing this flag, we can get rid of the two helper files, which
means we can also remove the reliance on a "sandbox temp directory"
completely in the next change.
--
PiperOrigin-RevId: 151107496
MOS_MIGRATED_REVID=151107496
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151092346
MOS_MIGRATED_REVID=151092346
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151089412
MOS_MIGRATED_REVID=151089412
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling forward with the correct changes to the AndroidResourceMergingAction. Tested manually.
*** Original change description ***
Automated [] rollback of commit a58f245a4b40c0ef961b1f30d96b16a9349711c3.
*** Reason for rollback ***
broke over 100k targets, in the depot, see []
*** Original change description ***
Move library R generation to a separate action, ensuring the merging happens
off the java critical path.
--
PiperOrigin-RevId: 151087737
MOS_MIGRATED_REVID=151087737
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the standard filemanager supports nio, there's a better-supported way
to keep the compilation outputs in memory. ZipOutputFileManager doesn't
implement the full filemanager contract, is not compatible with the latest
javac 9's.
--
PiperOrigin-RevId: 151082823
MOS_MIGRATED_REVID=151082823
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
classloader. Currently this funcionality is hidden behind the "experimental_testrunner" flag.
Original description (from commit 786cfa2ed980e278c42ee474408844f7e3720385):
Separate the classpaths of the TestRunner with the test target, and use a separate Classloader to load the test target's classes. This enables a clean separation of the classes of the TestRunner with the target under test.
This is achieved with the following steps:
1. Start the test runner with only the bare bones classpaths to the Test Runner's classes which are used by the system ClassLoader.
2. Have all the classpaths required to load the test target's classes in a TEST_TARGET_CLASSPATH environment variable exported by the stub script.
3. Use a new classloader to load all the test target's classes using the paths in TEST_TARGET_CLASSPATH.
This additionally enables the persistent test runner (currently experimental), to reload all the target's classes for every subsequent test run, so it can pick up any changes to the classes in between runs.
The persistent test runner can be used by adding the argument
--test_strategy=experimental_worker to the bazel test command (and having the tag "experimental_testrunner" in the java_test rule).
Tested this against:
1. gerrit/gerrit-common:client_tests: Dismal avg. improvement of 580ms to 557ms (just 23ms)
2. intellij/intellij/base:unit_tests: Somewhat modest avg. improvement 1661ms to 913ms (748 ms)
--
PiperOrigin-RevId: 151065529
MOS_MIGRATED_REVID=151065529
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involves:
(1) Adding the -g compiler flag
(2) If the target is a test, do not add linker flags.
(3) Move relevant tests to crosstool case.
--
PiperOrigin-RevId: 151055080
MOS_MIGRATED_REVID=151055080
|