aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Remove an obsolete TODOGravatar dmishe2017-08-30
| | | | PiperOrigin-RevId: 166889783
* Change bug tracking in TODOs for LegacyCompilationSupport deprecation.Gravatar cparsons2017-08-30
| | | | | RELNOTES: None. PiperOrigin-RevId: 166889164
* Remove default_macosx_sdk_version (use default_macos_sdk_version only)Gravatar cparsons2017-08-30
| | | | | RELNOTES: None. PiperOrigin-RevId: 166888780
* Narrow the LinkCommandLine API.Gravatar Googler2017-08-30
| | | | | | | | | Previously it had too many essentially identical accessors. This trims it down a bit and adjusts the call sites. This cl changes the command line passed to tests slightly - now they can possibly contain linkstamping command prepended to actual linker invocation. RELNOTES: None. PiperOrigin-RevId: 166888575
* devtools/build/lib/buildeventstream/proto: fix spelling in commentGravatar matloob2017-08-30
| | | | | | This change changes the misspelling "conents" to "contents". PiperOrigin-RevId: 166887321
* Internal changeGravatar Googler2017-08-30
| | | | PiperOrigin-RevId: 166874758
* Change TODO to reference individual instead of internal bug numberGravatar brandjon2017-08-30
| | | | | RELNOTES: None PiperOrigin-RevId: 166874734
* fix "weak_framwork_names" crosstool feature typoGravatar cparsons2017-08-30
| | | | | RELNOTES: None. PiperOrigin-RevId: 166868614
* BEP: add tool_tag explicitlyGravatar Klaus Aehlig2017-08-30
| | | | | | | | | Add the tool tag explicitly in the OptionsParsed event. In this way, consumers of the stream can more easily associate an invocation with a tool. Change-Id: I6040e91f657082782bf8010a6576001118672e2d PiperOrigin-RevId: 166862895
* Rollforward of ↵Gravatar apell2017-08-29
| | | | | | | | | https://github.com/bazelbuild/bazel/commit/0071b396776be4d146fd271499716dd5dea6f7e9: Enable parameter files for manifest merger actions. NEW: Using shell quoted param files and unescape arguments in ParamsFilePreProcessor to avoid miss-processing --manifestValues arguments containing whitespace. RELNOTES: None. PiperOrigin-RevId: 166858411
* Add a way to construct Frames in a two-step processGravatar brandjon2017-08-29
| | | | | RELNOTES: None PiperOrigin-RevId: 166857589
* Fix NPE in WorkerFilesHash.Gravatar philwo2017-08-29
| | | | | | | | We must check that a given artifact is a file, before calling getDigest, according to the interface contract specified in actions/Metadata.java. Add a regression test to bazel_worker_test.sh, too. It's enough to simply add a directory entry to the worker's data to trigger the original bug. PiperOrigin-RevId: 166856512
* Add a new toolchain type for c++. In order to do this, ↵Gravatar cpeyser2017-08-29
| | | | | | | | PlatformConfiguration is made a legal configuration fragment for every rule class. Add a default "dummy" c++ toolchain to prevent resolution errors when legacy toolchain selection logic is used. Add toolchain mocks to java and shell tests. PiperOrigin-RevId: 166854893
* Ensure ThinLTO backend actions always generate debug info when fission enabledGravatar Googler2017-08-29
| | | | | | | | | While we don't generate .dwp files for shared libraries, the link still expects the object files to contain split debug info. Enhanced tests to ensure the cc_library LTO backend actions always have the expected outputs/build variable, regardless of linking static or not. RELNOTES: NONE PiperOrigin-RevId: 166853630
* Remove an obsolete TODOGravatar dmishe2017-08-29
| | | | | | | | | | * Xcode's Swift 2.3 toolchain was an artifact of the Swift migration period and doesn't seem to be present in newer versions. Spending time on a likely unused feature isn't worth the time anymore. PiperOrigin-RevId: 166851949
* Split "shell", "graph" into their own packages.Gravatar philwo2017-08-29
| | | | PiperOrigin-RevId: 166849610
* Skylint: add lint for missing docstringsGravatar fzaiser2017-08-29
| | | | | RELNOTES: None PiperOrigin-RevId: 166846007
* remote: simplify upload logicGravatar buchgr2017-08-29
| | | | | | Use ByteStream for uploads. PiperOrigin-RevId: 166844266
* remote: close file when uploadingGravatar buchgr2017-08-29
| | | | | RELNOTES: None PiperOrigin-RevId: 166841380
* remote/http: distinquish between action cache and casGravatar buchgr2017-08-29
| | | | | | | | | | | | | | | | | | | | | | | | The remote http caching client now prefixes the URL of an action cache request with 'ac' and cas request with 'cas'. This is useful as servers might want to distinquish between the action cache and the cas. Before this change: (GET|PUT) /f141ae2d23d0f976599e678da1c51d82fedaf8b1 After this change: (GET|PUT) /ac/f141ae2d23d0f976599e678da1c51d82fedaf8b1 (GET|PUT) /cas/f141ae2d23d0f976599e678da1c51d82fedaf8b1 This change will likely break any HTTP caching service that assumed the old URL scheme. TESTED: Manually using https://github.com/buchgr/bazel-remote RELNOTES: The remote HTTP/1.1 caching client (--remote_rest_cache) now distinquishes between action cache and CAS. The request URL for the action cache is prefixed with 'ac' and the URL for the CAS is prefixed with 'cas'. PiperOrigin-RevId: 166831997
* Flip the --incompatible_disallow_set_constructor flag by defaultGravatar vladmos2017-08-29
| | | | | | | | | RELNOTES[INC]: `set` is deprecated in BUILD and .bzl files, please use `depset` instead. Ordering names have also been changed, please use "default", "postorder", "preorder", and "topological" instead of "stable", "compile", "naive_link", and "link" correspondingly. PiperOrigin-RevId: 166830004
* Removes all test parts of compile.shGravatar dmarting2017-08-29
| | | | | | | | So compile.sh is dedicated to bootstrapping Bazel. It has been a long time we are not testing those code path anymore and providing a bazel binary on the command line was regularly broken PiperOrigin-RevId: 166827487
* drop apt upgrade from shell script installGravatar Russ Cox2017-08-29
| | | | | | | | I assume apt-get upgrade does _not_ upgrade the shell-script install, especially if you used `--user` but also in general. Closes #3596. PiperOrigin-RevId: 166823519
* Make Windows C++ launcher support long pathGravatar Yun Peng2017-08-29
| | | | | Change-Id: I25795c748fa98b9275ae34ead17fce02a57dc8e4 PiperOrigin-RevId: 166816800
* aar_import creates res/values/empty.xml if it contains no resources.Gravatar ajmichael2017-08-29
| | | | | | | | | To do this, add a new tool that is used instead of zipper to get the resources out of the AAR. This tool creates res/values/empty.xml if there are no resources in the AAR. Also, some general cleaning of the code. RELNOTES: None PiperOrigin-RevId: 166768607
* Missing link in docs of proto_libraryGravatar Googler2017-08-29
| | | | | RELNOTES: none PiperOrigin-RevId: 166764640
* remove reference to native "ios_framework" rule, as it no longer exists.Gravatar cparsons2017-08-29
| | | | | RELNOTES: None. PiperOrigin-RevId: 166756809
* Automated rollback of commit 363413110f3a63a11d900864be1852adbaed2899.Gravatar cpeyser2017-08-29
| | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks //src/test/shell/bazel:bazel_bootstrap_distfile_test: INFO: You can skip this first step by providing a path to the bazel binary as second argument: INFO: ./compile.sh compile /path/to/bazel 🍃 Building Bazel from scratch...... 🍃 Building Bazel with Bazel. .WARNING: /tmp/bazel_cHivhPBc/out/external/bazel_tools/WORKSPACE:1: Workspace name in /tmp/bazel_cHivhPBc/out/external/bazel_tools/WORKSPACE (@io_bazel) does not match the name given in the repository's definition (@bazel_tools); this will cause a build error in future versions. ERROR: in target '//external:cc_toolchain': error loading package '@local_config_cc//': Extension file not found. Unable to load file '@local_config_cc//:dummy_toolchain.bzl': file doesn't exist or isn't a file. INFO: Elapsed time: 3.343s ERROR: Could not build Bazel Found by git bisect. *** Original change description *** Add a new toolchain type for c++. In order to do this, PlatformConfiguration is made a legal configuration fragment for every rule class. Add a default "dummy" c++ toolchain to prevent resolution errors when legacy toolchain selection logic is used. Add toolchain mocks to java and shell tests. PiperOrigin-RevId: 166750885
* Clean up after rolling out --jplNonStrictDepsLikePl.Gravatar carmi2017-08-29
| | | | | RELNOTES: None PiperOrigin-RevId: 166745722
* Refactor collection of action cache statistics.Gravatar jmmv2017-08-29
| | | | | | | | | | | | | | | | | This change gets rid of the old CachesSavedEvent object (note, plural) which used to capture details about various caches. As this was now only used for a single cache, rename it to ActionCacheStatistics so that the data it contains is more cohesive. The reason for this change is to make room for the addition of other metrics for the action cache (like hits/misses), which will come later. As of now, this change is intended to be a no-op. While doing this, use AutoValue to avoid mutability of the generated objects and use better types for the contained data (e.g. Duration for timings). RELNOTES: None. PiperOrigin-RevId: 166742117
* Clean up after rolling out --correctRollupTransitiveProtoRuntimes.Gravatar carmi2017-08-29
| | | | | RELNOTES: None PiperOrigin-RevId: 166735889
* Add debugging to other flaky test case in discard_graph_edges_test. We ↵Gravatar janakr2017-08-29
| | | | | | actually don't need most of the information being logged here, but on the other hand, I have no reports of flakiness from the other test case after these log lines were added, so maybe it'll be a heisenbug and go away. PiperOrigin-RevId: 166731945
* In the config_setting arguments section, the description of the "values" arg ↵Gravatar juliexxia2017-08-29
| | | | | | | states that "This and *values* cannot both be empty" with the word *values* hyperlinking to define_values. Assuming typo(?) and changing to "This and *define_values* cannot both be empty." RELNOTES: None. PiperOrigin-RevId: 166723373
* Use CustomCommandLine directly instead of via SpawnAction.Builder.Gravatar tomlu2017-08-29
| | | | | | | | | | | | | This change forces use of CustomCommandLine.Builder, which has a richer interface for constructing memory-efficient command lines. It will also permit surveying the code base for inefficient patterns using an IDE. This change was done by hand and split using Rosie to assist with rollbacks in case of bugs. Reviewers, please pay particular attention to: * Each all to addInputArgument/addOutputArgument should come with a corresponding matching pair to SpawnAction.Builder#addInput and CustomCommandLine.Builder#addExecPath (eg.). * The commandLine must be set on the SpawnAction using SpawnAction.Builder#setCommandLine. Note that most calls to addPrefixed("arg=", val) should be more idiomatically expressed as add("arg", val), but this involves changing tests and making sure that the command line tools can accept the format. PiperOrigin-RevId: 166723076
* Remove TODO from LegacyCompilationSupport.Gravatar tomlu2017-08-29
| | | | PiperOrigin-RevId: 166722992
* Visit subtrees of the AST in evaluation orderGravatar fzaiser2017-08-29
| | | | | | | | | | | For instance, it makes more sense to visit the RHS of an assignment first because this is evaluated first. This also fixes a bug in the validator, which allowed definitions like "a = a" RELNOTES: None PiperOrigin-RevId: 166709589
* Set the Objc tests to not run on windows.Gravatar dmarting2017-08-28
| | | | PiperOrigin-RevId: 166705717
* Add a --output_directory_suffix command line option to facilitate the ↵Gravatar lberki2017-08-28
| | | | | | | removal of the C++ toolchain identifier from the output path. RELNOTES: None. PiperOrigin-RevId: 166705005
* Change Identifier#boundNames to #boundIdentifiers.Gravatar fzaiser2017-08-28
| | | | | RELNOTES: None PiperOrigin-RevId: 166704851
* Flip the --incompatible_descriptive_string_representations flag by defaultGravatar vladmos2017-08-28
| | | | | | | | RELNOTES[INC]: Objects in Skylark are converted to strings in a more descriptive and less harmful way (they don't leak information that shouldn't be accessed by Skylark code, e.g. nondeterministic memory addresses of objects). PiperOrigin-RevId: 166697907
* Bazel client: debug info for corrupt installationGravatar László Csomor2017-08-28
| | | | | | | | | | | | | | | | | | | | The Bazel client checks the installation files every time it starts. Bazel checks that it can read the installation files and that their mtimes are in the future. The "bazel-tests" project on Bazel CI recently produced flaky-looking failures. The error messages talk about a missing installation file. This change makes Bazel print more debugging info when the aformentioned check fails. I hope the information will help catching this bug. See https://github.com/bazelbuild/bazel/issues/3618 Change-Id: Ic51384b5840262484515fa320f162a79cfd0e012 PiperOrigin-RevId: 166696141
* //src/test/shell/bazel:toolchain_test: increase sizeGravatar Klaus Aehlig2017-08-28
| | | | | | | ...and shard count, to avoid timeouts. See #3619. Change-Id: I52c0d1a2bcf8e7e6c5c01db58bdddc87fb9e7f07 PiperOrigin-RevId: 166696089
* This change adds an explicit dependency on the current Java runtime that ↵Gravatar lberki2017-08-28
| | | | | | | | indirectly depend on it by using the $(JAVABASE) or $(JAVA) Make variables. It was tested by running "bazel build --nobuild" on the affected targest to make sure that they still work. PiperOrigin-RevId: 166695324
* Use CustomCommandLine directly instead of via SpawnAction.Builder.Gravatar tomlu2017-08-28
| | | | | | | | | | | | | This change forces use of CustomCommandLine.Builder, which has a richer interface for constructing memory-efficient command lines. It will also permit surveying the code base for inefficient patterns using an IDE. This change was done by hand and split using Rosie to assist with rollbacks in case of bugs. Reviewers, please pay particular attention to: * Each all to addInputArgument/addOutputArgument should come with a corresponding matching pair to SpawnAction.Builder#addInput and CustomCommandLine.Builder#addExecPath (eg.). * The commandLine must be set on the SpawnAction using SpawnAction.Builder#setCommandLine. Note that most calls to addPrefixed("arg=", val) should be more idiomatically expressed as add("arg", val), but this involves changing tests and making sure that the command line tools can accept the format. PiperOrigin-RevId: 166694174
* Implement CustomCommandLine support for Skylark.Gravatar tomlu2017-08-28
| | | | | RELNOTES: Support ctx.actions.args() for more efficient Skylark command line construction. PiperOrigin-RevId: 166694148
* Move Statement.exec methods to a separate class.Gravatar laurentlb2017-08-28
| | | | | RELNOTES: None. PiperOrigin-RevId: 166689144
* Add a lint for missing return statementsGravatar fzaiser2017-08-28
| | | | | | | | This lint checks that if a functions returns a value in some execution paths, it does so in all execution paths. RELNOTES: None PiperOrigin-RevId: 166688783
* Replace which by bash-builtin hashGravatar Klaus Aehlig2017-08-28
| | | | | | | | | | | | Reportedly, which is not installed by default on all non-windows systems bazel is used. As we only use which to test if a program can be found on PATH, use the bash builtin hash command. While there - replace the search for [ by a search for tr, a program we care more, as [ is the builtin test anyway, - fix a typo in the name of the GNU tools collection searched for. Change-Id: Id78737eba10e96c6fa41ca68a47102ab28e6031f PiperOrigin-RevId: 166685117
* Auto-generate BUILD files for src/java_tools/junitrunnerGravatar ulfjack2017-08-28
| | | | | | | | | This and further changes may contain minor modifications to BUILD files that don't serve any apparent purpose. The reason for these changes is that we're switching from checked-in BUILD files to generated BUILD files, and there may be small differences between these files. PiperOrigin-RevId: 166684362
* Clean up NO_MSVC_WRAPPER flagGravatar Yun Peng2017-08-28
| | | | | | | This flag no longer exists after MSVC-less CROSSTOOL became default. Change-Id: I015c3c03c72d15c0efe00f48e923a2d54876b1b2 PiperOrigin-RevId: 166680678
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-04 18:37:21 +0000