| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139436876
|
|
|
|
|
|
| |
--
Reviewed-on: https://bazel-review.googlesource.com/c/7372/
MOS_MIGRATED_REVID=139432850
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139400647
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139399869
|
|
|
|
|
|
|
|
|
|
|
|
| |
When rewriting blocks to `{ throws new AssertionError(); }`, use
a fully-qualified name for `java.lang.AssertionError` in case we're
inside the declaration of a type with the same simple name.
Also, only add the throws expression statement when rewriting
lambda body blocks, since that's the only place it matters.
--
MOS_MIGRATED_REVID=139397324
|
|
|
|
|
|
|
|
|
| |
SkyQueryEnvironment#beforeEvaluateQuery if possible to save on latency for small queries.
This assumes that if the graph is up to date, then the data in SkyQueryEnvironment is also up to date. It also assumes that a ForkJoinPool remains usable until #shutdownNow is called.
--
MOS_MIGRATED_REVID=139386363
|
|
|
|
|
|
|
|
|
|
|
| |
The AndroidManifest.xml for the android_binary did not specify a minSdkVersion,
but the AAR that it depended on specified minSdkVersion=9. The legacy manifest
merger was OK with this, the new one is not.
See https://github.com/bazelbuild/bazel/issues/2086
--
MOS_MIGRATED_REVID=139384477
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding and removing hard links to a file from several processes
simultaneously appears to occasionally fail on macOS.
This commit changes the testjobs's test's strategy of keeping track
of the number of tests running in parallel. Instead of counting the
number of links to a shared file, it now counts the number of files
in a shared directory. Instead of each test run adding and removing
a link to a shared file, each run adds and removes a file from a
directory.
--
Change-Id: Idc0a9a9cf1c2f5b03221fcd991e4bf0155e62841
Reviewed-on: https://bazel-review.googlesource.com/c/7392/
MOS_MIGRATED_REVID=139384412
|
|
|
|
|
|
|
|
|
|
|
| |
test_maven_aar_skylark is essentially an android_integration_test and as such
requires that android_sdk_for_testing and android_ndk_for_testing be properly
set up.
See https://github.com/bazelbuild/bazel/issues/2086
--
MOS_MIGRATED_REVID=139384309
|
|
|
|
|
|
|
|
|
|
| |
The attribute for the source list is "srcs", not "src".
Closes #2098.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/2098
MOS_MIGRATED_REVID=139380743
|
|
|
|
|
|
|
| |
not untrimmed ones.
--
MOS_MIGRATED_REVID=139376735
|
|
|
|
|
|
|
| |
RELNOTES:
--
MOS_MIGRATED_REVID=139370787
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139364083
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Causes NPEs in tests that use AutoValue, on Kokoro and CI.
Bazel uses TestRunner_deploy.jar to run tests. To save time, we use the latest Bazel release to run tests. Therefore, we use a TestRunner_deploy.jar with an AutoValue 1.2 embedded.
If the test requires AV itself, we use the one from HEAD, which is 1.4-rc1, therefore causing one-definition rule violations.
Once we release a TestRunner without AV (commit 90b5b19927540fc1e1c9e1a7fbd05c816ae0e4e2), we can roll forward.
error: @AutoValue processor threw an exception: java.lang.NullPointerException
abstract static class AutoValuedClass implements TransitiveInfoProvider {
^
at com.google.auto.value.processor.AutoValueProcessor.getFieldOfClasses(AutoValueProcessor.java:566)
at com.google.auto.value.processor.AutoValueProcessor.allMethodExcludedAnnotations(AutoValueProcessor.java:818)
at com.google.auto.value.processor.AutoValueProcessor.defineVarsForType(AutoValueProcessor.java:763)
at com.google.auto.value.processor.AutoValueProcessor.processType(AutoValueProcessor.java:488)
at com.google.auto.value.processor.AutoValueProcessor.process(AutoValueProcessor.java:195)
at com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:803)
at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:715)
at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$2000(JavacProcessingEnvironment.java:93)
at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1023)
at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1130)
at com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1141)
at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:832)
at com.sun.tools.javac.main.Main.compile(Main.java:253)
at com.google.devtools.build.buildjar.javac.BlazeJavacMain.compile(BlazeJavacMain.java:140)
at com.google.devtools.build.buildjar.javac.BlazeJavacMain.compile(BlazeJavacMain.java:132)
at com.google.devtools.build.buildjar.AbstractJavaBuilder$1.invokeJavac(AbstractJavaBuilder.java:66)
at com.google.devtools.build.buildjar.ReducedClasspathJavaLibraryBuilder.compileSources(ReducedClasspathJavaLibraryBuilder.java:81)
at com.google.devtools.build.buildjar.AbstractJavaBuilder.compileJavaLibrary(AbstractJavaBuilder.java:69)
at com.google.devtools.build.buildjar.AbstractJavaBuilder.run(AbstractJavaBuilder.java:108)
at com.google.devtools.build.buildjar.BazelJavaBuilder.processRequest(BazelJavaBuilder.java:92)
at com.google.devtools.build.buildjar.BazelJavaBuilder.runPersistentWorker(BazelJavaBuilder.java:70)
at com.google.devtools.build.buildjar.BazelJavaBuilder.main(BazelJavaBuilder.java:47)
*** Original change description ***
Bazel to use AutoValue 1.4-rc1.
The big improvement is the addition of @AutoValue.CopyAnnotations, which allows AutoValue classes to be exposed to Skylark via @SkylarkModule.
--
MOS_MIGRATED_REVID=139361042
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139357569
|
|
|
|
|
|
|
| |
array resource types.
--
MOS_MIGRATED_REVID=139357164
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks targets in the depot:
[]
*** Original change description ***
output_group is not a real Skylark provider for aspects, as well as for rules.
--
MOS_MIGRATED_REVID=139354682
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test infrastructure.
The small picture story is that SkyframeExecutor.getDynamicConfigOptions
(which gets dynamic BuildOptions for tests) wasn't updated with dynamic
split support when that was added to
ConfiguredTargetFunction.getDynamicTransitionOptions (which does the same
thing for production builds). This change plugs that gap. See
373e3e28274cca5b87f48abe33884edb84016dd3 for the original change.
The bigger picture story is that Bazel's configured target creation
logic is forked: test code goes down a similar but sadly not-quite-the-same
path that results in tons of duplicated logic, spaghetti code mess,
and risk of bugs like this one. We'd like to ultimately undo that fork.
But unfortunately it's an involved effort that won't happen overnight. In
the meantime, this change takes one small step by merging the two methods
that caused this bug.
--
MOS_MIGRATED_REVID=139342710
|
|
|
|
|
|
|
| |
The big improvement is the addition of @AutoValue.CopyAnnotations, which allows AutoValue classes to be exposed to Skylark via @SkylarkModule.
--
MOS_MIGRATED_REVID=139336396
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cl merges two classes used to hold build variables context into one. Those
classes are (previously top-level) jcgd.build.lib.rules.cpp.Variables, and its
inner class View. Both represent a collection of build variables and imo it
makes sense to merge them to make the code simpler.
Also, I cleaned up the build variables api to use primitive strings or instances of VariableValueBuilders, and I've hidden subclasses of VariableValues.
Last but not least, I refactored the code to use immutable collections exclusively. That revealed that 'module_files' variable is sometimes registered twice. I want to clean this eventually ([]).
--
MOS_MIGRATED_REVID=139329823
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Lambda expression doesn't work with JDK7, which Bazel still supports
*** Original change description ***
Fix strict deps handling of the default package.
--
MOS_MIGRATED_REVID=139327789
|
|
|
|
|
|
|
| |
Fixes https://github.com/bazelbuild/bazel/issues/2096
--
MOS_MIGRATED_REVID=139322001
|
|
|
|
|
|
|
|
|
|
| |
Move the hashed base directory computation logic
into blaze_util_<platform>.cc in order to clean up
the call site and move platform-dependent code out
the client's main file.
--
MOS_MIGRATED_REVID=139319487
|
|
|
|
|
|
|
| |
to "there were other errors" to account for errors that aren't build failures.
--
MOS_MIGRATED_REVID=139314129
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BaseJavaCompilationHelper.
Changed JavaCompilationHelper constructor to take in the object it used to construct itself: java toolchain, a host javabase and a jacoco instrumental. Because the objects are now directly passed to the constructor there is no more need anymore for the implicit attribute suffix, that was used to construct these objects.
I also removed BaseJavaCompilationHelper as it was only used to create an ijar action and only had one class extend it (JavaCompilationHelper). All methods that construct objects (java toolchain, host javabase, jacoco instrumental) were moved to JavaCompilationHelper as static methods and the rest of its method were moved as they were also to JavaCompilationHelper.
This is needed in order to pass the right toolchain/host javabase/jacoco instrumental from a Skylark module. The problem arises when a Skylark aspect/rule is created and its attributes will have different labels then a Java native rule/aspect because they must be prefixed with "_" instead of ":", so their value cannot be retrieved in the same default way.
--
MOS_MIGRATED_REVID=139310690
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change:
- merges the //src/{main,test}/cpp:file and
//src/{main,test}/cpp:file_platform libraries
because "file" and "file_platform" need each other
and this makes logical sense anyway
- implements a function in file_<platform> to run
a custom function on every child of a directory
- implements a function in file.cc to recursively
traverse a directory tree, based on the previosly
mentioned function
- removes the corresponding logic from the Bazel
client to make it more portable
--
MOS_MIGRATED_REVID=139309562
|
|
|
|
|
|
|
|
|
| |
Fix https://github.com/bazelbuild/bazel/issues/2082
RELNOTES:
--
MOS_MIGRATED_REVID=139307613
|
|
|
|
|
|
|
|
|
| |
It seems unnecessary to pass these lists around, so this should simplify the
APIs. Also, I want to move the action input prefetcher setup to the serverInit
call.
--
MOS_MIGRATED_REVID=139304928
|
|
|
|
|
|
|
| |
RELNOTES: proto_library now produces a descriptor set, when built on the command-line.
--
MOS_MIGRATED_REVID=139288944
|
|
|
|
|
|
|
| |
Now, apks can be built faster in Bazel using the --use_singlejar_apkbuilder flag.
--
MOS_MIGRATED_REVID=139285943
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139265482
|
|
|
|
|
|
|
| |
buildConfiguration always present. This also fixes an issue with split targets in which the generated protos would end up in the wrong location, and then compiled with the wrong flags.
--
MOS_MIGRATED_REVID=139253937
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139243894
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139238158
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139234066
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following link features are *not* implemented yet:
1) Objc++ linking semantics
2) Dead stripping
3) --should_prioritize_static_libs
4) DSYM generation
5) Coverage support
6) Swift interop
7) Linkmap
--
MOS_MIGRATED_REVID=139232434
|
|
|
|
|
|
|
|
|
|
|
| |
--experimental_dynamic_configs=notrim.
This is simply a matter of populating the "global" host
config from the target config instead of applying
the HostTransition patch.
--
MOS_MIGRATED_REVID=139222963
|
|
|
|
|
|
|
|
| |
AAR embedded JARs contain some compressed files (.class) and some
non-compressed files (Java resources).
--
MOS_MIGRATED_REVID=139222696
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139219934
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139209942
|
|
|
|
|
|
|
| |
Change it to use relative links so it works for different deployments, and have the link for providers note that providers are attributes of a Target, not of ctx.
--
MOS_MIGRATED_REVID=139207051
|
|
|
|
|
|
|
| |
--distinct_host_configuration.
--
MOS_MIGRATED_REVID=139205874
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139205671
|
|
|
|
|
|
|
| |
attempts take into account the fact that failed connection attempts can take a long time.
--
MOS_MIGRATED_REVID=139199883
|
|
|
|
|
|
|
| |
Fixed https://github.com/bazelbuild/bazel/issues/1611
--
MOS_MIGRATED_REVID=139190088
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139189444
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139180153
|
|
|
|
|
|
|
|
|
| |
This is needed to fulfill the contract of the gensignature rule / the
corresponding audit trail protobuf. Note that the action is uncachable and
unconditional to execute.
--
MOS_MIGRATED_REVID=139178114
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139173954
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139159834
|